* Fix function definition for Waypoints and silence unneeded developer print
* Revert "Fix function definition for Waypoints and silence unneeded developer print"
This reverts commit 4e13b00c33.
* Fix typo from ai revamp merge
* typo#2
https://gcc.gnu.org/gcc-14/porting_to.html#warnings-as-errors
GCC 14 upgraded certain warnings about non-standard C features to errors.
-fpermissive is the documented way to turn them back to warnings and allow the build to succeed.
For our long term sanity, it would be better to resolve the warnings properly, but this will do for now.
source/main_sdl.c:234:52: warning: passing argument 2 of 'sceKernelCreateThread' from incompatible pointer type [-Wincompatible-pointer-types]
234 | SceUID main_thread = sceKernelCreateThread("NZP", nzp_main, 0x40, 0x800000, 0, 0, NULL);
| ^~~~~~~~
| |
| int (*)(unsigned int, char **)
In file included from /usr/local/vitasdk/arm-vita-eabi/include/psp2/kernel/threadmgr.h:28,
from /usr/local/vitasdk/arm-vita-eabi/include/psp2/paf/misc.h:12,
from /usr/local/vitasdk/arm-vita-eabi/include/psp2/paf.h:14,
from /usr/local/vitasdk/arm-vita-eabi/include/vitasdk.h:52,
from source/main_sdl.c:86:
/usr/local/vitasdk/arm-vita-eabi/include/psp2/kernel/threadmgr/thread.h:48:69: note: expected 'SceKernelThreadEntry' {aka 'int (*)(unsigned int, void *)'} but argument is of type 'int (*)(unsigned int, char **)'
48 | SceUID sceKernelCreateThread(const char *name, SceKernelThreadEntry entry, int initPriority,
| ~~~~~~~~~~~~~~~~~~~~~^~~~~
/__w/quakespasm/quakespasm/source/gl_rpart.c: In function 'QMB_InitParticles':
/__w/quakespasm/quakespasm/source/gl_rpart.c:509:9: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
509 | for (i = 0 ; i < 5 ; i++)
| ^~~
/__w/quakespasm/quakespasm/source/gl_rpart.c:219:1: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
219 | do { \
| ^~
source/view.c:1174:1: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
1174 | else
| ^~~~
source/view.c:1181:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
1181 | view2->origin[0] = view->origin[0];
| ^~~~~
The Vita doesn't use FSAA so it is safe to set this to zero.
source/gl_vidsdl.c: In function 'VID_SetMode':
source/gl_vidsdl.c:823:2: warning: 'fsaa_obtained' is used uninitialized in this function [-Wuninitialized]
823 | Con_SafePrintf ("Video mode %dx%dx%d %dHz (%d-bit z-buffer, %dx FSAA) initialized\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
824 | VID_GetCurrentWidth(),
| ~~~~~~~~~~~~~~~~~~~~~~
825 | VID_GetCurrentHeight(),
| ~~~~~~~~~~~~~~~~~~~~~~~
826 | VID_GetCurrentBPP(),
| ~~~~~~~~~~~~~~~~~~~~
827 | VID_GetCurrentRefreshRate(),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
828 | depthbits,
| ~~~~~~~~~~
829 | fsaa_obtained);
| ~~~~~~~~~~~~~~
source/net_udp.c: In function 'UDP_Init':
source/net_udp.c:102:25: warning: pointer targets in passing argument 2 of 'Cvar_Set' differ in signedness [-Wpointer-sign]
102 | Cvar_Set ("hostname", nick);
| ^~~~
| |
| SceChar8 * {aka signed char *}
In file included from source/quakedef.h:282,
from source/net_udp.c:26:
source/cvar.h:98:50: note: expected 'const char *' but argument is of type 'SceChar8 *' {aka 'signed char *'}
98 | void Cvar_Set (const char *var_name, const char *value);
| ~~~~~~~~~~~~^~~~~
source/net_udp.c:101:64: warning: pointer targets in passing argument 2 of 'sceAppUtilSystemParamGetString' differ in signedness [-Wpointer-sign]
101 | sceAppUtilSystemParamGetString(SCE_SYSTEM_PARAM_ID_USERNAME, nick, SCE_SYSTEM_PARAM_USERNAME_MAXSIZE);
| ^~~~
| |
| char *
In file included from /usr/local/vitasdk/arm-vita-eabi/include/psp2/appmgr.h:12,
from /usr/local/vitasdk/arm-vita-eabi/include/vitasdk.h:8,
from source/net_udp.c:30:
/usr/local/vitasdk/arm-vita-eabi/include/psp2/apputil.h:244:12: note: expected 'SceChar8 *' {aka 'signed char *'} but argument is of type 'char *'
244 | SceChar8 *buf, SceSize bufSize);
COM_LoadStackFile already returns a "byte*" so this cast is totally
unneeded. I'm not sure why it was there to begin with
source/gl_model.c: In function 'Mod_LoadModel':
source/gl_model.c:337:7: warning: assignment to 'byte *' {aka 'unsigned char *'} from incompatible pointer type 'unsigned int *' [-Wincompatible-pointer-types]
337 | buf = (unsigned*)COM_LoadStackFile ("models/missing_model.mdl", stackbuf, sizeof(stackbuf), NULL);
| ^
GCC 14 promotes this to an error.
source/gl_hud.c:1697:2: warning: implicit declaration of function 'Save_Achivements' [-Wimplicit-function-declaration]
1697 | Save_Achivements();
| ^~~~~~~~~~~~~~~~
source/gl_hud.c: In function 'HUD_Parse_Achievement':
source/gl_hud.c:1689:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
1689 | if (achievement_list[ach].unlocked)
| ^~
source/gl_hud.c:1692:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
1692 | achievement_unlocked = 1;
| ^~~~~~~~~~~~~~~~~~~~
source/gl_screen.c:375:17: warning: too many arguments for format [-Wformat-extra-args]
375 | strcpy(s, va("Hold %s to buy %s\n", GetUseButtonL(), GetPerkName(weapon), cost));
| ^~~~~~~~~~~~~~~~~~~~~
source/gl_screen.c:385:17: warning: too many arguments for format [-Wformat-extra-args]
385 | strcpy(s, va("Hold %s to Activate the Trap\n", GetUseButtonL(), cost));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source/gl_screen.c:390:17: warning: too many arguments for format [-Wformat-extra-args]
390 | strcpy(s, va("Hold %s to Pack-a-Punch\n", GetUseButtonL(), cost));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
source/gl_screen.c:405:17: warning: too many arguments for format [-Wformat-extra-args]
405 | strcpy(s, va("Hold %s to use Teleporter\n", GetUseButtonL(), cost));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source/gl_screen.c:430:17: warning: too many arguments for format [-Wformat-extra-args]
430 | strcpy(s, va("Hold %s to End the Game\n", GetUseButtonL(), cost));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
GCC 14 makes this an error.
source/gl_rmisc.c: In function 'R_Init':
source/gl_rmisc.c:256:2: warning: implicit declaration of function 'R_InitOtherTextures'; did you mean 'R_InitTextures'? [-Wimplicit-function-declaration]
256 | R_InitOtherTextures ();
| ^~~~~~~~~~~~~~~~~~~
| R_InitTextures
source/gl_rmisc.c: At top level:
source/gl_rmisc.c:671:6: warning: conflicting types for 'R_InitOtherTextures'
671 | void R_InitOtherTextures (void)
| ^~~~~~~~~~~~~~~~~~~
source/gl_rmisc.c:256:2: note: previous implicit declaration of 'R_InitOtherTextures' was here
256 | R_InitOtherTextures ();
| ^~~~~~~~~~~~~~~~~~~
