Commit graph

33 commits

Author SHA1 Message Date
Jonathan Gray
ef39017afd Fix game getting stuck in a do-while loop when "team follow1" or "team follow2" client sends a follownext or followprev command.
from Zack Middleton in ioquake3
svn 2317 git 02f3664b2e01591864b1d4022a8d7ddf10787f33
2013-05-07 22:20:03 +10:00
Jonathan Gray
2cb6b49d77 init arrays to zero in BG_LegalizedForcePowers() 2013-05-07 22:20:03 +10:00
Jonathan Gray
8be8413a0b bounds check values in BG_LegalizedForcePowers() 2013-05-07 22:20:03 +10:00
Jonathan Gray
df117b922f fix buffer overflow in CalculateRanks()
from Thilo Schulz in ioquake3
svn 1866 git a2715bc2831ca32605f0722b34666106a2a4fc27

Fix buffer overflow, reported by Mads Lind
2013-05-07 22:20:02 +10:00
Jonathan Gray
3fa32e5910 Potential buffer overflow in UpdateTournamentInfo()
bugzilla #4753

from Eugene C. in ioquake3
svn 1801 git a4327ef965fa6b8f4103f71ea4a7ae00f1fd97bc

Bugzilla #4753
Potential buffer overflow in UpdateTournamentInfo()
2013-05-07 22:20:02 +10:00
Jonathan Gray
647eeff5d3 security fix: prevent command injection via callvote
Luigi Auriemma q3cbufexec

from Ludwig Nussel in ioquake3
svn 1493 git f5aae78481d71307a0b874b1f17ecdead1469392

security fix: prevent command injection via callvote

from Thilo Schulz in ioquake3
svn 1838 git cf791d14c58f536eec8220d93fb9af443f8837e9

- Fix bug #4769 remote server crash
2013-05-07 22:20:02 +10:00
Jonathan Gray
61687fff0c CVE-2011-2764/CVE-2011-3012 check for dangerous file extensions
CVE-2011-2764
The FS_CheckFilenameIsNotExecutable function in qcommon/files.c in the
ioQuake3 engine 1.36 and earlier, as used in World of Padman, Smokin'
Guns, OpenArena, Tremulous, and ioUrbanTerror, does not properly
determine dangerous file extensions, which allows remote attackers to
execute arbitrary code via a crafted third-party addon that creates a
Trojan horse DLL file.

CVE-2011-3012
The ioQuake3 engine, as used in World of Padman 1.2 and earlier,
Tremulous 1.1.0, and ioUrbanTerror 2007-12-20, does not check for
dangerous file extensions before writing to the quake3 directory, which
allows remote attackers to execute arbitrary code via a crafted
third-party addon that creates a Trojan horse DLL file, a different
vulnerability than CVE-2011-2764.

bugzilla #3695

from Tim Angus in ioquake3
svn 1405 git 2c0861c1cea44861c5ceba2dc39e601d6bc3f0af

* (bug 3695) Not allowing to write file with lib extention (.dll/.so/...)
  (TsT <tst2006@gmail.com>)

from Tim Angus in ioquake3
svn 1499 git 48d8c8876b6ec035b0bb85f4d3c47c9210c3ca30

* s/FS_FilenameIsExecutable/FS_CheckFilenameIsNotExecutable/g
* Fix potential buffer under run in FS_CheckFilenameIsNotExecutable

from Thilo Schulz in ioquake3
svn 2098 git c4f739b8d03ca203435744c4a96e3561863ccdfe

Fix extension name comparison for DLL files

from Zack Middleton in ioquake3
git 6c88bf8aeee3c1e5449682f874f91e86cb393ef4

Rename FS_CheckFilenameIsNotExecutable to ..NotImmutable

from Harley Laue in ioquake3
git 1b2a6abed996b43eb108486abbda449b3d16e019

Rename FS_CheckFilenameIsNotImmutable to ..IsMutable
2013-05-07 22:20:02 +10:00
Jonathan Gray
d64b393927 add DLL_EXT defines 2013-05-07 22:20:02 +10:00
Jonathan Gray
8550620849 CVE-2006-3325 arbitrary cvar overwrite
CVE-2006-3325
client/cl_parse.c in the id3 Quake 3 Engine 1.32c and the Icculus
Quake 3 Engine (ioquake3) revision 810 and earlier allows remote
malicious servers to overwrite arbitrary write-protected cvars
variables on the client, such as cl_allowdownload for Automatic
Downloading and fs_homepath for the quake3 path, via a string of cvar
names and values sent from the server. NOTE: this can be combined with
another vulnerability to overwrite arbitrary files.

Luigi Auriemma q3cfilevar

from Thilo Schulz in ioquake3
svn 811 git 7d51d75b05a9593508040162709043516c0f2a17

- Fix arbitrary cvar overwrite flaw: http://aluigi.altervista.org/adv.htm
2013-05-07 22:18:55 +10:00
Jonathan Gray
ec595883ab vsprintf -> Q_vsnprintf 2013-05-07 22:18:45 +10:00
Jonathan Gray
518c81038f CVE-2005-0984 Buffer overflow in the G_Printf function
CVE-2005-0984
Buffer overflow in the G_Printf function in Star Wars Jedi Knight:
Jedi Academy 1.011 and earlier allows remote attackers to execute
arbitrary code via a long message using commands such as (1) say and
(2) tell.

Luigi Auriemma jamsgbof
2013-05-07 22:18:45 +10:00
Jonathan Gray
5ae4da05a7 Q_vsnprintf from ioquake3 2013-05-07 22:18:45 +10:00
Jonathan Gray
832b4342a8 CVE-2006-2236 Buffer overflow in the Quake 3 Engine
CVE-2006-2236
Buffer overflow in the Quake 3 Engine, as used by (1) ET 2.60,
(2) Return to Castle Wolfenstein 1.41, and (3) Quake III Arena 1.32b
allows remote attackers to execute arbitrary commands via a long
remapShader command.

from Thilo Schulz in ioquake3
svn 765 git d21411452ef32b86c0b79ddcaf49221701dcdb07

Add string length checking to function COM_StripExtension. This fixes
the R_RemapShader buffer overflow exploit that can be found here:
http://milw0rm.com/exploits/1750
2013-05-07 22:18:45 +10:00
Jonathan Gray
1a40cbbe89 Fix to COM_ParseExt 1 byte overwrite bug
from Tim Angus in ioquake3
svn 95 git 33a48a0336865a9d21983e4836920cd9f3401101

Fix to COM_ParseExt 1 byte overwrite bug

from http://www.quakesrc.org/forums/viewtopic.php?t=5374
2013-05-07 22:18:44 +10:00
Jonathan Gray
8fc8601e0b CVE-2005-0430 Fixed q3infoboom
CVE-2005-0430
The Quake 3 engine, as used in multiple game packages, allows remote
attackers to cause a denial of service (shutdown game server) and
possibly crash the server via a long infostring, possibly triggering a
buffer overflow.

Luigi Auriemma q3infoboom

from Tim Angus in ioquake3
svn 95 git 33a48a0336865a9d21983e4836920cd9f3401101

It looks as if the q3infoboom bug has already been fixed in ioQ3 in a
different way, though this patch addresses the cause. The existing fix
should stay since it's a sensible sanity check anyway.

from http://www.quakesrc.org/forums/viewtopic.php?t=5374
2013-05-07 22:18:29 +10:00
Jonathan Gray
6ae7218c21 remove the use of 'typedef enum' without an indentifier 2013-05-02 13:47:50 +10:00
Jonathan Gray
96fa13bbdb add sdl glimp/input from ioquake3 for MP 2013-04-30 15:02:26 +10:00
Jonathan Gray
fb2f55824f avoid redefining typedefs which is allowed in c++ but not c99 2013-04-26 22:27:23 +10:00
Jonathan Gray
59010a333c make inlines static inline 2013-04-26 22:27:22 +10:00
Jonathan Gray
b1f71d5b81 don't try to compile c files as c++ 2013-04-26 22:27:22 +10:00
Jonathan Gray
eb0c330619 strcmpi -> Q_strcmpi 2013-04-26 22:27:20 +10:00
Jonathan Gray
e8391f9c09 powf -> Q_powf 2013-04-25 23:51:57 +10:00
Jonathan Gray
f99cdcd1fa leave the masm assembly to msvc 2013-04-25 23:51:56 +10:00
Jonathan Gray
5c941d29f1 strnicmp -> Q_strnicmp 2013-04-25 23:51:56 +10:00
Jonathan Gray
901d5acb51 stricmp -> Q_stricmp 2013-04-25 23:51:55 +10:00
Jonathan Gray
54e3184cfc add an OpenBSD section to q_shared.h 2013-04-25 12:31:09 +10:00
Jonathan Gray
211687d21f test the non msvc path as __GNUC__ not __linux__ 2013-04-25 12:25:28 +10:00
Jonathan Gray
bd47e42e0e fix slashes in include paths 2013-04-23 15:40:23 +10:00
Jonathan Gray
85e0d466e2 remove the rest of the Visual SourceSafe files 2013-04-23 15:39:07 +10:00
Jonathan Gray
039ef2cb4a ditch dos style newlines 2013-04-23 15:21:39 +10:00
Josh Vega
107cd7a531 Deleted all the Visual SourceSafe files. 2013-04-06 20:59:34 -04:00
James Monroe
59f7e71450 Jedi Academy Patch 1.01 2013-04-04 18:21:13 -05:00
James Monroe
684d1bcb3b Jedi Academy Release 2013-04-04 17:35:38 -05:00