really fix the confusion with game entity and refentity numbers
for any natural number M, the following is logical as a whole:
- the array size for refentities is M;
- the refentity number limit is M-1, ie., each refentity number is in [0..M-1];
- the special number for the world is M.
before r1429, the code was roughly the following:
// constants related to the game, should not be used by the renderer
// renderer stuff
refEntity_t refEntities[MAX_ENTITIES];
int numRefEntities = 0;
void addRefEntity(refEntity_t re)
{
if (numRefEntities >= ENTITYNUM_WORLD)
return; // full
refEntities[numRefEntities++] = re;
}
void render(int num)
{
if (num == ENTITYNUM_WORLD)
renderWorld();
else
renderRefEntity(refEntities[num]);
}
so before r1429,
- the array size for refentities was 1023;
- the refentity number limit was 1021, ie., each refentity number was in [0..1021]; and
- the special number for the world entity was 1022.
this was a small waste of memory, as the last array element wasn't used.
r1429 changed
if (numRefEntities >= ENTITYNUM_WORLD)
to
if (numRefEntities >= MAX_ENTITIES).
this creates the following configuration:
- the array size for refentities is 1023;
- the refentity number limit is 1022, ie., each refentity number is in [0..1022]; and
- the special number for the world entity is 1022.
r1429 just makes things worse: it allows 1 more refentity to be added, but that entity doesn't get drawn anyway, as its number will be equal to the special number for the world. this is a small waste of not only memory, but also processing time.
perhaps in XreaL,
ENTITYNUM_WORLD is a game entity constant, and has nothing to do with refentities. a new REFENTITYNUM_WORLD constant should be added to denote the special number for the world, and that constant should be used in the renderer code in place of ENTITYNUM_WORLD. so define such a constant, and let it be equal to MAX_ENTITIES, which is 1023.
- Bug 5057 - Two weapon number range checks allows invalid number
- Bug 5058 - Railgun explosion cannot be colorized
- Bug 5059 - Client's railgun does not glow in third person and mirror
- Bug 5060 - Warning in RAVENMD4 R_GetAnimTag cross compiling with amd64-mingw32
- Make VM loading more robust, change loading order: when vm_* == 0 first try loading DLL, then QVM in *each* search directory/path
- Fix FS_FileForHandle that would return a FILE pointer to invalid file handle 0
- Clean up ftol()/snapvector() mess
- Make use of SSE instructions for ftol()/snapvector() if available
- move ftol/snapvector pure assembler to inline assembler, this will add x86_64 and improve support for different calling conventions
- Set FPU control word at program startup to get consistent behaviour on all platforms
- Bug 5029 - IQM skin support for upper case surface names
- Bug 5030 - IQM version 2 support
- Bug 5031 - Animated IQMs cause segfault
- Bug 5032 - IQM does not setup tag axis/origin correctly
- Bug 5033 - IQM bounds swap and segfault issues
Tim Angus
SmileTheory
Zachary Slater
Zack Middleton
Thilo Schulz