ioquake/gtkradiant
0
0
Fork 0
mirror of https://github.com/TTimo/GtkRadiant.git synced 2025-01-10 20:10:56 +00:00
Code Issues Projects Releases Packages Wiki Activity
gtkradiant/tools/quake3/q3map2
History
Ricardo Barreira 5e308f9056
Fix undefined behavior in FreeStackWinding 
Fix subtraction of unrelated pointers and integer overflow in FreeStackWinding (both are undefined behavior).

In rare cases "i" would non-deterministically be between 0 and 2 even though the
pointers were in unrelated addresses, which caused a spurious free of one of
the three windings - eventually the real free would happen, be detected as a
double free and an exit(1) would ensue.

Example contents of w and stack->windings that triggered this in a test: 0xa9251c0 0x7f440a924f78

Checking for pointer equality makes the behavior defined and correct: http://port70.net/~nsz/c/c99/n1256.html#6.5.9
2017-10-31 13:05:32 +00:00
..
brush.c [quake3/q3map2/brush.c] Fix misnamed variable 2016-08-16 22:50:14 +01:00
brush_primit.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
bsp.c Fix xml passing to parameter warnings 2017-07-10 01:04:28 +02:00
bsp_analyze.c split bsp analyze/info/scale stuff from q3map2 2016-02-13 04:54:26 +01:00
bsp_info.c split bsp analyze/info/scale stuff from q3map2 2016-02-13 04:54:26 +01:00
bsp_scale.c split bsp analyze/info/scale stuff from q3map2 2016-02-13 04:54:26 +01:00
bspfile_abstract.c readability 2016-08-20 16:06:09 -06:00
bspfile_ibsp.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
bspfile_rbsp.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
changelog.q3map1 ported over the 1.5 branch version of q3map2 which is newer 2008-07-25 07:31:37 +00:00
changelog.q3map2.txt ported over the 1.5 branch version of q3map2 which is newer 2008-07-25 07:31:37 +00:00
convert_ase.c Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
convert_bsp.c split bsp analyze/info/scale stuff from q3map2 2016-02-13 04:54:26 +01:00
convert_map.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
decals.c Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
exportents.c more cleanups 2016-08-20 17:50:23 -06:00
facebsp.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
fixaas.c split fixaas stuff from q3map2 2016-02-13 04:54:26 +01:00
fog.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_ef.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_etut.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_ja.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_jk2.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_nexuiz.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_qfusion.h this was built on top of 1.5, so it never got properly transformed to a GPL license. took care of that now 2012-05-28 18:29:36 -05:00
game_quake3.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_quakelive.h better QL Linux homepath config 2012-08-29 21:43:19 -05:00
game_reaction.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_sof2.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_t.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_tenebrae.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_tremulous.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_wolf.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
game_wolfet.h uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
image.c Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
leakfile.c Fix xml passing to parameter warnings 2017-07-10 01:04:28 +02:00
light.c Fix warning variable add is used uninitialized 2017-07-10 15:30:04 +02:00
light_bounce.c Fixed a number of out of bounds accesses. 2013-11-01 00:24:58 +00:00
light_shadows.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
light_trace.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
light_ydnar.c fix compile warning 2017-08-20 15:46:40 -05:00
lightmaps.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
lightmaps_ydnar.c [tools/quake3/q3map2/light{,maps}_ydnar.c] Fix float-to-int conversion by preventing NaN values 2016-08-14 12:16:13 +01:00
listen.pl ... 2007-11-04 04:08:17 +00:00
main.c Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
map.c Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
mesh.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
model.c Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
patch.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
path_init.c QuakeLive PK3 support for Q3Map2 2012-07-27 17:46:54 +01:00
portals.c Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
prtfile.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
q3map2.h more cleanups 2016-08-20 17:50:23 -06:00
q3map2.ico transfer from internal tree r5311 branches/1.4-gpl 2007-09-12 18:54:28 +00:00
q3map2.rc transfer from internal tree r5311 branches/1.4-gpl 2007-09-12 18:54:28 +00:00
q3map2.vcxproj Visual Studio 2015 on debug configs too 2016-04-24 14:52:52 -05:00
q3map2.vcxproj.filters split fixaas stuff from q3map2 2016-02-13 04:54:26 +01:00
shaders.c Fix uninitialized use of ext warning 2017-04-27 18:12:09 +02:00
surface.c Merge pull request #352 from Pan7/Sys_FPrintf 2016-06-11 13:01:13 -05:00
surface_extra.c Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
surface_foliage.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
surface_fur.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
surface_meta.c [tools/quake3/q3map2] Fix memset size bugs 2016-08-16 23:41:29 +01:00
tjunction.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
tree.c uncrustify! now the code is only ugly on the *inside* 2012-03-17 15:01:54 -05:00
vis.c Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00
visflow.c Fix undefined behavior in FreeStackWinding 2017-10-31 13:05:32 +00:00
writebsp.c Using Sys_FPrintf with SYS_WRN and SYS_ERR 2016-05-16 21:20:20 +02:00