Riccardo Mottola
d9b291085d
some come indenting cleanup
2024-05-13 22:10:31 +02:00
Riccardo Mottola
41ba427101
call SWAP_LINE_ENDIANNESS iniside the WRITE_SCANLINE macro and thus remove if() duplication
2024-05-13 21:53:06 +02:00
Riccardo Mottola
2328f7e99a
use char for bool
2024-05-13 21:43:58 +02:00
Riccardo Mottola
22dbbbb1f6
swap only if 16 or 32 bits, otherwise endianness has no meaningwq
2024-05-09 01:17:01 +02:00
Riccardo Mottola
f77370178a
update include guard to actual file name
2024-05-08 11:24:15 +02:00
Riccardo Mottola
b35b5714ed
update Adam's historic mail and copyright dates
2024-05-08 11:18:13 +02:00
Riccardo Mottola
4ea49b0260
now that we have individual flags to check, group swapping into a one big macro
2024-05-08 11:12:11 +02:00
Riccardo Mottola
55b75b9e33
instad of using NSBitmapFormat use individual flags
2024-05-08 10:28:49 +02:00
Riccardo Mottola
7c833cb5a6
try to swap 16bit and 32bit images line-per-line always into host byte order for TIFF library to write
2024-05-07 23:22:05 +02:00
Gregory Casamento
82dce67eb4
Reduce code duplication in GSThemeDrawing table/outline view drawing methods ( #262 )
...
* Reduce code duplication in drawViewCell:... method
* Further reduce code duplication, add common private method for calculating starting and ending column
* Use the tableView in the method that calculates the starting and ending rows
* Add code to properly handle prototypeViews, the XIB is NOT split, I was confused
* Call awakeFromNib on view as well
* Refactor so that the outlineColumn drawing code is shared
* Adjust the image drawing and the clickable area to be more aligned also make it easier to expand or collapse an item in the outline view
2024-04-26 18:40:11 +02:00
Jamie Ramone
c43bbb8a81
Update nsmapping.strings ( #266 )
...
Fixed the visual menu/browser arrow glitch where it didn't change the image when highlighted. This file was missing the "common_3DArrowRightH = NSHighlightedMenuArrow;" line.
2024-04-26 09:59:25 +02:00
Frederik Carlier
2ab5953ea3
Add NSButtonCell, NSMenuItem keyEquivalentModifierMask encoding tests ( #264 )
2024-04-25 17:31:47 +02:00
Frederik Carlier
2ebf167e6f
It looks like GNUstep backend is not yet installed ( #263 )
2024-04-25 17:22:57 +02:00
Gregory Casamento
d0db2dd2ee
Merge pull request #154 from gnustep/NSTableCellView_branch
...
Implement view based cells in NSTableView
2024-04-24 15:57:25 -04:00
Gregory John Casamento
930eb54290
Merge branch 'master' of github.com:gnustep/libs-gui into NSTableCellView_branch
2024-04-24 13:55:35 -04:00
williameveretteggplant
140124ed35
Revert "Left shift key equivalent modifier mask in xib unarchiver ( #259 )" ( #260 )
...
This reverts commit d1562a37cd
2024-04-23 20:09:39 +02:00
Gregory John Casamento
0e36b42837
Add a check to make sure that ov is set
2024-04-23 02:19:17 -04:00
Gregory John Casamento
3ff5efed30
Encapsulate the renderedPaths and pathsToViews ivars that track which views were displayed in a viewBased table
2024-04-22 09:00:53 -04:00
Gregory John Casamento
c1e3cf2f08
Fix the image position and refresh when opening and closing items if it is a viewBased outline view. Tested and behavior seems consistent with macOS 14.
2024-04-22 09:00:53 -04:00
Gregory John Casamento
3c01238988
Remove checks for the class/subclass of NSTableView/NSOutlineView, but make the decision about how to render by depending on which delegate method is implemented
2024-04-22 09:00:53 -04:00
Gregory John Casamento
3345b5c0de
Minor cleanup
2024-04-22 09:00:53 -04:00
Gregory John Casamento
64150ff2ba
Minor cleanup
2024-04-22 09:00:53 -04:00
Gregory John Casamento
abde29dbe3
Remove GSXibInternal.h reference from GSXib5KeyedUnarchiver to correct compilation error
2024-04-22 09:00:53 -04:00
Gregory John Casamento
a11f562997
Remove GSXibInternal, since it is not needed for this PR. Make drawing method parameter types more explicit, correct delegate method name in NSOutlineView
2024-04-22 09:00:53 -04:00
Gregory John Casamento
48d031a14a
Add improvements suggested by @fredkiefer
2024-04-22 09:00:53 -04:00
Gregory John Casamento
42bae42431
Fix issues mentioned by @fredkiefer
2024-04-22 09:00:53 -04:00
Gregory John Casamento
5d17658b0e
Add 10.12 imageViewWithImage to NSImageView, show outline view image to let the user know the item is expandable
2024-04-22 09:00:53 -04:00
Gregory John Casamento
9da7bd4502
Add implementation of NSUserInterfaceItemIdentifier to NSView
2024-04-22 09:00:53 -04:00
Gregory John Casamento
8c9278e12a
Fix memory leak when creating the blank image, the image is retained by -[NSCell initImageCell:]
2024-04-22 09:00:53 -04:00
Gregory John Casamento
e74144b1bd
Fix memory leak when creating the blank image, the image is retained by -[NSCell initImageCell:]
2024-04-22 09:00:53 -04:00
Gregory John Casamento
829d5367f9
Correct mispelling of key
2024-04-22 09:00:53 -04:00
Gregory John Casamento
64b35d46ca
Fixed issues recommended by @fredkiefer
2024-04-22 09:00:53 -04:00
Gregory John Casamento
e55babb04e
Add code to handle Title property on NSTableColumn, add code to NSTableView to set the table view to _viewBased if it responds to tableView:viewForTableColumn:row:
2024-04-22 09:00:53 -04:00
Gregory John Casamento
8895bd0335
Code cleanup
2024-04-22 09:00:53 -04:00
Gregory John Casamento
6ca3708722
Code cleanup, remove duplicates, reorganize some methods so that it is the same as in the header
2024-04-22 09:00:53 -04:00
Gregory John Casamento
f787edfcfb
Consolidate and refactor the cellview methods in the theme drawing code, so that there is no repeated code
2024-04-22 09:00:53 -04:00
Gregory John Casamento
8e2df65156
Add GSInternal.h
2024-04-22 09:00:53 -04:00
Gregory John Casamento
110b650a95
Add new class to hold deferred XIB data
2024-04-22 09:00:53 -04:00
Gregory John Casamento
fbb94af67b
Add methods to register views
2024-04-22 09:00:53 -04:00
Gregory John Casamento
726485fdc9
Add code to encode/initWithCoder to keys
2024-04-22 09:00:53 -04:00
Gregory John Casamento
d9d4f63c24
Whitespace cleanup
2024-04-22 09:00:53 -04:00
Gregory John Casamento
e51881514c
Add headers missing from AppKit.h
2024-04-22 09:00:53 -04:00
Gregory John Casamento
8d9cb6f933
Add logic to get the column / row for a given view
2024-04-22 09:00:53 -04:00
Gregory John Casamento
182427bf97
Add code to support item identifier to NSTableView
2024-04-22 09:00:53 -04:00
Gregory John Casamento
53e040a6bb
Changes to support view based NSOutlineView, untested
2024-04-22 09:00:53 -04:00
Gregory John Casamento
f71ee8641b
Initial changes for NSOutlineView view-based support
2024-04-22 09:00:53 -04:00
Gregory John Casamento
d99f82896b
Remove uneeded checks for _viewBased
2024-04-22 09:00:53 -04:00
Gregory John Casamento
db773ae9ec
Don't add the view again if it's one that has already been added, this causes the application to poll unneccessarily
2024-04-22 09:00:53 -04:00
Gregory John Casamento
e19038665b
Use an NSMapTable to store which views have been displayed
2024-04-22 09:00:53 -04:00
Gregory John Casamento
a73c3cc876
Add code to track if a view has been rendered, fix issue with duplication of the view, I am not sure if this method of tracking that the view has been rendered is correct, but it works for now
2024-04-22 09:00:53 -04:00
