terminx
175ac6dc6b
This looks dumb as fuck, but it tells static analysis tools that our memory allocation functions literally never return a null pointer
...
git-svn-id: https://svn.eduke32.com/eduke32@7095 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:30:22 +00:00
terminx
b65120200a
Clean up Bgethomedir() and a few of the other directory functions
...
git-svn-id: https://svn.eduke32.com/eduke32@7094 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:30:17 +00:00
terminx
9987b1ffa0
Return invalid keyword string instead of null when passing a bad ID to VM_GetKeywordForID()
...
git-svn-id: https://svn.eduke32.com/eduke32@7093 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:30:12 +00:00
terminx
76e86ddcea
Replace player number check with equivalent null pointer check
...
git-svn-id: https://svn.eduke32.com/eduke32@7092 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:30:08 +00:00
terminx
7bd8c55e32
Useless warning silencing
...
git-svn-id: https://svn.eduke32.com/eduke32@7091 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:30:03 +00:00
terminx
49de74fc3d
Minor update to _clang-format
...
git-svn-id: https://svn.eduke32.com/eduke32@7090 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:58 +00:00
terminx
4c57c4dd46
imo auto is cleaner here because the cast of the rvalue makes the resulting type explicitly clear
...
git-svn-id: https://svn.eduke32.com/eduke32@7089 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:54 +00:00
terminx
bac01d8e2a
Completely unused struct...?
...
git-svn-id: https://svn.eduke32.com/eduke32@7088 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:49 +00:00
terminx
82fcd89ed5
Add debug_break() to default case in VM_Execute()
...
git-svn-id: https://svn.eduke32.com/eduke32@7087 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:44 +00:00
terminx
9079beadb4
Remove some dead statements, useless assigments, etc
...
git-svn-id: https://svn.eduke32.com/eduke32@7086 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:38 +00:00
terminx
1d71ea3fc0
polymost_setTexturePosSize() and polymost_setHalfTexelSize(): pass vec4f_t and vec2f_t by const reference instead of by value
...
git-svn-id: https://svn.eduke32.com/eduke32@7085 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:30 +00:00
terminx
03332e8812
Fix double free in osdcmd_do() and clean up the variable definitions while we're there
...
git-svn-id: https://svn.eduke32.com/eduke32@7084 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:25 +00:00
terminx
4bb9a4b792
sscanf format parameter fixups
...
git-svn-id: https://svn.eduke32.com/eduke32@7083 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:20 +00:00
terminx
9e68009725
Fix downmix_int_8bit() in libxmp-lite assuming char is a signed type
...
git-svn-id: https://svn.eduke32.com/eduke32@7082 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:13 +00:00
terminx
688fadd729
macOS build fix
...
git-svn-id: https://svn.eduke32.com/eduke32@7081 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:08 +00:00
terminx
75e141ec81
Fix potential buffer overruns in sdlayer
...
git-svn-id: https://svn.eduke32.com/eduke32@7080 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:29:04 +00:00
terminx
1f8b23152e
Replace remaining instances of regular malloc/calloc/realloc/strdup with our memory error handler versions
...
git-svn-id: https://svn.eduke32.com/eduke32@7079 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-25 23:28:56 +00:00
terminx
9613bbac33
Use std::min and std::max instead of min and max macros.
...
git-svn-id: https://svn.eduke32.com/eduke32@7078 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:09:54 +00:00
terminx
e77325f2a4
Remove redundant assignments
...
git-svn-id: https://svn.eduke32.com/eduke32@7077 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:09:42 +00:00
terminx
2ff98ca1ce
Bump BYTEVERSION for previous change
...
git-svn-id: https://svn.eduke32.com/eduke32@7076 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:09:37 +00:00
terminx
2132fe978a
The LZ4 versions of kdfread and kdfwrite don't have the size limitations that the LZW versions have
...
git-svn-id: https://svn.eduke32.com/eduke32@7075 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:09:32 +00:00
terminx
e69aac2b93
Remove duplicated line
...
git-svn-id: https://svn.eduke32.com/eduke32@7074 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:09:26 +00:00
terminx
ebcebbde5e
Update engine headers so that argument names in function declarations match the actual function definitions. This also removes const from function declarations in cases when it isn't meaningful.
...
git-svn-id: https://svn.eduke32.com/eduke32@7073 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:09:20 +00:00
terminx
2e2731c119
Same sort of thing as the previous commits, but for the engine. Forward declaration cleanup and constification.
...
git-svn-id: https://svn.eduke32.com/eduke32@7072 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:09:09 +00:00
terminx
342b32c4aa
Update duke3d headers so that argument names in function declarations match the actual function definitions. This also removes const from function declarations in cases when it isn't meaningful.
...
git-svn-id: https://svn.eduke32.com/eduke32@7071 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:08:58 +00:00
terminx
af728b2641
Remove a few useless forward declarations and const-ify a couple of function parameters. Yawn.
...
git-svn-id: https://svn.eduke32.com/eduke32@7070 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:08:50 +00:00
terminx
e9797fe24d
Remove redundant return statements
...
git-svn-id: https://svn.eduke32.com/eduke32@7069 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:08:42 +00:00
terminx
dcb0f9d8bb
Convert a couple of strings with escaped characters to raw string literals
...
git-svn-id: https://svn.eduke32.com/eduke32@7068 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-16 06:08:36 +00:00
pogokeen
4b89c095e2
engine.cpp: fix crash when calling setrendermode 3
where PolymostProcessVoxels would be called before Polymost is initialized.
...
PolymostProcessVoxels would call videoNextPage during processing which would attempt to render the OSD and lead to a segfault due to Polymost not being properly initialized.
git-svn-id: https://svn.eduke32.com/eduke32@7067 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 21:04:42 +00:00
terminx
7b1cdb6f12
Remove redundant statements. This commit doesn't actually do anything.
...
git-svn-id: https://svn.eduke32.com/eduke32@7066 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:15:38 +00:00
terminx
d2f980694b
P_UpdateScreenPal() seems to belong here instead
...
git-svn-id: https://svn.eduke32.com/eduke32@7065 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:15:33 +00:00
terminx
da040c0690
Increase size of text buffer used for editor 3d mode info display--it was possible to overflow it
...
git-svn-id: https://svn.eduke32.com/eduke32@7064 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:15:28 +00:00
terminx
cc6e458d00
Prevent g_sounds[] buffer overflow when attempting to define a sound with an index higher than MAXSOUNDS-1. This reduces the number of sound definitions available by 1 as the last slot is now reserved for the error condition.
...
git-svn-id: https://svn.eduke32.com/eduke32@7063 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:15:22 +00:00
terminx
6248cc9cee
Remove redundant assignment and null ptr check
...
git-svn-id: https://svn.eduke32.com/eduke32@7062 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:15:17 +00:00
terminx
941aa87bce
Fix usage of pointer to stack allocated array outside of the scope the array was declared in
...
git-svn-id: https://svn.eduke32.com/eduke32@7061 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:15:12 +00:00
terminx
b50b1ad198
Fix huge bug in CON_COPY
...
git-svn-id: https://svn.eduke32.com/eduke32@7060 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:15:06 +00:00
terminx
1c5ddca44a
Clarify assignment in ternary condition as not a bug
...
git-svn-id: https://svn.eduke32.com/eduke32@7059 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:15:01 +00:00
terminx
3e380309ce
Replace error condition in rejectQueue_remove() with an assertion, because the NULL pointer it would return if something was fucked up would be unconditionally dereferenced in kdtree_add().
...
git-svn-id: https://svn.eduke32.com/eduke32@7058 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:14:56 +00:00
terminx
bcb1374391
Static analyzer says this condition is never true
...
git-svn-id: https://svn.eduke32.com/eduke32@7057 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:14:51 +00:00
terminx
15008d7aec
Revert r7017. I misread the code mismeasured the result.
...
git-svn-id: https://svn.eduke32.com/eduke32@7056 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:14:46 +00:00
terminx
1d3f77b46b
Clean up error handling in shitty G_GetVersionFromWebsite() function
...
git-svn-id: https://svn.eduke32.com/eduke32@7055 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:14:41 +00:00
terminx
e6c36442bd
Add missing ifdef guards to namesdyn.h
...
git-svn-id: https://svn.eduke32.com/eduke32@7054 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:14:36 +00:00
terminx
7763a379ef
Revert part of r7031 and fix the issue a different way
...
git-svn-id: https://svn.eduke32.com/eduke32@7053 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:14:31 +00:00
terminx
b3914431b0
Fix memory leaks in editor sound list
...
git-svn-id: https://svn.eduke32.com/eduke32@7052 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:14:26 +00:00
terminx
f354f824f4
Add missing ifdef guards to soundsdyn.h
...
git-svn-id: https://svn.eduke32.com/eduke32@7051 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 19:14:20 +00:00
pogokeen
f876e8ad0c
polymost.cpp: temporarily disable experimental r_enablepolymost2 cvar
...
git-svn-id: https://svn.eduke32.com/eduke32@7050 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 15:08:08 +00:00
pogokeen
0b41a17f6b
polymost.h: fix order of parameters to match polymost.cpp
...
git-svn-id: https://svn.eduke32.com/eduke32@7049 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 14:37:06 +00:00
pogokeen
d291a81ccd
polymost.cpp: fix lockup bug that would occur with polymost_waitForSubBuffer() when glClientWaitSync consistently returned GL_WAIT_FAILED on certain hardware/drivers.
...
Additionally, fix conditional check for r_persistentStreamBuffer requirements in polymost_glinit().
git-svn-id: https://svn.eduke32.com/eduke32@7048 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-10 14:37:03 +00:00
terminx
eee0a71496
Remove dead code branch from RECON (logic oversight) and get rid of a useless fallthrough__
...
git-svn-id: https://svn.eduke32.com/eduke32@7047 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-07 05:23:53 +00:00
terminx
59214a2d78
Fix off-by-one error in currently not very useful dedicated server text console input
...
git-svn-id: https://svn.eduke32.com/eduke32@7046 1a8010ca-5511-0410-912e-c29ae57300e0
2018-10-07 05:23:48 +00:00