Commit graph

835 commits

Author SHA1 Message Date
Marcus Weseloh
e0dcdbcdfc Correct documentation for fluid_ladspa_run 2017-10-22 11:24:25 +02:00
Marcus Weseloh
47d640571b Add missing check for ladspa_is_active to ladsap_control_defaults 2017-10-22 11:24:25 +02:00
Marcus Weseloh
29a4abb9a5 Use int for number of inputs and outputs, some plugins have a lot of ports 2017-10-22 11:24:25 +02:00
Marcus Weseloh
8aa2d14476 Nicer error message when user requests LADSPA but is not available. 2017-10-21 22:40:19 +02:00
Marcus Weseloh
3cc684e47e Avoid a few ifdefs by defining two separate sets of node<->buffer functions 2017-10-21 22:36:34 +02:00
Marcus Weseloh
4d256ce8cc Add new command to FluidSynth shell to set control ports to default value 2017-10-21 19:49:49 +02:00
Marcus Weseloh
2787b0e10e Add function to automatically set unconnected port to default value
Uses the hints in the plugin to determine the default value.
2017-10-21 19:47:03 +02:00
Marcus Weseloh
7534e54d4f Check LADSPA setup before activation 2017-10-21 19:47:03 +02:00
derselbst
3486bb515b avoid null deref in jack driver 2017-10-21 19:30:09 +02:00
derselbst
c205e0162d avoid null dereferences in delete_fluid_ladspa_plugin()
be extremely paranoid as suggested by clang-tidy
2017-10-21 19:01:07 +02:00
derselbst
6c69b8ccff ladspa: atomically get and set pending_deactivation 2017-10-21 18:31:20 +02:00
derselbst
81505b9324 remove redundant ';' 2017-10-21 18:22:19 +02:00
derselbst
402f76bfb8 avoid duplicate ';' 2017-10-21 18:21:03 +02:00
derselbst
1d0cfd605f prefer using enum for LADSPA state 2017-10-21 18:13:40 +02:00
derselbst
4911bc8de4 credit @mawe42 for rewriting LADSPA 2017-10-21 18:09:38 +02:00
derselbst
79cef163a1 fix cast operator precedence 2017-10-21 18:05:54 +02:00
Tom M
53e8e27049 Merge pull request #238 from carlo-bramini/fluidsynth-on-mcu-1
Fluidsynth on mcu 1
2017-10-21 17:39:19 +02:00
Tom M
c594bdf466 Merge branch 'master' into fluidsynth-on-mcu-1 2017-10-21 17:38:54 +02:00
Tom M
0600ba7c68 Merge pull request #235 from mawe42/ladspa-cleanup
LADSPA effect unit refactor
2017-10-21 17:36:04 +02:00
Marcus Weseloh
9f4c60c6c8 Remove unused includes 2017-10-21 17:18:05 +02:00
carlo-bramini
931e4349a6 Reverted again to unsigned type on fluid_synth_set_reverb_preset(), fixed error on fluid_return_val_if_fail() usage. 2017-10-21 17:13:02 +02:00
carlo-bramini
b15f6c4b2a Reverted change to unsigned type on fluid_synth_set_reverb_preset(), used fluid_return_val_if_fail() for consistency. 2017-10-21 16:49:07 +02:00
carlo-bramini
ae041fdcec Made fluid_gen_info[] static 2017-10-21 16:41:03 +02:00
Marcus Weseloh
885178ef9d Replace timeout in deactivate with mutex and cond. 2017-10-21 16:32:04 +02:00
Marcus Weseloh
5f488123d8 Also make node names case-insensitive and update comments to reflect this. 2017-10-21 15:58:22 +02:00
Marcus Weseloh
cecf115a38 Replace the fuzzy prefix matching by a simple strncasecmp.
That spaces and underscores are treated as equal is no needed anymore
anyway, as the token parser of the shell understands quoted names.
So searching for "Dry / Wet Mix" is possible.

Adds new FLUID_STRNCASECMP macro to fluid_priv.
2017-10-21 15:55:43 +02:00
Marcus Weseloh
e05f1904d5 Update the LADSPA sample rate if the rvoice mixer sample rate changes. 2017-10-21 15:08:04 +02:00
Marcus Weseloh
2c7e1696fd Completely decouple LADSPA engine from FluidSynth
Knowledge of FluidSynth is completely removed from the LADSPA effects
unit. All synchronization happens inside LADSPA with atomic operations.
The LADSPA fx instance created by FluidSynth is only special in that
FluidSynth knows about it and calls it's run method when enabled.

This simplifies the code structure, makes the FluidSynth and the LADSPA
engine easier to maintain due to the loose coupling. It also enables
users to create their own (or additional) LADSPA fx unit for further
processing as soon as we expose the LADSPA functions via a public API.
2017-10-21 15:07:39 +02:00
Marcus Weseloh
812ea57ed0 Bugfix: properly release the LADSPA API lock after exiting fluid_ladspa_check 2017-10-21 15:03:38 +02:00
Marcus Weseloh
d6066d0560 Remove LADSPA deactivation hooks from FluidSynth again 2017-10-21 15:01:02 +02:00
carlo-bramini
6f51fca022 Same fix for fluid_adriver.c 2017-10-21 14:01:22 +02:00
carlo-bramini
6b3ec26242 Added 2 missing tests with FLUID_N_ELEMENTS() 2017-10-21 13:56:48 +02:00
carlo-bramini
fceeffa8de Remove unused variable. 2017-10-21 13:33:28 +02:00
derselbst
cd17358b7e FLUID_STRNCPY: always add terminator '\0' 2017-10-21 13:19:21 +02:00
carlo-bramini
be8acf4e27 Replace PI with standard M_PI. 2017-10-21 13:15:57 +02:00
derselbst
36f7cc1b21 avoid garbage value for client->handler 2017-10-21 13:04:09 +02:00
carlo-bramini
94b752f433 Made fluid_libname[] to be const. 2017-10-21 12:54:53 +02:00
carlo-bramini
4293fddc05 Fixes for using standard math constants 2017-10-21 12:54:00 +02:00
carlo-bramini
48936975e7 Fixed prototype for fluid_synth_set_reverb_preset() 2017-10-21 12:52:03 +02:00
carlo-bramini
0722ab3ab4 Optimized revmodel_preset[] as const and rewritten fluid_synth_set_reverb_preset() 2017-10-21 12:50:52 +02:00
derselbst
9e3b01927e fix use after free 2017-10-21 12:48:52 +02:00
carlo-bramini
95ea3c0fba idlist[], badgen[] and badpgen[] made static const 2017-10-21 12:47:59 +02:00
carlo-bramini
4f8ab20355 fluid_gen_info[] made as a const object 2017-10-21 12:46:13 +02:00
carlo-bramini
87bff4d3ef Optimized arrays to be fully const and FLUID_N_ELEMENTS() support. 2017-10-21 12:43:59 +02:00
carlo-bramini
5e0bc7c143 Optimized fluid_midi_drivers[] 2017-10-21 12:41:42 +02:00
carlo-bramini
a10662e897 Optimized fluid_audio_drivers[] 2017-10-21 12:40:38 +02:00
carlo-bramini
152fb395f5 Optimized fluid_commands[] 2017-10-21 12:38:44 +02:00
derselbst
b266369561 avoid mem leaks in pulse audio driver 2017-10-21 12:17:26 +02:00
derselbst
758f29cb58 add py script to run clang-tidy 2017-10-21 12:16:54 +02:00
derselbst
e9e5e625bc add .clang-tidy
clang-tidy -checks=-*,cert-*,clang-analyzer-*,performance-*,readability-avoid-const-params-in-decls,readability-braces-around-statements,readability-delete-null-pointer,readability-implicit-bool-conversion,readability-inconsistent-declaration-parameter-name,readability-misleading-indentation,readability-misplaced-array-index,readability-non-const-parameter,readability-redundant-control-flow,readability-redundant-declaration,readability-redundant-function-ptr-dereference,readability-simplify-boolean-expr -dump-config > clang-tidy
2017-10-21 11:03:06 +02:00