- the variable names are using zero-based indices (eg, mod0,mod1,..)
(instead of 1 based indices).
- this naming is coherent with indices displayed on output which are
zero-based:
Example of output message:
fluidsynth: warning: invalid destination test zone with linked modulators/mod1
This message says that mod1 (i.e modulator at index 1 in the list) is
an invalid destination.
- fluid_voice.c:1856:37: warning: Assigned value is garbage or undefined
min_val *= link_min_max[j].min;
- Add a comment to explain that link_min_max[j].min is still a valid value.
- Clang-tidy complaint should be ignored here.
- fluid_mod.c:867:26: warning: The right operand of '<' is a garbage value
while(r < branch_level[is].dest0_idx)
- rename is to state_idx for clarity.
- Add a comment to explain that branch_level[state_idx].dest0_idx is still
a valid value. Clang-tidy complaint should be ignored here.
- fluid_voice.c:1634:29: warning: Dereference of undefined pointer value
voice_mod->next = NULL;
- Add a comment to explain that voice_mod is still a valid pointer.
Clang-tidy complaint should be ignored here.
- fluid_voice.c:1228:17: warning: The left operand of '>>' is a garbage
value if(!is_gen_updated(updated_gen_bit, gen)).
- Add a comment to explain that gen is always initialized. clang-tidy
complaint should be ignored here.
new_fluid_mod() creates a modulator, but leaves the `next` member
uninitialized. Passing this modulator object to fluid_voice_add_mod()
will attempt to iterate the modulators that are linked together by `next`.
By default, libinstpatch silently adds all SF2 default modulators to the
converted DLS voices. Since fluidsynth respects the modulators provided
by libinstpatch, those modulators would conflict with the default
modulator list managed by fluidsynth. This is only noticeable, if the
user used fluidsynth's API to manipulate default modulators.
When compiled with compatibility for WinXP (toolset v141_xp), read() may return 0 (EOF) rather than '\n' which led to an early exit of the shell after a single user input.
