Christoph Oelckers
5422bff683
‚char‘ review in Blood - part 1
2021-11-29 00:55:42 +01:00
Christoph Oelckers
53998c9cb7
- Blood: remove unneeded replacement functions.
...
changespritesect is the only one called from the engine.
2021-11-29 00:55:42 +01:00
Christoph Oelckers
e9c79292ff
- Blood: use wider integer types for a few more things
...
Mainly removing shorts from all function signatures, except the engine replace interface, replacing them either with int or bool, depending on the use case.
2021-11-29 00:55:41 +01:00
Christoph Oelckers
b685163ab1
- Blood: extend all 16 bit fields holding sector or wall indices to 32 bit.
2021-11-29 00:55:41 +01:00
Christoph Oelckers
499dc9953b
- reduction of 'short' noise in Blood.
...
Mainly using int16_t for deliberately sized struct fields, auto for temporary saves of global data and making several local variables full int.
This changes nothing substantial.
2021-11-29 00:55:41 +01:00
Christoph Oelckers
345d9c87b6
- RR: no more wall[] in actors_r.cpp
2021-11-29 00:55:41 +01:00
Christoph Oelckers
00edd16834
- Duke: get rid of the remaining wall[] references in actors_d.cpp
2021-11-29 00:55:41 +01:00
Christoph Oelckers
e0260bc709
- Duke/RR: weaponhitwall cleaned up (both variants)
2021-11-29 00:55:40 +01:00
Christoph Oelckers
5bb805663e
- Duke/RR: cleaned up the rest of hitradius* as well
...
Using wallsofsector iterator plus defining local variables more locally.
2021-11-29 00:55:40 +01:00
Christoph Oelckers
63985ce6be
- Duke/RR: redo the supremely ugly code to access the third point in hitradius*
2021-11-29 00:55:40 +01:00
Mitch Richters
da7de8f1d8
- Harden the skill
CCMD to test for valid skill range for loaded game, not the maximum size of the gSkillNames[]
array which may not be completely filled. Also print valid skill names in addition to numbers to help the user.
2021-11-29 00:55:40 +01:00
Christoph Oelckers
68d653efe9
- made the same changes to hitradius_r
...
Also had to do some reformatting to get rid of the goto in there.
2021-11-29 00:55:40 +01:00
Christoph Oelckers
821f341e03
- use BFSSearch in hitradius_d
2021-11-29 00:55:39 +01:00
Christoph Oelckers
a29e6c084a
- BFSSearch class added
...
This was prompted by a bug that was recently introduced in one of the ad-hoc implementations of such a search.
Let’s better use a helper class to deal with the problems and help unify memory usage.
2021-11-29 00:55:39 +01:00
Christoph Oelckers
ad030d7e23
- Duke: SE20 + SE128 are wall-free
...
Also use symbolic constantfor SE_128 to make it easier to find.
2021-11-29 00:55:39 +01:00
Christoph Oelckers
010162261e
- Duke: use utilities in handle_se19
2021-11-29 00:55:39 +01:00
Christoph Oelckers
312bf5bf95
- Duke: use wall utilities in bounce and queball
2021-11-29 00:55:39 +01:00
Christoph Oelckers
58a091067f
- use provided sector/wall iterators in cacheit functions
2021-11-29 00:55:39 +01:00
Christoph Oelckers
aadbca8e5d
- zombie.cpp.
2021-11-29 00:55:38 +01:00
Christoph Oelckers
95c92153ad
- zilla.cpp
2021-11-29 00:55:38 +01:00
Christoph Oelckers
e98e1a6fea
- warp.cpp
2021-11-29 00:55:38 +01:00
Christoph Oelckers
21af63dfcc
- wallmove.cpp
2021-11-29 00:55:38 +01:00
Christoph Oelckers
10ea8b0fb5
- vator.cpp
2021-11-29 00:55:38 +01:00
Christoph Oelckers
2c94259603
- BossSpriteNum
2021-11-29 00:55:37 +01:00
Christoph Oelckers
36067baedd
- owner cleanup.
2021-11-29 00:55:37 +01:00
Christoph Oelckers
411c814dc3
- vis.cpp
2021-11-29 00:55:37 +01:00
Christoph Oelckers
02bdba71fc
- spike.cpp.
2021-11-29 00:55:37 +01:00
Christoph Oelckers
e2e697e9bb
- do better owner checks in weapon code.
...
Due to poor data clearing logic there is a chance that the owner of a sprite is 0 if invalid, but this code never properly checked all conditions before accessing the owner's user's ID.
2021-11-29 00:55:37 +01:00
Christoph Oelckers
cb31127df5
- removed Set3DSoundOwner entirely.
2021-11-29 00:55:36 +01:00
Christoph Oelckers
0df721f331
- sumo.cpp + associated code elsewhere.
2021-11-29 00:55:36 +01:00
Christoph Oelckers
e32a1af7b2
- lots of PlaySound calls migrated to actors.
2021-11-29 00:55:36 +01:00
Christoph Oelckers
e6c625f6e8
- second part of slidor.cpp.
2021-11-29 00:55:36 +01:00
Christoph Oelckers
2397e4c2a5
- one third of slidor.cpp
2021-11-29 00:55:35 +01:00
Christoph Oelckers
dfc557e0ec
- StarQueue
2021-11-29 00:55:35 +01:00
Christoph Oelckers
bd161f155c
- skull.cpp
2021-11-29 00:55:35 +01:00
Christoph Oelckers
a728555ec7
- skel.cpp
2021-11-29 00:55:35 +01:00
Christoph Oelckers
07f61e061e
- serp.cpp
2021-11-29 00:55:35 +01:00
Christoph Oelckers
7704042df4
- the rest of sector.cpp.
2021-11-29 00:55:35 +01:00
Christoph Oelckers
98c1684c13
- OperateSprite
2021-11-29 00:55:34 +01:00
Christoph Oelckers
1e00a4ff18
- second batch of sector.cpp
2021-11-29 00:55:34 +01:00
Christoph Oelckers
2b8ea7ae1b
- first half of sector.cpp.
...
Mostly iterators replaced.
2021-11-29 00:55:34 +01:00
Christoph Oelckers
edf8ba0aa1
- cleanup pass on sector.cpp.
...
No functional changes here.
2021-11-29 00:55:34 +01:00
Christoph Oelckers
cfebfbca8a
- rest of rotator.cpp.
2021-11-29 00:55:34 +01:00
Christoph Oelckers
1388794032
- first half of rotator.cpp.
2021-11-29 00:55:34 +01:00
Christoph Oelckers
0a18edfdad
- iterators in rooms.cpp.
2021-11-29 00:55:33 +01:00
Christoph Oelckers
6b92ee1ee6
- InitPlayerSprite
2021-11-29 00:55:33 +01:00
Christoph Oelckers
eb3131df97
- cleanup
...
mostly redundant comments.
2021-11-29 00:55:33 +01:00
Christoph Oelckers
da683ddf7a
- ripper2.cpp
2021-11-29 00:55:33 +01:00
Christoph Oelckers
3ed3029345
-some overlooked User’s.
2021-11-29 00:55:32 +01:00
Christoph Oelckers
82b4385ede
- ripper.cpp
2021-11-29 00:55:32 +01:00