Commit graph

9214 commits

Author SHA1 Message Date
Gregory John Casamento
ce04b24f05 Minor correction 2022-10-05 18:45:08 -04:00
Gregory John Casamento
909c5af00e Add code to generate keyvaluepair 2022-10-05 18:45:08 -04:00
Gregory John Casamento
7fa1ce78bb Initial skeletal implementation of NSDictionaryController 2022-10-05 18:45:08 -04:00
Gregory John Casamento
abb10cb670 Add binding name 2022-10-05 18:45:08 -04:00
Gregory John Casamento
629c3afef2 Add new class NSDictionaryController. 2022-10-05 18:45:08 -04:00
Gregory Casamento
7a42b1d04c
Merge pull request #152 from gnustep/issue151_nsradiobutton_behavior 2022-09-05 20:23:43 -04:00
Gregory John Casamento
0633f214c5 Remove unneeded import 2022-09-01 15:39:45 -04:00
Gregory John Casamento
a2b57fd1f3 Move logic to detect if it's a radio button to NSButtonCell, also simplify logic to flip the button state and prevent switch to off if button is currently on and is a radio button. This is consistent with 10.7+ behavior 2022-09-01 09:22:45 -04:00
Gregory John Casamento
3558247662 Move the call to a more centralized method so that it will be called in all cases without repeating code. 2022-08-28 05:22:16 -04:00
Gregory John Casamento
fdba6d2be6 Fixes as discussed with @fredkiefer 2022-08-27 10:09:56 -04:00
Gregory John Casamento
a9ca806c2b Changes to address issue #151. This should correct behavior of NSRadio buttons in GS and should implement the behavior seen in 10.7+ 2022-08-27 03:46:12 -04:00
Fred Kiefer
645fa46a65
Merge pull request #150 from buzzdeee/declutter_INTERFACE_VERSION
Don't misuse libgnustep-gui_INTERFACE_VERSION to define Resource Inst…
2022-08-21 22:30:04 +02:00
Sebastian Reitenbach
857c173d03 Don't misuse libgnustep-gui_INTERFACE_VERSION to define Resource Install paths
$(GNUSTEP_INSTANCE)_INTERFACE_VERSION is used in gnustep-make to define
the version of the shared object.

As a packager, there might be various reasons to
override the $(GNUSTEP_INSTANCE)_INTERFACE_VERSION
in order to control the library version.

So I do for gnustep-gui on OpenBSD packages. The problem here is, that
the libgnustep-gui_INTERFACE_VERSION is additionally used to specify the path
where resources like Panels, Localizations etc. get installed, however,
in Source/NSApplication.m, the use of
GNUSTEP_GUI_MAJOR_VERSION.GNUSTEP_GUI_MINOR_VERSION

As long as the libgnustep-gui_INTERFACE_VERSION is not overridden with
some other value, everything is fine. However, as in my case, Applications
aren't able to find the Panels/Translations provided by -gui anymore.

Decided to just remove the definition of libgnustep-gui_INTERFACE_VERSION
in these three Makefiles, as it was only used once, and used the
GNUSTEP_GUI_MAJOR_VERSION.GNUSTEP_GUI_MINOR_VERSION directly.

Alternatively, libgnustep-gui_INTERFACE_VERSION in these Makefiles
could could have been renamed to avoid this conflict.
2022-08-19 15:54:41 +02:00
Gregory John Casamento
1809fc4dc0 Add missing attributes 2022-08-09 01:35:51 -04:00
Gregory John Casamento
bd3c954807 Merge branch 'master' of github.com:gnustep/libs-gui 2022-08-09 01:25:59 -04:00
Fred Kiefer
3fcd2e704f Fix typo in test comment 2022-06-19 16:49:47 +02:00
Fred Kiefer
34423da47e * Source/NSImageCell.m,
* Source/NSAccessibilityCustomAction.m,
* Source/NSStackView.m,
* Source/NSGridView.m: Fix compiler warnings
2022-06-12 22:13:06 +02:00
Gregory John Casamento
751d94aa2c Temporary fix for issue caused by libs-base change 2022-04-30 02:27:38 -04:00
Riccardo Mottola
e0012349f6 Refactor resize bar notch width to be a constant and private inside GSTheme, making it accessible through -[GSTheme resizebarNotchWidth]. 2022-03-31 23:43:52 +02:00
Riccardo Mottola
96db5bf89c Fix resizing mode by fixing initialization order. 2022-03-31 22:58:02 +02:00
Gregory Casamento
fa1369cb64
Merge pull request #147 from gnustep/custom_class_xib3_changes 2022-03-31 00:21:28 -04:00
Fred Kiefer
24a3c29748
Merge pull request #146 from DavidHVernon/keysight-win
Another windows fix, per Greg C recommendation.
2022-03-30 23:35:33 +02:00
Gregory John Casamento
f21aa20815 Move check of index in 'key' before the xpath call 2022-03-29 20:06:53 -04:00
Gregory John Casamento
5f3b54e330 GSXibKeyedUnarchiver: Change format of customClasses dictionary 2022-03-29 19:49:35 -04:00
Gregory John Casamento
39bd359505 Move createCustomClassRecordForId:... to parent class 2022-03-28 18:47:41 -04:00
Gregory Casamento
33fea1762d
Merge branch 'master' into custom_class_xib3_changes 2022-03-26 11:28:29 -04:00
Gregory John Casamento
6025179ad2 Update ChangeLog 2022-03-26 11:25:20 -04:00
Gregory John Casamento
790b686f0d Move _customClasses to GSXibKeyedUnarchiver and implement logic to build the _customClasses array for use in Gorm when loading the xib file. 2022-03-26 11:19:59 -04:00
Fred Kiefer
80140c6336
Merge pull request #145 from gnustep/cell_resp2
Cell responder
2022-03-24 22:46:14 +01:00
David Vernon
f874ae3b9f Another windows fix, per Greg C recommendation. 2022-03-24 14:21:11 -06:00
Gregory John Casamento
de767ac0e0 Add version logic to correct issue for older gorm archives 2022-03-24 07:57:09 -04:00
Riccardo Mottola
a7397b787c add tests 2022-03-22 23:59:10 +01:00
Riccardo Mottola
6ec6f20f19 subclass initImageCell, so that RefusesFirstResponder can be set, matching Mac. 2022-03-22 22:52:06 +01:00
Fred Kiefer
def2c9765d
Merge pull request #141 from svgol/custom_build_dir_fails_to_build_libs_gui
fix to build GSSpell in custom build dir
2022-03-21 08:50:13 +01:00
Wolfgang Lux
efb9bcb2e7 Select the first item of a NSPopUpButtonCell's new menu 2022-02-26 15:30:26 +01:00
Wolfgang Lux
ec3353ecd8 Never change the state of the selected item of a NSPopUpButton configured as a pull down 2022-02-26 15:21:04 +01:00
Sergei Golovin
94dc3a107a * fix to build GSSpell in custom build dir 2022-02-22 17:26:54 +04:00
Gregory John Casamento
606505326c Minor change: Add all new headers to DocMakefile 2022-02-21 14:22:47 -05:00
Fred Kiefer
7c1af2c874
Merge pull request #140 from williameveretteggplant/autoreleasepool_NSTextView
Fix memory leak in NSTextView
2022-02-14 23:42:08 +01:00
williameveretteggplant
b70fad26a6
Use autorelease pool macros 2022-02-14 15:35:37 -07:00
Fred Kiefer
20f5694444
Merge pull request #139 from williameveretteggplant/master
Fix minor memory leaks
2022-02-14 22:45:48 +01:00
williameveretteggplant
0211713766
Remove extra line 2022-02-14 14:16:42 -07:00
williameveretteggplant
9925f50aef
Indentation 2022-02-14 14:15:26 -07:00
williameveretteggplant
aae1f34d0d
Undo change 2022-02-14 14:09:34 -07:00
williameveretteggplant
2403c21978
Fix memory leak of tool tips
Prevents the creation of tool tips where they don't already exist. Tool tips only need to be removed in the rect if there are tool tips.
2022-02-14 14:03:49 -07:00
williameveretteggplant
f37e93a440
Fix memory leak in NSTextView
On Windows, there is an occasional sporadic failure of autorelease to work correctly. In particular, this seems to happen when autorelease is invoked on an object while a call stack is in the middle of draining an autorelease pool. So, for example, when dealloc is called on an NSTextContainer, it then calls setTextContainer: on the associated NSTextView, which in turn calls textContainers on the layoutManager, which returns an autoreleased array of NSTextContainers. This array is sometimes released and sometimes it isn't.
Wrapping the setTextContainer: in an autorelease pool, which will then drain at the end of the method, rather than relying on the main autorelease pool in the run loop (which is in the middle of being drained), appears to fix this problem. This adds a small amount of overhead, but also makes the memory usage a little more efficient, since anything autoretained during the course of this method is released more quickly.
2022-02-11 17:12:50 -07:00
williameveretteggplant
3190ce4363
Merge pull request #1 from williameveretteggplant/patch-1
Fix memory leak in NSBox
2022-02-11 16:17:11 -07:00
williameveretteggplant
d744b26429
Fix GSToolTips leak in NSView
ToolTips can be present even when the flag is false, and it does no harm to invoke removeTipsForView: even if there are none. So this fixes a memory leak without any downside.
2022-02-11 16:15:28 -07:00
williameveretteggplant
db5ad42d8a
Fix memory leak in NSBox 2022-02-11 16:09:35 -07:00
Wolfgang Lux
f5ebdcd1d2 Do not update selected item's state when changing the menu 2022-02-08 22:21:38 +01:00