Commit graph

5448 commits

Author SHA1 Message Date
Gregory John Casamento
34ea78114d Merge.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35513 72102866-910b-0410-8b05-ffd578937521
2012-09-04 02:06:51 +00:00
Marcian Lytwyn
040da4f332 Patch fix for custom class substition - TEMPORARY
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35507 72102866-910b-0410-8b05-ffd578937521
2012-09-03 20:48:10 +00:00
Marcian Lytwyn
0520b35f07 Implement toolTip/setToolTip for NSTabViewItem - NOT TIED IN YET
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35506 72102866-910b-0410-8b05-ffd578937521
2012-09-03 20:39:02 +00:00
Marcian Lytwyn
781794e998 Implement showsResizeIndicator method
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35505 72102866-910b-0410-8b05-ffd578937521
2012-09-03 20:38:03 +00:00
Gregory John Casamento
3761e33981 change to id
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35498 72102866-910b-0410-8b05-ffd578937521
2012-09-02 19:20:47 +00:00
Gregory John Casamento
85a9492d22 Merge
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35497 72102866-910b-0410-8b05-ffd578937521
2012-09-02 19:18:21 +00:00
Gregory John Casamento
7fdbf3c5d0 Merge to branch.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35495 72102866-910b-0410-8b05-ffd578937521
2012-09-02 18:07:52 +00:00
Gregory John Casamento
7e684669ed * Source/GSXibLoader.m: Merge from trunk
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35486 72102866-910b-0410-8b05-ffd578937521
2012-08-31 20:34:35 +00:00
Gregory John Casamento
7b1a15cd96 * Source/GSXibLoader.m
* Source/GSXibLoading.m: Merge from trunk of new XIB fixes.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35483 72102866-910b-0410-8b05-ffd578937521
2012-08-31 16:57:39 +00:00
Marcian Lytwyn
37d5e64967 Modify WinNSOpenPanel to utilize base classes directory attribute variable
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35464 72102866-910b-0410-8b05-ffd578937521
2012-08-27 16:43:09 +00:00
Marcian Lytwyn
0cb5167322 Save NSURL (from rep) before trying to replace so it's available if the NSImageRep fails
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35406 72102866-910b-0410-8b05-ffd578937521
2012-08-13 22:37:18 +00:00
Marcian Lytwyn
b5f4b49fdb TEMP FIX for missing helvetica font
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35375 72102866-910b-0410-8b05-ffd578937521
2012-08-08 22:46:54 +00:00
Gregory John Casamento
eee9416e6b Merging changes from the trunk to the branch for testplant for NSImage changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35317 72102866-910b-0410-8b05-ffd578937521
2012-07-24 17:04:52 +00:00
Marcian Lytwyn
d888d2ec77 Fixed multi-screen support on window frame restore
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35241 72102866-910b-0410-8b05-ffd578937521
2012-06-27 18:10:40 +00:00
Marcian Lytwyn
91399c7d53 Added NSOpenSavePanelDelegate
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35237 72102866-910b-0410-8b05-ffd578937521
2012-06-27 17:50:57 +00:00
Marcian Lytwyn
1b5f5d337a Added NSControlTextEditingDelegate
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/gnustep_testplant_branch@35236 72102866-910b-0410-8b05-ffd578937521
2012-06-27 17:49:57 +00:00
Germán Arias
60f4f3c880 Revert last change in GSWindowDecorationView.m while found the real problem
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35205 72102866-910b-0410-8b05-ffd578937521
2012-06-15 18:45:14 +00:00
Eric Wasylishen
a92d331704 * Source/NSSplitView.m (adjustSubviews): Use centerScanRect to
give subviews pixel-aligned frames.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35199 72102866-910b-0410-8b05-ffd578937521
2012-06-13 06:30:42 +00:00
Germán Arias
2495374d27 Use the font size in user defaults for tooltips
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35185 72102866-910b-0410-8b05-ffd578937521
2012-06-08 04:43:06 +00:00
Germán Arias
6e3e481071 Fix bugs #36419 and #36586
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35183 72102866-910b-0410-8b05-ffd578937521
2012-06-07 18:46:44 +00:00
Wolfgang Lux
70fe303412 Prevent potential crashes due to invalid pointers left in text
containers and layout managers when their respective layout manager
and text storage are deallocated.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35178 72102866-910b-0410-8b05-ffd578937521
2012-06-05 11:34:02 +00:00
Wolfgang Lux
1dd7be22f7 Update text storage directly when undoing text changes in a NSTextView
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35175 72102866-910b-0410-8b05-ffd578937521
2012-06-02 22:31:54 +00:00
Gregory John Casamento
f8c5c4673d * Source/GSXibLoader.m:
Added NSMenu (XibCompatibility) category with method: _isMainMenu
	Added NSMenu (XibCompatibility) category implementation.
        Modified setting main menu in awake:inContainer:withContext:
	Fixes bug #36427
	Committed by: gcasa



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35159 72102866-910b-0410-8b05-ffd578937521
2012-05-21 17:56:05 +00:00
Fred Kiefer
82a110d152 * Headers/AppKit/NSInterfaceStyle.h: Remove GSNativeInterfaceStyle.
* Source/NSComboBoxCell.m (-encodeWithCoder:, -initWithCoder:):
Add a few more keyed coding values. Fixes bug #36426.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35146 72102866-910b-0410-8b05-ffd578937521
2012-05-07 20:21:59 +00:00
Fred Kiefer
023f0030e2 * Source/GSXibLoader.m: Add some (currently unused) helper code
for class substitution in flattenedProperties.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35138 72102866-910b-0410-8b05-ffd578937521
2012-05-05 16:49:43 +00:00
Fred Kiefer
74139f4848 * Source/NSPasteboard.m (NSURL-writeToPasteboard:): Revert the
last change.
* Source/NSWorkspace.m (-openURL:): Declare the URL pasteboard
type here.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35110 72102866-910b-0410-8b05-ffd578937521
2012-04-24 16:54:53 +00:00
Fred Kiefer
ea5e2a3c97 * Source/NSPasteboard.m (NSURL-writeToPasteboard:): Declare the type.
Patch by Andreas Schik <andreas.schik@web.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35109 72102866-910b-0410-8b05-ffd578937521
2012-04-24 07:48:53 +00:00
Fred Kiefer
323e1dc02f * Source/NSTabView.m (+initialize): Increase version number.
* Source/NSTabView.m (-encodeWithCoder:, -decodeWithCoder:):
Clean up last patch.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35054 72102866-910b-0410-8b05-ffd578937521
2012-04-10 21:42:25 +00:00
Sebastian Reitenbach
e65c5bc665 some int/NSInteger to NSUInteger changes to better
match return values of methods

OK Fred Kiefer



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35052 72102866-910b-0410-8b05-ffd578937521
2012-04-10 07:16:36 +00:00
Fred Kiefer
4efed91607 * Source/NSMenuItem.m (GSMenuSeparator -classForCoder): Add
missing method to get separator coding correct.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35023 72102866-910b-0410-8b05-ffd578937521
2012-04-02 20:51:06 +00:00
Eric Wasylishen
c500d8379f * Source/NSCell.m (_updateFieldEditor:): Fix what I presume is
a typo. The "if (nil == _contents) { contents = @""; }" blocks were
dead code because the contents variable would later
be set to nil if _contents was nil. This was causing an exception
when starting editing an empty text field loaded from a xib.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35011 72102866-910b-0410-8b05-ffd578937521
2012-03-27 19:26:17 +00:00
Eric Wasylishen
a900e2f5cb * Headers/AppKit/NSSplitView.h:
* Source/NSSplitView.m: Add support for
splitView:shouldAdjustSizeOfSubview: delegate method.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35002 72102866-910b-0410-8b05-ffd578937521
2012-03-27 04:32:57 +00:00
Eric Wasylishen
32aa3f4c83 * Source/GSToolTips.m (-mouseEntered:): When calling the owner's
view:stringForToolTip:point:userData: method, make the point
relative to the view's coordinate system (tested on OS X) instead
of relative to the tracking rect (as before.)
* Source/GSToolTips.m (-_timedOut:): Fix a crash caused by
invalidating the timer and then using its userInfo object.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35000 72102866-910b-0410-8b05-ffd578937521
2012-03-27 03:38:59 +00:00
Eric Wasylishen
62a3374ae9 * Source/NSAttributedString.m
(-initWithData:options:documentAttributes:error:): Set
NSCharacterEncodingDocumentAttribute in the documentAttributes dict
when reading plain text.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34987 72102866-910b-0410-8b05-ffd578937521
2012-03-23 03:16:40 +00:00
Eric Wasylishen
9345069a14 * Source/NSAttributedString.m
(-initWithData:options:documentAttributes:error:): Fixes for TextEdit.
If no type is provided, assume plain text. If no encoding is provided,
assume UTF-8 unless a UTF-16 BOM is detected.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34985 72102866-910b-0410-8b05-ffd578937521
2012-03-23 01:40:11 +00:00
Eric Wasylishen
93ca7c0e0e * Source/GSThemeDrawing.m (-toolbarBorderColor): Change default to
[NSColor darkGrayColor]
* Source/NSToolbar.m (-initWithIdentifier:): Call
[self setShowsBaselineSeparator: YES] by default so the toolbar has
a bottom border.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34983 72102866-910b-0410-8b05-ffd578937521
2012-03-22 23:11:44 +00:00
Fred Kiefer
e8d2648aca * Headers/AppKit/NSKeyValueBinding.h,
* Source/externs.m: Additional binding names.
* Source/GSBindingHelpers.h,
* Source/NSKeyValueBinding.m: Additional helper methods.
* Source/NSObjectController.m: Use helper methods.
* Source/NSArrayController.m: Signal when the arranged objects
change.
* Source/NSTableColumn.m,
* Source/NSTableView.m: First attempt at support for content
binding.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34923 72102866-910b-0410-8b05-ffd578937521
2012-03-12 12:24:17 +00:00
Eric Wasylishen
df87a9f362 * Source/NSTableView.m:
* Source/GSNibLoading.m: Move -[coder setClassName: @"_NSCornerView"
forClass: [GSTableCornerView class]] call from
-[NSTableView initWithCoder:] to GSNibLoading, because corner views
can be encountered before hitting -[NSTableView initWithCoder:]


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34919 72102866-910b-0410-8b05-ffd578937521
2012-03-09 23:18:18 +00:00
Eric Wasylishen
325a56881f * Source/NSClipView.m: Re-enable copy-on-scroll
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34918 72102866-910b-0410-8b05-ffd578937521
2012-03-09 22:28:59 +00:00
Eric Wasylishen
88fdeb6886 * Source/NSWindow.m: Only invoke -prepareForDragOperation: if the
most recent -draggingEntered: or -draggingUpdated: call returned
something other than NSDragOperationNone.
* Source/NSOutlineView.m (-draggingUpdated:): Save the drag operation
value returned from the data source in a static variable.
Previously it was fetched once and then discarded, so all drags were
being mistakenly permitted.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34910 72102866-910b-0410-8b05-ffd578937521
2012-03-09 08:03:45 +00:00
Fred Kiefer
37db8ec30e * Source/NSObjectController.m: Complete encoding/decoding methods.
* Headers/AppKit/NSArrayController.h,
* Source/NSArrayController.m: Add some implementation to this class.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34904 72102866-910b-0410-8b05-ffd578937521
2012-03-07 23:58:57 +00:00
Eric Wasylishen
733983d52b * Source/NSMenuItemCell.m (-titleRectForBounds:): Attempted fix
for bug 35702.
Don't use [_menuView imageAndTitleWidth] or
_titleWidth in calculating the size to put the title in. In other
words, -titleRectForBounds: will now return the available space
for the title, rather than the rect that the title text is
predicted to use up.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34885 72102866-910b-0410-8b05-ffd578937521
2012-03-06 04:24:51 +00:00
Gregory John Casamento
4193fb4122 * Headers/AppKit/NSTreeController.h
* Headers/AppKit/NSTreeNode.h
	* Source/NSTreeController.m: Add tree controller skeleton.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34847 72102866-910b-0410-8b05-ffd578937521
2012-02-29 15:32:09 +00:00
Gregory John Casamento
444f88c80c * Source/GNUmakefile: Add GSXibLoading.m file to GNUmakefile.
* Source/GSXibLoading.m: Add some classes which I found
	are relevant to Xib loading: IBAccessibilityAttribute,
	IBUserDefinedRuntimeAttributesPlaceholder.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34846 72102866-910b-0410-8b05-ffd578937521
2012-02-29 15:27:09 +00:00
Eric Wasylishen
fa247da211 * Source/NSPrintPanel.m: Add file type chooser (PDF, PostScript)
to save panel


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34844 72102866-910b-0410-8b05-ffd578937521
2012-02-28 07:22:16 +00:00
Eric Wasylishen
ac0663e17a * Source/NSMenuItemCell.m (-titleRectForBounds:): Keep title rect
inside cell bounds, to prevent drawing text outside of a
NSPopUpButtonCell which has a label that is too long to fit.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34838 72102866-910b-0410-8b05-ffd578937521
2012-02-28 00:13:04 +00:00
Fred Kiefer
3d73efb55c * Source/NSWindowController.m (-initWithWindow:): Set the owner to
self and only call setDocument: if we have an actual window.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34825 72102866-910b-0410-8b05-ffd578937521
2012-02-27 12:23:05 +00:00
Fred Kiefer
d3321c2ffa * Source/NSWindow.m (-setFrameFromString:): Correct bug in
handling of in-window menus.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34798 72102866-910b-0410-8b05-ffd578937521
2012-02-20 17:46:28 +00:00
Wolfgang Lux
44fb01a3fb Replace calls to private method -_setupForTypes: in NSOpenPanel, as
that method was removed from its superclass NSSavePanel.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34782 72102866-910b-0410-8b05-ffd578937521
2012-02-19 16:32:52 +00:00
Wolfgang Lux
1d0294acc2 Revert change from r34642 which has broken OS X compatibility and fix
sender of a pop up button's action when it is sent through one of the
menu items.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34781 72102866-910b-0410-8b05-ffd578937521
2012-02-19 16:22:49 +00:00
Fred Kiefer
e654c1c5b5 Replace NSCompositeHighlight with GSCompositeHighlight and map NSCompositeHighlight onto
NSCompositeSourceOver.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34773 72102866-910b-0410-8b05-ffd578937521
2012-02-18 21:10:07 +00:00
Fred Kiefer
4d8bbcfe9b * Source/NSBitmapImageRep.m (-_convertToFormatBitsPerSample:...bitsPerPixel:): Correct
handling of black data.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34762 72102866-910b-0410-8b05-ffd578937521
2012-02-15 22:04:08 +00:00
Richard Frith-MacDonald
b18a55a842 filter service fixes
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34752 72102866-910b-0410-8b05-ffd578937521
2012-02-14 18:31:28 +00:00
Richard Frith-MacDonald
b71be91d36 minor tidyup
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34742 72102866-910b-0410-8b05-ffd578937521
2012-02-08 10:36:46 +00:00
Fred Kiefer
0bf9693431 * Source/NSPasteboard.m (+pasteboardByFilteringFile:): Correct
typo in Richard's change.
* Source/NSPasteboard.m (-pasteboard:provideDataForType:): Use
 the file name directly instead of reading the file contents.
* Source/NSImageRep.m (+imageRepsWithContentsOfFile:,
+imageFileTypes):
Start working on filter service support for images.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34741 72102866-910b-0410-8b05-ffd578937521
2012-02-08 09:42:46 +00:00
Richard Frith-MacDonald
4efb00ae4c fixup error in filtering file by name
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34740 72102866-910b-0410-8b05-ffd578937521
2012-02-08 09:21:06 +00:00
Eric Wasylishen
bd5ff5ba95 * Headers/AppKit/NSOutlineView.h:
* Source/NSOutlineView.m: Add support for
outlineView:dataCellForTableColumn:item: delegate method
* Headers/AppKit/NSTableView.h:
* Source/NSTableView.m: Add support for
tableView:dataCellForTableColumn:row: delegate method


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34717 72102866-910b-0410-8b05-ffd578937521
2012-02-03 21:41:41 +00:00
Riccardo Mottola
7f6bdeb0a2 centerScanRect button to avoid blurring
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34693 72102866-910b-0410-8b05-ffd578937521
2012-02-01 22:07:41 +00:00
Fred Kiefer
cea7a7e137 * Source/GSThemeInspector.m: Add missing include.
This was causing prblems on Windows.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34692 72102866-910b-0410-8b05-ffd578937521
2012-02-01 18:42:10 +00:00
Fred Kiefer
2d48b49175 Deal with images taht result in no data. This happens in themes that
have to small images to be split up into 9 tiles.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34688 72102866-910b-0410-8b05-ffd578937521
2012-02-01 10:49:35 +00:00
Fred Kiefer
462b24489f * Source/NSMenu.m (-setMain:): Rearrange code to avoid duplicate
menu for in-window menu themes.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34687 72102866-910b-0410-8b05-ffd578937521
2012-02-01 09:12:34 +00:00
Fred Kiefer
1b398c6621 * Source/GSThemeInspector.m (-update:): Don't get the frame from a
non-existing view. This was currupting the stack with gcc 4.6 on i386.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34686 72102866-910b-0410-8b05-ffd578937521
2012-02-01 09:00:23 +00:00
Eric Wasylishen
6e4da7d0e3 * Source/NSImageCell.m (-drawInteriorWithFrame:inView:): Only
draw at 50% opacity if no bezel is set for cocoa compatibility.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34674 72102866-910b-0410-8b05-ffd578937521
2012-01-31 02:27:18 +00:00
Eric Wasylishen
c2ef95964f * Source/GNUmakefile: Remove GSGhostscriptImageRep from the build
* Source/NSImageRep.m: Remove GSGhostscriptImageRep
* configure.ac: Disable ImageMagic by default
* configure: Regenerate


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34671 72102866-910b-0410-8b05-ffd578937521
2012-01-30 21:06:08 +00:00
Fred Kiefer
9d0b8b4dfd * Source/NSMenu.m (-setMain:): Remove the in-window menu when
switching to a theme without that.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34652 72102866-910b-0410-8b05-ffd578937521
2012-01-29 00:43:50 +00:00
Fred Kiefer
899ce772cb * Source/NSMenu.m (-performActionForItemAtIndex:): Check for the
popup button cell and its action, before checking for the item
action. This caused a problem due to NIB decoding changes.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34642 72102866-910b-0410-8b05-ffd578937521
2012-01-26 22:38:50 +00:00
Fred Kiefer
2d2026e7fc Revert last change and replace with something a little bit better. The
whole ruler handling will need some deeper inspection.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34636 72102866-910b-0410-8b05-ffd578937521
2012-01-26 09:25:29 +00:00
Doug Simons
3e7c9bceef Call setClientView: before calling setMarkers: to fix a problem when a textView's text is set or changed when the textView is not the first responder, such as at windowControllerDidLoadNib: time.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34633 72102866-910b-0410-8b05-ffd578937521
2012-01-25 23:28:51 +00:00
Eric Wasylishen
cbf7bc52a9 * Source/NSImage.m (+imageNamed:): Don't try to look up path
if called with nil (just return nil).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34632 72102866-910b-0410-8b05-ffd578937521
2012-01-25 23:25:14 +00:00
Eric Wasylishen
d81df878a5 * Source/NSClipView.m: Disable copy-on-scroll until after release
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34631 72102866-910b-0410-8b05-ffd578937521
2012-01-25 22:17:53 +00:00
Eric Wasylishen
e1aff0a971 * Source/NSClipView (-constrainScrollPoint:): Revert last change
until after the release.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34630 72102866-910b-0410-8b05-ffd578937521
2012-01-25 22:13:58 +00:00
Fred Kiefer
7c3ae3029d * Source/NSSecureTextField.m: Add GSSimpleSecureGlyphGenerator and
use this to generate the bullet glyphs.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34622 72102866-910b-0410-8b05-ffd578937521
2012-01-24 10:40:13 +00:00
Eric Wasylishen
fe39394d44 * Source/NSClipView.m (-constrainScrollPoint:): Restore old code
which correctly rounded the scroll point to an integer point in
device-space. It seems the correct code was commented out in 2002,
perhaps as a performance optimisation?


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34614 72102866-910b-0410-8b05-ffd578937521
2012-01-24 01:33:17 +00:00
Fred Kiefer
d570812401 Fix clang compiler warnings as reported by Sebastian Reitenbach
<sebastia@l00-bugdead-prods.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34608 72102866-910b-0410-8b05-ffd578937521
2012-01-23 14:27:58 +00:00
Eric Wasylishen
d55752b22c * Source/NSView.m (-setBounds:, -setBoundsOrigin:, -setBoundsSize:):
Revert a portion of r32955 which I committed last april but I now
see was a mistake, and I just discovered is breaking the  copy-on-scroll
behaviour of NSClipView - we end up always redrawing the entire visible
portion of the document view right now.

In r32955 I added [self setNeedsDisplay: YES] calls to these methods
even though these are documented explicitly as not marking the view for
needing display. Approved by Fred for commit during the code freeze.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34606 72102866-910b-0410-8b05-ffd578937521
2012-01-21 19:15:51 +00:00
Germán Arias
13f1a53070 Fix bug #35335
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34599 72102866-910b-0410-8b05-ffd578937521
2012-01-20 06:10:03 +00:00
Fred Kiefer
ace1561e52 * Source/NSCell.m (-setStringValue:, setObjectValue:): Always use
ASSIGNCOPY for the contents. This fixes memory leak of last commit.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34585 72102866-910b-0410-8b05-ffd578937521
2012-01-19 08:47:52 +00:00
Riccardo Mottola
9603f29b84 Copy contents before setting it [setObjectValue]
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34584 72102866-910b-0410-8b05-ffd578937521
2012-01-19 00:40:47 +00:00
Fred Kiefer
62f2a5af94 * Headers/AppKit/NSImageView.h,
* Source/NSImageView.m: Protect image drag with new ivar that
gets set via a new GNUstep extension method.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34580 72102866-910b-0410-8b05-ffd578937521
2012-01-18 21:03:37 +00:00
Eric Wasylishen
7da6d417a7 * Source/NSImageCell.m (-drawInteriorWithFrame:inView:):
Draw image with 50% opacity if the cell is disabled


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34548 72102866-910b-0410-8b05-ffd578937521
2012-01-15 21:35:47 +00:00
Eric Wasylishen
1b70ae827a * Source/NSTableColumn.m (-initWithIdentifier:): Make data
cell editable by default.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34547 72102866-910b-0410-8b05-ffd578937521
2012-01-15 21:34:40 +00:00
Richard Frith-MacDonald
db92916b2f Attempt to get gnome and windows themes working again.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34528 72102866-910b-0410-8b05-ffd578937521
2012-01-14 17:55:43 +00:00
Richard Frith-MacDonald
28460f68e4 Cleanup/simplify code for handling theme names in defaults system
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34527 72102866-910b-0410-8b05-ffd578937521
2012-01-14 16:10:48 +00:00
Fred Kiefer
6149707b77 * Source/GSStandardWindowDecorationView.m (-mouseDown:): Pass the
event on to the super implementation if we don't handle it.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34500 72102866-910b-0410-8b05-ffd578937521
2012-01-12 09:42:03 +00:00
Fred Kiefer
e2884bafce * Source/NSImage.m (+_clearFileTypeCaches): Use DESTROY instead of
RELEASE.
Patch by Philippe Roussel <p.o.roussel@free.fr>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34492 72102866-910b-0410-8b05-ffd578937521
2012-01-11 08:12:43 +00:00
Eric Wasylishen
53ac9ad559 * Source/NSImage.m: Remove duplicate #import
* Source/NSImage.m: Correct _clearFileTypeCaches notification
method to take a NSNotification* parameter.
* Soure/NSImage.m (themeDidActivate:): Move to a class method,
and move the GSThemeDidActivateNotification subscription
to +[NSImage initialize]. Now the +_themeDidActivate: updates
all images by looking at all the values in nameDict. This should
function exactly the same as before, but seems to be quite a bit
faster due to fewer notifications being sent (?)
* Source/NSImage.m (+imageNamed:): Remove redundant fetch from
nameDict pointed out by Fred


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34482 72102866-910b-0410-8b05-ffd578937521
2012-01-10 19:16:46 +00:00
Eric Wasylishen
378ca9230e * Source/NSImage.m (+pathForImageNamed:): Add underscore and
move to private category. Also remove use of lock as it is
unnecessary
* Source/NSImage.m: (-themeDidActivate:): Extract method
_resetAndUseFromFile:. Don't reset _size if
flags.sizeWasExplicitlySet was true.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34481 72102866-910b-0410-8b05-ffd578937521
2012-01-10 18:55:57 +00:00
Eric Wasylishen
f2fe6fead5 * Source/NSOpenPanel.m: Rewrite/simplify selection handling,
fix bug reported by Riccardo where OK button is disabled when
selecting directories after selecting a file.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34480 72102866-910b-0410-8b05-ffd578937521
2012-01-10 18:42:04 +00:00
Eric Wasylishen
bfd7621ba5 * Source/GSGhostscriptImageRep.m: Add missing ASSIGN
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34479 72102866-910b-0410-8b05-ffd578937521
2012-01-10 18:39:34 +00:00
Eric Wasylishen
bff0f57b54 * Source/GSTheme.m: Remove code which sets and unsets images
on theme activation/deactivation.
* Source/NSImage.m (+imageNamed:): Factor out code for finding
the path for a name to a separate method, +pathForImageNamed.
The code is unchanged otherwise, except for fixing the retrieval
of images from the theme bundle, which was broken.
* Source/NSImage.m (-setName:): Remove code for creating theme
proxy. Subscribe/unscribe to theme change notification when
the receiver is added/removed from the name dictionary.
* Source/NSImage.m (-themeDidActivate:): Method called in
response to a GSThemeDidActivateNotification on images with
a name set. It does a path lookup in the same way that
+imageNamed: would, and checks if the path has changed due
to the theme change. If it has, all reps are discarded and
the image at the new path is loaded. This avoids the need for
the theme proxy objects.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34474 72102866-910b-0410-8b05-ffd578937521
2012-01-10 04:38:10 +00:00
Fred Kiefer
82eac9eaf0 Declare the new method
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34470 72102866-910b-0410-8b05-ffd578937521
2012-01-09 14:40:45 +00:00
Fred Kiefer
93403780f3 Cache the file type results for the image reps and clear the cache when these change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34469 72102866-910b-0410-8b05-ffd578937521
2012-01-09 14:39:50 +00:00
Fred Kiefer
c1a3a4549b Raise an exception if the PPD file cannot be read. Change make based on
request by Riccardo on the mailing list.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34397 72102866-910b-0410-8b05-ffd578937521
2012-01-03 09:18:51 +00:00
Wolfgang Lux
95c5829fa5 Fix two incorrect comparisons in NSLayoutManager which were causing
range exceptions when moving the cursor up in the first line and down
in the last line of a NSTextView, respectively.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34375 72102866-910b-0410-8b05-ffd578937521
2012-01-01 11:29:20 +00:00
Eric Wasylishen
4eac748b62 * Source/NSPrintOperation.m (_print): Fix read of uninitialized
variable, which was breaking printing of wrap-to-page mode in
TextEdit. TODO: Run the printing code through valgrind, there is
a lot of suspicious code.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34373 72102866-910b-0410-8b05-ffd578937521
2011-12-31 22:37:55 +00:00
Wolfgang Lux
cc31ecbeda Change the default text container inset for NSTextView to (0,0) to
reduce blank space around text.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34367 72102866-910b-0410-8b05-ffd578937521
2011-12-29 22:16:50 +00:00
Wolfgang Lux
b046febc21 Get the insertion point rectangle right for character index 0.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34364 72102866-910b-0410-8b05-ffd578937521
2011-12-29 18:34:27 +00:00
Wolfgang Lux
0da1b1f034 Adjust the minimum and maximum sizes of a NSTextView to ensure that
the minimum size is not greater than the current size and the maximum
size is not smaller than the current size.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34362 72102866-910b-0410-8b05-ffd578937521
2011-12-29 16:48:17 +00:00
Eric Wasylishen
2f0f50cc95 Undo last change as it broke Graphos printing
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34353 72102866-910b-0410-8b05-ffd578937521
2011-12-23 21:22:41 +00:00
Eric Wasylishen
d374f0acae * Source/NSView.m (-beginPageInRect:atPlacement:): Always translate
by the placement value. Previously, we would translate only if the
rect parameter was empty, which doesn't make sense to me.
This fixes the bug where the last page of a document printed from
Ink/TextEdit was incorrectly positioned at the bottom of the
printed page.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34352 72102866-910b-0410-8b05-ffd578937521
2011-12-23 20:33:19 +00:00
Fred Kiefer
e740f7b0cc * Source/NSTextView.m (-setFieldEditor:): Use different values for
both cases.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34347 72102866-910b-0410-8b05-ffd578937521
2011-12-22 22:00:42 +00:00
Eric Wasylishen
30a76f4458 * Source/NSSavePanel.m (-browser:createRowsForColumn:inMatrix:):
Set icon size based on cell's cellSize


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34346 72102866-910b-0410-8b05-ffd578937521
2011-12-22 19:08:47 +00:00
Fred Kiefer
12bbf00d16 Removed a few compiler warnings found by gcc 4.6
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34344 72102866-910b-0410-8b05-ffd578937521
2011-12-22 09:16:04 +00:00
Eric Wasylishen
52b39d8923 * Source/NSBrowserCell.m (-drawInteriorWithFrame:inView:):
Restore code to draw the background when the cell is highligted


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34337 72102866-910b-0410-8b05-ffd578937521
2011-12-21 06:43:42 +00:00
Eric Wasylishen
b2e98ecb59 * Source/NSSavePanel.m (-browser:createRowsForColumn:inMatrix:):
Set file icons on browser cells in the open/save panels.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34322 72102866-910b-0410-8b05-ffd578937521
2011-12-19 01:00:07 +00:00
Eric Wasylishen
3445284ccc * Source/NSBrowserCell.m (-drawInteriorWithFrame:inView:):
When highlighted, use -image if -alternateImage is nil.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34321 72102866-910b-0410-8b05-ffd578937521
2011-12-19 00:54:49 +00:00
Eric Wasylishen
d8ed82a8a8 * Source/NSTableView.m (-_isCellEditableColumn:row:): Tweak
criteria for determining cell editability::
- the delegate (if present) must say YES
- and the cell itself must return YES for isEditable
- and the table column must return YES for isEditable
Previously you could edit cells that returned NO for
isEditable if the column they were in was editable.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34320 72102866-910b-0410-8b05-ffd578937521
2011-12-19 00:18:58 +00:00
Eric Wasylishen
0c1a040bda * Source/NSTableHeaderView.m (-initWithCoder:): Remove unneeded
"_tableView = nil" which was causing a problem with my xib file.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34319 72102866-910b-0410-8b05-ffd578937521
2011-12-18 23:57:39 +00:00
Eric Wasylishen
58c670f346 * Source/NSBrowserCell.m (-image, -setImage:): Override NSCell
implementation so these methods work without requiring the
cell to be an image cell.
* Source/NSBrowserCell.m (-drawInteriorWithFrame:inView:): Don't
draw background. Remove -(void) isOpaque { return YES; }. Also
pixel-align images and use modern -drawInRect: method.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34317 72102866-910b-0410-8b05-ffd578937521
2011-12-18 22:16:20 +00:00
Fred Kiefer
a17f42c6da * Source/NSOutlineView.m (-_openItem:): Changed i fron NSUInteger
to NSInteger.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34316 72102866-910b-0410-8b05-ffd578937521
2011-12-18 21:06:31 +00:00
Fred Kiefer
c35a95998d Make the same change in NSDrawer and also switch to CGFloat.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34314 72102866-910b-0410-8b05-ffd578937521
2011-12-17 20:29:09 +00:00
Fred Kiefer
8ad4aa86c4 Replace some occurences of int with NSInteger
and unsigned with NSUInteger. This allows to recompile gui on 
64 bit systems after the change to NSNotFound in base.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34312 72102866-910b-0410-8b05-ffd578937521
2011-12-17 17:16:09 +00:00
Eric Wasylishen
10ee7a4dd2 * Source/NSPrintPanel.m:
Move _finalWritePrintInfo: call to the end of _pickedButton:. This
fixes the save and preview buttons for me.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34294 72102866-910b-0410-8b05-ffd578937521
2011-12-15 18:31:34 +00:00
Eric Wasylishen
e395fe88d7 * Source/NSPrinter.m:
* Source/NSPrintOperation.m:
* Source/NSPageLayout.m:
* Source/NSPrintInfo.m:
* Headers/AppKit/NSPrintInfo.h: Migrate printing code to CGFloat
or double.
* Source/NSTextView.m: Rewrite -adjustPageHeightNew🔝bottom:limit:


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34288 72102866-910b-0410-8b05-ffd578937521
2011-12-15 06:51:02 +00:00
Eric Wasylishen
44d4221385 * Source/NSImageCell.m: if drawing on a view use -centerScanRect:
to pixel align the drawing rect.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34285 72102866-910b-0410-8b05-ffd578937521
2011-12-14 18:52:42 +00:00
Germán Arias
8936dbf826 Verify if there is error information to be displayed in an Alert panel
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34242 72102866-910b-0410-8b05-ffd578937521
2011-12-02 23:15:07 +00:00
Wolfgang Lux
6365fa5127 Reinstate Fred's change with the additional correction to the string
drawing code he proposed on the mailing list.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34241 72102866-910b-0410-8b05-ffd578937521
2011-12-02 21:36:58 +00:00
Eric Wasylishen
f218a41010 * Source/NSTextView.m
(-_scheduleTextCheckingInVisibleRectIfNeeded): Check for
nil before sending -rectValue to avoid crash


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34238 72102866-910b-0410-8b05-ffd578937521
2011-12-02 05:10:54 +00:00
Gregory John Casamento
14d5d889be revert change by fred.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34230 72102866-910b-0410-8b05-ffd578937521
2011-11-30 15:43:04 +00:00
Fred Kiefer
db75526dee * Source/NSPopUpButtonCell.m (-initWithCoder:): If no selection
index is given select the first item. This should fix bug #34923.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34228 72102866-910b-0410-8b05-ffd578937521
2011-11-28 20:29:35 +00:00
Fred Kiefer
865c22357b * Source/NSTextView.m (-buildUpTextNetwork:): Move setting the
default line framgent padding from here ...
* Source/NSTextContainer.m (-initWithContainerSize:): ... to here.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34227 72102866-910b-0410-8b05-ffd578937521
2011-11-28 17:20:45 +00:00
Fred Kiefer
e11f1e26b3 Commit OpenGL patch by Julian Mayer <julian@corecode.at>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34226 72102866-910b-0410-8b05-ffd578937521
2011-11-28 17:16:10 +00:00
Gregory John Casamento
e9aaaf4b61 Changes to correct bug#34919. NSTextView should now correctly show the padding set in the lineFragmentPadding attribute of NSTextContainer.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34222 72102866-910b-0410-8b05-ffd578937521
2011-11-28 02:37:58 +00:00
Eric Wasylishen
2992f4fa1d * Source/GSNibLoading.m:
* Source/NSToolbar.m:
* Source/GSToolbarCustomizationPalette.m:
* Source/GSToolbarView.m:
* Source/NSToolbarItem.m:
* Source/NSToolbarFrameworkPrivate.h:
* Headers/AppKit/NSToolbar.h: Implement -initWithCoder: for
NSToolbar. This required a bit more work that usual because
toolbars created with -initWithCoder can operate without a delegate.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34189 72102866-910b-0410-8b05-ffd578937521
2011-11-18 20:15:53 +00:00
Riccardo Mottola
115a372c27 minor compiler compatibility
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34183 72102866-910b-0410-8b05-ffd578937521
2011-11-16 23:33:48 +00:00
Quentin Mathe
98e188a767 Removed logging statement that shouldn't have been committed
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34175 72102866-910b-0410-8b05-ffd578937521
2011-11-16 10:37:47 +00:00
Quentin Mathe
96aad93e0f Improved the menu theming to support some common menu look variations.
Fixed bug #34792 too.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34174 72102866-910b-0410-8b05-ffd578937521
2011-11-16 10:32:15 +00:00
Fred Kiefer
eaafb6754d * Source/NSImage.m (-bestRepresentationForDevice:): Fix last
change for the case where there are no representations for the
image.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34168 72102866-910b-0410-8b05-ffd578937521
2011-11-13 19:24:17 +00:00
Fred Kiefer
7b7ec00dba * Source/NSUserDefaultsController.m
([GSUserDefaultsHelper-valueForKey:]) Use a marker for values
  being nil. This should fix bug #34790.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34167 72102866-910b-0410-8b05-ffd578937521
2011-11-13 16:43:26 +00:00
Eric Wasylishen
3ace7a7cf7 * Source/NSImage.m (-bestRepresentationForDevice:): When
all other matching criteria fail, use the first image instead
of the last (arbitrary, but seems to match cocoa.)


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34166 72102866-910b-0410-8b05-ffd578937521
2011-11-12 01:57:01 +00:00
Eric Wasylishen
ed60c25d45 * Source/NSAlert.m: Use NSImageScaleProportionallyUpOrDown on
app icon button cell.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34165 72102866-910b-0410-8b05-ffd578937521
2011-11-12 01:16:17 +00:00
Eric Wasylishen
c7531f2386 * Source/NSImage.m (-setScalesWhenResized:): Disable this method
as it is currently broken on the cairo backend.
* Source/NSApplication.m (-setApplicationIconImage:): Don't
use call -setScalesWhenResized:, because if it worked as it is
supposed to, it would scale all icon reps down to 48x48,
making large icon sizes useless.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34164 72102866-910b-0410-8b05-ffd578937521
2011-11-12 00:40:18 +00:00
Eric Wasylishen
1cffdb27c7 * Source/GSInfoPanel.m: Fix app icon button size at 48x48 and use
NSImageScaleProportionallyUpOrDown.
This prevents icons with large sizes (e.g. 512x512 pixel) from
making the info panel really big.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34161 72102866-910b-0410-8b05-ffd578937521
2011-11-11 23:16:50 +00:00
Eric Wasylishen
60674d5076 * Headers/AppKit/NSImageCell.h:
* Headers/AppKit/NSCell.h: Move NSImageScaling constants to NSCell
* Source/NSImageCell.m:
* Source/NSCell.m: Refactor the image scaling logic to a private
method in NSCell, -_scaleImageWithSize:toFitInSize:scalingType:
which can be share by NSImageCell, NSButtonCell, and any other
cell classes that need it.
* Source/NSButtonCell.m:
* Headers/AppKit/NSButtonCell.h: Implement -imageScaling and
-setImageScaling methods. 
* Source/GSThemeDrawing.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Remove the
-drawImage:inButtonCell:withFrame:position: API intended
to let themes substitute images right before drawing,
as IMHO it's the wrong place to hook in new images (by
the time this method was caleld, sizing/positionging
was already done).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34160 72102866-910b-0410-8b05-ffd578937521
2011-11-11 23:10:15 +00:00
Fred Kiefer
45d5c38825 * Source/GSXibLoader.m: Better handling for flattened properties
to set the tool tips of an object. Should fix bug report #34783


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34155 72102866-910b-0410-8b05-ffd578937521
2011-11-11 00:03:11 +00:00
Fred Kiefer
d0d0df78ee * Source/NSKeyValueBinding.m ([GSKeyValueBinding-transformValue:withOptions:]):
Don't use @"" when no null placeholder is defined.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34135 72102866-910b-0410-8b05-ffd578937521
2011-11-07 20:46:55 +00:00
Fred Kiefer
4d0e9108ba * Source/NSColorWell.m (-objectValue, -setObjectValue:,
-takeObjectValueFrom:): Add these missing methods.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34132 72102866-910b-0410-8b05-ffd578937521
2011-11-07 15:30:33 +00:00
Eric Wasylishen
7362d7314d * Source/NSBitmapImageRep+PNG.m:
HACK: PNG can not represent 72DPI exactly. If the pixels-per-meter value is
near 72DPI, assume it is exactly 72 DPI. Note that the same problem occurrs
at 144DPI, or 288DPI... so don't use PNG for resolution independent graphics.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34127 72102866-910b-0410-8b05-ffd578937521
2011-11-06 22:31:23 +00:00
Fred Kiefer
4b64d6f2f6 * Source/NSPopUpButtonCell.m (-insertItemWithTitle:atIndex:): Set
the action on the menu item to -_popUpItemAction:.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34126 72102866-910b-0410-8b05-ffd578937521
2011-11-06 17:10:10 +00:00
Fred Kiefer
407da1b829 Add decoding of class IBInitialTabViewItemAttribute.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34124 72102866-910b-0410-8b05-ffd578937521
2011-11-05 17:45:09 +00:00
Richard Frith-MacDonald
be8c8f6657 iTolerat 'Authors' in the plist being a string
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34116 72102866-910b-0410-8b05-ffd578937521
2011-11-04 06:16:37 +00:00
Fred Kiefer
ccbfc5c0c0 Add some bindings for NSTabView.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34112 72102866-910b-0410-8b05-ffd578937521
2011-11-02 23:16:38 +00:00
Eric Wasylishen
26567e31d8 * Source/NSColorPanel.m: Always send action and colorChanged: when
the color changes. NSColorPanel is always "continuous" for now...
to support -isContinuous == NO, we need to augment the API between
the color panel and the pickers so they can send a message when
the mouse is released.
* Source/NSTextView.m: Change typing attributes in response to
colorChanged:


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34105 72102866-910b-0410-8b05-ffd578937521
2011-11-01 20:31:24 +00:00
Eric Wasylishen
e6db640322 * Source/NSView.m: centerScanRect patch from Sebastian Reitenbach.
Note that this makes the NSView autoresizing and rounding test pass,
but the new centerScanRect test I just added fail.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34104 72102866-910b-0410-8b05-ffd578937521
2011-11-01 17:45:21 +00:00
Fred Kiefer
ba0d01b2fb * Source/NSPopUpButtonCell.m (-_popUpItemAction:): Inform bindings
of the control view that the value has changed.
Should fix bug #34492


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34099 72102866-910b-0410-8b05-ffd578937521
2011-10-31 21:48:32 +00:00
Fred Kiefer
16e01f25a1 Correct the instantiation of NIB bindings. Should fix bug #34644.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34098 72102866-910b-0410-8b05-ffd578937521
2011-10-31 17:52:33 +00:00
Fred Kiefer
c72e465a66 Remove useless KVB code. I hope to commit better code later on.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34097 72102866-910b-0410-8b05-ffd578937521
2011-10-31 17:12:39 +00:00
Fred Kiefer
7e8ce092b1 Clean up last change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34096 72102866-910b-0410-8b05-ffd578937521
2011-10-31 16:58:27 +00:00
Gregory John Casamento
045d8b59b6 Added code to handle sort descriptors from gorm files into NSTableColumn.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34095 72102866-910b-0410-8b05-ffd578937521
2011-10-31 14:45:06 +00:00
Quentin Mathe
e2967ab5bc Made separator menu item themable, by moving the drawing code from
NSMenuItemCell to a new method in GSThemeDrawing.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34079 72102866-910b-0410-8b05-ffd578937521
2011-10-28 09:40:41 +00:00
Fred Kiefer
afe8c3bea5 * Source/NSBitmapImageRep.m (+imageRepWithData:): Add missing
AUTORELEASE.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34078 72102866-910b-0410-8b05-ffd578937521
2011-10-27 17:07:54 +00:00
Eric Wasylishen
fde5f243d8 * Source/NSCell.m: Read/write NSLineBreakMode from the bits masked off
by 0xE00 in NSCellFlags2. The previous location they were being
read/written from was giving bogus values such as 7.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34073 72102866-910b-0410-8b05-ffd578937521
2011-10-26 20:01:31 +00:00
Eric Wasylishen
991c4639a7 * Source/GSThemeDrawing.m: Draw a question mark centered in the bezel
for NSHelpButtonBezelStyle


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34072 72102866-910b-0410-8b05-ffd578937521
2011-10-26 02:25:36 +00:00
Eric Wasylishen
25c6770196 * Source/NSBitmapImageRep.m:
* Source/NSColor.m:
* Source/GSThemeTools.m:
* Source/NSGraphicsContext.m:
* Headers/AppKit/NSColor.h:
* Headers/AppKit/NSGraphicsContext.h:
* ColorPickers/GSGrayColorPicker.m:
* ColorPickers/GSCMYKColorPicker.m:
* ColorPickers/GSWheelColorPicker.m:
* ColorPickers/GSRGBColorPicker.m:
* ColorPickers/GSHSBColorPicker.m: Migrate float to CGFloat in
NSColor


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34070 72102866-910b-0410-8b05-ffd578937521
2011-10-26 00:21:57 +00:00
Fred Kiefer
6aafb3c0e6 Integrate XIB loading methods used in Gorm.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34055 72102866-910b-0410-8b05-ffd578937521
2011-10-25 09:06:01 +00:00
Fred Kiefer
a47199291f Big improvement of XIB loading. Now all XIB files from the bug reports
get loaded.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34050 72102866-910b-0410-8b05-ffd578937521
2011-10-24 14:44:29 +00:00
Fred Kiefer
5d85ea1040 * Source/GSXibLoader.m (-objectForXib:): Add type "real" and
handle empty strings.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34011 72102866-910b-0410-8b05-ffd578937521
2011-10-17 08:34:02 +00:00
Fred Kiefer
f901c378ca * Source/NSScrollView.m (-encodeWithCoder:, -initWithCoder:):
Correct keyed encoding and decoding of flags. NIB files created
from GNUstep will need to be recreated.
Should fix bug #34498.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34008 72102866-910b-0410-8b05-ffd578937521
2011-10-15 20:29:02 +00:00
Fred Kiefer
b04bfd507a * Source/NSColor.m: Add alpha handling to keyed-coding/decoding.
Should fix bug #34501.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33965 72102866-910b-0410-8b05-ffd578937521
2011-10-11 20:57:24 +00:00
Fred Kiefer
8240c3bb55 * Source/NSTextView.m(currentVersion, -encodeWithCoder:,
-initWithCoder:): Archive missing attributes in non-keyed
mode. This required updating the NSTextView version to 4.
Should fix bug #33884.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33962 72102866-910b-0410-8b05-ffd578937521
2011-10-11 08:21:13 +00:00
Fred Kiefer
2fa1752b03 * Source/NSImage.m (-lockFocusOnRepresentation:): Draw the
representation into the new cache. Use NSRectFillUsingOperation
  instead of PScompositerect.
* Source/NSImage.m (-drawRepresentation:inRect:): Use DPS
  operations instead of PS operations.

Should fix bug #34470


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33948 72102866-910b-0410-8b05-ffd578937521
2011-10-06 11:06:31 +00:00
Fred Kiefer
0d40411b75 * Source/NSProgressIndicator.m (-encodeWithCoder:, initWithCoder:)
The flag isDisplayedWhenStopped is stored negated.
Should fix bug #34487


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33947 72102866-910b-0410-8b05-ffd578937521
2011-10-06 08:47:59 +00:00
Fred Kiefer
93234fe0e2 Rewrote NSBezierPath to allow subclasses.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33942 72102866-910b-0410-8b05-ffd578937521
2011-10-04 13:32:50 +00:00
Fred Kiefer
23b1ff3f36 Fix XIB loading bug reported by Julian Mayer as bug #34454.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33931 72102866-910b-0410-8b05-ffd578937521
2011-10-03 12:48:15 +00:00
Fred Kiefer
e9f1eff154 Started rewrite that simplifies menu tracking code.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33926 72102866-910b-0410-8b05-ffd578937521
2011-10-01 14:09:56 +00:00
Fred Kiefer
1c39281aaf Merge original in-window menu branch.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33924 72102866-910b-0410-8b05-ffd578937521
2011-10-01 11:17:16 +00:00
Germán Arias
92c89331d2 Improvements to menu in window
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33837 72102866-910b-0410-8b05-ffd578937521
2011-09-13 01:45:13 +00:00
Fred Kiefer
c74c96ca81 * Source/NSControl.m (+initialize, -valueForKey:,
-setValue:forKey:): Add support for the bindings NSFontNameBinding
  and NSFontSizeBinding.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33834 72102866-910b-0410-8b05-ffd578937521
2011-09-12 21:04:53 +00:00
Eric Wasylishen
507b4c76e8 * Source/NSImage.m (_cacheForRep:): Don't assume rep is non-nil. This should fix
locking focus on an image with no representations.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33827 72102866-910b-0410-8b05-ffd578937521
2011-09-09 19:49:08 +00:00
Gregory John Casamento
9a606392b7 Correction for compilation error. NSSizesEqual should have been NSEqualSizes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33820 72102866-910b-0410-8b05-ffd578937521
2011-09-08 20:13:42 +00:00
Eric Wasylishen
192e2d6174 * Source/NSImage.m: Throw an exception if you attempt to lock focus on an image with
size (0, 0)
* Source/NSCachedImageRep.m: Throw an exception if you attempt to create a cached
image rep with a size of (0, 0).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33819 72102866-910b-0410-8b05-ffd578937521
2011-09-08 18:42:31 +00:00
Eric Wasylishen
741578fb42 * Source/NSFontPanel.m: Add a tooltip on the character panel button
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33817 72102866-910b-0410-8b05-ffd578937521
2011-09-08 05:59:20 +00:00
Eric Wasylishen
9bbf725f7c * Source/NSSpellChecker.m: Use NSLog rather than a popup alert when the spell
server can't be contacted; otherwise the user may be spammed with a series
of popups if automatic spellchecking (underlining) is turned on, but
the current language isn't set.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33816 72102866-910b-0410-8b05-ffd578937521
2011-09-07 19:56:36 +00:00
Eric Wasylishen
4e0ff7f305 * Source/GSCharacterPanel.m: Implement -[NSApplication orderFrontCharacterPalette:]
* Source/NSFontPanel.m: Use NSApplication method to order front character palette


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33815 72102866-910b-0410-8b05-ffd578937521
2011-09-07 19:31:22 +00:00
Eric Wasylishen
a6788023fb * Source/NSImageCell.m (-drawInteriorWithFrame:inView:): Simplify a bit
bit by using
-[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:]
* Source/NSCell.m (-drawInteriorWithFrame:inView:): Switch from
-[NSImage compositeToPoint...] to
-[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:]


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33813 72102866-910b-0410-8b05-ffd578937521
2011-09-07 08:18:40 +00:00
Eric Wasylishen
19b6765e49 * Source/NSOpenPanel.m: Use the NSSavePanel _allowedFileTypes ivar
in place of the _fileTypes ivar. Replace calls to _setupForTypes: with
-setAllowedFileTypes:.
* Headers/AppKit/NSOpenPanel.h: Remove now unused _fileTypes ivar
* Source/NSSavePanel.m: Treat directories whose names have extensions
in the _allowedFileTypes array as file packages.
Previously, we only relied on -[NSWorkspace isFilePackageAtPath:],
to determine if a director is a file package, which only considers the
info.plists of installed applications.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33810 72102866-910b-0410-8b05-ffd578937521
2011-09-07 07:46:28 +00:00
Eric Wasylishen
c4048d4f4b * Source/NSView.m (_setNeedsDisplayInRect_real:): Enlarge
(if necessary) _invalidRect so it lies on integral device pixels.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33809 72102866-910b-0410-8b05-ffd578937521
2011-09-07 05:33:25 +00:00
Fred Kiefer
046bc43c63 * Source/NSApplication.m (-setApplicationIconImage): Ignore this
call when the image is nil.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33801 72102866-910b-0410-8b05-ffd578937521
2011-08-31 19:15:47 +00:00
Eric Wasylishen
1b780e1bc7 * Source/NSCachedImageRep.m: Restore the implementation of -draw
because libart/xlib need it.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33797 72102866-910b-0410-8b05-ffd578937521
2011-08-30 02:20:29 +00:00
Christopher Armstrong
42162c4e22 2011-08-28 Christopher Armstrong <carmstrong@fastmail.com.au>
* Source/GSHorizontalTypesetter.m: Split declaration of struct
	GSHorizontalTypesetter_glyph_cache_s and struct
	GSHorizontalTypesetter_line_frag_s from their typedefs to compile
	under clang.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33793 72102866-910b-0410-8b05-ffd578937521
2011-08-28 09:25:02 +00:00
Fred Kiefer
5554634f9c Correct last commit to use && instead of ||.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33788 72102866-910b-0410-8b05-ffd578937521
2011-08-26 07:35:41 +00:00
Riccardo Mottola
4e0e32caac check that the array of reps is populated, not just non-nil
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33786 72102866-910b-0410-8b05-ffd578937521
2011-08-25 15:20:45 +00:00
Eric Wasylishen
e14b034d8d * Source/NSImage.m (-setSize:): Don't invalidate the cache anymore,
because we now cache the entire representation and not the rep scaled
to the image's size.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33770 72102866-910b-0410-8b05-ffd578937521
2011-08-20 18:37:52 +00:00
Eric Wasylishen
5531d27e56 * Source/NSImage.m: Reinstate use of the cached image rep, but only
on backends supporting GSdraw: (cairo).  This means we don't have to
create a window for every call to draw an image, and gives me a 5-10x
speedup for image drawing.
* Source/NSCachedImageRep.m: Implement private method
-nativeDrawInRect:.. which is called by NSImageRep's
-drawInRect:fromRect:..., and efficiently draw the cached rep
using GSdraw:. Also make some changes so cached image reps can have a
DPI != 72.
* Headers/AppKit/NSCachedImageRep.h: New private init method that lets
you specify diferent pixel size and point size.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33765 72102866-910b-0410-8b05-ffd578937521
2011-08-19 19:06:41 +00:00
Eric Wasylishen
99abec2ebf * Headers/AppKit/NSImageRep.h: Add
-drawInRect:fromRect:operation:fraction:respectFlipped:hints: method
* Source/NSImage.m:
* Source/NSImageRep.m: Refactor drawing code from NSImage to NSImageRep.
This should cause no functionlity change, but it lets NSImageRep
subclasses implement more efficient versions of -drawInRect:fromRect:...
that don't involve the (expensive) drawing of the image in a temporary
offscreen window and then drawing from there on to the destination surface.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33764 72102866-910b-0410-8b05-ffd578937521
2011-08-18 23:57:50 +00:00
Eric Wasylishen
e4979c9102 * Source/Functions.m (NSDrawNinePartImage): Pixel-align drawing rect using
-[NSView centerScanRect]


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33761 72102866-910b-0410-8b05-ffd578937521
2011-08-17 16:24:17 +00:00
Eric Wasylishen
8770276b3b * Source/Functions.m (NSDrawNinePartImage): Bugfix when drawing with
not enough space


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33749 72102866-910b-0410-8b05-ffd578937521
2011-08-16 03:45:12 +00:00
Eric Wasylishen
977806c7e1 * Source/Functions.m (NSDrawNinePartImage): Bugfix in flipped drawing code
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33748 72102866-910b-0410-8b05-ffd578937521
2011-08-16 03:31:04 +00:00
Eric Wasylishen
ad562c0794 * Source/Functions.m:
* Headers/AppKit/NSGraphics.h: NSDrawNinePartImage implementation


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33745 72102866-910b-0410-8b05-ffd578937521
2011-08-16 02:58:12 +00:00
Eric Wasylishen
01c4a0be63 * Headers/Additions/GNUstepGUI/GSTheme.h: New GSThemeMargins struct.
Rename buttonBorderForCell:style:state: to buttonMarginsForCell:style:state:
and return the top/bottom/left/right margins instead of just two values.
(This is a theme API break.)
* Source/GSThemeDrawing.m: Implement buttonMarginsForCell:style:state:.
Also reduce the top and left margin of the default button by 1 pt, to
better reflect the button's appearance.
* Source/GSGuiPrivate.h: Add a GSRoundTowardsNegativeInfinity function
* Source/NSButtonCell.m (-drawImage:withFrame:inView:): Round the image
position down and to the right, as this seems to look the best.
* Source/NSButtonCell.m (-cellSize): Call new buttonMarginsForCell: method
* Source/NSButtonCell.m (-drawingRectForBounds:): Call new
buttonMarginsForCell: method


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33743 72102866-910b-0410-8b05-ffd578937521
2011-08-15 23:12:37 +00:00
Eric Wasylishen
6ec3f1a58b * Source/NSImage.m (GSResolutionOfImageRep): Specify behaviour when the
rep has a size of zero, or is a vector rep. Prevent division by 0.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33742 72102866-910b-0410-8b05-ffd578937521
2011-08-15 20:19:21 +00:00
Eric Wasylishen
e9367ed059 * Source/NSImage.m (-nativeDrawInRect:...): Deal with a zero rep size
* Source/NSCustomImageRep.m:
- Don't retain the delegate (matching OS X)
- Remove unnecessary flip checks from -drawAtPoint: and -drawInRect:
  to match the code in NSImageRep
- Fix a mistake when setting the ctm scale factor


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33741 72102866-910b-0410-8b05-ffd578937521
2011-08-15 20:11:11 +00:00
Fred Kiefer
4e05c96c6f * Source/NSView.m (-setBoundsSize:): Adjust the origin as well.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33717 72102866-910b-0410-8b05-ffd578937521
2011-08-11 08:14:53 +00:00
Fred Kiefer
9d79d0c978 * Source/NSMenu.m (+initialize): Don't create the default menu
zone as we never use it and a change in base made this an
  expensive operation.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33694 72102866-910b-0410-8b05-ffd578937521
2011-08-04 08:52:42 +00:00
Eric Wasylishen
5d897881e4 * Source/GSLayoutManager.m:
* Source/GSHorizontalTypesetter.m:
* Headers/Additions/GNUstepGUI/GSLayoutManager_internal.h:
* Headers/Additions/GNUstepGUI/GSLayoutManager.h: Store
glyph advances in the runs in GSLayoutManager. Extend the
NSGlyphStorage protocol to support a case where the glyph
generator provides the glyph advances.

I'm hoping to use this in the future to implement (optional)
glyph generators which are wrappers around HarfBuzz or the ICU
OpenType layout engine.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33684 72102866-910b-0410-8b05-ffd578937521
2011-08-02 23:34:06 +00:00
Eric Wasylishen
48f0fd951c * Source/NSScreen.m (-userSpaceScaleFactor): Use the DPI
from the display server instead of ignoring it and assuming 72.

The X11 server was changed to always return 72 for now, so there
is no change in behaviour on X.

On Windows we do use the system DPI/scale factor now.

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33659 72102866-910b-0410-8b05-ffd578937521
2011-07-30 20:44:06 +00:00
Fred Kiefer
d2011237e8 * Source/NSAnimation.m (NSViewAnimation -dealloc): Use DESTROY
instead of RELEASE as _viewAnimationDesc to prevent segmentation
        fault in super call.
        * Source/NSWindow.m (-setFrame:display:animate:): Use
        NSViewAnimation instead of local blocking code.
        * Source/NSWindow.m (-animationResizeTime:): Use abs() in all
        * directions.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33624 72102866-910b-0410-8b05-ffd578937521
2011-07-24 18:53:07 +00:00
Fred Kiefer
c100baf6b4 Lots of minimal changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33613 72102866-910b-0410-8b05-ffd578937521
2011-07-23 13:43:33 +00:00
Eric Wasylishen
119056ab5f * Source/GSToolTips.m (-_timedOut:): Guard against nil tooltip string
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33599 72102866-910b-0410-8b05-ffd578937521
2011-07-21 07:12:07 +00:00
Eric Wasylishen
a15066d183 * Source/NSButtonCell.m (-title): Return @"" instead of nil
* Source/NSButtonCell.m (-alternateTitle): Return @"" instead of nil
* Source/NSButtonCell.m (-attributedAlternateTitle): Use
[self alternateTitle] instead of accessing _altContents directly to guard
against _altContents being nil
* Source/NSButtonCell.m (-attributedTitle): Don't return nil. Use
[self title] instead of accessing _contents directly to guard against
_contents being nil
* Source/NSButtonCell.m (-keyEquivalent): Return @"" instead of nil
* Source/NSButtonCell.m (-encodeWithCoder):
For keyEquivelant and alternateTitle, now that the methods never return
nil, instead of checking if they return nil to decide whether to encode them,
check if the string length is > 0.
* Source/NSToolbarItem.m (-label): Return @"" instead of nil.
* Source/NSCell.m (-stringValue): Return @"" instead of nil
* Source/NSCell.m (-attributedStringValue): Don't return nil. Use
[self stringValue] instead of accessing _contents directly to guard against
_contents being nil.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33598 72102866-910b-0410-8b05-ffd578937521
2011-07-21 06:31:34 +00:00
Eric Wasylishen
d919131abb * Source/NSTextView.m (-view:stringForToolTip:point:userData:):
Ensure this returns an NSString, even if NSToolTipAttributeName
is set to something else (it calls -description on the value).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33597 72102866-910b-0410-8b05-ffd578937521
2011-07-21 04:56:02 +00:00
Eric Wasylishen
c1e194da9f * Source/GSGhostscriptImageRep.m: Search for gs by enumerating directories
in PATH rather than calling 'which'. Also search for gswin32c.exe for
Windows.

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33587 72102866-910b-0410-8b05-ffd578937521
2011-07-19 21:51:25 +00:00
Eric Wasylishen
97e9d3bda8 * Source/NSImage.m: Implement
-[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33571 72102866-910b-0410-8b05-ffd578937521
2011-07-16 02:09:06 +00:00
Eric Wasylishen
4e36d04d40 * Source/NSImage.m (-nativeDrawInRect:...): Fix two bugs
demonstrated in GSTest:
- drawing an image in a flipped view with -drawInRect:... wasn't
  working, and
- drawing a vector rep in a dest rect larger than the point
  size of the rep was resulting in blurry output.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33570 72102866-910b-0410-8b05-ffd578937521
2011-07-16 01:23:40 +00:00
Eric Wasylishen
390b3290f3 * Source/NSColorPanel.m: Remove code for generating a dynamic
magnifying glass cursor; it flickers on X11.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33565 72102866-910b-0410-8b05-ffd578937521
2011-07-15 19:55:38 +00:00
Richard Frith-MacDonald
4e44c1f5b2 remove obsolete include
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33561 72102866-910b-0410-8b05-ffd578937521
2011-07-15 13:51:22 +00:00
Eric Wasylishen
bfb415ee79 * Source/NSOutlineView.m: Allow collapsing or expanding multiple
rows at a time using the arrow keys


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33552 72102866-910b-0410-8b05-ffd578937521
2011-07-15 05:39:10 +00:00
Fred Kiefer
86ff6abf69 Replace direct use of the isa pointer with a call to object_getClass()
to make David happy.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33545 72102866-910b-0410-8b05-ffd578937521
2011-07-14 07:17:24 +00:00
Eric Wasylishen
3958406375 * Source/NSColorPanel.m: Make a magnifying glass cursor when using
the magnifying glass color picker. back/x11 isn't displaying
the cursor at the moment.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33543 72102866-910b-0410-8b05-ffd578937521
2011-07-13 23:10:51 +00:00
Germán Arias
a8c841bd33 Character Panel in Spanish
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33542 72102866-910b-0410-8b05-ffd578937521
2011-07-13 18:51:59 +00:00
Eric Wasylishen
bef9ca8b85 * Source/GSImageMagickImageRep.m: Don't call DestroyImage on a
NULL image


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33541 72102866-910b-0410-8b05-ffd578937521
2011-07-13 03:34:38 +00:00
Eric Wasylishen
237476cb79 * Source/GSImageMagickImageRep.m: Log warnings from ImageMagick
instead of giving up.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33540 72102866-910b-0410-8b05-ffd578937521
2011-07-13 02:46:12 +00:00
Eric Wasylishen
22bfbcc946 * Source/GSGuiPrivate.h: New rounding rounding function
GSRoundTowardsInfinity which is simply floor(x+0.5)
* Source/NSBrowser.m:
* Source/NSSliderCell.m:
* Source/NSButtonCell.m:
* Source/NSClipView.m:
* Source/NSOutlineView.m:
* Source/NSRulerView.m:
Switch rint[f] to GSRoundTowardsInfinity


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33539 72102866-910b-0410-8b05-ffd578937521
2011-07-12 21:12:22 +00:00
Eric Wasylishen
0024ee69e2 * Source/GSGhostscriptImageRep.m: Only invoke 'which' once.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33529 72102866-910b-0410-8b05-ffd578937521
2011-07-11 18:46:05 +00:00
Eric Wasylishen
31f3fffb8f * Source/GSGhostscriptImageRep.m: Change to NSLog, only log
a warning the first time invoking ghostscript throws an exception,
and log a message if it returns a nonzero exit status.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33527 72102866-910b-0410-8b05-ffd578937521
2011-07-11 18:16:45 +00:00
Eric Wasylishen
f13998e491 * Source/GSGhostscriptImageRep.m: Add NSWarnLog to execption
handlers to print a message when finding or invoking Ghostscript
fails.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33524 72102866-910b-0410-8b05-ffd578937521
2011-07-11 16:09:35 +00:00
Fred Kiefer
f13ac2cd84 * Source/NSImage.m (-nativeDrawInRect:...): Compute the rep size
after the nil test.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33513 72102866-910b-0410-8b05-ffd578937521
2011-07-11 09:41:47 +00:00
Fred Kiefer
727e1993f0 Unbind key bindings.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33511 72102866-910b-0410-8b05-ffd578937521
2011-07-11 08:40:31 +00:00
Eric Wasylishen
7005abd617 * Source/NSColorPanel.m (-_magnify:): Preliminary implementation
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33510 72102866-910b-0410-8b05-ffd578937521
2011-07-11 06:25:29 +00:00
Eric Wasylishen
56bf8c17be * Source/NSMenuView.m (-_trackWithEvent:): Fix for the bug where
the highlighted menu item can be offset from the mouse pointer
location when menu windows are moved by the window manager. See
detailed comment in the code for more info.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33508 72102866-910b-0410-8b05-ffd578937521
2011-07-11 02:58:36 +00:00
Eric Wasylishen
74e522c0c2 * Source/GSGhostscriptImageRep.m: Remove hardcoded path to gs
executable. First try GSGhostscriptExecutablePath default, then
try running "$SHELL -c which gs" to get the path.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33505 72102866-910b-0410-8b05-ffd578937521
2011-07-10 22:41:35 +00:00
Fred Kiefer
34266c025a Declare variable at begin of method to allow compilation with older
compilers.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33493 72102866-910b-0410-8b05-ffd578937521
2011-07-08 22:52:35 +00:00
Eric Wasylishen
e5bd93c5d8 * Source/NSView.m (-resizeWithOldSuperviewSize:): Factor out
autoresizing logic into a function. Add an extra code path to handle
when the flexible space is 0, which behaves like the old version
of the code (it divides the available space evenly).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33490 72102866-910b-0410-8b05-ffd578937521
2011-07-08 19:29:50 +00:00
Eric Wasylishen
88be063a41 * Headers/AppKit/NSView.h:
* Source/NSView.m (-resizeWithOldSuperviewSize): Pixel-align
view frame when autoresizing.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33483 72102866-910b-0410-8b05-ffd578937521
2011-07-07 23:16:02 +00:00
Fred Kiefer
a71f6baac8 * Source/NSView.m (-resizeWithOldSuperviewSize): Reimplement to
resize proportionally as Cocoa does.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33482 72102866-910b-0410-8b05-ffd578937521
2011-07-07 22:19:07 +00:00
Eric Wasylishen
845ed11c17 * Source/GSCharacterPanel.m: Double click inserts character into
main window


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33474 72102866-910b-0410-8b05-ffd578937521
2011-07-07 07:14:49 +00:00
Eric Wasylishen
1c87001866 * Source/GSCharacterPanel.m (-characterForRow:): Fix off-by-1 error
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33473 72102866-910b-0410-8b05-ffd578937521
2011-07-07 06:48:31 +00:00
Eric Wasylishen
896c6d73a3 Add a new character picker panel. It's accessible
via a button in the font panel.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33470 72102866-910b-0410-8b05-ffd578937521
2011-07-06 18:39:49 +00:00
Eric Wasylishen
7a47a5e929 * Source/GSDisplayServer.m:
* Headers/Additions/GNUstepGUI/GSDisplayServer.h: Add a new API for taking
screenshots: -contentsOfScreen:inRect:


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33442 72102866-910b-0410-8b05-ffd578937521
2011-07-03 23:43:07 +00:00
Eric Wasylishen
de89388c7f * Source/NSTextView.m: Use respectFraction: YES when deciding whether
to do a word selection upon a right click


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33441 72102866-910b-0410-8b05-ffd578937521
2011-07-03 20:53:44 +00:00
Eric Wasylishen
1bc738ec3e * Source/NSMenuView.m: Allow any mouse up (left/right/other)
to choose a menu item.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33435 72102866-910b-0410-8b05-ffd578937521
2011-07-03 06:47:41 +00:00
Eric Wasylishen
04342f72c6 * Source/NSTextView.m (-_updateState:): Invalidate cursor rects
so the cursor rects over links, for example, are updated when
text is edited.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33434 72102866-910b-0410-8b05-ffd578937521
2011-07-03 04:45:29 +00:00
Riccardo Mottola
394d42736a Add support for for link attributes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33433 72102866-910b-0410-8b05-ffd578937521
2011-07-02 22:15:17 +00:00
Riccardo Mottola
b7f57fe859 Circular sliders never return the maximum value, tested on Apple
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33432 72102866-910b-0410-8b05-ffd578937521
2011-07-02 22:01:23 +00:00
Gregory John Casamento
f69ffcb8e3 Changes to encode and decode sortDescriptors into the gorm file.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33430 72102866-910b-0410-8b05-ffd578937521
2011-07-02 19:41:38 +00:00
Riccardo Mottola
d4955c013e tix tick marks in circular sliders
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33429 72102866-910b-0410-8b05-ffd578937521
2011-07-02 19:04:11 +00:00
Eric Wasylishen
8a9f26ceff * Source/NSOutlineView.m: Implement left arrow key moving selection
to parent node when the current item is collapsed.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33428 72102866-910b-0410-8b05-ffd578937521
2011-07-02 17:40:58 +00:00
David Chisnall
002f6635b4 Small GC fixups. Make sure that we're actually using GC-tracked memory when we think that we are.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33416 72102866-910b-0410-8b05-ffd578937521
2011-06-29 15:41:14 +00:00
Eric Wasylishen
7f4e569c47 * Headers/Additions/GNUstepGUI/GSImageMagickImageRep.h:
* Source/GNUmakefile:
* Source/NSImageRep.m:
* Source/GSImageMagickImageRep.m:
* configure.ac: New ImageMagick-based NSBitmapImageRep subclass


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33399 72102866-910b-0410-8b05-ffd578937521
2011-06-29 03:35:25 +00:00
Fred Kiefer
87c05a3ba1 * Source/GSDragView.m (-init): Set the window background colour to clear.
* Headers/AppKit/NSAffineTransform.h,
* Headers/AppKit/NSView.h,
* Source/NSAffineTransform.m,
* Source/NSPrintOperation.m,
* Source/NSView.m: Use CGFlaot instead of float.
* Tests/gui/NSView/NSView_bounds_scale.m: New test file that currently fails.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33398 72102866-910b-0410-8b05-ffd578937521
2011-06-28 20:59:24 +00:00
Eric Wasylishen
f79e17387b * Source/GSGhostscriptImageRep.m:
* Headers/Additions/GNUstepGUI/GSGhostscriptImageRep.h:
* Source/GNUmakefile:
* Source/NSImageRep.m: New image rep which attempts to
invoke Ghostscript to rasterize PS/EPS/PDF images. It needs
some polishing but basically works.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33389 72102866-910b-0410-8b05-ffd578937521
2011-06-27 05:45:40 +00:00
Wolfgang Lux
ed3c950428 Implement NSTextView -deleteToEndOfParagraph:, which was introduced in
OS X 10.3.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33378 72102866-910b-0410-8b05-ffd578937521
2011-06-26 09:20:01 +00:00
Wolfgang Lux
251ee4d491 Fix implementation of NSTextView -deleteToEndOfLine: to work in the
same way as under Emacs and OS X. In particular, the action now
deletes the newline character when the insertion point is at the end
of a line.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33377 72102866-910b-0410-8b05-ffd578937521
2011-06-26 09:12:40 +00:00
Fred Kiefer
5d344a2b0a Change all the runModal:... methods to return an NSInteger.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33352 72102866-910b-0410-8b05-ffd578937521
2011-06-19 20:44:24 +00:00
Eric Wasylishen
91159aa357 * Source/NSTextView.m (-scrollRangeToVisible:): Fix to support scrolling
to the empty range at the end of a document (i.e. {[string length], 0}).
This fixes the scrolling when you repeatedly hit RETURN in TextEdit to
create new pages (in wrap to page mode).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33351 72102866-910b-0410-8b05-ffd578937521
2011-06-19 17:52:05 +00:00
Fred Kiefer
2443222fcb * Source/NSButtonCell.m (-setTitle:, -setAttributedTitle:,
-setAlternateImage:, -setImagePosition:): Update the control to
reflect the changes.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33350 72102866-910b-0410-8b05-ffd578937521
2011-06-19 16:13:47 +00:00
Fred Kiefer
b6fab5861c * Source/NSDocumentController.m (-_openRecentDocument:): Use most
current method to display document.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33348 72102866-910b-0410-8b05-ffd578937521
2011-06-19 10:55:16 +00:00
Fred Kiefer
52aee6a0ee * Source/NSView.m (-_viewWillMoveToWindow:): Move the invalidation of
the coordinate transformations and the cursor rects before the
window test. Remove calls to coordinate invalidation from other places.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33347 72102866-910b-0410-8b05-ffd578937521
2011-06-19 10:04:24 +00:00
Fred Kiefer
b1a51425e6 * Source/NSView.m (-setBounds:, -setBoundsSize:): Rewrite of this
methods plus a few helpers. We pass now all the frame/bounds test cases.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33343 72102866-910b-0410-8b05-ffd578937521
2011-06-18 22:59:58 +00:00
Eric Wasylishen
54ff379877 * Headers/AppKit/NSImageCell.h:
* Source/NSImageCell.m: Add support for NSImageScaleProportionallyUpOrDown


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@33309 72102866-910b-0410-8b05-ffd578937521
2011-06-15 18:38:12 +00:00