Commit graph

55 commits

Author SHA1 Message Date
Gregory John Casamento
ac5b949f2a Add fix to prevent iterating past the number of visible back views. 2021-10-27 15:00:38 -04:00
Riccardo Mottola
4004f549d7 height is CGFloat 2020-12-12 02:20:01 +01:00
Riccardo Mottola
0ff4adfd42 minor code style updates, transition to CGFloat and correct signedness too 2020-12-12 01:54:37 +01:00
Riccardo Mottola
9db97cd047 Use centerScanRect to correct Items frame and avoid flickering. 2020-12-12 23:32:01 +01:00
fredkiefer
5cee71869b * Source/NSToolbarFrameworkPrivate.h,
* Source/GSToolbarView.m,
* Source/NSToolbar.m: Minor changes to format code, remove unused
methods and introduce some new helper methods.
2020-12-06 22:10:13 +01:00
Fred Kiefer
099257dac9 Fix some clang static analyser warnings reported by
Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40484 72102866-910b-0410-8b05-ffd578937521
2017-04-16 11:54:21 +00:00
Fred Kiefer
ca8abf4c27 * Headers/Additions/GNUstepGUI/GSToolbarView.h
* Source/GSToolbarView.m
	Change draggedItemIndex to NSUInteger.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40270 72102866-910b-0410-8b05-ffd578937521
2016-12-17 00:00:19 +00:00
Riccardo Mottola
11a55d01f1 Use protocol not class for NSMenuItem
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38277 72102866-910b-0410-8b05-ffd578937521
2015-01-05 14:01:47 +00:00
Fred Kiefer
8ad4aa86c4 Replace some occurences of int with NSInteger
and unsigned with NSUInteger. This allows to recompile gui on 
64 bit systems after the change to NSNotFound in base.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34312 72102866-910b-0410-8b05-ffd578937521
2011-12-17 17:16:09 +00:00
Eric Wasylishen
2992f4fa1d * Source/GSNibLoading.m:
* Source/NSToolbar.m:
* Source/GSToolbarCustomizationPalette.m:
* Source/GSToolbarView.m:
* Source/NSToolbarItem.m:
* Source/NSToolbarFrameworkPrivate.h:
* Headers/AppKit/NSToolbar.h: Implement -initWithCoder: for
NSToolbar. This required a bit more work that usual because
toolbars created with -initWithCoder can operate without a delegate.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34189 72102866-910b-0410-8b05-ffd578937521
2011-11-18 20:15:53 +00:00
Fred Kiefer
3b7e6aa708 * Source/GSToolbarView.m (initSystemExtensionsColors): Remove
this function and the NSColor extensions as these no longer get
used. The colours for NSToolbar are handled by GSTheme.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31807 72102866-910b-0410-8b05-ffd578937521
2010-12-31 16:19:52 +00:00
Fred Kiefer
d08b23d9b0 First batch of corrections based on David's static analysis.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31337 72102866-910b-0410-8b05-ffd578937521
2010-09-12 16:34:22 +00:00
Doug Simons
24fad47739 Make toolbar resizing behavior match the Cocoa behavior
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30440 72102866-910b-0410-8b05-ffd578937521
2010-05-21 15:01:45 +00:00
Fred Kiefer
0693cd9edc Toolbar resizing: If there are flexible items and flexible space the items will be expanded
first.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30381 72102866-910b-0410-8b05-ffd578937521
2010-05-13 16:29:38 +00:00
Fred Kiefer
4335c12ae4 Further improvement of toolbar resizing and missing changelog entry.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30380 72102866-910b-0410-8b05-ffd578937521
2010-05-13 14:25:54 +00:00
Fred Kiefer
ed30b6221a Clean up toolbar item resizing, this now allows for resizable item other than flexible space.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30371 72102866-910b-0410-8b05-ffd578937521
2010-05-12 23:06:02 +00:00
Riccardo Mottola
b06fad609f removed c99isms
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30175 72102866-910b-0410-8b05-ffd578937521
2010-04-16 18:58:26 +00:00
Doug Simons
fe66919f5b Fix numerous issues with toolbar customization
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30143 72102866-910b-0410-8b05-ffd578937521
2010-04-13 21:38:31 +00:00
Fred Kiefer
63638ee055 Remove compiler warnings from clang.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30117 72102866-910b-0410-8b05-ffd578937521
2010-04-10 17:48:46 +00:00
Riccardo Mottola
e0b40e98fc revert accidental commit
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29758 72102866-910b-0410-8b05-ffd578937521
2010-02-25 21:56:34 +00:00
Riccardo Mottola
a295ee6455 revert accidental commit
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29757 72102866-910b-0410-8b05-ffd578937521
2010-02-25 21:49:24 +00:00
Riccardo Mottola
01f7fe5c27 fix c99-ism
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29756 72102866-910b-0410-8b05-ffd578937521
2010-02-25 21:41:39 +00:00
Fred Kiefer
eecdf96f4b Extract a few more drawing and colour methods to GSTheme.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28937 72102866-910b-0410-8b05-ffd578937521
2009-11-02 11:48:22 +00:00
Fred Kiefer
420648751a Correct the only use of the method that Hans Baier renamed :-)
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28690 72102866-910b-0410-8b05-ffd578937521
2009-09-16 07:11:21 +00:00
Gregory John Casamento
a74a5f8ffd * Source/GSToolbarView.m: Added code to save the configuration when
deleting an item as well as saving an item.
	* Source/NSToolbarFrameworkPrivate.h: removed old _loadConfig method
	added new methods to track changes to toolbars.
	* Source/NSToolbar.m: Added check for items already in the toolbar,
	removed calls to _loadConfig which were commented out, implemented
	setConfigurationFromDictionary: as described in the documentation,
	changed _build to get dictionary from defaults if it's there. 
	Implemented new method _containsItemWithIdentifier: and 
	_itemsFromConfig.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28084 72102866-910b-0410-8b05-ffd578937521
2009-03-16 07:33:31 +00:00
Gregory John Casamento
6f3f7be33c Fixes to correct issues with toolbar pallete customization.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28083 72102866-910b-0410-8b05-ffd578937521
2009-03-16 05:25:22 +00:00
Gregory John Casamento
0548fc3f19 * Source/GSToolbarView.m:
* Source/NSToolbar.m: Partial fix for toolbar drag and drop issues.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28072 72102866-910b-0410-8b05-ffd578937521
2009-03-13 05:03:50 +00:00
Fred Kiefer
71f807b1c7 Add theme drawing for toolbar view.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27806 72102866-910b-0410-8b05-ffd578937521
2009-02-07 21:58:12 +00:00
Wolfgang Lux
cdc21a5395 Fix a few issues with toolbar item validation.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27626 72102866-910b-0410-8b05-ffd578937521
2009-01-18 15:11:37 +00:00
Fred Kiefer
ec783dc3b3 Revert the relationship between NSToolbar and GSToolbarView,
now the toolbar retains the view.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27550 72102866-910b-0410-8b05-ffd578937521
2009-01-07 08:49:53 +00:00
Gregory John Casamento
b8033adbb3 * Source/GSToolbarView.m: Use ASSIGN as suggested. This corrects
the crash and fixes the leak caused by the previous change.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27516 72102866-910b-0410-8b05-ffd578937521
2009-01-04 23:26:06 +00:00
Gregory John Casamento
3dd82a38fa Correct crash in NSToolbar.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27515 72102866-910b-0410-8b05-ffd578937521
2009-01-04 21:40:49 +00:00
Fred Kiefer
74d7fcffd8 Add new private header file with shared toolbar classes interfaces.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27503 72102866-910b-0410-8b05-ffd578937521
2009-01-02 17:24:06 +00:00
Fred Kiefer
4fc5a6f196 General clean up of GSToolbarView code.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27501 72102866-910b-0410-8b05-ffd578937521
2009-01-02 14:05:39 +00:00
Fred Kiefer
f66a0decc7 Merge GSToolbar with NSToolbar and remove all traces of the old class.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27491 72102866-910b-0410-8b05-ffd578937521
2009-01-01 22:04:38 +00:00
Fred Kiefer
46af2db2df Small changes to prepare for merge of NSToolbar and GSToolbar.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27488 72102866-910b-0410-8b05-ffd578937521
2009-01-01 19:22:50 +00:00
Fred Kiefer
66e22d664f Start to rewrite the window toolbar handling code.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27478 72102866-910b-0410-8b05-ffd578937521
2008-12-31 16:06:58 +00:00
Adam Fedor
7afdd32ac1 Revert library license version to 2 until applications can be converted
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26619 72102866-910b-0410-8b05-ffd578937521
2008-06-10 04:01:49 +00:00
Fred Kiefer
193e31e678 Change all files to use GPL 3 and LGPL 3.
Prepare for next release.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25536 72102866-910b-0410-8b05-ffd578937521
2007-10-29 21:16:17 +00:00
Fred Kiefer
b7cb6503ee Different patches by Andreas Höschler <ahoesch@smartsoft.de>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24846 72102866-910b-0410-8b05-ffd578937521
2007-03-11 17:07:44 +00:00
Quentin Mathe
0b1ea1bbc2 Shut down some toolbar related compiler warnings
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@22571 72102866-910b-0410-8b05-ffd578937521
2006-02-23 23:41:22 +00:00
Adam Fedor
303dd1baf9 Update FSF Address.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@21259 72102866-910b-0410-8b05-ffd578937521
2005-05-26 02:52:46 +00:00
Quentin Mathe
4348b3a5ac Fixed white toolbar background bug
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@20609 72102866-910b-0410-8b05-ffd578937521
2005-01-24 11:25:42 +00:00
Quentin Mathe
efe686d736 Fixed GNUMail compilation with recent Darwin linker versions
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@20588 72102866-910b-0410-8b05-ffd578937521
2005-01-21 09:32:50 +00:00
Quentin Mathe
f43c0326c6 Fixed the toolbar bug #11393
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@20503 72102866-910b-0410-8b05-ffd578937521
2004-12-30 14:02:00 +00:00
Quentin Mathe
06bd77f976 Deactivated the toolbar delegate synchronisation and other toolbar modifications
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@20001 72102866-910b-0410-8b05-ffd578937521
2004-09-05 17:56:11 +00:00
Alexander Malmberg
e8ce1bfa9f Remove spurious ';'.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@19985 72102866-910b-0410-8b05-ffd578937521
2004-09-03 23:10:13 +00:00
Quentin Mathe
ef1010acc4 Added the possibility to rearrange toolbar items
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@19976 72102866-910b-0410-8b05-ffd578937521
2004-09-02 17:40:00 +00:00
Quentin Mathe
6576a77429 NSToolbar visibility issue corrected
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@19780 72102866-910b-0410-8b05-ffd578937521
2004-07-27 15:15:29 +00:00
Quentin Mathe
e428e69f82 Toolbar improvements... Fixed several major and minor bugs, rewritten the validation support, lot of memory leaks eliminated and other changes
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@19689 72102866-910b-0410-8b05-ffd578937521
2004-07-07 21:25:42 +00:00