gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-04-22 07:10:46 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix some clang static analyser warnings reported by

Browse source 
Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@40484 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Fred Kiefer 2017-04-16 11:54:21 +00:00
parent 521fd071b4
commit 099257dac9
6 changed files with 19 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
ChangeLog
View file

@ -1,3 +1,17 @@
2017-04-16 Fred Kiefer <FredKiefer@gmx.de>
* Model/IMLoading.m
* Source/GSTextStorage.m
* Source/GSToolbarView.m
* Source/NSLayoutManager.m
* Source/NSTableView.m
Fix some clang static analyser warnings reported by
Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>.
2017-04-06 Ivan Vucica <ivan@vucica.net>
* Releasing 0.25.1.
2017-04-05 Fred Kiefer <FredKiefer@gmx.de>
* Headers/Additions/GNUstepGUI/GSXibKeyedUnarchiver.h: Moved from Source.
@ -6,10 +20,6 @@
* Source/GSXibKeyedUnarchiver.m,
* Source/GNUmakefile: Use and install moved header file.
2017-04-04 Ivan Vucica <ivan@vucica.net>
* Releasing 0.25.1.
2017-04-01 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSMenu.m (-displayTransient): Update menu before displaying.

16
Model/IMLoading.m
View file

@ -43,7 +43,6 @@
void __dummy_IMLoading_functionForLinking()
{
__dummy_IMLoading_functionForLinking();
}
@implementation GMModel
@ -207,18 +206,3 @@ BOOL _fileOwnerDecoded = NO;
}
@end /* GMModel */
#if GNU_RUNTIME
#include "IMConnectors.h"
__attribute__((unused))
static void __dummyFunctionForLinking (void)
{
[IMCustomObject new];
[IMConnector new];
__dummyFunctionForLinking();
}
#endif

2
Source/GSTextStorage.m
View file

@ -89,7 +89,7 @@ cacheEqual(id A, id B)
static NSDictionary *blank;
static NSLock *attrLock = nil;
static __strong GSIMapTable_t attrMap;
static GSIMapTable_t attrMap;
static SEL lockSel;
static SEL unlockSel;
static IMP lockImp;

7
Source/GSToolbarView.m
View file

@ -63,9 +63,6 @@ static const int InsetItemViewX = 10;
static const int ClippedItemsViewWidth = 28;
// Internal
static const int current_version = 1;
static NSUInteger draggedItemIndex = NSNotFound;
/*
@ -270,12 +267,12 @@ static NSUInteger draggedItemIndex = NSNotFound;
if (draggedItemIndex == NSNotFound)
{
//simply locate the nearest location between existing items
for (index=0; index < [visibleBackViews count]; index++)
for (index = 0; index < [visibleBackViews count]; index++)
{
NSRect itemRect = [[visibleBackViews objectAtIndex:index] frame];
if (location.x < (itemRect.origin.x + (itemRect.size.width/2)))
{
NSLog(@"AT location %d", index);
NSLog(@"At location %lu", (unsigned long)index);
return index;
}
}

2
Source/NSLayoutManager.m
View file

@ -1815,7 +1815,7 @@ attachmentSize(linefrag_t *lf, NSUInteger glyphIndex)
unsigned int char_index =
[self characterRangeForGlyphRange: NSMakeRange(g, 1)
actualGlyphRange: NULL].location;
NSObject<NSTextAttachmentCell> *cell = [[_textStorage attribute: NSAttachmentAttributeName
id<NSTextAttachmentCell> cell = [[_textStorage attribute: NSAttachmentAttributeName
atIndex: char_index
effectiveRange: NULL] attachmentCell];
NSRect cellFrame;

2
Source/NSTableView.m
View file

@ -6031,7 +6031,7 @@ This method is deprecated, use -columnIndexesInRect:. */
{
NSArray *array;
NSNumber *width, *identNum;
NSObject *ident;
id ident;
width = [NSNumber numberWithInt: [column width]];
ident = [column identifier];