correct imp type.
* Source/NSButtonCell.m (-setBackgroundColor:): Update the
control view.
* Source/NSSegmentedCell.m (-drawSegment:inFrame:withView:):
* Draw
image if available.
* Source/NSPopUpButtonCell.m (-initWithCoder:): Add work around
for NSClassSwapper cell replacement.
Patches based on changes by Josh Freeman
<pikopixel@twilightedge.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@39006 72102866-910b-0410-8b05-ffd578937521
* Source/NSTextView.m: Invalidate insertion point timer in
dealloc.
* Source/NSToolbarItem.m: Check for drawing rect within bounds
before drawing toolbar item.
Patch by Marcian Lytwyn <gna@advcsi.com>.
2015-09-10 Doug Simons <doug.simons@testplant.com> and Paul Landers
<paul.landers@testplant.com>
* Source/NSLayoutManager.m: Fix a bug that would try to adjust
the length of the selected range to a negative number, leading
to an exception and eventual crashes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38986 72102866-910b-0410-8b05-ffd578937521
Patch by Doug Simons <doug.simons@testplant.com>
* Source/NSControl.m (-initWithCoder:): Don't use NSEnabled flag
as it is wrong for NSComboBox.
* Source/NSComboBoxCell.m (_loadButtonCell): Set enabled on
button cell.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38933 72102866-910b-0410-8b05-ffd578937521
for centerScanRect: with flipped view.
* Source/NSView.m (-centerScanRect:): Change to get the failed
tests to pass.
* Source/GSThemeTools.m (-drawRoundBezel:withColor:): Make round
bezel look a bit nicer.
* Source/NSButtonCell.m (-drawImage:withFrame:inView:): Use
centerScanRect: instead of similar code.
* Source/NSCell.m: Use imageRectForBounds: and
titleRectForBounds: in drawInteriorWithFrame:inView:.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38929 72102866-910b-0410-8b05-ffd578937521
* Source/NSNibConnector.m: Move NSNibConnector and subclasses in
separate file. Add isEqual: method from Gorm. Switch to new
libobjc runtime ivar access for NSNibOutletConnector.
* Source/GNUmakefile: Add new file NSNibConnector.m
* Source/GSXibLoader.m: Similar change to IBOutletConnection.
Replace GSMime base64 decode method with standard one.
* Source/GSImageMagickImageRep.m,
* Source/GSTheme.m: Remove unused #import.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38919 72102866-910b-0410-8b05-ffd578937521
escape key and make list of bindings easier to extend.
* KeyBindings/DefaultKeyBindings.dict: Add default escape key
binding to complete: method.
Patch by Marcian Lytwyn <gna@advcsi.com>.
* Source/NSInputManager.m: Fixed alt behaviors for return
Patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38918 72102866-910b-0410-8b05-ffd578937521
translations.
Patch by Seong-Gu Lee <sgleehd@gmail.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38890 72102866-910b-0410-8b05-ffd578937521
autosaveName as nil to fix problem with some nibs.
Patch by Doug Simons <doug.simons@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38889 72102866-910b-0410-8b05-ffd578937521
row/column insert, as Cocoa does.
Clean up and more NSInteger changes.
* ColorPickers/GSStandardColorPicker.m,
* Source/NSColorPanel.m (-_setupPickers): Prevent warning from
NSMatrix.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38883 72102866-910b-0410-8b05-ffd578937521
writeSelectionToPasteboard:... methods.
Based on patch by Adam Fox <adam.fox@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38871 72102866-910b-0410-8b05-ffd578937521
* Source/NSFont.m: Look for xib font property IBIsSystemFont.
Patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38837 72102866-910b-0410-8b05-ffd578937521
* Source/NSTextStorage.m: Fixed a bug with setting _editedRange
for multiple edits when the first one is a delete (which results in
_editedRange having a length of 0) so it gets replaced instead
of expanded to include all edits.
Patch by Doug Simons <doug.simons@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38836 72102866-910b-0410-8b05-ffd578937521
setting divider position. Otherwise, adjustSubviews will wipe out the
setting.
Patch by Doug Simons <doug.simons@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38626 72102866-910b-0410-8b05-ffd578937521
id<NSMenuItem> to NSMenuitem* as it is done by Apple too
fixes warnings in NSApplication.m and NSTextView.m
OK Fred Kiefer
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38568 72102866-910b-0410-8b05-ffd578937521
* Source/NSButtonCell.m (-encodeWithCoder:): Correct bug with
image position in NSButtonFlags.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38526 72102866-910b-0410-8b05-ffd578937521
Previously, under GNUstep, NSLocalizedFailureReasonKey was ignored when
presented with +[NSAlert alertWithError]. Additionally, error set in
-readFromData:ofType:error: was overwritten by two different methods in the
file reading chain.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38483 72102866-910b-0410-8b05-ffd578937521
the save panel's title bar not matching the set title when
the panel is reused for a different purpose.
Patch by Doug Simons <doug.simons@testplant.com>
* Source/NSApplication.m: Adjust modal window position to
relative window requested.
Patch by Marcian Lytwyn <gna@advcsi.com> with small change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38440 72102866-910b-0410-8b05-ffd578937521
* Images/GNUmakefile: Handle new file.
* Source/GSXibLoader.m: Better error reporting for wrong
application class.
* Source/NSOutline.m (-drawRow:clipRect:): Don't set the value
for the edited cell.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38408 72102866-910b-0410-8b05-ffd578937521
Don't autorelease the returned object as this method starts with
"new".
* Source/NSCollectionViewItem.m (-copyWithZone:): Add call to
new method to copy over the bindings from the old view hierarchy to
the new.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38405 72102866-910b-0410-8b05-ffd578937521
from being 0.
* Source/NSArrayController.m: Revert last change and add proper
handling of arrangeObjects for many cases.
* Source/NSCollectionViewItem.m: Fix reference counting. Add
method -view to have something to display.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38387 72102866-910b-0410-8b05-ffd578937521
content.
* Source/NSViewController.m (-loadView): Don't try to load the
view if there is no name for the NIB.
* Source/NSArrayController.m (-initWithContent:): Sets
automaticallyRearrangesObjects to true.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38384 72102866-910b-0410-8b05-ffd578937521
* Source/NSSpellChecker.m
Two small cleanups.
Patch by Marat Ibadinov <ibadinov@me.com>
* Source/NSLayoutManager.m
Changed == to >= to fix a crash when layout_char is beyond the
length of the string.
Patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38312 72102866-910b-0410-8b05-ffd578937521
from -copyWithZone: to -mutableCopyWithZone:.
* Tests/gui/NSBitmapImageRep/testcopy.m: Test for this change
Patch by Josh Freeman <tedge>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38301 72102866-910b-0410-8b05-ffd578937521
idea by Riccardo Mottola <rm@gnu.org>.
Remove all usages of deprecated types.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38300 72102866-910b-0410-8b05-ffd578937521
disable supermenus that have empty submenus, when there is no
validator.
Patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38289 72102866-910b-0410-8b05-ffd578937521
actions carrying across between different fields with the
fieldEditor.
Patch by Doug Simons <doug.simons@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38288 72102866-910b-0410-8b05-ffd578937521
Base on patch by Marat Ibadinov <ibadinov@me.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38287 72102866-910b-0410-8b05-ffd578937521
nil tests.
Patch by Eric Wasylishen <ewasylishen@gmail.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38283 72102866-910b-0410-8b05-ffd578937521
* Source/NSDocumentController.m:
Open recent menu to clear items that have been deleted whenever
it reloads.
Based on patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38242 72102866-910b-0410-8b05-ffd578937521
(a) locationInView was being converted twice, producing invalid
coordinates the second time, when using a provider to get the
tooltips.
(b) Tooltips were not working if you had two tracking rects next
to each other in the same view, when moving from one to the
other,
depending on the order they were processed, one could get the
enter before the other's exit, thus canceling the timer.
Patch by Paul Landers <paul.landers@testplant.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38241 72102866-910b-0410-8b05-ffd578937521
* Source/NSTableView.m:
Create working stubs for table view batch insertions/removals of
rows
Patch by Marcian Lytwyn <gna@advcsi.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38240 72102866-910b-0410-8b05-ffd578937521
Based on patch by Marcian Lytwyn <gna@advcsi.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38239 72102866-910b-0410-8b05-ffd578937521
(_insertionPointRectForCharacterIndex:textContainer:): Fix
initial
cursor insertion location with paragraph alignment setting.
This patch has no visual effect as the alignment of the typing
attributes never gets set.
Based on patch by Marcian Lytwyn <gna@advcsi.com>.
* Source/NSLayoutManager.m: Fix some compiler warnings.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38238 72102866-910b-0410-8b05-ffd578937521
* Source/GSXibLoader.m: Fix object ID parsing in XIB loading due
to Apple moving to string ID represenatation.
Patch by Marcian Lytwyn <gna@advcsi.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38236 72102866-910b-0410-8b05-ffd578937521
out
tabs in default paragraph style as Apple doesn't seem to have
them.
* Source/GSNibLoading.m: Set the main menu already when
instantiating the top level objects. Thi is needed for newer
versions of NIB files.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38160 72102866-910b-0410-8b05-ffd578937521
(-drawBackgroundForGlyphRange:atPoint:): Make save against
glyph_run being null. Should fix part of #43454.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38141 72102866-910b-0410-8b05-ffd578937521
_cell being nil.
* Source/NSBox.m (-initWithCoder:): Add a few default values.
* Source/NSMenu.m (-_setGeometry): Protect against _aWindow
being nil.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@38003 72102866-910b-0410-8b05-ffd578937521
workaround to adjust window min and max size when the height changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37982 72102866-910b-0410-8b05-ffd578937521
* Source/NSStatusItem.m
make return value of -sendActionOn: match apple documentation
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37925 72102866-910b-0410-8b05-ffd578937521
for subclasses of NSApplication as rootObjects.
Based on patch by Marcian Lytwyn <gna@advcsi.com>.
* Source/NSWindow.m (-userSpaceScaleFactor): Handle case where
_screen is nil.
Patch by Doug Simons (dsimons@testplant.com).
* Source/NSWindow.m (-_screenForFrame:): Require real overlapp.
Patch by Doug Simons (dsimons@testplant.com).
* Source/NSTextField.m (-textDidChange:): Improve editing
behavior when formatter returns a new string.
Patch by Doug Simons (dsimons@testplant.com).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37830 72102866-910b-0410-8b05-ffd578937521
* Source/NSWindow.m: (-encodeWithCoder:, -initWithCoder:): Use
content min/max size instead of min/max size.
* Source/NSWindow.m: (+initialize): Increase version number to 3.
* Source/GSNibLoading.m (NSWindowTemplate -encodeWithCoder:,
-initWithCoder:): Use NSWindowContentMinSize/NSWindowContentMaxSize
instead of NSMinSize/NSMaxSize.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37828 72102866-910b-0410-8b05-ffd578937521
* Source/NSToolbarItem.m: Fixed a bug where calling setImage:
on a toolbar item would draw the image even if the toolbar
display mode would be set to NSToolbarDisplayModeLabelOnly
* Source/GSToolbarCustomizationPalette.m: Turn NSLog into
NSDebugLLog.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37782 72102866-910b-0410-8b05-ffd578937521
* Source/NSTextAttachment.m: Use NSUInteger and bring closer to
the Apple implementation.
* Source/GSHorizontalTypesetter.m (-layoutLineNewParagraph:):
For attachments use the cell origin y flipped.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37704 72102866-910b-0410-8b05-ffd578937521
* Some int -> NSInteger and float -> CGFloat transitions
OK Fred
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37635 72102866-910b-0410-8b05-ffd578937521
look for substitutions for control or attachment characters.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37575 72102866-910b-0410-8b05-ffd578937521
identifier used by the backend's windowing system instead of
just the GNUstep-internal window number. On X11, the identifier
is useful, among other things, to implement the D-Bus menu
protocol.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37533 72102866-910b-0410-8b05-ffd578937521
* Headers/AppKit/NSApplication.h
* Headers/AppKit/NSControl.h
* Headers/AppKit/NSPopover.h
* Headers/AppKit/NSSavePanel.h
* Headers/AppKit/NSTableView.h
* Headers/AppKit/NSTextView.h
* Headers/AppKit/NSWindow.h: Use GS_PROTOCOLS_HAVE_OPTIONAL to
protect the @optional keyword in protocol definitions.
Based on base patch by Marcus Mueller <znek@mulle-kybernetik.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37530 72102866-910b-0410-8b05-ffd578937521
Patch by Johannes Lundberg <johannes@brilliantservice.co.jp>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37518 72102866-910b-0410-8b05-ffd578937521
Based on patch by Marcian Lytwyn <marcian.lytwyn@advcsi.com>.
* Source/GSXibLoader.m (-parser:...): Warn about unsupported XIB 5 format.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37463 72102866-910b-0410-8b05-ffd578937521
of rows not the internal cached value.
Replace some occurences of int with NSInteger
and unsigned with NSUInteger.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37461 72102866-910b-0410-8b05-ffd578937521
-setNeedsDisplay: to redraw areas no longer covered by the
document view.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37441 72102866-910b-0410-8b05-ffd578937521
background colour from the document view.
Patch by Jeff Teunissen <deek@d2dc.net>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37440 72102866-910b-0410-8b05-ffd578937521
scrollview bounds instead of the scroller frame for drawing the
border.
Patch by Jeff Teunissen <deek@d2dc.net>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37438 72102866-910b-0410-8b05-ffd578937521
as it is no longer needed. I leave the code for this in for a
while.
Patch by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37435 72102866-910b-0410-8b05-ffd578937521
documentView as needing redisplay. Fixes#40776.
Based on patch by Jeff Teunissen <deek@d2dc.net>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37429 72102866-910b-0410-8b05-ffd578937521
NSRectFill() instead of line drawing to get sharper separator
lines.
* Source/GSThemeDrawing.m (-drawScrollerRect:...): Don't fill
with window background colour.
* Source/NSScroller.m (-drawRect:): Draw only the knob slot when
disabled.
* Source/NSScroller.m (-mouseDown:): Don't handle mouse down
event when disabled.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37428 72102866-910b-0410-8b05-ffd578937521
if a value of 0 is given. Fixes bug #40760
* Source/NSScroller.m: Move disable check out of -rectForPart:.
Fixes bug #40761.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37425 72102866-910b-0410-8b05-ffd578937521
* Source/GSModelLoaderFactory.m: Add new method +supportedTypes.
* Source/NSBundleAdditions.m: Use this new method to implement
NIB resource detection on top of the base methods instead of doing
it here.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37421 72102866-910b-0410-8b05-ffd578937521
error in last change.
Detected by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37403 72102866-910b-0410-8b05-ffd578937521
Use color named @"highlightedTableRowBackgroundColor", if present in
the theme, to fill the selected row background.
* Source/GSThemeDrawing.m (-drawTableViewRow:clipRect:inView:):
When the row/column is selected, if the cell is a NSTextFieldCell,
set the text color to @"highlightedTableRowTextColor" before drawing the
cell (only if the theme defines that color).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37363 72102866-910b-0410-8b05-ffd578937521
Only adjust max_line_height to minimumLineHeight if it isn't zero.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37296 72102866-910b-0410-8b05-ffd578937521
-menuItemCellForItemAtIndex: to protect against an index being to
big. This happens when the menu does not send notifications and a
non-existing item gets highlighted.
* Source/NSMenuView.m (-menuItemCellForItemAtIndex:): Protect
against negative index values.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37279 72102866-910b-0410-8b05-ffd578937521
* Source/NSBitmapImageRep.m (_set_bit_value): Correct error in
bit operation. This should allow the code to work with 16 bit images.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37267 72102866-910b-0410-8b05-ffd578937521
* Images/common_SliderVert.tiff: Bake in the control background
color because the NSSliderCell now draws these without filling
with [NSColor controlBackgroundColor] first.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37250 72102866-910b-0410-8b05-ffd578937521
* Source/GSThemeTools.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Small refactor:
most uses of -[GSTheme fillRect:withTiles:background:] use
[NSColor clearColor], so add a version without the background:
param.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37244 72102866-910b-0410-8b05-ffd578937521
* Source/GSTheme.m: Add GSStringFromImageFrameStyle
* Source/GSThemeDrawing.m (-drawBorderForImageFrameStyle:...):
Use GSStringFromImageFrameStyle to get tiles, if presentwq
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37242 72102866-910b-0410-8b05-ffd578937521
border using part GSColorWellInnerBorder
* Source/GSTheme.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Add GSColorWellInnerBorder
part name
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37240 72102866-910b-0410-8b05-ffd578937521
part name, instead themes should just provide a part called NSScrollView.
Add -scrollViewScrollersOverlapBorders method.
* Source/GSTheme.m: Remove GSScrollViewBottomCorner part name.
* Source/GSThemeDrawing.m: Add -scrollViewScrollersOverlapBorders.
* Source/GSThemeDrawing.m (-drawBrowserRect:...): If
-scrollViewScrollersOverlapBorders is enabled, fill the browser background
with the NSScrollView tile.
* Source/GSThemeDrawing.m (-drawScrollViewRect:...): If
-scrollViewScrollersOverlapBorders is enabled, fill the scroll view background
with the NSScrollView tile.
* Source/NSScroller.m (-rectForPart:): Change the meaning of the
GSScrollerKnobOvershoot default so the knob only overlaps the buttons
by this much (rather than both ends of the track). Turns out this is more
useful for themes.
* Source/NSScrollView.m (-tile): Add support for
-[GSTheme scrollViewScrollersOverlapBorders]
* Source/NSBrowser.m (-tile): Add support for
-[GSTheme scrollViewScrollersOverlapBorders] and
-[GSTheme scrollViewUseBottomCorner]
The overall point of these additions is to support NSScrollView and
NSBrowser looking like: http://jesseross.com/clients/gnustep/ui/concepts/
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37238 72102866-910b-0410-8b05-ffd578937521
user default to see whether to expand the corner view by 1pt or not.
* Source/GSThemeDrawing.m (-drawTableHeaderRect:inView:): Remove
special case which reduced the width of the last column header by 1pt.
I don't see any reason for doing that and it looks better to me without
the gap, and more uniform for themeing.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37237 72102866-910b-0410-8b05-ffd578937521
* Source/NSMenuItemCell.m: Make a shared -themeControlState in
NSButtonCell and eliminate duplicated code.
* Source/NSPopUpButtonCell.m: Add private declaration for
-[NSButtonCell themeControlState]
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37236 72102866-910b-0410-8b05-ffd578937521
Set alpha to 1 before drawing because the current value could be
not 1, and PSsetrgbcolor doesn't set it.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37235 72102866-910b-0410-8b05-ffd578937521
method.
* Source/GSThemeDrawing.m:
* Source/NSTabView.m: Move the -contentRect implementation to GSTheme
so we can delegate to GSDrawTiles, if used.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37234 72102866-910b-0410-8b05-ffd578937521
call -selectTabViewItem: to select the current tab at unarchiving
time (keyed archives were already doing this.)
Comment: "N.B.: As a side effect, this discards the subview frame
and sets it to [self contentRect].
This is desirable because the subview frame will be different
depending on whether the arcive is from Cocoa or GNUstep,
and which GNUstep theme was active at save time.
However, it does mean that the tab view contents should be
prepared to resize slightly."
The immediate need for this is tab views were changed to use
flipped coordinates, so the subview frames stored in existing
archives are now in the wrong coordinate system.
This is essentially the same idea as NSScrollView calling -tile at the
end of -initWithCoder: so I hope it makes sense for tab views too.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37232 72102866-910b-0410-8b05-ffd578937521
before calling -size on an NSImage, for systems where this
corrupts the stack.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37231 72102866-910b-0410-8b05-ffd578937521
images. The stepper is too small to make decomposing it in to
border + bezel + arrow worthwhile; it's simpler to just use images.
* Images/GNUmakefile:
* Images/common_StepperDown.tiff:
* Images/common_StepperDownHighlighted.tiff:
* Images/common_StepperUp.tiff:
* Images/common_StepperUpHighlighted.tiff: Add stepper images
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37229 72102866-910b-0410-8b05-ffd578937521
control state: GSThemeFirstResponderState,
GSThemeHighlightedFirstResponderState,
and GSThemeSelectedFirstResponderState. This lets themes draw
custom first responder tiles, if the desired effect can't be
accomplished by drawing on top of an existing button.
* Source/GSThemeDrawing.m (-drawFocusFrame:inRect:):
Use tiles named "NSFocusRing" if available, else draw dotted
rect.
* Source/GSTheme.m:
* Source/NSButtonCell.m: Use new GSTheme*FirstResponderState
states
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37227 72102866-910b-0410-8b05-ffd578937521
Add support for drawing striped table backgrounds, using the colors
returned by [NSColor controlAlternatingRowBackgroundColors].
Currently not used because
-[NSTableView usesAlternatingRowBackgroundColors] is hardcoded to
return NO.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37226 72102866-910b-0410-8b05-ffd578937521
with a background color before drawing the cell. Seems pointless
- GNUstep's default knob image is opaque, but filling with a solid
color prevents transparent knob images from looking good.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37224 72102866-910b-0410-8b05-ffd578937521
* Panels/Spanish.lproj/GSPageLayout.gorm: Minor visual tweaks:
Turn off "draws background" on the portrait/landscape matrix
so it looks better with themes. Remove 0.5 point offsets on
some views on the second and third tabs to eliminate blurring.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37223 72102866-910b-0410-8b05-ffd578937521
* Source/GSTheme.m: Add GSProgressIndicatorBezel part name
* Source/GSThemeDrawing.m (-drawProgressIndicatorBezel:withClip:):
Use GSProgressIndicatorBezel to draw bezel if available.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37222 72102866-910b-0410-8b05-ffd578937521
"optiacal bounds" metadata in 9-patch images. It's stored
in the layoutRect ivar but not used otherwise.
See "Optical bounds layout" section of:
http://developer.android.com/about/versions/android-4.3.html
* Source/GSThemePrivate.h (GSDrawTiles): Add layoutRect ivar
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37219 72102866-910b-0410-8b05-ffd578937521
with clipping rect that was causing artifacts when scrolling a list
of color wells in Thematic.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37218 72102866-910b-0410-8b05-ffd578937521
in the 9-patch content rect parsing code. Add some comments.
Simplify contentRectForRect: implementation.
* Source/GSThemeDrawing.m (-browserHeaderDrawingRectForCell:...):
Use -contentRectForRect: to get the content rect instead of
incorrectly reading from ivar. Fixes broken text positioning
in browser header with Nesedah theme.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37217 72102866-910b-0410-8b05-ffd578937521
* Source/NSBox.m (-calcSizesAllowingNegative):
Special case for box type NSBoxSeparator to draw a centered line
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37210 72102866-910b-0410-8b05-ffd578937521
as NinePatch=YES. If a tile isn't listed in GSThemeTiles in the
plist, try to find it in the ThemeTiles directory anyway. This
lets you avoid declaring tiles in the info plist.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37208 72102866-910b-0410-8b05-ffd578937521
use actual clipping to clip a hole in the border, so we can avoid
filling anything with the background color.
* Source/NSBox.m (-isOpaque:): change to NO.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37207 72102866-910b-0410-8b05-ffd578937521
organized, lay out the images in a straightforward way, and
allow themeing the fill part of the tab between the end images.
The output is almost pixel-identical to
the old code (only some unnoticable 1-pixel differences
in where shadows end). It's also organized so that adding support
for left and right tabs should be easy.
* Headers/Additions/GNUstepGUI/GSTheme.h: Add some part names
* Images/common_Tab*.tiff: Tweak to work with the new layout code.
All top images are now the same size, as are all bottom images.
* Images/GNUmakefile:
* Images/common_TabUnSelectToSelectedJunction.tiff: Renamed to
Images/common_TabUnSelectedToSelectedJunction.tiff
* Source/GSThemePrivate.h:
* Source/GSTheme.m: Add GSStringFromTabViewType utility function
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37205 72102866-910b-0410-8b05-ffd578937521
Clean up grid drawing code; use rect fills to avoid blurriness.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37204 72102866-910b-0410-8b05-ffd578937521
* Source/GSThemeDrawing.m:
* Source/NSPopUpButtonCell.m:
Remove -[GSTheme drawBorderAndBackgroundForPopUpButtonCell:
withFrame:inView:state:] which I added recently, and just use
-[GSTheme drawButton:in:view:style:state]. This way,
NSPopUpButtonCell automatically supports all of the different
NSBezelStyles.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37202 72102866-910b-0410-8b05-ffd578937521
-setName:forElement:temporary: mechanism to bind the menu close
button's cell to the name GSMenuCloseButton, so themes can provide
a custom border for this button.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37201 72102866-910b-0410-8b05-ffd578937521
* Source/NSColorWell.m: Move code to draw the black and white
triangles background for transparent colors to
-[NSColor drawSwatchInRect:].
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37194 72102866-910b-0410-8b05-ffd578937521
the arrow using NSHighlightedMenuArrow (if available).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37192 72102866-910b-0410-8b05-ffd578937521
to get the margins for draw tiles.
* Source/GSThemePrivate.h:
* Source/GSThemeTools.m: Get the 9-patch content rect support
working from end-to-end.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37191 72102866-910b-0410-8b05-ffd578937521
* Source/GSTheme.m:
* Source/GSThemeDrawing.m:
* Source/NSBox.m: Factor out -[NSBox drawRect:] to GSTheme
method -drawBoxInClipRect:boxType:borderType:inView:.
Add a tiles name GSBoxBorder for themeing the box border.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37188 72102866-910b-0410-8b05-ffd578937521
with the image @"common_CircularSlider". Draw the dimple
with @"common_Dimple" instead of an NSBezierPath.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37186 72102866-910b-0410-8b05-ffd578937521
* Source/GSTheme.m:
Declare GSSliderHorizontalTrack and GSSliderVerticalTrack
part names for themeing the background of NSSlider
* Source/GSThemeDrawing.m:
Add new drawSliderBorderAndBackground:frame:inCell:isHorizontal:
method to draw the slider border and background.
* Source/GSThemePrivate.h:
* Source/GSThemeTools.m:
Add a -size method on GSDrawTiles which returns the total
original size of the tiles, so we can easily compute a rect
that scales the tiles in only one dimension.
* Source/NSSliderCell.m:
Override _drawBorderAndBackgroundWithFrame: to call new
GSTheme method. Also, tweak the knob drawing code; the knob
is now centered and drawn at its native size. This still looks
correct with the default slider sizes create by Gorm.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37185 72102866-910b-0410-8b05-ffd578937521
Accept negative item indicies, which are passed in when
opening the preferences window in TextEdit. Need to investigate
further why that is happening.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37184 72102866-910b-0410-8b05-ffd578937521
* Source/GSTheme.m:
* Source/GSThemeDrawing.m:
* Source/NSPopUpButtonCell.m: Add a theme part GSPopUpButton
so NSPopUpButtonCell can be drawn with a different background
than NSMenuItemCell.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37183 72102866-910b-0410-8b05-ffd578937521
* Source/NSScrollView.m:
* Source/GSThemeDrawing.m:
* Source/GSTheme.m: Add GSScrollViewUseBottomCorner default,
which themes can set to NO to leave a square gap in the bottom-
left (or bottom-right) corner where the horizontal and vertical
scrollers meet.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37176 72102866-910b-0410-8b05-ffd578937521
Remove update logic from -setSeparatesColumns: and just use
-tile. Tested by toggling "separates columns" flag in Gorm.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37173 72102866-910b-0410-8b05-ffd578937521
macros to static floats. Cache the values in +initialize and
when GSThemeDidActivateNotification is sent, by calling the
new GSTheme methods.
* Source/GSThemeDrawing.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Add
-browserColumnSeparation and -browserVerticalPadding methods
which access user defaults GSBrowserColumnSeparation and
GSBrowserVerticalPadding. These determine the padding between
browser columns, and the vertical padding between the bottom
scroller, contents, and headers.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37171 72102866-910b-0410-8b05-ffd578937521
* Source/GSTitleView.m:
* Source/GSThemeDrawing.m:
* Headers/Additions/GNUstepGUI/GSTheme.h: Add GSMenuTitleBackground
theme tile for themeing the background of GSTitleView.
NOTE: I removed some code that was in -[GSTitleView drawRect:] for
drawing with a different style when the GSTitleView is NOT owned
by an NSMenu, but by an NSWindow/NSPanel (_ownedByMenu == NO).
If needed, this can be added back, but it doesn't appear to ever
be used in gnustep-gui - GSTitleView is only created in one place,
with NSMenu as the owner.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37165 72102866-910b-0410-8b05-ffd578937521
Remove call to [controlView displayRect: cellFrame];
There was a comment saying it should be removed, and when
combined with the -[NSButtonCell isOpaque] change, it
was casuing scroller buttons to stay "stuck" down.
* Source/NSBrowser.m (-isOpaque):
* Source/NSButtonCell.m (-isOpaque):
* Source/NSColorWell.m (-isOpaque):
Force -isOpaque to return NO, because it's
possible to make all of these controls semitransparent with
theme tiles. This was visible with the Narcissus theme
(svn://svn.gna.org/svn/etoile/trunk/Etoile/Themes/Narcissus.theme)
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37164 72102866-910b-0410-8b05-ffd578937521
so non-code themes can change -[GSTheme defaultScrollerWidth]
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37163 72102866-910b-0410-8b05-ffd578937521
allows themes to make the scroller knob overlap the scroller buttons
by a specified amount.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37162 72102866-910b-0410-8b05-ffd578937521
draw string when editing.
* Source/NSBrowserCell.m (-titleRectForBounds:): Implement to
exactly match calculation in -drawInteriorWithFrame:inView:.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37159 72102866-910b-0410-8b05-ffd578937521
path to "/" would not deselect the cells.
Based on patch by Frank Le Grand <frank.legrand@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37081 72102866-910b-0410-8b05-ffd578937521
* the
absence of a NSFontAttributeName attribute, use a default font
to
prevent the substitution from stopping. This fixes a bug where
unicode characters would not get the proper font substitution.
Patch by: Frank Le Grand <frank.legrand@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@37027 72102866-910b-0410-8b05-ffd578937521
* Headers/AppKit/NSTreeNode.h: Add method declarations to these
* files.
* Headers/AppKit/AppKit.h,
* Source/GNUmakefile: Include new files.
* Source/NSObjectController.m (+initialize, -selection): Get
* basic
binding example working.
* Source/NSTreeController.m: Minimal implementation.
* Source/NSTreeNode.m: Full implementation of this class.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36991 72102866-910b-0410-8b05-ffd578937521
Theme bundles that contain theme images named using either GNUstep or
OPENSTEP names now work properly again (bug introduced in r36836).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36916 72102866-910b-0410-8b05-ffd578937521
* Source/GSDisplayServer.m: Add new method -setIgnoreMouse::
* with
empty implementation.
* Source/NSWindow.m (-setIgnoresMouseEvents:): Use this new
* method.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36854 72102866-910b-0410-8b05-ffd578937521
handling for printing as suggested by Eric Wasylishen <ewasylishen@gmail.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36847 72102866-910b-0410-8b05-ffd578937521
makes Grr happy again loading its gorm files
OK Fred Kiefer
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36646 72102866-910b-0410-8b05-ffd578937521
-replaceObject:withObject:] which was moved to base.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36619 72102866-910b-0410-8b05-ffd578937521
for popoverShouldClose:
* Headers/AppKit/NSWindow.h: add convertRectToScreen: and
convertRectFromScreen: methods.
* Source/NSPopover.m: Correct delegate method for popoverShouldClose:.
Changes to align popover window with rect it is being placed relative
to.
* Source/NSWindow.m: implementation of convertRectToScreen: and
convertRectFromScreen: methods.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36577 72102866-910b-0410-8b05-ffd578937521
* -selectedRowIndexes): Return an
autoreleased copy of the corresponding ivar. Returning a
reference to the ivar
leads to issues (and behavior different from Cocoa) when
iterating thru the
indexsets if at a time they would be being altered.
Patch by Frank LeGrand (flegrand@testplant.com).
* Source/GNUmakefile: Add NSCollectionViewItem.
* Headers/AppKit/NSCollectionView.h,
* Headers/AppKit/NSCollectionViewItem.h,
* Source/NSCollectionViewItem.m,
* Source/NSCollectionView.m: Bring closer to the GNUstep coding
* standard.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36551 72102866-910b-0410-8b05-ffd578937521
* Headers/AppKit/NSCollectionViewItem.h
* Source/GNUmakefile
* Source/NSCollectionViewItem.m
* Source/NSCollectionView.m: Added NSCollectionView and
NSCollectionViewItem classes from testplant branch. Made changes
to original patch to conform to coding standards, NSCoding for
non-keyed archiving and moved instances of float/integer to
CGFloat and NSInteger/NSUInteger as appropriate.
Patch by Doug Simons (dsimons@testplant.com) and
Frank LeGrand (flegrand@testplant.com).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36545 72102866-910b-0410-8b05-ffd578937521
* Source/NSImage.m: Revert previous commit and write a much cleaner
implementation that fixes the same bug.
I removed the step in theme activation where we call
+[NSImage _setImagePath:name:] on each image in the theme, and instead
modified +[NSImage _pathForImageNamed:] to also search the theme images
directory.
When a GSTheme activates now, it only calls +[NSImage _reloadCachedImages]
which checks all NSImage cached by name and reloads any whose path has
changed.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36482 72102866-910b-0410-8b05-ffd578937521
common_3DArrowRight and have images that map to it (NSMenuArrow)
automatically update.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36474 72102866-910b-0410-8b05-ffd578937521
instead of isa. Make exitIfUnneeded: a class method. Reformat
code.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36460 72102866-910b-0410-8b05-ffd578937521
additional argument to function DGifOpen in newer libgif
versions.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36459 72102866-910b-0410-8b05-ffd578937521
* tip
window to NSPopUpMenuWindowLevel.
Change suggested by Wolfgang Lux <wolfgang.lux@gmail.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36393 72102866-910b-0410-8b05-ffd578937521
* Source/NSOutline.m(-drawRow:clipRect:): The selected cell
* shows
its first responder state.
Patch by Frank LeGrand <frank.legrand@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36378 72102866-910b-0410-8b05-ffd578937521
that checks the cells selectable state, in -mouseDown:.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36363 72102866-910b-0410-8b05-ffd578937521
Re-add call to -replaceObject:withObject: on decoder, but this
time in the right place.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36329 72102866-910b-0410-8b05-ffd578937521
use of @defs().
Base on idea by Wolfgang Lux <wolfgang.lux@gmail.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36313 72102866-910b-0410-8b05-ffd578937521
non-editable by default.
* Source/NSTableView.m (-editColumn:...select:): Make editing
here independ of the datasource.
* Source/NSTableView.m: Split -_isCellEditableColumn:row: in two
methods and ignore the cell isEditable state in -mouseDown:.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36307 72102866-910b-0410-8b05-ffd578937521
handling of close element.
Patch by Bluna Ratimonkey <object@gmail.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36304 72102866-910b-0410-8b05-ffd578937521
Patch by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36268 72102866-910b-0410-8b05-ffd578937521
keyed decoding.
Patch by Christopher Armstrong <carmstrong@fastmail.com.au>
* Source/NSBezierPath.m: Rewrote -elementAtIndex:associatedPoints:
to return a point for NSClosePathBezierPathElement. And adjust
all callers to make use of that point. Complete non-keyed coding and
decoding.
* Tests/gui/NSBezierPath/basic.m: Add basic tests for NSBezierPath.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36267 72102866-910b-0410-8b05-ffd578937521
int -> NSInteger transitions for NSOutlineView protocol
OK Fred
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36240 72102866-910b-0410-8b05-ffd578937521
more float -> CGFloat transitions
like the one before, OK Fred
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36239 72102866-910b-0410-8b05-ffd578937521
to match GSEPSPrintOperation to get the class to at least partly
working. Output is appearing up-side-down for me though.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36203 72102866-910b-0410-8b05-ffd578937521
notifications if same delegate is set twice.
Patch by Doug Simons <doug.simons@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36192 72102866-910b-0410-8b05-ffd578937521
* values
here consistent with the code in GSThemeDrawing.
* Source/GSThemeDrawing.m (-drawTabViewRect:...): Remove useless
line of code.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36184 72102866-910b-0410-8b05-ffd578937521
(-_PNGRepresentationWithProperties:): Revert last change and
don't use png_info_init_3() on PNG >= 1.5.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36178 72102866-910b-0410-8b05-ffd578937521
Release the document.
Patch by Doug Simons <doug.simons@testplant.com>
* Source/GSXibLoader.m: Fix a problem where owner,
* firstResponder and application
were put in the list of top-level objects, creating a
retain-cycle.
* Source/NSViewController.m: Fix a problem where view
* controllers
did not release their top-level objects as expected.
* Source/NSWindowController.m: Fix a problem where window
controllers did not release their top-level objects as expected.
Changes made in occordance with
https://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/LoadingResources/CocoaNibs/CocoaNibs.html
Patch by Jonathan Gillaspie <jonathan.gillaspie@testplant.com>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36134 72102866-910b-0410-8b05-ffd578937521
Patch by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36133 72102866-910b-0410-8b05-ffd578937521
* Source/NSSplitView.m: Change to CGFloat, NSUInteger and NSInteger.
Patch partly by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36109 72102866-910b-0410-8b05-ffd578937521
* range.
Patch by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36093 72102866-910b-0410-8b05-ffd578937521
* Source/NSPageLayout.m: Change int to NSInteger.
Patch by Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36092 72102866-910b-0410-8b05-ffd578937521
does (Apple discusses superview encoding as a use case for conditional encoding
in the Archiving related documentation).
Note: A view can now be archived (or copied) without having to remove the view
from its hierarchy before archiving it.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36065 72102866-910b-0410-8b05-ffd578937521
Prevent negative width/height from being returned.
Bug found by unit test from Nikolaus Schaller
<hns@computer.org>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@36026 72102866-910b-0410-8b05-ffd578937521
where one has size information, but the other hasn't.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35935 72102866-910b-0410-8b05-ffd578937521
state of the view has changed. Call this method all the times
instead of checking _coordinates_valid.
This change allows views to dynamically change their flipped
state.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35928 72102866-910b-0410-8b05-ffd578937521
matrixExplicitlySet.
Patch by Derek Fawcus <dfawcus@cisco.com>.
* Source/NSFont.m: Remove all other usages of
matrixExplicitlySet.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35926 72102866-910b-0410-8b05-ffd578937521
-_invalidateEverything visible.
* Source/GSLayoutManager.m
* (-invalidateGlyphsForCharacterRange:...): Call
-_invalidateEverything when the whole character range is
invalidated.
* Source/NSStringDrawing.m: Remove workarounds for full layout
* invalidation.
Move initialisation check into cache_lock().
Extract size match code in function.
Put #ifdef around all statistics code.
Use same LARGE_SIZE value as Apple does.
Make the methods taking options the main ones.
* Source/GSHorizontalTypesetter.m (-fullJustifyLine::,
-rightAlignLine::, -centerAlignLine::): Don't align when the
line
width is bigger than 1e7.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35925 72102866-910b-0410-8b05-ffd578937521
* Source/NSOpenGLPixelFormat.m: NSOpenGLPixelFormat directly
* implements
initWithCoder so that it may marshall the pixel attributes prior
to
initWithAttributes:. Change the getValues:... method to take an
int argument instead of long. GLint is mapped to int on most
systems.
* Source/NSOpenGLContext.m: Use the format decoding to decode an
* OpenGL context.
Patch by Clint Smullen <daemonae>.
* Source/GSLayoutManager.m: Small cleanup in glyph code.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35923 72102866-910b-0410-8b05-ffd578937521
separate method -_replacementFontName and add replacement for
"Helvetica-" prefix.
* Header/AppKit/NSLayoutManager.h: Add some 10.5 methods.
* Source/NSLayoutManager.m: Simple implementations for these new
methods.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35922 72102866-910b-0410-8b05-ffd578937521
file with key equivalent. Make sure that the image is properly
set.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35717 72102866-910b-0410-8b05-ffd578937521
Added check to make sure the image is not overriden.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35705 72102866-910b-0410-8b05-ffd578937521
for method setKeyEquivalent:forButtonCell:
* Source/GSThemeDrawing.m: Add implementation for method
setKeyEquivalent:forButtonCell:
* Source/NSButtonCell.m: Add call to new method.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35702 72102866-910b-0410-8b05-ffd578937521
* Source/NSTabView.m (-drawRect:): Move the select logic from
theme into normal code.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35686 72102866-910b-0410-8b05-ffd578937521
NSBundle method to get the info dictionary.
Patch by: Luboš Doležel <lubos@dolezel.info>
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35673 72102866-910b-0410-8b05-ffd578937521
for a window (and tab view item). This implicit key view is created
when a window is made key and does not have an explicit key view loop,
which is detected by checking the initial first responder of the
window.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35632 72102866-910b-0410-8b05-ffd578937521
cursor from being deallocated when client code releases the last
reference to it.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35586 72102866-910b-0410-8b05-ffd578937521
even if another panel (with worksWhenModal=YES) is key window.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35585 72102866-910b-0410-8b05-ffd578937521
* Source/NSCell.m (+initialize): Expose title binding.
* Source/NSOpenPanel.m (-runModal): Use _directory if it is set.
* Source/NSTableView.m (-validateEditing): Check _isValidating to
prevent recursive calls into validateEditing.
* Source/NSTabView.m (-initWithCoder:): Set _selected_item to
NSNotFound.
* Source/NSView.m (-addSubview:): Do not throw an exception when
adding a nil subview, just ignore it. This matches behavior on
Cocoa.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35562 72102866-910b-0410-8b05-ffd578937521
was removed without reason during the last change of NSSavePanel.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35516 72102866-910b-0410-8b05-ffd578937521
frame had zero width or height. This could destroy a valid screen
attribute of a window.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35502 72102866-910b-0410-8b05-ffd578937521
custom class substitutions when loading a XIB file.
* Source/GSXibLoading.m: Add stub classes for IBNSLayoutConstraint
and IBNSLayoutConstant so that these can now be loaded.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35482 72102866-910b-0410-8b05-ffd578937521
the previous change. If the URL doesn't load then try to load
the image in the NSURL as a "named" image in resources so that
the developer of the app has a way to provide this image.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35316 72102866-910b-0410-8b05-ffd578937521
Some XIB files have image representations encoded
via NSURL. When this happens it causes the XIB not to be loaded at
all since the image rep fails to load and causes the xib loading
process to fail.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35310 72102866-910b-0410-8b05-ffd578937521
operation system specific application for files or URL that
could
not be handled by GNUstep applications. Based on patch by Julian
Mayer <julian@corecode.at>.
* Source/NSWorkspace.m
* (-openFile:withApplication:andDeactivate:,
-openTempFile:, -openURL:): Use this new method.
* Documentation/GuiUser/DefaultsSummary.gsdoc: Document the new
setting GSUnknownFileTool that allows to define a default
application.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35246 72102866-910b-0410-8b05-ffd578937521
NB This test is unlikely to yield correct results with a garbage
collected runtime; volunteers?
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35179 72102866-910b-0410-8b05-ffd578937521
containers and layout managers when their respective layout manager
and text storage are deallocated.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35178 72102866-910b-0410-8b05-ffd578937521
last change.
* Source/NSWorkspace.m (-openURL:): Declare the URL pasteboard
type here.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35110 72102866-910b-0410-8b05-ffd578937521
missing method to get separator coding correct.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35023 72102866-910b-0410-8b05-ffd578937521
a typo. The "if (nil == _contents) { contents = @""; }" blocks were
dead code because the contents variable would later
be set to nil if _contents was nil. This was causing an exception
when starting editing an empty text field loaded from a xib.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35011 72102866-910b-0410-8b05-ffd578937521
view:stringForToolTip:point:userData: method, make the point
relative to the view's coordinate system (tested on OS X) instead
of relative to the tracking rect (as before.)
* Source/GSToolTips.m (-_timedOut:): Fix a crash caused by
invalidating the timer and then using its userInfo object.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35000 72102866-910b-0410-8b05-ffd578937521
(-initWithData:options:documentAttributes:error:): Set
NSCharacterEncodingDocumentAttribute in the documentAttributes dict
when reading plain text.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34987 72102866-910b-0410-8b05-ffd578937521
(-initWithData:options:documentAttributes:error:): Fixes for TextEdit.
If no type is provided, assume plain text. If no encoding is provided,
assume UTF-8 unless a UTF-16 BOM is detected.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34985 72102866-910b-0410-8b05-ffd578937521
[NSColor darkGrayColor]
* Source/NSToolbar.m (-initWithIdentifier:): Call
[self setShowsBaselineSeparator: YES] by default so the toolbar has
a bottom border.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34983 72102866-910b-0410-8b05-ffd578937521
* Source/externs.m: Additional binding names.
* Source/GSBindingHelpers.h,
* Source/NSKeyValueBinding.m: Additional helper methods.
* Source/NSObjectController.m: Use helper methods.
* Source/NSArrayController.m: Signal when the arranged objects
change.
* Source/NSTableColumn.m,
* Source/NSTableView.m: First attempt at support for content
binding.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34923 72102866-910b-0410-8b05-ffd578937521
* Source/GSNibLoading.m: Move -[coder setClassName: @"_NSCornerView"
forClass: [GSTableCornerView class]] call from
-[NSTableView initWithCoder:] to GSNibLoading, because corner views
can be encountered before hitting -[NSTableView initWithCoder:]
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34919 72102866-910b-0410-8b05-ffd578937521
most recent -draggingEntered: or -draggingUpdated: call returned
something other than NSDragOperationNone.
* Source/NSOutlineView.m (-draggingUpdated:): Save the drag operation
value returned from the data source in a static variable.
Previously it was fetched once and then discarded, so all drags were
being mistakenly permitted.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34910 72102866-910b-0410-8b05-ffd578937521
* Headers/AppKit/NSArrayController.h,
* Source/NSArrayController.m: Add some implementation to this class.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34904 72102866-910b-0410-8b05-ffd578937521
for bug 35702.
Don't use [_menuView imageAndTitleWidth] or
_titleWidth in calculating the size to put the title in. In other
words, -titleRectForBounds: will now return the available space
for the title, rather than the rect that the title text is
predicted to use up.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34885 72102866-910b-0410-8b05-ffd578937521
* Source/GSXibLoading.m: Add some classes which I found
are relevant to Xib loading: IBAccessibilityAttribute,
IBUserDefinedRuntimeAttributesPlaceholder.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34846 72102866-910b-0410-8b05-ffd578937521
inside cell bounds, to prevent drawing text outside of a
NSPopUpButtonCell which has a label that is too long to fit.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34838 72102866-910b-0410-8b05-ffd578937521
self and only call setDocument: if we have an actual window.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34825 72102866-910b-0410-8b05-ffd578937521
is a primitive method which subclasses should override.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34815 72102866-910b-0410-8b05-ffd578937521
that method was removed from its superclass NSSavePanel.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34782 72102866-910b-0410-8b05-ffd578937521
sender of a pop up button's action when it is sent through one of the
menu items.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34781 72102866-910b-0410-8b05-ffd578937521
