Mmory leak fix

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@14856 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
CaS 2002-10-28 09:09:14 +00:00
parent c295765267
commit c7efda6fab
2 changed files with 8 additions and 6 deletions

View file

@ -3,8 +3,11 @@
* Source/NSTextField.m: ([-dealloc]) morph self to be an NSTextView * Source/NSTextField.m: ([-dealloc]) morph self to be an NSTextView
so that when dealloc is re-called, any subclass dealloc methods so that when dealloc is re-called, any subclass dealloc methods
don't get re-called. don't get re-called.
* Source/NSTableView.m: Memory leak fix added as suggested by
Stefan Urbanek. NOTE ... selection code looks very inefficient,
perhaps we should look into whether it is worth optimising?
2002-10-27 Pierre-Yves Rivaille <pyrivail@ens-lyon.fr> 2002-10port-Yves Rivaille <pyrivail@ens-lyon.fr>
* Source/NSMenuView.m ([NSMenuView -trackWithEvent:]): * Source/NSMenuView.m ([NSMenuView -trackWithEvent:]):
new tracking code. The menu feels snappier now (at least for me). new tracking code. The menu feels snappier now (at least for me).

View file

@ -196,9 +196,9 @@ static void computeNewSelection
int *_selectedRow, int *_selectedRow,
unsigned selectionMode) unsigned selectionMode)
{ {
if ( (selectionMode & ALLOWS_MULTIPLE) if ((selectionMode & ALLOWS_MULTIPLE)
&& (selectionMode & SHIFT_DOWN) && (selectionMode & SHIFT_DOWN)
&& (selectionMode & ADDING_ROW)) && (selectionMode & ADDING_ROW))
// we add new row to the current selection // we add new row to the current selection
{ {
if (_oldRow == -1) if (_oldRow == -1)
@ -4293,8 +4293,7 @@ byExtendingSelection: (BOOL)flag
} }
// let's sort the _selectedRows // let's sort the _selectedRows
_oldSelectedRows = [[NSSet alloc] _oldSelectedRows = [NSSet setWithArray: _selectedRows];
initWithArray: _selectedRows];
lastEvent = theEvent; lastEvent = theEvent;
while (done != YES) while (done != YES)