diff --git a/ChangeLog b/ChangeLog index e3de67434..c22f8a833 100644 --- a/ChangeLog +++ b/ChangeLog @@ -3,8 +3,11 @@ * Source/NSTextField.m: ([-dealloc]) morph self to be an NSTextView so that when dealloc is re-called, any subclass dealloc methods don't get re-called. + * Source/NSTableView.m: Memory leak fix added as suggested by + Stefan Urbanek. NOTE ... selection code looks very inefficient, + perhaps we should look into whether it is worth optimising? -2002-10-27 Pierre-Yves Rivaille +2002-10port-Yves Rivaille * Source/NSMenuView.m ([NSMenuView -trackWithEvent:]): new tracking code. The menu feels snappier now (at least for me). diff --git a/Source/NSTableView.m b/Source/NSTableView.m index 9bfb88c9c..a1ce0706b 100644 --- a/Source/NSTableView.m +++ b/Source/NSTableView.m @@ -196,9 +196,9 @@ static void computeNewSelection int *_selectedRow, unsigned selectionMode) { - if ( (selectionMode & ALLOWS_MULTIPLE) - && (selectionMode & SHIFT_DOWN) - && (selectionMode & ADDING_ROW)) + if ((selectionMode & ALLOWS_MULTIPLE) + && (selectionMode & SHIFT_DOWN) + && (selectionMode & ADDING_ROW)) // we add new row to the current selection { if (_oldRow == -1) @@ -4293,8 +4293,7 @@ byExtendingSelection: (BOOL)flag } // let's sort the _selectedRows - _oldSelectedRows = [[NSSet alloc] - initWithArray: _selectedRows]; + _oldSelectedRows = [NSSet setWithArray: _selectedRows]; lastEvent = theEvent; while (done != YES)