gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-05-30 15:00:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix small bugs found by static analyser.

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31410 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Fred Kiefer 2010-09-24 18:58:57 +00:00
parent 8d1ae3ab80
commit bdda29451c
3 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog
View file

@ -1,3 +1,11 @@
2010-09-24 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSButton.m (-keyDown:): Remove unused code found by
static analyser.
* Source/NSColor.m (-colorUsingColorSpace:): Add missing break
statements.
* Source/NSColor.m (initSystemColors): Remove unused variable.
2010-09-24 Fred Kiefer <FredKiefer@gmx.de> 2010-09-24 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSView.m (-_viewWillMoveToWindow:): When calling * Source/NSView.m (-_viewWillMoveToWindow:): When calling

6
Source/NSButton.m
View file

@ -477,12 +477,6 @@ static id buttonCellClass = nil;
if ([self isEnabled]) if ([self isEnabled])
{ {
NSString *characters = [theEvent characters]; NSString *characters = [theEvent characters];
unichar character = 0;
if ([characters length] > 0)
{
character = [characters characterAtIndex: 0];
}
/* Handle SPACE to perform a click */ /* Handle SPACE to perform a click */
if ([characters isEqualToString: @" "]) if ([characters isEqualToString: @" "])

5
Source/NSColor.m
View file

@ -250,7 +250,6 @@ void initSystemColors(void)
{ {
NSEnumerator *enumerator; NSEnumerator *enumerator;
NSString *key; NSString *key;
BOOL changed = NO;
// Set up default system colors // Set up default system colors
@ -269,7 +268,6 @@ void initSystemColors(void)
NSCAssert1(color, @"couldn't get default system color %@", key); NSCAssert1(color, @"couldn't get default system color %@", key);
[systemColors setColor: color forKey: key]; [systemColors setColor: color forKey: key];
changed = YES;
} }
if (defaultSystemColors != systemColors) if (defaultSystemColors != systemColors)
{ {
@ -1250,10 +1248,13 @@ systemColorWithName(NSString *name)
return nil; return nil;
case NSGrayColorSpaceModel: case NSGrayColorSpaceModel:
colorSpaceName = NSDeviceWhiteColorSpace; colorSpaceName = NSDeviceWhiteColorSpace;
break;
case NSRGBColorSpaceModel: case NSRGBColorSpaceModel:
colorSpaceName = NSDeviceRGBColorSpace; colorSpaceName = NSDeviceRGBColorSpace;
break;
case NSCMYKColorSpaceModel: case NSCMYKColorSpaceModel:
colorSpaceName = NSDeviceCMYKColorSpace; colorSpaceName = NSDeviceCMYKColorSpace;
break;
case NSLABColorSpaceModel: case NSLABColorSpaceModel:
return nil; return nil;
case NSDeviceNColorSpaceModel: case NSDeviceNColorSpaceModel: