diff --git a/ChangeLog b/ChangeLog index d9ca1a85e..9f08b7fab 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2010-09-24 Fred Kiefer + + * Source/NSButton.m (-keyDown:): Remove unused code found by + static analyser. + * Source/NSColor.m (-colorUsingColorSpace:): Add missing break + statements. + * Source/NSColor.m (initSystemColors): Remove unused variable. + 2010-09-24 Fred Kiefer * Source/NSView.m (-_viewWillMoveToWindow:): When calling diff --git a/Source/NSButton.m b/Source/NSButton.m index fccccde6b..f1286b62f 100644 --- a/Source/NSButton.m +++ b/Source/NSButton.m @@ -477,12 +477,6 @@ static id buttonCellClass = nil; if ([self isEnabled]) { NSString *characters = [theEvent characters]; - unichar character = 0; - - if ([characters length] > 0) - { - character = [characters characterAtIndex: 0]; - } /* Handle SPACE to perform a click */ if ([characters isEqualToString: @" "]) diff --git a/Source/NSColor.m b/Source/NSColor.m index 12415dcbf..b78d54864 100644 --- a/Source/NSColor.m +++ b/Source/NSColor.m @@ -250,7 +250,6 @@ void initSystemColors(void) { NSEnumerator *enumerator; NSString *key; - BOOL changed = NO; // Set up default system colors @@ -269,7 +268,6 @@ void initSystemColors(void) NSCAssert1(color, @"couldn't get default system color %@", key); [systemColors setColor: color forKey: key]; - changed = YES; } if (defaultSystemColors != systemColors) { @@ -1250,10 +1248,13 @@ systemColorWithName(NSString *name) return nil; case NSGrayColorSpaceModel: colorSpaceName = NSDeviceWhiteColorSpace; + break; case NSRGBColorSpaceModel: colorSpaceName = NSDeviceRGBColorSpace; + break; case NSCMYKColorSpaceModel: colorSpaceName = NSDeviceCMYKColorSpace; + break; case NSLABColorSpaceModel: return nil; case NSDeviceNColorSpaceModel: