Commit graph

7374 commits

Author SHA1 Message Date
Richard Frith-Macdonald
ebfe915619 Fixups for stack handling 2018-03-27 07:06:17 +01:00
Richard Frith-Macdonald
82675cd3d9 more lock tracing tweaks 2018-03-26 16:35:17 +01:00
Richard Frith-Macdonald
75bf489aec Allow for waiting on a mutex we already own 2018-03-26 16:05:18 +01:00
Richard Frith-Macdonald
05439fe15d Experimental deadlock detection code 2018-03-26 15:20:48 +01:00
Richard Frith-Macdonald
43673452a5 locking debug/performance tweaks 2018-03-26 15:05:01 +01:00
Richard Frith-Macdonald
2d3039694f Stack tyrace generation optimisation 2018-03-26 14:49:13 +01:00
David Chisnall
9b7e3a8fff Make the NSXMLNode ivar a union.
Having the same ivar exposed as different types in different compilation
units is probably a bad idea in general and will break with the new ObjC
ABI, where we have link-time checks for this.  It would also confuse
reflection and any languages that use reflection for bridging in
exciting ways.
2018-03-20 17:44:16 +00:00
Richard Frith-Macdonald
81102fae85 improve logging of http comms and of deadlocks 2018-03-16 15:11:02 +00:00
Richard Frith-Macdonald
7c1b9b4d15 fix style errors 2018-03-15 14:09:14 +00:00
Richard Frith-Macdonald
4233915c06 Fix boundary issues 2018-02-27 15:06:27 +00:00
Richard Frith-Macdonald
c6e4220409 Add _unicodeString method to return GSUnicodeString subclass instance for tests 2018-02-27 15:00:52 +00:00
Richard Frith-Macdonald
776c0bbcd8 Fix boundary checks searching for unicode strings 2018-02-25 22:30:08 +00:00
Richard Frith-Macdonald
984803d922 Put characterset data on one line to avoid misleading line-count of source 2018-02-11 17:07:25 +00:00
Richard Frith-Macdonald
a6c7492c42 avoid checker warning 2018-02-11 17:03:24 +00:00
Richard Frith-Macdonald
b3ce87ff4f tweaks to keep static checker happy 2018-02-11 12:03:52 +00:00
Richard Frith-Macdonald
f72708742a Avoid compiler warnings 2018-02-11 09:46:07 +00:00
Richard Frith-Macdonald
64732ce825 add comment and cast to void 2018-02-09 08:41:11 +00:00
Richard Frith-Macdonald
96e16ba825 improve comment and compiler hint 2018-02-09 08:37:25 +00:00
Richard Frith-Macdonald
006160ebc3 Merge branch 'master' of ssh://github.com/gnustep/libs-base
Conflicts:
	ChangeLog
2018-02-09 08:33:30 +00:00
Richard Frith-Macdonald
c9a1d39055 Fix potential buffer overrun 2018-02-09 08:32:22 +00:00
fredkiefer
2901390d0f * Source/NSXMLElement.m(-addAttribute:): Correct linear list code
for name spaces. This fixes the last remaining Coverity issue.
2018-02-09 00:07:53 +01:00
Richard Frith-Macdonald
323f9abace cast -scanString: return to void where we don't need to check it. 2018-02-08 06:10:47 +00:00
Richard Frith-Macdonald
ab822a35a3 check and warn about failure to set reuseaddr 2018-02-08 06:08:41 +00:00
Richard Frith-Macdonald
a211bb4aee improve warnings about loss of infomration converting scalar type sizes 2018-02-08 06:05:25 +00:00
Richard Frith-Macdonald
d95203c968 Tweka for overflow of negative number calculation 2018-02-07 15:13:48 +00:00
Richard Frith-Macdonald
c515993d45 avoid checker warning 2018-02-07 13:31:26 +00:00
Richard Frith-Macdonald
6ad1b0e7b2 add security checks on port file 2018-02-07 13:26:38 +00:00
Richard Frith-Macdonald
8420eeed03 keep checker happy 2018-02-07 13:02:08 +00:00
Richard Frith-Macdonald
fec1eafa32 cast to void to avoid warning 2018-02-07 11:40:34 +00:00
Richard Frith-Macdonald
9968a13711 temporarily ifdef out some code thast's not yet used 2018-02-07 11:36:59 +00:00
Richard Frith-Macdonald
93a961304a casts to avoid spurious warnings 2018-02-07 10:53:13 +00:00
Richard Frith-Macdonald
73f3fb78ab raise on character conversion failure 2018-02-07 10:49:02 +00:00
Richard Frith-Macdonald
0d61b42215 remove dead code 2018-02-07 10:45:08 +00:00
Richard Frith-Macdonald
ad87ff5462 raise exception on character conversion failure 2018-02-07 10:38:57 +00:00
Richard Frith-Macdonald
14c2d9402d Remove dead code and improve testing 2018-02-07 09:48:56 +00:00
Richard Frith-Macdonald
3edc201239 Patch by Yavor Doganov to send message id in port messages 2018-02-07 07:02:40 +00:00
Richard Frith-Macdonald
033b921903 improve error checking 2018-02-06 18:05:28 +00:00
Richard Frith-Macdonald
c0d6599def use double type for average 2018-02-06 16:59:49 +00:00
Richard Frith-Macdonald
fcd464f118 Help checker know that we don't need return value 2018-02-06 16:49:07 +00:00
Richard Frith-Macdonald
df6d65accc check step in function before use 2018-02-06 12:51:25 +00:00
Richard Frith-Macdonald
f7c71c695e fix possible nul pointer deref 2018-02-06 12:43:55 +00:00
Richard Frith-Macdonald
3d98433cc7 log failure to turn on keepalive 2018-02-06 12:37:03 +00:00
Richard Frith-Macdonald
0f7a6d58d3 log if we fail to turn on keepalive 2018-02-06 12:34:04 +00:00
Richard Frith-Macdonald
ccd2fb1ac0 Tell compiler we don't care about rreturn value 2018-02-06 12:26:32 +00:00
Richard Frith-Macdonald
1937b36b86 Update assertion macros to support multiple arguments 2018-02-06 09:35:34 +00:00
Richard Frith-Macdonald
8450b94bc8 logic fig for overflow becoming underflow when using negated values 2018-02-05 13:26:41 +00:00
Richard Frith-Macdonald
0d6d01bc00 use cast when masking 64bit value 2018-02-05 13:14:31 +00:00
Richard Frith-Macdonald
96dcac7a74 remove dead code 2018-02-05 13:07:59 +00:00
Richard Frith-Macdonald
a29213a3a2 remove unused code 2018-02-05 13:03:58 +00:00
Richard Frith-Macdonald
7e7d71d63e remove redundant code 2018-02-05 08:14:41 +00:00
Richard Frith-Macdonald
493eb2cf2f remove unused code 2018-02-05 08:11:46 +00:00
Richard Frith-Macdonald
546deb4604 check for failure of dup/dup2 even though it will never happen 2018-02-04 11:36:06 +00:00
Richard Frith-Macdonald
54bf6598ed make sure the hour we read from the time zone file is constrained to 0-23 2018-02-04 11:21:47 +00:00
Richard Frith-Macdonald
b135bc8ae0 suppress warning using cast 2018-02-04 11:17:33 +00:00
Richard Frith-Macdonald
ab670fd27a improive handling of failed character conversion 2018-02-04 11:10:07 +00:00
Richard Frith-Macdonald
113867e9e6 fix for collation alone being set 2018-02-04 10:51:01 +00:00
Richard Frith-Macdonald
5277bf7043 Keep checker happy by avoiding possible null pointer deref 2018-02-04 10:35:15 +00:00
Richard Frith-Macdonald
890eaa9d32 don't copy address info ifg getpeername fails 2018-02-04 10:10:57 +00:00
Richard Frith-Macdonald
4f50f358c3 more fixups for unicode and to avoid warnings 2018-02-04 08:38:20 +00:00
Richard Frith-Macdonald
78087d0aa4 tweak to keep checker happy 2018-02-04 08:28:51 +00:00
Richard Frith-Macdonald
f1b1c1c754 fix bad type in assignment 2018-02-03 16:03:32 +00:00
Richard Frith-Macdonald
41fd87ce35 potential resource leak fix 2018-02-03 15:57:04 +00:00
Richard Frith-Macdonald
8a66507f29 changer memcpy to memmove 2018-02-03 10:11:30 +00:00
fredkiefer
e69450400a * Source/GSFormat.m: Call va_end with the correct parameter.
* Source/NSObject+NSComparisonMethods.m: Add missing return.
* Source/GSString.m (-replaceCharactersInRange:withString:,
-initWithBytesNoCopy:...freeWhenDone:): Remove dead code.
* Source/NSDistantObject.m (-initWithCoder:): Remove dead code.
* Source/NSPredicate.m (_eval_avg:): Don't devide by zero.
Fix issues found by Coverity.
2018-02-01 22:31:15 +01:00
Richard Frith-Macdonald
dcd3b8c5a9 fix possible error with negative time zone offset. 2018-01-31 14:31:37 +00:00
Richard Frith-Macdonald
c30166c612 add missing va_end 2018-01-31 14:28:44 +00:00
Richard Frith-Macdonald
9d21ee5671 check for null pointer 2018-01-31 14:24:46 +00:00
Richard Frith-Macdonald
9a8c3486ff fix bad copy/paste 2018-01-31 14:17:50 +00:00
Richard Frith-Macdonald
5a2506dca9 Remove unused line 2018-01-31 14:15:32 +00:00
Richard Frith-Macdonald
f718aa30c9 Make it clear that we are doing a standard binary search and allow for changes
to character composition/decomposition in future.
2018-01-31 07:42:59 +00:00
Richard Frith-Macdonald
c31c6a87b8 fix uninitialised variable 2018-01-30 15:01:01 +00:00
Richard Frith-Macdonald
92f961dbb6 remove redundant close 2018-01-30 14:40:12 +00:00
Richard Frith-Macdonald
ee8bb1fbeb Fix possible deref of null pointer 2018-01-30 14:34:27 +00:00
Richard Frith-Macdonald
56aaa72d3d be more careful about closing iconv handle on errors 2018-01-30 14:03:01 +00:00
Richard Frith-Macdonald
06ff76d882 fix use after free 2018-01-30 07:57:36 +00:00
Richard Frith-Macdonald
22d7d2428a warn about corrupt archive 2018-01-30 07:54:23 +00:00
Richard Frith-Macdonald
65ac0eca15 fix potential unterminated buffer and leak on failure 2018-01-30 07:43:58 +00:00
Richard Frith-Macdonald
b76089f0cd fix potential unterminated string 2018-01-30 07:39:25 +00:00
Richard Frith-Macdonald
86af4da784 fix possible resource leak on conversion failure 2018-01-30 07:38:08 +00:00
Richard Frith-Macdonald
3884a82c7a comment on why descriptor is NOT leaked 2018-01-30 07:36:53 +00:00
Richard Frith-Macdonald
ba7c5086d1 gix handle leak on write failure 2018-01-30 07:26:05 +00:00
Richard Frith-Macdonald
6b1f8f7962 fix very minor descriptor leak (one descriptor in subtask) 2018-01-30 07:21:39 +00:00
Richard Frith-Macdonald
3281c0f6b6 fix potentially unterminated buffer 2018-01-30 07:12:32 +00:00
Richard Frith-Macdonald
7045f84acc OSX compatibility fixes for zero width space character and initialising an NSURL
with bad strings.
2018-01-26 12:53:47 +00:00
Richard Frith-Macdonald
d8e7607582 Tweaks to let comp[iler know that methods to raise an exception don't return. 2018-01-25 10:05:52 +00:00
Richard Frith-Macdonald
cc97172bdd check for nul pointer when destroying zone 2018-01-23 16:34:26 +00:00
Richard Frith-Macdonald
746f2a2a1a ndentation fixups 2018-01-23 16:17:57 +00:00
Richard Frith-Macdonald
07ba3ec932 add comments 2018-01-23 14:07:46 +00:00
Richard Frith-Macdonald
c7ba537c75 fix issues picked up by automated checker 2018-01-23 11:32:36 +00:00
Richard Frith-Macdonald
5f7e53c175 Re-enable optimisation on NSConnection/NSInvocation 2018-01-19 08:44:50 +00:00
Richard Frith-Macdonald
c7fc9c4b65 notify immediately if in correct thread 2018-01-15 11:57:23 +00:00
Richard Frith-Macdonald
28048a5947 Don't try to notify about task termination on the thread that started the task
if it has already finished executing.
2018-01-15 11:42:04 +00:00
Richard Frith-Macdonald
7fd95c877f Improve message in exception when we perform on a finished thread 2018-01-15 10:08:13 +00:00
Richard Frith-Macdonald
925f1dd5e1 Add Yavor Doganov's patches for tests and config. Add fixes for GSXML
validation of xml documents
2018-01-14 12:30:13 +00:00
Richard Frith-Macdonald
31257785d6 External entity resolution turned off by default for security 2018-01-11 16:39:21 +00:00
Richard Frith-Macdonald
93389bb357 Minore xml parsing fixes 2018-01-11 13:50:39 +00:00
Richard Frith-Macdonald
4efa322ca2 Fix bug in object allocation when ARC is available 2018-01-04 09:08:36 +00:00
Richard Frith-Macdonald
dae9b8973e OSX compatibility tweaks based on running testcases on 10.13.2 (high sierra). 2018-01-03 15:42:09 +00:00
Richard Frith-Macdonald
6150b3fd62 Fix for bug #51592 2018-01-02 12:48:18 +00:00
Richard Frith-Macdonald
6ec34b4df4 Merge branch 'master' of ssh://github.com/gnustep/libs-base
Conflicts:
	ChangeLog
2017-12-21 13:56:34 +00:00