gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-04-23 00:41:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

add security checks on port file

Browse source
This commit is contained in:
Richard Frith-Macdonald 2018-02-07 13:26:38 +00:00
parent 8420eeed03
commit 6ad1b0e7b2
2 changed files with 32 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ChangeLog
View file

@ -6,6 +6,7 @@
* Source/GSString.m: raise exception on character conversion failure
* Source/NSNumberFormatter.m: remove dead code
* Source/NSPropertyList.m: avoid warnings using cast to void
* Source/NSMessagePortNameServer.m: added security checks
* Tools/AGSHtml.m: remove useless test
2018-02-07 Yavor Doganov <yavor@gnu.org>

34
Source/NSMessagePortNameServer.m
View file

@ -323,6 +323,7 @@ static NSMapTable *portToNamesMap;
{
FILE *f;
char socket_path[512];
int len;
int pid;
struct stat sb;
@ -331,16 +332,43 @@ static NSMapTable *portToNamesMap;
f = fopen([path fileSystemRepresentation], "rt");
if (!f)
{
NSDebugLLog(@"NSMessagePort", @"not live, couldn't open file (%m)");
NSDebugLLog(@"NSMessagePort", @"not live, couldn't open %@ (%m)", path);
return NO;
}
if (fstat(fileno(f), &sb) < 0)
{
NSDebugLLog(@"NSMessagePort", @"not live, couldn't stat %@ (%m)", path);
fclose(f);
return NO;
}
if (sb.st_uid != getuid() && sb.st_uid != geteuid())
{
NSDebugLLog(@"NSMessagePort", @"not live, %@ not owned by us", path);
fclose(f);
return NO;
}
if ((sb.st_mode & 0777) != 0600)
{
NSDebugLLog(@"NSMessagePort", @"not live, %@ not correct access", path);
fclose(f);
return NO;
}
fgets(socket_path, sizeof(socket_path), f);
if (strlen(socket_path) > 0) socket_path[strlen(socket_path) - 1] = 0;
len = strlen(socket_path);
if (len == 0 || socket_path[len - 1] != '\n')
{
fclose(f);
NSDebugLLog(@"NSMessagePort", @"not live, couldn't get file in %@", path);
return NO;
}
socket_path[len - 1] = '\0';
if (fscanf(f, "%i", &pid) != 1)
{
NSDebugLLog(@"NSMessagePort", @"not live, couldn'read PID");
fclose(f);
NSDebugLLog(@"NSMessagePort", @"not live, couldn't read PID in %@", path);
return NO;
}