Merge branch 'fix-nsurlcomponents' of github.com:gnustep/libs-base into fix-nsurlcomponents

This commit is contained in:
Gregory John Casamento 2020-04-04 12:34:21 -04:00
commit bc0be86d46

View file

@ -2629,23 +2629,39 @@ GS_PRIVATE_INTERNAL(NSURLComponents)
- (NSString *) query - (NSString *) query
{ {
NSString *query = @""; NSString *result = nil;
NSEnumerator *en = [internal->_queryItems objectEnumerator];
NSURLQueryItem *item = nil;
if (internal->_queryItems != nil)
{
NSMutableString *query = nil;
NSURLQueryItem *item = nil;
NSEnumerator *en;
en = [internal->_queryItems objectEnumerator];
while ((item = (NSURLQueryItem *)[en nextObject]) != nil) while ((item = (NSURLQueryItem *)[en nextObject]) != nil)
{ {
NSString *name = [item name]; NSString *name = [item name];
NSString *value = [item value]; NSString *value = [item value];
NSString *itemString = [NSString stringWithFormat: @"%@=%@",name,value];
if ([query length] > 0) if (nil == query)
{ {
query = [query stringByAppendingString: @"&"]; query = [[NSMutableString alloc] initWithCapacity: 1000];
} }
query = [query stringByAppendingString: itemString]; else
{
[query appendString: @"&"];
} }
return query; [query appendString: name];
if (value != nil)
{
[query appendString: @"="];
[query appendString: value];
}
}
result = AUTORELEASE([query copy]);
RELEASE(query);
}
return result;
} }
- (void) _setQuery: (NSString *)query fromPercentEncodedString: (BOOL)encoded - (void) _setQuery: (NSString *)query fromPercentEncodedString: (BOOL)encoded
@ -2848,7 +2864,7 @@ GS_PRIVATE_INTERNAL(NSURLComponents)
name = [name _stringByAddingPercentEscapesForQuery]; name = [name _stringByAddingPercentEscapesForQuery];
value = [value _stringByAddingPercentEscapesForQuery]; value = [value _stringByAddingPercentEscapesForQuery];
ni = [NSURLQueryItem queryItemWithName: name ni = [NSURLQueryItem queryItemWithName: name
value: name]; value: value];
[items addObject: ni]; [items addObject: ni];
} }
result = AUTORELEASE([items copy]); result = AUTORELEASE([items copy]);