gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-04-22 16:33:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix error in refactoring query (storing name twice rather than name/value)

Browse source
This commit is contained in:
Richard Frith-Macdonald 2020-04-04 17:32:27 +01:00
parent cf13a7c21b
commit ac45beb4c1
1 changed files with 30 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
Source/NSURL.m
View file

@ -2629,23 +2629,39 @@ GS_PRIVATE_INTERNAL(NSURLComponents)
- (NSString *) query
{
NSString *query = @"";
NSEnumerator *en = [internal->_queryItems objectEnumerator];
NSURLQueryItem *item = nil;
NSString *result = nil;
while ((item = (NSURLQueryItem *)[en nextObject]) != nil)
if (internal->_queryItems != nil)
{
NSString *name = [item name];
NSString *value = [item value];
NSString *itemString = [NSString stringWithFormat: @"%@=%@",name,value];
NSMutableString *query = nil;
NSURLQueryItem *item = nil;
NSEnumerator *en;
if ([query length] > 0)
{
query = [query stringByAppendingString: @"&"];
}
query = [query stringByAppendingString: itemString];
en = [internal->_queryItems objectEnumerator];
while ((item = (NSURLQueryItem *)[en nextObject]) != nil)
{
NSString *name = [item name];
NSString *value = [item value];
if (nil == query)
{
query = [[NSMutableString alloc] initWithCapacity: 1000];
}
else
{
[query appendString: @"&"];
}
[query appendString: name];
if (value != nil)
{
[query appendString: @"="];
[query appendString: value];
}
}
result = AUTORELEASE([query copy]);
RELEASE(query);
}
return query;
return result;
}
- (void) _setQuery: (NSString *)query fromPercentEncodedString: (BOOL)encoded
@ -2848,7 +2864,7 @@ GS_PRIVATE_INTERNAL(NSURLComponents)
name = [name _stringByAddingPercentEscapesForQuery];
value = [value _stringByAddingPercentEscapesForQuery];
ni = [NSURLQueryItem queryItemWithName: name
value: name];
value: value];
[items addObject: ni];
}
result = AUTORELEASE([items copy]);