raze/polymer/eduke32/source
helixhorned 1009e0f2ec Remove many redundant (int16_t) casts and one now incorrect one.
The redundant ones are in code like this: s->cstat = (int16_t)32768;
Because the value is eventually converted to the type of "s->cstat", any
casts to integral types having at least as many bits are no-ops, signedness
being irrelevant due to (probably any two's complement arch targeting
compiler's) bit-pattern preserving semantics of these conversions.

The now incorrect one is: if (lotag == (int16_t) 65535),
"int32_t lotag" being read from a wall or sprite struct directly earlier.
Now, with these members being unsigned, and (int16_t)65535 equalling -1,
the check always fails.  The correction fixes normal switches having such
a lotag ending the level immediately.

In short: integer casts before assignments are unnecessary, those in reads
highly relevant!

git-svn-id: https://svn.eduke32.com/eduke32@3211 1a8010ca-5511-0410-912e-c29ae57300e0
2012-11-18 19:01:34 +00:00
..
enet Split r3159..r3161, part 7: code touching networking. 2012-11-15 14:28:14 +00:00
jaudiolib Split r3159..r3161, part 11: Add explicit casts, pointer types. 2012-11-15 14:28:36 +00:00
jmact Fix bound keys' commands being truncated in settings.cfg, control* cleanup. 2012-11-18 15:44:18 +00:00
lunatic Lunatic: update BUILD types with signed->unsigned changes of *stat. 2012-11-17 19:46:18 +00:00
misc Updated synthesis script, moved some non-essential files around, updated license headers on all non-BUILDLIC files, added memory cache on top of texcache to improve load times, moved some duplicated keyboard handling stuff from winlayer/sdlayer to baselayer, fixed keypad / in Mapster32 tile selector, fixed bug where p->rotscrnang and p->look_ang never reset to 0, added support for reloading maphack based polymer lights after mode changes/savegame loads, other minor changes 2010-05-25 10:56:00 +00:00
util Tools updates: 2012-11-15 06:42:37 +00:00
_functio.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
_midi.h Fix JonoF's email address. 2012-03-12 04:47:04 +00:00
_rts.h Updated synthesis script, moved some non-essential files around, updated license headers on all non-BUILDLIC files, added memory cache on top of texcache to improve load times, moved some duplicated keyboard handling stuff from winlayer/sdlayer to baselayer, fixed keypad / in Mapster32 tile selector, fixed bug where p->rotscrnang and p->look_ang never reset to 0, added support for reloading maphack based polymer lights after mode changes/savegame loads, other minor changes 2010-05-25 10:56:00 +00:00
actors.c Remove many redundant (int16_t) casts and one now incorrect one. 2012-11-18 19:01:34 +00:00
actors.h Split r3159..r3161, part 4: Tweaks of tiledata_t's "cacherange" member. 2012-11-15 14:28:00 +00:00
actors_inline.c Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
actors_inline.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
anim.c Move G_HandleAsync() into game.h as 'static inline' and use everywhere else. 2012-09-05 17:25:34 +00:00
anim.h Possibility of specifying sounds for a VPX anim-replacement via DEF. 2012-01-10 23:43:54 +00:00
animvpx.c Split r3159..r3161, part 10: add explicit casts to *alloc return values. 2012-11-15 14:28:29 +00:00
animvpx.h Make ivfrate build standalone, Makefile tweaks. 2012-11-08 21:54:17 +00:00
astub.c Mapster32: fix cycling picnum in 3D mode. 2012-11-17 19:46:33 +00:00
common.c Split r3159..r3161, part 10: add explicit casts to *alloc return values. 2012-11-15 14:28:29 +00:00
common_game.h Constify various char* vars, parameters, etc. for more -Wwrite-strings cleanness 2012-07-01 22:11:33 +00:00
config.c Fix bound keys' commands being truncated in settings.cfg, control* cleanup. 2012-11-18 15:44:18 +00:00
config.h Fix warning from r3128 2012-11-08 22:09:00 +00:00
demo.c demo.c: time G_DoMoveThings() using a double instead of an int32_t. 2012-11-15 14:28:53 +00:00
demo.h In -d command line arg, allow specifying demo number in addition to file name. 2012-10-01 17:52:40 +00:00
duke3d.h Bump BYTEVERSION. 2012-11-15 14:28:50 +00:00
function.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
game.c Remove many redundant (int16_t) casts and one now incorrect one. 2012-11-18 19:01:34 +00:00
game.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
game_inline.c Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
game_inline.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
gamedef.c Add "ulotag" and "uhitag" to get/setactor/wall/sector, which exposes the tags unsigned, without the typecast to int16_t. This might be useful to someone. 2012-11-16 00:54:04 +00:00
gamedef.h Add "ulotag" and "uhitag" to get/setactor/wall/sector, which exposes the tags unsigned, without the typecast to int16_t. This might be useful to someone. 2012-11-16 00:54:04 +00:00
gamedefs.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
gameexec.c Further minor MACT cleanups 2012-11-17 16:48:11 +00:00
gameexec.h Split r3159..r3161, part 5: "nowarn" wrapping of printing functions. 2012-11-15 14:28:04 +00:00
gamestructures.c Add "ulotag" and "uhitag" to get/setactor/wall/sector, which exposes the tags unsigned, without the typecast to int16_t. This might be useful to someone. 2012-11-16 00:54:04 +00:00
gamevars.c Split r3159..r3161, part 10: add explicit casts to *alloc return values. 2012-11-15 14:28:29 +00:00
gamevars.h Fix gamearrays on 64-bit platforms. 2012-05-25 15:23:48 +00:00
global.c Tweak r3116. 2012-11-05 03:48:03 +00:00
global.h Fix demo playback with diff application enabled. 2012-11-11 17:57:06 +00:00
GNU.TXT Importing source for great justice 2006-04-13 20:47:06 +00:00
grpscan.c Split r3159..r3161, part 12: Add explicit casts, non-pointer types. 2012-11-15 14:28:41 +00:00
grpscan.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
input.c Further minor MACT cleanups 2012-11-17 16:48:11 +00:00
input.h Massive menu input control revamp/cleanup/factor. (added: input.[ch]) 2012-06-03 16:11:22 +00:00
keys.h Updated synthesis script, moved some non-essential files around, updated license headers on all non-BUILDLIC files, added memory cache on top of texcache to improve load times, moved some duplicated keyboard handling stuff from winlayer/sdlayer to baselayer, fixed keypad / in Mapster32 tile selector, fixed bug where p->rotscrnang and p->look_ang never reset to 0, added support for reloading maphack based polymer lights after mode changes/savegame loads, other minor changes 2010-05-25 10:56:00 +00:00
m32def.c Split r3159..r3161, part 10: add explicit casts to *alloc return values. 2012-11-15 14:28:29 +00:00
m32def.h New M32Script command "getspritelinktype" <spritenum> <<linktypevar>>. 2012-04-05 19:49:12 +00:00
m32exec.c Split r3159..r3161, part 11: Add explicit casts, pointer types. 2012-11-15 14:28:36 +00:00
m32structures.c Addresses posts #180 and #181 of the TROR thread. Specifically, 2011-07-04 21:20:59 +00:00
m32vars.c Split r3159..r3161, part 10: add explicit casts to *alloc return values. 2012-11-15 14:28:29 +00:00
macros.h Accumulated trivia, mostly "the usual". 2012-05-05 22:23:44 +00:00
mapster32.h Split r3159..r3161, part 14: The rest. 2012-11-15 14:28:47 +00:00
mdump.cpp Superficial text changes: 2012-03-26 05:05:57 +00:00
mdump.h 1. Removed unneeded the svn:executable proprties. These files aren't actually executable. 2008-07-12 14:09:52 +00:00
menus.c Fix bound keys' commands being truncated in settings.cfg, control* cleanup. 2012-11-18 15:44:18 +00:00
menus.h Minor menu cleanups, only half-finished (if that). 2012-10-14 22:16:07 +00:00
midi.c Split r3159..r3161, part 10: add explicit casts to *alloc return values. 2012-11-15 14:28:29 +00:00
midi.h Fix JonoF's email address. 2012-03-12 04:47:04 +00:00
mpu401.c Global thermonuclear code rape 2010-08-02 08:13:51 +00:00
mpu401.h Fix JonoF's email address. 2012-03-12 04:47:04 +00:00
music.c This should fix the "assignment discards 'const' qualifier" warning in music.c. 2012-07-09 19:00:23 +00:00
names.h add two tile labels which Todd forgot to move from GAME.CON to DEFS.CON and therefore did not make it to names.h 2011-08-20 23:27:46 +00:00
namesdyn.c Constify various char* vars, parameters, etc. for more -Wwrite-strings cleanness 2012-07-01 22:11:33 +00:00
namesdyn.h Patch adding Wii support by tueidj, part 11: miscellaneous changes 2012-05-01 12:41:13 +00:00
net.c Remove xdelta3 since it doesn't fit in with our current networking plans anymore 2012-11-16 15:40:28 +00:00
net.h Split r3159..r3161, part 7: code touching networking. 2012-11-15 14:28:14 +00:00
old.diff Tweakery in various places. 2011-03-17 23:37:38 +00:00
osdcmds.c Fix bound keys' commands being truncated in settings.cfg, control* cleanup. 2012-11-18 15:44:18 +00:00
osdcmds.h Fix bound keys' commands being truncated in settings.cfg, control* cleanup. 2012-11-18 15:44:18 +00:00
osdfuncs.c Clean up picanm[] by making its elements values of struct type picanm_t. 2012-11-17 19:46:28 +00:00
osdfuncs.h Updated synthesis script, moved some non-essential files around, updated license headers on all non-BUILDLIC files, added memory cache on top of texcache to improve load times, moved some duplicated keyboard handling stuff from winlayer/sdlayer to baselayer, fixed keypad / in Mapster32 tile selector, fixed bug where p->rotscrnang and p->look_ang never reset to 0, added support for reloading maphack based polymer lights after mode changes/savegame loads, other minor changes 2010-05-25 10:56:00 +00:00
player.c Couple of tweaks in player.c to match all ProjectileData[...].xxx with a regexp. 2012-11-11 17:57:09 +00:00
player.h Fix viewing through moving cameras. 2012-11-11 17:56:57 +00:00
premap.c A couple of meaning-preserving rewrites of picanm[]-touching code. 2012-11-17 19:46:37 +00:00
premap.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
quotes.h Addition of 3 events: 2012-05-14 18:12:27 +00:00
rev.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
rts.c Split r3159..r3161, part 10: add explicit casts to *alloc return values. 2012-11-15 14:28:29 +00:00
rts.h Possibly fix another weird crash 2010-08-07 23:14:23 +00:00
savegame.c Split r3159..r3161, part 14: The rest. 2012-11-15 14:28:47 +00:00
savegame.h Rewrite old-version-savegame signaling in a cleaner fashion. 2012-11-13 10:50:06 +00:00
sdlmusic.c Fix C90 compliance warning in sdlmusic 2012-11-08 22:09:30 +00:00
sector.c Remove many redundant (int16_t) casts and one now incorrect one. 2012-11-18 19:01:34 +00:00
sector.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
sector_inline.c Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
sector_inline.h Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
soundefs.h update soundefs.h to match the final v1.5 DEFS.CON 2011-08-20 23:27:58 +00:00
sounds.c Work-in-progress adjustment to the C code to compile under C++. It builds for me without errors using Win32 MinGW-GCC, but it still generates warning soup. No guarantees about MSVC or anything using SDL. Enable C++ by building with CPLUSPLUS=1. C remains the default and should compile with no change in setup. 2012-11-05 02:49:08 +00:00
sounds.h The other half of the previous commit. 2012-10-08 07:07:59 +00:00
sounds_mapster32.c Rename SOUNDOWNER's (used in sound_t) member .i to .ow for easier grepping. 2012-03-10 21:22:44 +00:00
sounds_mapster32.h Rename SOUNDOWNER's (used in sound_t) member .i to .ow for easier grepping. 2012-03-10 21:22:44 +00:00
standard.h Fix JonoF's email address. 2012-03-12 04:47:04 +00:00
startgtk.game.c Split r3159..r3161, part 3: MSVC, nedmalloc, *layer, startup windows. 2012-11-15 14:27:57 +00:00
startwin.game.c The handling for grp, con, and def filenames has been massively cleaned up and factored into common.c. A new header, common_game.h, was created because common.h was placed in build/include (see r2542) and we need a common header for things that strictly should not be in the engine. RTS file names were also improved but some of the patterned changes were already made in r2420, and they were not factored because they are strictly part of the game, not the editor. 2012-06-03 16:09:33 +00:00
startwin.game.h Updated synthesis script, moved some non-essential files around, updated license headers on all non-BUILDLIC files, added memory cache on top of texcache to improve load times, moved some duplicated keyboard handling stuff from winlayer/sdlayer to baselayer, fixed keypad / in Mapster32 tile selector, fixed bug where p->rotscrnang and p->look_ang never reset to 0, added support for reloading maphack based polymer lights after mode changes/savegame loads, other minor changes 2010-05-25 10:56:00 +00:00
winbits.c Define Batoi/Batol to strtol(...) in compat.h and use these when necessary. 2012-02-20 21:17:39 +00:00