mirror of
https://github.com/ZDoom/qzdoom.git
synced 2024-11-13 07:57:58 +00:00
- fixed: DecoHandleRuntimeState must check all parent classes when trying to determine if the target is a valid state. It should also ensure that both the calling and target state belong to the same actor. Although unlikely it cannot be entirely ruled out that a bogus index randomly points to a seemingly valid state elsewhere.
This commit is contained in:
parent
594b344be9
commit
15cbf4bae6
1 changed files with 20 additions and 1 deletions
|
@ -4956,6 +4956,25 @@ FxExpression *FxRuntimeStateIndex::Resolve(FCompileContext &ctx)
|
||||||
return this;
|
return this;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static bool VerifyJumpTarget(AActor *stateowner, FStateParamInfo *stateinfo, int index)
|
||||||
|
{
|
||||||
|
PClassActor *cls = stateowner->GetClass();
|
||||||
|
|
||||||
|
while (cls != RUNTIME_CLASS(AActor))
|
||||||
|
{
|
||||||
|
// both calling and target state need to belong to the same class.
|
||||||
|
if (cls->OwnsState(stateinfo->mCallingState))
|
||||||
|
{
|
||||||
|
return cls->OwnsState(stateinfo->mCallingState + index);
|
||||||
|
}
|
||||||
|
|
||||||
|
// We can safely assume the ParentClass is of type PClassActor
|
||||||
|
// since we stop when we see the Actor base class.
|
||||||
|
cls = static_cast<PClassActor *>(cls->ParentClass);
|
||||||
|
}
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
static int DecoHandleRuntimeState(VMFrameStack *stack, VMValue *param, int numparam, VMReturn *ret, int numret)
|
static int DecoHandleRuntimeState(VMFrameStack *stack, VMValue *param, int numparam, VMReturn *ret, int numret)
|
||||||
{
|
{
|
||||||
PARAM_PROLOGUE;
|
PARAM_PROLOGUE;
|
||||||
|
@ -4963,7 +4982,7 @@ static int DecoHandleRuntimeState(VMFrameStack *stack, VMValue *param, int numpa
|
||||||
PARAM_POINTER(stateinfo, FStateParamInfo);
|
PARAM_POINTER(stateinfo, FStateParamInfo);
|
||||||
PARAM_INT(index);
|
PARAM_INT(index);
|
||||||
|
|
||||||
if (index == 0 || !stateowner->GetClass()->OwnsState(stateinfo->mCallingState + index))
|
if (index == 0 || !VerifyJumpTarget(stateowner, stateinfo, index))
|
||||||
{
|
{
|
||||||
// Null is returned if the location was invalid which means that no jump will be performed
|
// Null is returned if the location was invalid which means that no jump will be performed
|
||||||
// if used as return value
|
// if used as return value
|
||||||
|
|
Loading…
Reference in a new issue