- fixed: TVector3::Pitch() got the sign inverted.

This caused bad calculations with CMF_OFFSETPITCH. Note that to compensate for the fix, the SphericalCoords function had to have its own inversion of the value removed so that it calculates the same result as before.

src/g_level.cpp

@@ -2143,7 +2143,7 @@ DEFINE_ACTION_FUNCTION(FLevelLocals, SphericalCoords)
 
 	ACTION_RETURN_VEC3(DVector3(
 		deltaangle(vecTo.Angle(), viewYaw).Degrees,
-		deltaangle(-vecTo.Pitch(), viewPitch).Degrees,
+		deltaangle(vecTo.Pitch(), viewPitch).Degrees,
 		vecTo.Length()
 	));
 }

src/vectors.h

@@ -1417,7 +1417,7 @@ TAngle<T> TVector3<T>::Angle() const
 template<class T>
 TAngle<T> TVector3<T>::Pitch() const
 {
-	return VecToAngle(TVector2<T>(X, Y).Length(), Z);
+	return -VecToAngle(TVector2<T>(X, Y).Length(), Z);
 }
 
 // Much of this is copied from TVector3. Is all that functionality really appropriate?