zdoom/gzdoom
0
0
Fork 0
mirror of https://github.com/ZDoom/gzdoom.git synced 2024-11-26 22:11:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

- fixed: SafeCommand did not work anymore because it failed the abuse prevention check for DoCommand.

Browse source
This commit is contained in:
Christoph Oelckers 2017-03-28 22:34:12 +02:00
parent 224219dd66
commit d5772ff895
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
wadsrc/static/zscript/menu/optionmenuitems.txt
View file

@ -132,11 +132,14 @@ class OptionMenuItemCommand : OptionMenuItemSubmenu
override bool Activate() override bool Activate()
{ {
// This needs to perform a few checks to prevent abuse by malicious modders. // This needs to perform a few checks to prevent abuse by malicious modders.
if (GetClass() != "OptionMenuItemSafeCommand")
{
let m = OptionMenu(Menu.GetCurrentMenu()); let m = OptionMenu(Menu.GetCurrentMenu());
// don't execute if no menu is active // don't execute if no menu is active
if (m == null) return false; if (m == null) return false;
// don't execute if this item cannot be found in the current menu. // don't execute if this item cannot be found in the current menu.
if (m.GetItem(mAction) != self) return false; if (m.GetItem(mAction) != self) return false;
}
Menu.MenuSound("menu/choose"); Menu.MenuSound("menu/choose");
DoCommand(mAction); DoCommand(mAction);
return true; return true;