- use a unique_ptr for the GL debug object.

This doesn’t get shared and the containing class doesn’t need to be copied so this is sufficient.
This commit is contained in:
Christoph Oelckers 2022-06-07 00:11:56 +02:00
parent 989dcfcf1c
commit c7798d5503
3 changed files with 2 additions and 5 deletions

View file

@ -175,7 +175,7 @@ void OpenGLFrameBuffer::InitializeState()
GLRenderer->Initialize(GetWidth(), GetHeight()); GLRenderer->Initialize(GetWidth(), GetHeight());
static_cast<GLDataBuffer*>(mLights->GetBuffer())->BindBase(); static_cast<GLDataBuffer*>(mLights->GetBuffer())->BindBase();
mDebug = std::make_shared<FGLDebug>(); mDebug = std::make_unique<FGLDebug>();
mDebug->Update(); mDebug->Update();
} }

View file

@ -20,7 +20,6 @@ class OpenGLFrameBuffer : public SystemGLFrameBuffer
public: public:
explicit OpenGLFrameBuffer() {}
OpenGLFrameBuffer(void *hMonitor, bool fullscreen) ; OpenGLFrameBuffer(void *hMonitor, bool fullscreen) ;
~OpenGLFrameBuffer(); ~OpenGLFrameBuffer();
bool CompileNextShader() override; bool CompileNextShader() override;
@ -66,7 +65,7 @@ public:
void PostProcessScene(bool swscene, int fixedcm, float flash, const std::function<void()> &afterBloomDrawEndScene2D) override; void PostProcessScene(bool swscene, int fixedcm, float flash, const std::function<void()> &afterBloomDrawEndScene2D) override;
bool HWGammaActive = false; // Are we using hardware or software gamma? bool HWGammaActive = false; // Are we using hardware or software gamma?
std::shared_ptr<FGLDebug> mDebug; // Debug API std::unique_ptr<FGLDebug> mDebug; // Debug API
FTexture *WipeStartScreen() override; FTexture *WipeStartScreen() override;
FTexture *WipeEndScreen() override; FTexture *WipeEndScreen() override;

View file

@ -10,7 +10,6 @@ namespace OpenGLESRenderer
{ {
class FHardwareTexture; class FHardwareTexture;
class FGLDebug;
class OpenGLFrameBuffer : public SystemGLFrameBuffer class OpenGLFrameBuffer : public SystemGLFrameBuffer
{ {
@ -61,7 +60,6 @@ public:
void PostProcessScene(bool swscene, int fixedcm, float flash, const std::function<void()> &afterBloomDrawEndScene2D) override; void PostProcessScene(bool swscene, int fixedcm, float flash, const std::function<void()> &afterBloomDrawEndScene2D) override;
bool HWGammaActive = false; // Are we using hardware or software gamma? bool HWGammaActive = false; // Are we using hardware or software gamma?
std::shared_ptr<FGLDebug> mDebug; // Debug API
FTexture *WipeStartScreen() override; FTexture *WipeStartScreen() override;
FTexture *WipeEndScreen() override; FTexture *WipeEndScreen() override;