- uncouple the file system from the engine's Printf function.

This is needed to use it in non GZDoom based projects.
This commit is contained in:
Christoph Oelckers 2023-08-17 21:28:35 +02:00
parent 9b790d23a8
commit 7fee89d1f5
23 changed files with 272 additions and 245 deletions

View file

@ -197,7 +197,7 @@ FileReader FSF2Reader::OpenFile(const char *name)
FZipPatReader::FZipPatReader(const char *filename) FZipPatReader::FZipPatReader(const char *filename)
{ {
mAllowAbsolutePaths = true; mAllowAbsolutePaths = true;
resf = FResourceFile::OpenResourceFile(filename, true); resf = FResourceFile::OpenResourceFile(filename);
} }
FZipPatReader::~FZipPatReader() FZipPatReader::~FZipPatReader()

View file

@ -39,7 +39,6 @@
#include "resourcefile.h" #include "resourcefile.h"
#include "cmdlib.h" #include "cmdlib.h"
#include "printf.h"
@ -189,7 +188,7 @@ class F7ZFile : public FResourceFile
public: public:
F7ZFile(const char * filename, FileReader &filer); F7ZFile(const char * filename, FileReader &filer);
bool Open(bool quiet, LumpFilterInfo* filter); bool Open(LumpFilterInfo* filter, FileSystemMessageFunc Printf);
virtual ~F7ZFile(); virtual ~F7ZFile();
virtual FResourceLump *GetLump(int no) { return ((unsigned)no < NumLumps)? &Lumps[no] : NULL; } virtual FResourceLump *GetLump(int no) { return ((unsigned)no < NumLumps)? &Lumps[no] : NULL; }
}; };
@ -216,7 +215,7 @@ F7ZFile::F7ZFile(const char * filename, FileReader &filer)
// //
//========================================================================== //==========================================================================
bool F7ZFile::Open(bool quiet, LumpFilterInfo *filter) bool F7ZFile::Open(LumpFilterInfo *filter, FileSystemMessageFunc Printf)
{ {
Archive = new C7zArchive(Reader); Archive = new C7zArchive(Reader);
int skipped = 0; int skipped = 0;
@ -227,25 +226,21 @@ bool F7ZFile::Open(bool quiet, LumpFilterInfo *filter)
{ {
delete Archive; delete Archive;
Archive = NULL; Archive = NULL;
if (!quiet)
{
Printf("\n" TEXTCOLOR_RED "%s: ", FileName.GetChars());
if (res == SZ_ERROR_UNSUPPORTED) if (res == SZ_ERROR_UNSUPPORTED)
{ {
Printf("Decoder does not support this archive\n"); Printf(FSMessageLevel::Error, "%s: Decoder does not support this archive\n", FileName.GetChars());
} }
else if (res == SZ_ERROR_MEM) else if (res == SZ_ERROR_MEM)
{ {
Printf("Cannot allocate memory\n"); Printf(FSMessageLevel::Error, "Cannot allocate memory\n");
} }
else if (res == SZ_ERROR_CRC) else if (res == SZ_ERROR_CRC)
{ {
Printf("CRC error\n"); Printf(FSMessageLevel::Error, "CRC error\n");
} }
else else
{ {
Printf("error #%d\n", res); Printf(FSMessageLevel::Error, "error #%d\n", res);
}
} }
return false; return false;
} }
@ -308,7 +303,7 @@ bool F7ZFile::Open(bool quiet, LumpFilterInfo *filter)
if (SZ_OK != Archive->Extract(Lumps[0].Position, &temp[0])) if (SZ_OK != Archive->Extract(Lumps[0].Position, &temp[0]))
{ {
if (!quiet) Printf("\n%s: unsupported 7z/LZMA file!\n", FileName.GetChars()); Printf(FSMessageLevel::Error, "%s: unsupported 7z/LZMA file!\n", FileName.GetChars());
return false; return false;
} }
} }
@ -356,7 +351,7 @@ int F7ZLump::FillCache()
// //
//========================================================================== //==========================================================================
FResourceFile *Check7Z(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter) FResourceFile *Check7Z(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
char head[k7zSignatureSize]; char head[k7zSignatureSize];
@ -368,7 +363,7 @@ FResourceFile *Check7Z(const char *filename, FileReader &file, bool quiet, LumpF
if (!memcmp(head, k7zSignature, k7zSignatureSize)) if (!memcmp(head, k7zSignature, k7zSignatureSize))
{ {
auto rf = new F7ZFile(filename, file); auto rf = new F7ZFile(filename, file);
if (rf->Open(quiet, filter)) return rf; if (rf->Open(filter, Printf)) return rf;
file = std::move(rf->Reader); // to avoid destruction of reader file = std::move(rf->Reader); // to avoid destruction of reader
delete rf; delete rf;

View file

@ -38,7 +38,6 @@
#include "resourcefile.h" #include "resourcefile.h"
#include "cmdlib.h" #include "cmdlib.h"
#include "printf.h"
#include "findfile.h" #include "findfile.h"
//========================================================================== //==========================================================================
@ -67,12 +66,12 @@ class FDirectory : public FResourceFile
TArray<FDirectoryLump> Lumps; TArray<FDirectoryLump> Lumps;
const bool nosubdir; const bool nosubdir;
int AddDirectory(const char *dirpath); int AddDirectory(const char* dirpath, FileSystemMessageFunc Printf);
void AddEntry(const char *fullpath, int size); void AddEntry(const char *fullpath, int size);
public: public:
FDirectory(const char * dirname, bool nosubdirflag = false); FDirectory(const char * dirname, bool nosubdirflag = false);
bool Open(bool quiet, LumpFilterInfo* filter); bool Open(LumpFilterInfo* filter, FileSystemMessageFunc Printf);
virtual FResourceLump *GetLump(int no) { return ((unsigned)no < NumLumps)? &Lumps[no] : NULL; } virtual FResourceLump *GetLump(int no) { return ((unsigned)no < NumLumps)? &Lumps[no] : NULL; }
}; };
@ -110,7 +109,7 @@ FDirectory::FDirectory(const char * directory, bool nosubdirflag)
// //
//========================================================================== //==========================================================================
int FDirectory::AddDirectory(const char *dirpath) int FDirectory::AddDirectory(const char *dirpath, FileSystemMessageFunc Printf)
{ {
void * handle; void * handle;
int count = 0; int count = 0;
@ -122,7 +121,7 @@ int FDirectory::AddDirectory(const char *dirpath)
handle = I_FindFirst(dirmatch.GetChars(), &find); handle = I_FindFirst(dirmatch.GetChars(), &find);
if (handle == ((void *)(-1))) if (handle == ((void *)(-1)))
{ {
Printf("Could not scan '%s': %s\n", dirpath, strerror(errno)); Printf(FSMessageLevel::Error, "Could not scan '%s': %s\n", dirpath, strerror(errno));
} }
else else
{ {
@ -148,7 +147,7 @@ int FDirectory::AddDirectory(const char *dirpath)
} }
FString newdir = dirpath; FString newdir = dirpath;
newdir << fi << '/'; newdir << fi << '/';
count += AddDirectory(newdir); count += AddDirectory(newdir, Printf);
} }
else else
{ {
@ -193,9 +192,9 @@ int FDirectory::AddDirectory(const char *dirpath)
// //
//========================================================================== //==========================================================================
bool FDirectory::Open(bool quiet, LumpFilterInfo* filter) bool FDirectory::Open(LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
NumLumps = AddDirectory(FileName); NumLumps = AddDirectory(FileName, Printf);
PostProcessArchive(&Lumps[0], sizeof(FDirectoryLump), filter); PostProcessArchive(&Lumps[0], sizeof(FDirectoryLump), filter);
return true; return true;
} }
@ -265,10 +264,10 @@ int FDirectoryLump::FillCache()
// //
//========================================================================== //==========================================================================
FResourceFile *CheckDir(const char *filename, bool quiet, bool nosubdirflag, LumpFilterInfo* filter) FResourceFile *CheckDir(const char *filename, bool nosubdirflag, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
auto rf = new FDirectory(filename, nosubdirflag); auto rf = new FDirectory(filename, nosubdirflag);
if (rf->Open(quiet, filter)) return rf; if (rf->Open(filter, Printf)) return rf;
delete rf; delete rf;
return nullptr; return nullptr;
} }

View file

@ -34,7 +34,6 @@
*/ */
#include "resourcefile.h" #include "resourcefile.h"
#include "printf.h"
//========================================================================== //==========================================================================
// //
@ -72,7 +71,7 @@ class FGrpFile : public FUncompressedFile
{ {
public: public:
FGrpFile(const char * filename, FileReader &file); FGrpFile(const char * filename, FileReader &file);
bool Open(bool quiet, LumpFilterInfo* filter); bool Open(LumpFilterInfo* filter);
}; };
@ -93,7 +92,7 @@ FGrpFile::FGrpFile(const char *filename, FileReader &file)
// //
//========================================================================== //==========================================================================
bool FGrpFile::Open(bool quiet, LumpFilterInfo*) bool FGrpFile::Open(LumpFilterInfo* filter)
{ {
GrpHeader header; GrpHeader header;
@ -129,7 +128,7 @@ bool FGrpFile::Open(bool quiet, LumpFilterInfo*)
// //
//========================================================================== //==========================================================================
FResourceFile *CheckGRP(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter) FResourceFile *CheckGRP(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
char head[12]; char head[12];
@ -141,7 +140,7 @@ FResourceFile *CheckGRP(const char *filename, FileReader &file, bool quiet, Lump
if (!memcmp(head, "KenSilverman", 12)) if (!memcmp(head, "KenSilverman", 12))
{ {
auto rf = new FGrpFile(filename, file); auto rf = new FGrpFile(filename, file);
if (rf->Open(quiet, filter)) return rf; if (rf->Open(filter)) return rf;
file = std::move(rf->Reader); // to avoid destruction of reader file = std::move(rf->Reader); // to avoid destruction of reader
delete rf; delete rf;

View file

@ -34,7 +34,6 @@
#include "resourcefile.h" #include "resourcefile.h"
#include "cmdlib.h" #include "cmdlib.h"
#include "printf.h"
//========================================================================== //==========================================================================
// //
@ -46,7 +45,7 @@ class FLumpFile : public FUncompressedFile
{ {
public: public:
FLumpFile(const char * filename, FileReader &file); FLumpFile(const char * filename, FileReader &file);
bool Open(bool quiet, LumpFilterInfo* filter); bool Open(LumpFilterInfo* filter);
}; };
@ -67,7 +66,7 @@ FLumpFile::FLumpFile(const char *filename, FileReader &file)
// //
//========================================================================== //==========================================================================
bool FLumpFile::Open(bool quiet, LumpFilterInfo*) bool FLumpFile::Open(LumpFilterInfo*)
{ {
FString name(ExtractFileBase(FileName, true)); FString name(ExtractFileBase(FileName, true));
@ -78,10 +77,6 @@ bool FLumpFile::Open(bool quiet, LumpFilterInfo*)
Lumps[0].LumpSize = (int)Reader.GetLength(); Lumps[0].LumpSize = (int)Reader.GetLength();
Lumps[0].Flags = 0; Lumps[0].Flags = 0;
NumLumps = 1; NumLumps = 1;
if (!quiet)
{
Printf("\n");
}
return true; return true;
} }
@ -91,11 +86,11 @@ bool FLumpFile::Open(bool quiet, LumpFilterInfo*)
// //
//========================================================================== //==========================================================================
FResourceFile *CheckLump(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter) FResourceFile *CheckLump(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
// always succeeds // always succeeds
auto rf = new FLumpFile(filename, file); auto rf = new FLumpFile(filename, file);
if (rf->Open(quiet, filter)) return rf; if (rf->Open(filter)) return rf;
file = std::move(rf->Reader); // to avoid destruction of reader file = std::move(rf->Reader); // to avoid destruction of reader
delete rf; delete rf;
return NULL; return NULL;

View file

@ -33,7 +33,6 @@
*/ */
#include "resourcefile.h" #include "resourcefile.h"
#include "printf.h"
//========================================================================== //==========================================================================
// //
@ -65,7 +64,7 @@ class FPakFile : public FUncompressedFile
{ {
public: public:
FPakFile(const char * filename, FileReader &file); FPakFile(const char * filename, FileReader &file);
bool Open(bool quiet, LumpFilterInfo* filter); bool Open(LumpFilterInfo* filter);
}; };
@ -88,7 +87,7 @@ FPakFile::FPakFile(const char *filename, FileReader &file)
// //
//========================================================================== //==========================================================================
bool FPakFile::Open(bool quiet, LumpFilterInfo* filter) bool FPakFile::Open(LumpFilterInfo* filter)
{ {
dpackheader_t header; dpackheader_t header;
@ -123,7 +122,7 @@ bool FPakFile::Open(bool quiet, LumpFilterInfo* filter)
// //
//========================================================================== //==========================================================================
FResourceFile *CheckPak(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter) FResourceFile *CheckPak(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
char head[4]; char head[4];
@ -135,7 +134,7 @@ FResourceFile *CheckPak(const char *filename, FileReader &file, bool quiet, Lump
if (!memcmp(head, "PACK", 4)) if (!memcmp(head, "PACK", 4))
{ {
auto rf = new FPakFile(filename, file); auto rf = new FPakFile(filename, file);
if (rf->Open(quiet, filter)) return rf; if (rf->Open(filter)) return rf;
file = std::move(rf->Reader); // to avoid destruction of reader file = std::move(rf->Reader); // to avoid destruction of reader
delete rf; delete rf;

View file

@ -35,8 +35,6 @@
#include "resourcefile.h" #include "resourcefile.h"
#include "printf.h"
//========================================================================== //==========================================================================
// //
// //
@ -111,7 +109,7 @@ class FRFFFile : public FResourceFile
public: public:
FRFFFile(const char * filename, FileReader &file); FRFFFile(const char * filename, FileReader &file);
virtual ~FRFFFile(); virtual ~FRFFFile();
virtual bool Open(bool quiet, LumpFilterInfo* filter); virtual bool Open(LumpFilterInfo* filter);
virtual FResourceLump *GetLump(int no) { return ((unsigned)no < NumLumps)? &Lumps[no] : NULL; } virtual FResourceLump *GetLump(int no) { return ((unsigned)no < NumLumps)? &Lumps[no] : NULL; }
}; };
@ -134,7 +132,7 @@ FRFFFile::FRFFFile(const char *filename, FileReader &file)
// //
//========================================================================== //==========================================================================
bool FRFFFile::Open(bool quiet, LumpFilterInfo*) bool FRFFFile::Open(LumpFilterInfo*)
{ {
RFFLump *lumps; RFFLump *lumps;
RFFInfo header; RFFInfo header;
@ -237,7 +235,7 @@ int FRFFLump::FillCache()
// //
//========================================================================== //==========================================================================
FResourceFile *CheckRFF(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter) FResourceFile *CheckRFF(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
char head[4]; char head[4];
@ -249,7 +247,7 @@ FResourceFile *CheckRFF(const char *filename, FileReader &file, bool quiet, Lump
if (!memcmp(head, "RFF\x1a", 4)) if (!memcmp(head, "RFF\x1a", 4))
{ {
auto rf = new FRFFFile(filename, file); auto rf = new FRFFFile(filename, file);
if (rf->Open(quiet, filter)) return rf; if (rf->Open(filter)) return rf;
file = std::move(rf->Reader); // to avoid destruction of reader file = std::move(rf->Reader); // to avoid destruction of reader
delete rf; delete rf;

View file

@ -34,7 +34,6 @@
*/ */
#include "resourcefile.h" #include "resourcefile.h"
#include "printf.h"
//========================================================================== //==========================================================================
// //
@ -46,7 +45,7 @@ class FSSIFile : public FUncompressedFile
{ {
public: public:
FSSIFile(const char * filename, FileReader &file); FSSIFile(const char * filename, FileReader &file);
bool Open(bool quiet, int version, int lumpcount, LumpFilterInfo* filter); bool Open(int version, int lumpcount, LumpFilterInfo* filter);
}; };
@ -68,7 +67,7 @@ FSSIFile::FSSIFile(const char *filename, FileReader &file)
// //
//========================================================================== //==========================================================================
bool FSSIFile::Open(bool quiet, int version, int lumpcount, LumpFilterInfo*) bool FSSIFile::Open(int version, int lumpcount, LumpFilterInfo*)
{ {
NumLumps = lumpcount*2; NumLumps = lumpcount*2;
Lumps.Resize(lumpcount*2); Lumps.Resize(lumpcount*2);
@ -115,7 +114,7 @@ bool FSSIFile::Open(bool quiet, int version, int lumpcount, LumpFilterInfo*)
// //
//========================================================================== //==========================================================================
FResourceFile* CheckSSI(const char* filename, FileReader& file, bool quiet, LumpFilterInfo* filter) FResourceFile* CheckSSI(const char* filename, FileReader& file, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
char zerobuf[72]; char zerobuf[72];
char buf[72]; char buf[72];
@ -146,7 +145,7 @@ FResourceFile* CheckSSI(const char* filename, FileReader& file, bool quiet, Lump
if (!skipstring(70)) return nullptr; if (!skipstring(70)) return nullptr;
} }
auto ssi = new FSSIFile(filename, file); auto ssi = new FSSIFile(filename, file);
if (ssi->Open(filename, version, numfiles, filter)) return ssi; if (ssi->Open(version, numfiles, filter)) return ssi;
file = std::move(ssi->Reader); // to avoid destruction of reader file = std::move(ssi->Reader); // to avoid destruction of reader
delete ssi; delete ssi;
} }

View file

@ -35,7 +35,6 @@
#include <ctype.h> #include <ctype.h>
#include "resourcefile.h" #include "resourcefile.h"
#include "v_text.h"
#include "filesystem.h" #include "filesystem.h"
#include "engineerrors.h" #include "engineerrors.h"
@ -125,13 +124,13 @@ class FWadFile : public FResourceFile
TArray<FWadFileLump> Lumps; TArray<FWadFileLump> Lumps;
bool IsMarker(int lump, const char *marker); bool IsMarker(int lump, const char *marker);
void SetNamespace(const char *startmarker, const char *endmarker, namespace_t space, bool flathack=false); void SetNamespace(const char *startmarker, const char *endmarker, namespace_t space, FileSystemMessageFunc Printf, bool flathack=false);
void SkinHack (); void SkinHack (FileSystemMessageFunc Printf);
public: public:
FWadFile(const char * filename, FileReader &file); FWadFile(const char * filename, FileReader &file);
FResourceLump *GetLump(int lump) { return &Lumps[lump]; } FResourceLump *GetLump(int lump) { return &Lumps[lump]; }
bool Open(bool quiet, LumpFilterInfo* filter); bool Open(LumpFilterInfo* filter, FileSystemMessageFunc Printf);
}; };
@ -154,7 +153,7 @@ FWadFile::FWadFile(const char *filename, FileReader &file)
// //
//========================================================================== //==========================================================================
bool FWadFile::Open(bool quiet, LumpFilterInfo*) bool FWadFile::Open(LumpFilterInfo*, FileSystemMessageFunc Printf)
{ {
wadinfo_t header; wadinfo_t header;
uint32_t InfoTableOfs; uint32_t InfoTableOfs;
@ -176,7 +175,8 @@ bool FWadFile::Open(bool quiet, LumpFilterInfo*)
// Check again to detect broken wads // Check again to detect broken wads
if (InfoTableOfs + NumLumps*sizeof(wadlump_t) > (unsigned)wadSize) if (InfoTableOfs + NumLumps*sizeof(wadlump_t) > (unsigned)wadSize)
{ {
I_Error("Cannot load broken WAD file %s\n", FileName.GetChars()); Printf(FSMessageLevel::Error, "%s: Bad directory offset.\n", FileName.GetChars());
return false;
} }
} }
@ -212,7 +212,7 @@ bool FWadFile::Open(bool quiet, LumpFilterInfo*)
{ {
if (Lumps[i].LumpSize != 0) if (Lumps[i].LumpSize != 0)
{ {
Printf(PRINT_HIGH, "%s: Lump %s contains invalid positioning info and will be ignored\n", FileName.GetChars(), Lumps[i].getName()); Printf(FSMessageLevel::Warning, "%s: Lump %s contains invalid positioning info and will be ignored\n", FileName.GetChars(), Lumps[i].getName());
Lumps[i].LumpNameSetup(""); Lumps[i].LumpNameSetup("");
} }
Lumps[i].LumpSize = Lumps[i].Position = 0; Lumps[i].LumpSize = Lumps[i].Position = 0;
@ -221,18 +221,15 @@ bool FWadFile::Open(bool quiet, LumpFilterInfo*)
GenerateHash(); // Do this before the lump processing below. GenerateHash(); // Do this before the lump processing below.
if (!quiet) // don't bother with namespaces in quiet mode. We won't need them. SetNamespace("S_START", "S_END", ns_sprites, Printf);
{ SetNamespace("F_START", "F_END", ns_flats, Printf, true);
SetNamespace("S_START", "S_END", ns_sprites); SetNamespace("C_START", "C_END", ns_colormaps, Printf);
SetNamespace("F_START", "F_END", ns_flats, true); SetNamespace("A_START", "A_END", ns_acslibrary, Printf);
SetNamespace("C_START", "C_END", ns_colormaps); SetNamespace("TX_START", "TX_END", ns_newtextures, Printf);
SetNamespace("A_START", "A_END", ns_acslibrary); SetNamespace("V_START", "V_END", ns_strifevoices, Printf);
SetNamespace("TX_START", "TX_END", ns_newtextures); SetNamespace("HI_START", "HI_END", ns_hires, Printf);
SetNamespace("V_START", "V_END", ns_strifevoices); SetNamespace("VX_START", "VX_END", ns_voxels, Printf);
SetNamespace("HI_START", "HI_END", ns_hires); SkinHack(Printf);
SetNamespace("VX_START", "VX_END", ns_voxels);
SkinHack();
}
return true; return true;
} }
@ -273,7 +270,7 @@ struct Marker
unsigned int index; unsigned int index;
}; };
void FWadFile::SetNamespace(const char *startmarker, const char *endmarker, namespace_t space, bool flathack) void FWadFile::SetNamespace(const char *startmarker, const char *endmarker, namespace_t space, FileSystemMessageFunc Printf, bool flathack)
{ {
bool warned = false; bool warned = false;
int numstartmarkers = 0, numendmarkers = 0; int numstartmarkers = 0, numendmarkers = 0;
@ -300,7 +297,7 @@ void FWadFile::SetNamespace(const char *startmarker, const char *endmarker, name
{ {
if (numendmarkers == 0) return; // no markers found if (numendmarkers == 0) return; // no markers found
Printf(TEXTCOLOR_YELLOW"WARNING: %s marker without corresponding %s found.\n", endmarker, startmarker); Printf(FSMessageLevel::Warning, "%s: %s marker without corresponding %s found.\n", FileName.GetChars(), endmarker, startmarker);
if (flathack) if (flathack)
@ -314,7 +311,7 @@ void FWadFile::SetNamespace(const char *startmarker, const char *endmarker, name
{ {
// We can't add this to the flats namespace but // We can't add this to the flats namespace but
// it needs to be flagged for the texture manager. // it needs to be flagged for the texture manager.
DPrintf(DMSG_NOTIFY, "Marking %s as potential flat\n", Lumps[ii].getName()); Printf(FSMessageLevel::DebugNotify, "%s: Marking %s as potential flat\n", FileName.GetChars(), Lumps[ii].getName());
Lumps[ii].Flags |= LUMPF_MAYBEFLAT; Lumps[ii].Flags |= LUMPF_MAYBEFLAT;
} }
} }
@ -328,7 +325,7 @@ void FWadFile::SetNamespace(const char *startmarker, const char *endmarker, name
int start, end; int start, end;
if (markers[i].markertype != 0) if (markers[i].markertype != 0)
{ {
Printf(TEXTCOLOR_YELLOW"WARNING: %s marker without corresponding %s found.\n", endmarker, startmarker); Printf(FSMessageLevel::Warning, "%s: %s marker without corresponding %s found.\n", FileName.GetChars(), endmarker, startmarker);
i++; i++;
continue; continue;
} }
@ -337,21 +334,21 @@ void FWadFile::SetNamespace(const char *startmarker, const char *endmarker, name
// skip over subsequent x_START markers // skip over subsequent x_START markers
while (i < markers.Size() && markers[i].markertype == 0) while (i < markers.Size() && markers[i].markertype == 0)
{ {
Printf(TEXTCOLOR_YELLOW"WARNING: duplicate %s marker found.\n", startmarker); Printf(FSMessageLevel::Warning, "%s: duplicate %s marker found.\n", FileName.GetChars(), startmarker);
i++; i++;
continue; continue;
} }
// same for x_END markers // same for x_END markers
while (i < markers.Size()-1 && (markers[i].markertype == 1 && markers[i+1].markertype == 1)) while (i < markers.Size()-1 && (markers[i].markertype == 1 && markers[i+1].markertype == 1))
{ {
Printf(TEXTCOLOR_YELLOW"WARNING: duplicate %s marker found.\n", endmarker); Printf(FSMessageLevel::Warning, "%s: duplicate %s marker found.\n", FileName.GetChars(), endmarker);
i++; i++;
continue; continue;
} }
// We found a starting marker but no end marker. Ignore this block. // We found a starting marker but no end marker. Ignore this block.
if (i >= markers.Size()) if (i >= markers.Size())
{ {
Printf(TEXTCOLOR_YELLOW"WARNING: %s marker without corresponding %s found.\n", startmarker, endmarker); Printf(FSMessageLevel::Warning, "%s: %s marker without corresponding %s found.\n", FileName.GetChars(), startmarker, endmarker);
end = NumLumps; end = NumLumps;
} }
else else
@ -360,14 +357,14 @@ void FWadFile::SetNamespace(const char *startmarker, const char *endmarker, name
} }
// we found a marked block // we found a marked block
DPrintf(DMSG_NOTIFY, "Found %s block at (%d-%d)\n", startmarker, markers[start].index, end); Printf(FSMessageLevel::DebugNotify, "%s: Found %s block at (%d-%d)\n", FileName.GetChars(), startmarker, markers[start].index, end);
for(int j = markers[start].index + 1; j < end; j++) for(int j = markers[start].index + 1; j < end; j++)
{ {
if (Lumps[j].Namespace != ns_global) if (Lumps[j].Namespace != ns_global)
{ {
if (!warned) if (!warned)
{ {
Printf(TEXTCOLOR_YELLOW"WARNING: Overlapping namespaces found (lump %d)\n", j); Printf(FSMessageLevel::Warning, "%s: Overlapping namespaces found (lump %d)\n", FileName.GetChars(), j);
} }
warned = true; warned = true;
} }
@ -377,7 +374,7 @@ void FWadFile::SetNamespace(const char *startmarker, const char *endmarker, name
// ignore sprite lumps smaller than 8 bytes (the smallest possible) // ignore sprite lumps smaller than 8 bytes (the smallest possible)
// in size -- this was used by some dmadds wads // in size -- this was used by some dmadds wads
// as an 'empty' graphics resource // as an 'empty' graphics resource
DPrintf(DMSG_WARNING, " Skipped empty sprite %s (lump %d)\n", Lumps[j].getName(), j); Printf(FSMessageLevel::DebugWarn, "%s: Skipped empty sprite %s (lump %d)\n", FileName.GetChars(), Lumps[j].getName(), j);
} }
else else
{ {
@ -401,7 +398,7 @@ void FWadFile::SetNamespace(const char *startmarker, const char *endmarker, name
// //
//========================================================================== //==========================================================================
void FWadFile::SkinHack () void FWadFile::SkinHack (FileSystemMessageFunc Printf)
{ {
// this being static is not a problem. The only relevant thing is that each skin gets a different number. // this being static is not a problem. The only relevant thing is that each skin gets a different number.
static int namespc = ns_firstskin; static int namespc = ns_firstskin;
@ -447,11 +444,8 @@ void FWadFile::SkinHack ()
} }
if (skinned && hasmap) if (skinned && hasmap)
{ {
Printf (TEXTCOLOR_BLUE Printf(FSMessageLevel::Attention, "%s: The maps will not be loaded because it has a skin.\n", FileName.GetChars());
"The maps in %s will not be loaded because it has a skin.\n" Printf(FSMessageLevel::Attention, "You should remove the skin from the wad to play these maps.\n");
TEXTCOLOR_BLUE
"You should remove the skin from the wad to play these maps.\n",
FileName.GetChars());
} }
} }
@ -462,7 +456,7 @@ void FWadFile::SkinHack ()
// //
//========================================================================== //==========================================================================
FResourceFile *CheckWad(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter) FResourceFile *CheckWad(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
char head[4]; char head[4];
@ -474,7 +468,7 @@ FResourceFile *CheckWad(const char *filename, FileReader &file, bool quiet, Lump
if (!memcmp(head, "IWAD", 4) || !memcmp(head, "PWAD", 4)) if (!memcmp(head, "IWAD", 4) || !memcmp(head, "PWAD", 4))
{ {
auto rf = new FWadFile(filename, file); auto rf = new FWadFile(filename, file);
if (rf->Open(quiet, filter)) return rf; if (rf->Open(filter, Printf)) return rf;
file = std::move(rf->Reader); // to avoid destruction of reader file = std::move(rf->Reader); // to avoid destruction of reader
delete rf; delete rf;

View file

@ -35,7 +35,6 @@
*/ */
#include "resourcefile.h" #include "resourcefile.h"
#include "printf.h"
#include "cmdlib.h" #include "cmdlib.h"
//========================================================================== //==========================================================================
@ -68,7 +67,7 @@ class FWHResFile : public FUncompressedFile
FString basename; FString basename;
public: public:
FWHResFile(const char * filename, FileReader &file); FWHResFile(const char * filename, FileReader &file);
bool Open(bool quiet, LumpFilterInfo* filter); bool Open(LumpFilterInfo* filter);
}; };
@ -92,7 +91,7 @@ FWHResFile::FWHResFile(const char *filename, FileReader &file)
// //
//========================================================================== //==========================================================================
bool FWHResFile::Open(bool quiet, LumpFilterInfo*) bool FWHResFile::Open(LumpFilterInfo*)
{ {
int directory[1024]; int directory[1024];
@ -129,7 +128,7 @@ bool FWHResFile::Open(bool quiet, LumpFilterInfo*)
// //
//========================================================================== //==========================================================================
FResourceFile *CheckWHRes(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter) FResourceFile *CheckWHRes(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
if (file.GetLength() >= 8192) // needs to be at least 8192 to contain one file and the directory. if (file.GetLength() >= 8192) // needs to be at least 8192 to contain one file and the directory.
{ {
@ -149,7 +148,7 @@ FResourceFile *CheckWHRes(const char *filename, FileReader &file, bool quiet, Lu
checkpos += (length+4095) / 4096; checkpos += (length+4095) / 4096;
} }
auto rf = new FWHResFile(filename, file); auto rf = new FWHResFile(filename, file);
if (rf->Open(quiet, filter)) return rf; if (rf->Open(filter)) return rf;
file = std::move(rf->Reader); // to avoid destruction of reader file = std::move(rf->Reader); // to avoid destruction of reader
delete rf; delete rf;
} }

View file

@ -37,7 +37,6 @@
#include "file_zip.h" #include "file_zip.h"
#include "cmdlib.h" #include "cmdlib.h"
#include "printf.h"
#include "w_zip.h" #include "w_zip.h"
#include "ancientzip.h" #include "ancientzip.h"
@ -51,8 +50,6 @@
//========================================================================== //==========================================================================
static bool UncompressZipLump(char *Cache, FileReader &Reader, int Method, int LumpSize, int CompressedSize, int GPFlags) static bool UncompressZipLump(char *Cache, FileReader &Reader, int Method, int LumpSize, int CompressedSize, int GPFlags)
{
try
{ {
switch (Method) switch (Method)
{ {
@ -92,12 +89,6 @@ static bool UncompressZipLump(char *Cache, FileReader &Reader, int Method, int L
assert(0); assert(0);
return false; return false;
} }
}
catch (CRecoverableError &err)
{
Printf("%s\n", err.GetMessage());
return false;
}
return true; return true;
} }
@ -173,7 +164,7 @@ FZipFile::FZipFile(const char * filename, FileReader &file)
Lumps = NULL; Lumps = NULL;
} }
bool FZipFile::Open(bool quiet, LumpFilterInfo* filter) bool FZipFile::Open(LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
bool zip64 = false; bool zip64 = false;
uint32_t centraldir = Zip_FindCentralDir(Reader, &zip64); uint32_t centraldir = Zip_FindCentralDir(Reader, &zip64);
@ -183,7 +174,7 @@ bool FZipFile::Open(bool quiet, LumpFilterInfo* filter)
if (centraldir == 0) if (centraldir == 0)
{ {
if (!quiet) Printf(TEXTCOLOR_RED "\n%s: ZIP file corrupt!\n", FileName.GetChars()); Printf(FSMessageLevel::Error, "%s: ZIP file corrupt!\n", FileName.GetChars());
return false; return false;
} }
@ -199,7 +190,7 @@ bool FZipFile::Open(bool quiet, LumpFilterInfo* filter)
if (info.NumEntries != info.NumEntriesOnAllDisks || if (info.NumEntries != info.NumEntriesOnAllDisks ||
info.FirstDisk != 0 || info.DiskNumber != 0) info.FirstDisk != 0 || info.DiskNumber != 0)
{ {
if (!quiet) Printf(TEXTCOLOR_RED "\n%s: Multipart Zip files are not supported.\n", FileName.GetChars()); Printf(FSMessageLevel::Error, "%s: Multipart Zip files are not supported.\n", FileName.GetChars());
return false; return false;
} }
@ -218,7 +209,7 @@ bool FZipFile::Open(bool quiet, LumpFilterInfo* filter)
if (info.NumEntries != info.NumEntriesOnAllDisks || if (info.NumEntries != info.NumEntriesOnAllDisks ||
info.FirstDisk != 0 || info.DiskNumber != 0) info.FirstDisk != 0 || info.DiskNumber != 0)
{ {
if (!quiet) Printf(TEXTCOLOR_RED "\n%s: Multipart Zip files are not supported.\n", FileName.GetChars()); Printf(FSMessageLevel::Error, "%s: Multipart Zip files are not supported.\n", FileName.GetChars());
return false; return false;
} }
@ -257,7 +248,7 @@ bool FZipFile::Open(bool quiet, LumpFilterInfo* filter)
if (dirptr > ((char*)directory) + dirsize) // This directory entry goes beyond the end of the file. if (dirptr > ((char*)directory) + dirsize) // This directory entry goes beyond the end of the file.
{ {
free(directory); free(directory);
if (!quiet) Printf(TEXTCOLOR_RED "\n%s: Central directory corrupted.", FileName.GetChars()); Printf(FSMessageLevel::Error, "%s: Central directory corrupted.", FileName.GetChars());
return false; return false;
} }
@ -323,7 +314,7 @@ bool FZipFile::Open(bool quiet, LumpFilterInfo* filter)
if (dirptr > ((char*)directory) + dirsize) // This directory entry goes beyond the end of the file. if (dirptr > ((char*)directory) + dirsize) // This directory entry goes beyond the end of the file.
{ {
free(directory); free(directory);
if (!quiet) Printf(TEXTCOLOR_RED "\n%s: Central directory corrupted.", FileName.GetChars()); Printf(FSMessageLevel::Error, "%s: Central directory corrupted.", FileName.GetChars());
return false; return false;
} }
@ -350,7 +341,7 @@ bool FZipFile::Open(bool quiet, LumpFilterInfo* filter)
zip_fh->Method != METHOD_IMPLODE && zip_fh->Method != METHOD_IMPLODE &&
zip_fh->Method != METHOD_SHRINK) zip_fh->Method != METHOD_SHRINK)
{ {
if (!quiet) Printf(TEXTCOLOR_YELLOW "\n%s: '%s' uses an unsupported compression algorithm (#%d).\n", FileName.GetChars(), name.GetChars(), zip_fh->Method); Printf(FSMessageLevel::Error, "%s: '%s' uses an unsupported compression algorithm (#%d).\n", FileName.GetChars(), name.GetChars(), zip_fh->Method);
skipped++; skipped++;
continue; continue;
} }
@ -358,7 +349,7 @@ bool FZipFile::Open(bool quiet, LumpFilterInfo* filter)
zip_fh->Flags = LittleShort(zip_fh->Flags); zip_fh->Flags = LittleShort(zip_fh->Flags);
if (zip_fh->Flags & ZF_ENCRYPTED) if (zip_fh->Flags & ZF_ENCRYPTED)
{ {
if (!quiet) Printf(TEXTCOLOR_YELLOW "\n%s: '%s' is encrypted. Encryption is not supported.\n", FileName.GetChars(), name.GetChars()); Printf(FSMessageLevel::Error, "%s: '%s' is encrypted. Encryption is not supported.\n", FileName.GetChars(), name.GetChars());
skipped++; skipped++;
continue; continue;
} }
@ -385,7 +376,7 @@ bool FZipFile::Open(bool quiet, LumpFilterInfo* filter)
if (zip_64->CompressedSize > 0x7fffffff || zip_64->UncompressedSize > 0x7fffffff) if (zip_64->CompressedSize > 0x7fffffff || zip_64->UncompressedSize > 0x7fffffff)
{ {
// The file system is limited to 32 bit file sizes; // The file system is limited to 32 bit file sizes;
if (!quiet) Printf(TEXTCOLOR_YELLOW "\n%s: '%s' is too large.\n", FileName.GetChars(), name.GetChars()); Printf(FSMessageLevel::Warning, "%s: '%s' is too large.\n", FileName.GetChars(), name.GetChars());
skipped++; skipped++;
continue; continue;
} }
@ -508,7 +499,16 @@ int FZipLump::FillCache()
Owner->Reader.Seek(Position, FileReader::SeekSet); Owner->Reader.Seek(Position, FileReader::SeekSet);
Cache = new char[LumpSize]; Cache = new char[LumpSize];
try
{
UncompressZipLump(Cache, Owner->Reader, Method, LumpSize, CompressedSize, GPFlags); UncompressZipLump(Cache, Owner->Reader, Method, LumpSize, CompressedSize, GPFlags);
}
catch (const CRecoverableError& )
{
// this cannot propagate the exception but also has no means to handle the error message. Damn...
// At least don't return uninitialized memory here.
memset(Cache, 0, LumpSize);
}
RefCount = 1; RefCount = 1;
return 1; return 1;
} }
@ -532,7 +532,7 @@ int FZipLump::GetFileOffset()
// //
//========================================================================== //==========================================================================
FResourceFile *CheckZip(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter) FResourceFile *CheckZip(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
char head[4]; char head[4];
@ -544,7 +544,7 @@ FResourceFile *CheckZip(const char *filename, FileReader &file, bool quiet, Lump
if (!memcmp(head, "PK\x3\x4", 4)) if (!memcmp(head, "PK\x3\x4", 4))
{ {
auto rf = new FZipFile(filename, file); auto rf = new FZipFile(filename, file);
if (rf->Open(quiet, filter)) return rf; if (rf->Open(filter, Printf)) return rf;
file = std::move(rf->Reader); // to avoid destruction of reader file = std::move(rf->Reader); // to avoid destruction of reader
delete rf; delete rf;

View file

@ -41,7 +41,7 @@ class FZipFile : public FResourceFile
public: public:
FZipFile(const char * filename, FileReader &file); FZipFile(const char * filename, FileReader &file);
virtual ~FZipFile(); virtual ~FZipFile();
bool Open(bool quiet, LumpFilterInfo* filter); bool Open(LumpFilterInfo* filter, FileSystemMessageFunc Printf);
virtual FResourceLump *GetLump(int no) { return ((unsigned)no < NumLumps)? &Lumps[no] : NULL; } virtual FResourceLump *GetLump(int no) { return ((unsigned)no < NumLumps)? &Lumps[no] : NULL; }
}; };

View file

@ -152,7 +152,7 @@ struct FileSystem::LumpRecord
// PRIVATE FUNCTION PROTOTYPES --------------------------------------------- // PRIVATE FUNCTION PROTOTYPES ---------------------------------------------
static void PrintLastError (); static void PrintLastError (FileSystemMessageFunc Printf);
// PUBLIC DATA DEFINITIONS ------------------------------------------------- // PUBLIC DATA DEFINITIONS -------------------------------------------------
@ -162,7 +162,7 @@ FileSystem fileSystem;
FileSystem::FileSystem() FileSystem::FileSystem()
{ {
// This is needed to initialize the LumpRecord array, which depends on data only available here. // Cannot be defaulted! This is needed to initialize the LumpRecord array, which depends on data only available here.
} }
FileSystem::~FileSystem () FileSystem::~FileSystem ()
@ -199,14 +199,14 @@ void FileSystem::DeleteAll ()
// //
//========================================================================== //==========================================================================
void FileSystem::InitSingleFile(const char* filename, bool quiet) bool FileSystem::InitSingleFile(const char* filename, FileSystemMessageFunc Printf)
{ {
TArray<FString> filenames; TArray<FString> filenames;
filenames.Push(filename); filenames.Push(filename);
InitMultipleFiles(filenames, true); return InitMultipleFiles(filenames, nullptr, Printf);
} }
void FileSystem::InitMultipleFiles (TArray<FString> &filenames, bool quiet, LumpFilterInfo* filter, bool allowduplicates, FILE* hashfile) bool FileSystem::InitMultipleFiles (TArray<FString> &filenames, LumpFilterInfo* filter, FileSystemMessageFunc Printf, bool allowduplicates, FILE* hashfile)
{ {
int numfiles; int numfiles;
@ -232,7 +232,7 @@ void FileSystem::InitMultipleFiles (TArray<FString> &filenames, bool quiet, Lump
for(unsigned i=0;i<filenames.Size(); i++) for(unsigned i=0;i<filenames.Size(); i++)
{ {
AddFile (filenames[i], nullptr, quiet, filter, hashfile); AddFile (filenames[i], nullptr, filter, Printf, hashfile);
if (i == (unsigned)MaxIwadIndex) MoveLumpsInFolder("after_iwad/"); if (i == (unsigned)MaxIwadIndex) MoveLumpsInFolder("after_iwad/");
FStringf path("filter/%s", Files.Last()->GetHash().GetChars()); FStringf path("filter/%s", Files.Last()->GetHash().GetChars());
@ -242,13 +242,13 @@ void FileSystem::InitMultipleFiles (TArray<FString> &filenames, bool quiet, Lump
NumEntries = FileInfo.Size(); NumEntries = FileInfo.Size();
if (NumEntries == 0) if (NumEntries == 0)
{ {
if (!quiet) I_FatalError("W_InitMultipleFiles: no files found"); return false;
else return;
} }
if (filter && filter->postprocessFunc) filter->postprocessFunc(); if (filter && filter->postprocessFunc) filter->postprocessFunc();
// [RH] Set up hash table // [RH] Set up hash table
InitHashChains (); InitHashChains ();
return true;
} }
//========================================================================== //==========================================================================
@ -308,7 +308,7 @@ int FileSystem::AddFromBuffer(const char* name, const char* type, char* data, in
// [RH] Removed reload hack // [RH] Removed reload hack
//========================================================================== //==========================================================================
void FileSystem::AddFile (const char *filename, FileReader *filer, bool quiet, LumpFilterInfo* filter, FILE* hashfile) void FileSystem::AddFile (const char *filename, FileReader *filer, LumpFilterInfo* filter, FileSystemMessageFunc Printf, FILE* hashfile)
{ {
int startlump; int startlump;
bool isdir = false; bool isdir = false;
@ -319,10 +319,10 @@ void FileSystem::AddFile (const char *filename, FileReader *filer, bool quiet, L
// Does this exist? If so, is it a directory? // Does this exist? If so, is it a directory?
if (!DirEntryExists(filename, &isdir)) if (!DirEntryExists(filename, &isdir))
{ {
if (!quiet) if (Printf)
{ {
Printf(TEXTCOLOR_RED "%s: File or Directory not found\n", filename); Printf(FSMessageLevel::Error, "%s: File or Directory not found\n", filename);
PrintLastError(); PrintLastError(Printf);
} }
return; return;
} }
@ -331,10 +331,10 @@ void FileSystem::AddFile (const char *filename, FileReader *filer, bool quiet, L
{ {
if (!filereader.OpenFile(filename)) if (!filereader.OpenFile(filename))
{ // Didn't find file { // Didn't find file
if (!quiet) if (Printf)
{ {
Printf(TEXTCOLOR_RED "%s: File not found\n", filename); Printf(FSMessageLevel::Error, "%s: File not found\n", filename);
PrintLastError(); PrintLastError(Printf);
} }
return; return;
} }
@ -342,19 +342,20 @@ void FileSystem::AddFile (const char *filename, FileReader *filer, bool quiet, L
} }
else filereader = std::move(*filer); else filereader = std::move(*filer);
if (!batchrun && !quiet) Printf (" adding %s", filename);
startlump = NumEntries; startlump = NumEntries;
FResourceFile *resfile; FResourceFile *resfile;
if (!isdir) if (!isdir)
resfile = FResourceFile::OpenResourceFile(filename, filereader, quiet, false, filter); resfile = FResourceFile::OpenResourceFile(filename, filereader, false, filter, Printf);
else else
resfile = FResourceFile::OpenDirectory(filename, quiet, filter); resfile = FResourceFile::OpenDirectory(filename, filter, Printf);
if (resfile != NULL) if (resfile != NULL)
{ {
if (!quiet && !batchrun) Printf(", %d lumps\n", resfile->LumpCount()); if (!batchrun && Printf)
Printf(FSMessageLevel::Message, "adding %s, %d lumps\n", filename, resfile->LumpCount());
uint32_t lumpstart = FileInfo.Size(); uint32_t lumpstart = FileInfo.Size();
@ -376,11 +377,11 @@ void FileSystem::AddFile (const char *filename, FileReader *filer, bool quiet, L
FString path; FString path;
path.Format("%s:%s", filename, lump->getName()); path.Format("%s:%s", filename, lump->getName());
auto embedded = lump->NewReader(); auto embedded = lump->NewReader();
AddFile(path, &embedded, quiet, filter, hashfile); AddFile(path, &embedded, filter, Printf, hashfile);
} }
} }
if (hashfile && !quiet) if (hashfile)
{ {
uint8_t cksum[16]; uint8_t cksum[16];
char cksumout[33]; char cksumout[33];
@ -1647,7 +1648,7 @@ __declspec(dllimport) void * __stdcall LocalFree (void *);
__declspec(dllimport) unsigned long __stdcall GetLastError (); __declspec(dllimport) unsigned long __stdcall GetLastError ();
} }
static void PrintLastError () static void PrintLastError (FileSystemMessageFunc Printf)
{ {
char *lpMsgBuf; char *lpMsgBuf;
FormatMessageA(0x1300 /*FORMAT_MESSAGE_ALLOCATE_BUFFER | FormatMessageA(0x1300 /*FORMAT_MESSAGE_ALLOCATE_BUFFER |
@ -1660,14 +1661,14 @@ static void PrintLastError ()
0, 0,
NULL NULL
); );
Printf (TEXTCOLOR_RED " %s\n", lpMsgBuf); Printf (FSMessageLevel::Error, " %s\n", lpMsgBuf);
// Free the buffer. // Free the buffer.
LocalFree( lpMsgBuf ); LocalFree( lpMsgBuf );
} }
#else #else
static void PrintLastError () static void PrintLastError (FileSystemMessageFunc Printf)
{ {
Printf (TEXTCOLOR_RED " %s\n", strerror(errno)); Printf(FSMessageLevel::Error, " %s\n", strerror(errno));
} }
#endif #endif
@ -1681,21 +1682,3 @@ FResourceLump* FileSystem::GetFileAt(int no)
{ {
return FileInfo[no].lump; return FileInfo[no].lump;
} }
#include "c_dispatch.h"
CCMD(fs_dir)
{
int numfiles = fileSystem.GetNumEntries();
for (int i = 0; i < numfiles; i++)
{
auto container = fileSystem.GetResourceFileFullName(fileSystem.GetFileContainer(i));
auto fn1 = fileSystem.GetFileFullName(i);
auto fns = fileSystem.GetFileShortName(i);
auto fnid = fileSystem.GetResourceId(i);
auto length = fileSystem.FileLength(i);
bool hidden = fileSystem.FindFile(fn1) != i;
Printf(PRINT_HIGH | PRINT_NONOTIFY, "%s%-64s %-15s (%5d) %10d %s %s\n", hidden ? TEXTCOLOR_RED : TEXTCOLOR_UNTRANSLATED, fn1, fns, fnid, length, container, hidden ? "(h)" : "");
}
}

View file

@ -67,9 +67,9 @@ public:
int GetMaxIwadNum() { return MaxIwadIndex; } int GetMaxIwadNum() { return MaxIwadIndex; }
void SetMaxIwadNum(int x) { MaxIwadIndex = x; } void SetMaxIwadNum(int x) { MaxIwadIndex = x; }
void InitSingleFile(const char *filename, bool quiet = false); bool InitSingleFile(const char *filename, FileSystemMessageFunc Printf = nullptr);
void InitMultipleFiles (TArray<FString> &filenames, bool quiet = false, LumpFilterInfo* filter = nullptr, bool allowduplicates = false, FILE* hashfile = nullptr); bool InitMultipleFiles (TArray<FString> &filenames, LumpFilterInfo* filter = nullptr, FileSystemMessageFunc Printf = nullptr, bool allowduplicates = false, FILE* hashfile = nullptr);
void AddFile (const char *filename, FileReader *wadinfo, bool quiet, LumpFilterInfo* filter, FILE* hashfile); void AddFile (const char *filename, FileReader *wadinfo, LumpFilterInfo* filter, FileSystemMessageFunc Printf, FILE* hashfile);
int CheckIfResourceFileLoaded (const char *name) noexcept; int CheckIfResourceFileLoaded (const char *name) noexcept;
void AddAdditionalFile(const char* filename, FileReader* wadinfo = NULL) {} void AddAdditionalFile(const char* filename, FileReader* wadinfo = NULL) {}

View file

@ -223,46 +223,54 @@ int FResourceLump::Unlock()
// //
//========================================================================== //==========================================================================
typedef FResourceFile * (*CheckFunc)(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter); typedef FResourceFile * (*CheckFunc)(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
FResourceFile *CheckWad(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter); FResourceFile *CheckWad(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
FResourceFile *CheckGRP(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter); FResourceFile *CheckGRP(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
FResourceFile *CheckRFF(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter); FResourceFile *CheckRFF(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
FResourceFile *CheckPak(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter); FResourceFile *CheckPak(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
FResourceFile *CheckZip(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter); FResourceFile *CheckZip(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
FResourceFile *Check7Z(const char *filename, FileReader &file, bool quiet, LumpFilterInfo* filter); FResourceFile *Check7Z(const char *filename, FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
FResourceFile* CheckSSI(const char* filename, FileReader& file, bool quiet, LumpFilterInfo* filter); FResourceFile* CheckSSI(const char* filename, FileReader& file, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
FResourceFile *CheckLump(const char *filename,FileReader &file, bool quiet, LumpFilterInfo* filter); FResourceFile* CheckWHRes(const char* filename, FileReader& file, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
FResourceFile *CheckDir(const char *filename, bool quiet, bool nosub, LumpFilterInfo* filter); FResourceFile *CheckLump(const char *filename,FileReader &file, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
FResourceFile *CheckDir(const char *filename, bool nosub, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
static CheckFunc funcs[] = { CheckWad, CheckZip, Check7Z, CheckPak, CheckGRP, CheckRFF, CheckSSI, CheckLump }; static CheckFunc funcs[] = { CheckWad, CheckZip, Check7Z, CheckPak, CheckGRP, CheckRFF, CheckSSI, CheckWHRes, CheckLump };
FResourceFile *FResourceFile::DoOpenResourceFile(const char *filename, FileReader &file, bool quiet, bool containeronly, LumpFilterInfo* filter) static int nulPrintf(FSMessageLevel msg, const char* fmt, ...)
{ {
return 0;
}
FResourceFile *FResourceFile::DoOpenResourceFile(const char *filename, FileReader &file, bool containeronly, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{
if (Printf == nullptr) Printf = nulPrintf;
for(size_t i = 0; i < countof(funcs) - containeronly; i++) for(size_t i = 0; i < countof(funcs) - containeronly; i++)
{ {
FResourceFile *resfile = funcs[i](filename, file, quiet, filter); FResourceFile *resfile = funcs[i](filename, file, filter, Printf);
if (resfile != NULL) return resfile; if (resfile != NULL) return resfile;
} }
return NULL; return NULL;
} }
FResourceFile *FResourceFile::OpenResourceFile(const char *filename, FileReader &file, bool quiet, bool containeronly, LumpFilterInfo* filter) FResourceFile *FResourceFile::OpenResourceFile(const char *filename, FileReader &file, bool containeronly, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
return DoOpenResourceFile(filename, file, quiet, containeronly, filter); return DoOpenResourceFile(filename, file, containeronly, filter, Printf);
} }
FResourceFile *FResourceFile::OpenResourceFile(const char *filename, bool quiet, bool containeronly, LumpFilterInfo* filter) FResourceFile *FResourceFile::OpenResourceFile(const char *filename, bool containeronly, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
FileReader file; FileReader file;
if (!file.OpenFile(filename)) return nullptr; if (!file.OpenFile(filename)) return nullptr;
return DoOpenResourceFile(filename, file, quiet, containeronly, filter); return DoOpenResourceFile(filename, file, containeronly, filter, Printf);
} }
FResourceFile *FResourceFile::OpenDirectory(const char *filename, bool quiet, LumpFilterInfo* filter) FResourceFile *FResourceFile::OpenDirectory(const char *filename, LumpFilterInfo* filter, FileSystemMessageFunc Printf)
{ {
return CheckDir(filename, quiet, false, filter); if (Printf == nullptr) Printf = nulPrintf;
return CheckDir(filename, false, filter, Printf);
} }
//========================================================================== //==========================================================================

View file

@ -8,6 +8,7 @@
#include "files.h" #include "files.h"
#include "zstring.h" #include "zstring.h"
// user context in which the file system gets opened. This also contains a few callbacks to avoid direct dependencies on the engine.
struct LumpFilterInfo struct LumpFilterInfo
{ {
TArray<FString> gameTypeFilter; // this can contain multiple entries TArray<FString> gameTypeFilter; // this can contain multiple entries
@ -20,6 +21,20 @@ struct LumpFilterInfo
std::function<void()> postprocessFunc; std::function<void()> postprocessFunc;
}; };
enum class FSMessageLevel
{
Error = 1,
Warning = 2,
Attention = 3,
Message = 4,
DebugWarn = 5,
DebugNotify = 6,
};
// pass the text output function as parameter to avoid a hard dependency on higher level code.
using FileSystemMessageFunc = int(*)(FSMessageLevel msglevel, const char* format, ...);
class FResourceFile; class FResourceFile;
// [RH] Namespaces from BOOM. // [RH] Namespaces from BOOM.
@ -151,12 +166,12 @@ private:
int FilterLumpsByGameType(LumpFilterInfo *filter, void *lumps, size_t lumpsize, uint32_t max); int FilterLumpsByGameType(LumpFilterInfo *filter, void *lumps, size_t lumpsize, uint32_t max);
bool FindPrefixRange(FString filter, void *lumps, size_t lumpsize, uint32_t max, uint32_t &start, uint32_t &end); bool FindPrefixRange(FString filter, void *lumps, size_t lumpsize, uint32_t max, uint32_t &start, uint32_t &end);
void JunkLeftoverFilters(void *lumps, size_t lumpsize, uint32_t max); void JunkLeftoverFilters(void *lumps, size_t lumpsize, uint32_t max);
static FResourceFile *DoOpenResourceFile(const char *filename, FileReader &file, bool quiet, bool containeronly, LumpFilterInfo* filter); static FResourceFile *DoOpenResourceFile(const char *filename, FileReader &file, bool containeronly, LumpFilterInfo* filter, FileSystemMessageFunc Printf);
public: public:
static FResourceFile *OpenResourceFile(const char *filename, FileReader &file, bool quiet = false, bool containeronly = false, LumpFilterInfo* filter = nullptr); static FResourceFile *OpenResourceFile(const char *filename, FileReader &file, bool containeronly = false, LumpFilterInfo* filter = nullptr, FileSystemMessageFunc Printf = nullptr);
static FResourceFile *OpenResourceFile(const char *filename, bool quiet = false, bool containeronly = false, LumpFilterInfo* filter = nullptr); static FResourceFile *OpenResourceFile(const char *filename, bool containeronly = false, LumpFilterInfo* filter = nullptr, FileSystemMessageFunc Printf = nullptr);
static FResourceFile *OpenDirectory(const char *filename, bool quiet = false, LumpFilterInfo* filter = nullptr); static FResourceFile *OpenDirectory(const char *filename, LumpFilterInfo* filter = nullptr, FileSystemMessageFunc Printf = nullptr);
virtual ~FResourceFile(); virtual ~FResourceFile();
// If this FResourceFile represents a directory, the Reader object is not usable so don't return it. // If this FResourceFile represents a directory, the Reader object is not usable so don't return it.
FileReader *GetReader() { return Reader.isOpen()? &Reader : nullptr; } FileReader *GetReader() { return Reader.isOpen()? &Reader : nullptr; }

View file

@ -43,7 +43,6 @@
#include "files.h" #include "files.h"
#include "zstring.h"
#include "cmdlib.h" #include "cmdlib.h"
//========================================================================== //==========================================================================

View file

@ -308,8 +308,7 @@ FIWadManager::FIWadManager(const char *firstfn, const char *optfn)
fns.Push(firstfn); fns.Push(firstfn);
if (optfn) fns.Push(optfn); if (optfn) fns.Push(optfn);
check.InitMultipleFiles(fns, true); if (check.InitMultipleFiles(fns, nullptr, nullptr))
if (check.GetNumEntries() > 0)
{ {
int num = check.CheckNumForName("IWADINFO"); int num = check.CheckNumForName("IWADINFO");
if (num >= 0) if (num >= 0)
@ -331,7 +330,7 @@ FIWadManager::FIWadManager(const char *firstfn, const char *optfn)
int FIWadManager::ScanIWAD (const char *iwad) int FIWadManager::ScanIWAD (const char *iwad)
{ {
FileSystem check; FileSystem check;
check.InitSingleFile(iwad, true); check.InitSingleFile(iwad, nullptr);
mLumpsFound.Resize(mIWadInfos.Size()); mLumpsFound.Resize(mIWadInfos.Size());
@ -390,8 +389,7 @@ int FIWadManager::CheckIWADInfo(const char* fn)
TArray<FString> filenames; TArray<FString> filenames;
filenames.Push(fn); filenames.Push(fn);
check.InitMultipleFiles(filenames, true, &lfi); if (check.InitMultipleFiles(filenames, &lfi, nullptr))
if (check.GetNumEntries() > 0)
{ {
int num = check.CheckNumForName("IWADINFO"); int num = check.CheckNumForName("IWADINFO");
if (num >= 0) if (num >= 0)

View file

@ -1924,8 +1924,7 @@ static FString CheckGameInfo(TArray<FString> & pwads)
GetReserved(lfi); GetReserved(lfi);
// Open the entire list as a temporary file system and look for a GAMEINFO lump. The last one will automatically win. // Open the entire list as a temporary file system and look for a GAMEINFO lump. The last one will automatically win.
check.InitMultipleFiles(pwads, true, &lfi); if (check.InitMultipleFiles(pwads, &lfi, nullptr))
if (check.GetNumEntries() > 0)
{ {
int num = check.CheckNumForName("GAMEINFO"); int num = check.CheckNumForName("GAMEINFO");
if (num >= 0) if (num >= 0)
@ -3031,6 +3030,35 @@ static FILE* D_GetHashFile()
return hashfile; return hashfile;
} }
static int FileSystemPrintf(FSMessageLevel level, const char* fmt, ...)
{
va_list arg;
va_start(arg, fmt);
FString text;
text.VFormat(fmt, arg);
switch (level)
{
case FSMessageLevel::Error:
return Printf(TEXTCOLOR_RED "%s", text.GetChars());
break;
case FSMessageLevel::Warning:
Printf(TEXTCOLOR_YELLOW "%s", text.GetChars());
break;
case FSMessageLevel::Attention:
Printf(TEXTCOLOR_BLUE "%s", text.GetChars());
break;
case FSMessageLevel::Message:
Printf("%s", text.GetChars());
break;
case FSMessageLevel::DebugWarn:
DPrintf(DMSG_WARNING, "%s", text.GetChars());
break;
case FSMessageLevel::DebugNotify:
DPrintf(DMSG_NOTIFY, "%s", text.GetChars());
break;
}
return text.Len();
}
//========================================================================== //==========================================================================
// //
// D_InitGame // D_InitGame
@ -3119,7 +3147,10 @@ static int D_InitGame(const FIWADInfo* iwad_info, TArray<FString>& allwads, TArr
bool allowduplicates = Args->CheckParm("-allowduplicates"); bool allowduplicates = Args->CheckParm("-allowduplicates");
auto hashfile = D_GetHashFile(); auto hashfile = D_GetHashFile();
fileSystem.InitMultipleFiles (allwads, false, &lfi, allowduplicates, hashfile); if (!fileSystem.InitMultipleFiles(allwads, &lfi, FileSystemPrintf, allowduplicates, hashfile))
{
I_FatalError("FileSystem: no files found");
}
allwads.Clear(); allwads.Clear();
allwads.ShrinkToFit(); allwads.ShrinkToFit();
SetMapxxFlag(); SetMapxxFlag();
@ -3914,3 +3945,19 @@ void I_UpdateWindowTitle()
I_UpdateDiscordPresence(false, nullptr, nullptr, nullptr); I_UpdateDiscordPresence(false, nullptr, nullptr, nullptr);
I_SetWindowTitle(copy.Data()); I_SetWindowTitle(copy.Data());
} }
CCMD(fs_dir)
{
int numfiles = fileSystem.GetNumEntries();
for (int i = 0; i < numfiles; i++)
{
auto container = fileSystem.GetResourceFileFullName(fileSystem.GetFileContainer(i));
auto fn1 = fileSystem.GetFileFullName(i);
auto fns = fileSystem.GetFileShortName(i);
auto fnid = fileSystem.GetResourceId(i);
auto length = fileSystem.FileLength(i);
bool hidden = fileSystem.FindFile(fn1) != i;
Printf(PRINT_HIGH | PRINT_NONOTIFY, "%s%-64s %-15s (%5d) %10d %s %s\n", hidden ? TEXTCOLOR_RED : TEXTCOLOR_UNTRANSLATED, fn1, fns, fnid, length, container, hidden ? "(h)" : "");
}
}

View file

@ -1975,7 +1975,7 @@ void G_DoLoadGame ()
hidecon = gameaction == ga_loadgamehidecon; hidecon = gameaction == ga_loadgamehidecon;
gameaction = ga_nothing; gameaction = ga_nothing;
std::unique_ptr<FResourceFile> resfile(FResourceFile::OpenResourceFile(savename.GetChars(), true, true)); std::unique_ptr<FResourceFile> resfile(FResourceFile::OpenResourceFile(savename.GetChars(), true));
if (resfile == nullptr) if (resfile == nullptr)
{ {
LoadGameError("TXT_COULDNOTREAD"); LoadGameError("TXT_COULDNOTREAD");

View file

@ -883,7 +883,7 @@ bool MapLoader::LoadGLNodes(MapData * map)
strcpy(ext, ".gwa"); strcpy(ext, ".gwa");
// Todo: Compare file dates // Todo: Compare file dates
f_gwa = FResourceFile::OpenResourceFile(path, true); f_gwa = FResourceFile::OpenResourceFile(path);
if (f_gwa==nullptr) return false; if (f_gwa==nullptr) return false;
strncpy(map->MapLumps[0].Name, fileSystem.GetFileFullName(map->lumpnum), 8); strncpy(map->MapLumps[0].Name, fileSystem.GetFileFullName(map->lumpnum), 8);

View file

@ -77,7 +77,7 @@ void FSavegameManager::ReadSaveStrings()
// I_FindName only returns the file's name and not its full path // I_FindName only returns the file's name and not its full path
FString filepath = G_BuildSaveName(I_FindName(&c_file)); FString filepath = G_BuildSaveName(I_FindName(&c_file));
std::unique_ptr<FResourceFile> savegame(FResourceFile::OpenResourceFile(filepath, true, true)); std::unique_ptr<FResourceFile> savegame(FResourceFile::OpenResourceFile(filepath, true));
if (savegame != nullptr) if (savegame != nullptr)
{ {
bool oldVer = false; bool oldVer = false;

View file

@ -125,7 +125,7 @@ MapData *P_OpenMapData(const char * mapname, bool justcheck)
delete map; delete map;
return NULL; return NULL;
} }
map->resource = FResourceFile::OpenResourceFile(mapname, true); map->resource = FResourceFile::OpenResourceFile(mapname);
wadReader = map->resource->GetReader(); wadReader = map->resource->GetReader();
} }
else else