zdoom/gzdoom-gles
0
0
Fork 0
mirror of https://github.com/ZDoom/gzdoom-gles.git synced 2024-11-13 16:07:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix FxPick code emission

Browse source 
- Fixed: Integer constants passed to pick() need to manually generate load
  instructions, since FxConstant::Emit() will just return a constant
  register with its value.
- Fixed: VMFunctionBuilder::RegAvailability::Reuse() didn't actually
  calculate a proper mask. Also added another assert to this function.
This commit is contained in:
Randy Heit 2014-12-21 21:57:30 -06:00
parent 1ea03ffbec
commit b14f768b68
2 changed files with 20 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/thingdef/thingdef_expression.cpp
View file

@ -2203,17 +2203,25 @@ ExpEmit FxPick::Emit(VMFunctionBuilder *build)
for (unsigned i = 0; i < choices.Size(); ++i) for (unsigned i = 0; i < choices.Size(); ++i)
{ {
build->BackpatchToHere(jumptable + i); build->BackpatchToHere(jumptable + i);
ExpEmit casereg = choices[i]->Emit(build); if (choices[i]->isConstant())
if (casereg.RegNum != resultreg.RegNum) {
{ // The result of the case is in a different register from what int val = static_cast<FxConstant *>(choices[i])->GetValue().GetInt();
// was expected. Copy it to the one we wanted. build->EmitLoadInt(resultreg.RegNum, val);
}
resultreg.Reuse(build); // This is really just for the assert in Reuse() else
build->Emit(OP_MOVE, resultreg.RegNum, casereg.RegNum, 0); {
resultreg.Free(build); ExpEmit casereg = choices[i]->Emit(build);
if (casereg.RegNum != resultreg.RegNum)
{ // The result of the case is in a different register from what
// was expected. Copy it to the one we wanted.
resultreg.Reuse(build); // This is really just for the assert in Reuse()
build->Emit(OP_MOVE, resultreg.RegNum, casereg.RegNum, 0);
resultreg.Free(build);
}
// Free this register so the remaining cases can use it.
casereg.Free(build);
} }
// Free this register so the remaining cases can use it.
casereg.Free(build);
// All but the final case needs a jump to the end of the expression's code. // All but the final case needs a jump to the end of the expression's code.
if (i + 1 < choices.Size()) if (i + 1 < choices.Size())
{ {

3
src/zscript/vmbuilder.cpp
View file

@ -423,8 +423,9 @@ void VMFunctionBuilder::RegAvailability::Return(int reg, int count)
bool VMFunctionBuilder::RegAvailability::Reuse(int reg) bool VMFunctionBuilder::RegAvailability::Reuse(int reg)
{ {
assert(reg >= 0 && reg <= 255); assert(reg >= 0 && reg <= 255);
assert(reg < MostUsed && "Attempt to reuse a register that was never used");
VM_UWORD mask = reg & 31; VM_UWORD mask = 1 << (reg & 31);
int word = reg / 32; int word = reg / 32;
if (Used[word] & mask) if (Used[word] & mask)