Jack driver will now pair up audio and MIDI driver instances, so that audio and MIDI is synchronous.

Fixed bug in delete_fluid_timer() where timer instance was being accessed after it was possibly destroyed (if auto_destroy enabled).
This commit is contained in:
Josh Green 2009-10-26 03:17:01 +00:00
parent 08d1dea6b8
commit 2a367ab6a0
2 changed files with 385 additions and 288 deletions

View file

@ -42,47 +42,56 @@
#include "fluid_lash.h"
/**************************************************************
*
* JACK audio driver
*
*/
typedef struct _fluid_jack_audio_driver_t fluid_jack_audio_driver_t;
typedef struct _fluid_jack_midi_driver_t fluid_jack_midi_driver_t;
/*
* fluid_jack_audio_driver_t
*
*/
typedef struct {
fluid_audio_driver_t driver;
/* Clients are shared for drivers using the same server. */
typedef struct
{
jack_client_t *client;
char *server; /* Jack server name used */
fluid_jack_audio_driver_t *audio_driver;
fluid_jack_midi_driver_t *midi_driver;
} fluid_jack_client_t;
/* Jack audio driver instance */
struct _fluid_jack_audio_driver_t
{
fluid_audio_driver_t driver;
fluid_jack_client_t *client_ref;
int audio_channels;
jack_port_t **output_ports;
int num_output_ports;
float **output_bufs;
fluid_audio_func_t callback;
void* data;
} fluid_jack_audio_driver_t;
};
/* Jack MIDI driver instance */
typedef struct {
struct _fluid_jack_midi_driver_t
{
fluid_midi_driver_t driver;
jack_client_t *client;
fluid_jack_client_t *client_ref;
jack_port_t *midi_port;
fluid_midi_parser_t *parser;
} fluid_jack_midi_driver_t;
};
static fluid_jack_client_t *new_fluid_jack_client (fluid_settings_t *settings,
int isaudio, void *driver);
static int fluid_jack_client_register_ports (void *driver, int isaudio,
jack_client_t *client,
fluid_settings_t *settings);
fluid_audio_driver_t*
new_fluid_jack_audio_driver2(fluid_settings_t* settings, fluid_audio_func_t func, void* data);
int delete_fluid_jack_audio_driver(fluid_audio_driver_t* p);
void fluid_jack_audio_driver_shutdown(void *arg);
int fluid_jack_audio_driver_srate(jack_nframes_t nframes, void *arg);
int fluid_jack_audio_driver_bufsize(jack_nframes_t nframes, void *arg);
int fluid_jack_audio_driver_process(jack_nframes_t nframes, void *arg);
int fluid_jack_audio_driver_process2(jack_nframes_t nframes, void *arg);
void fluid_jack_driver_shutdown(void *arg);
int fluid_jack_driver_srate(jack_nframes_t nframes, void *arg);
int fluid_jack_driver_bufsize(jack_nframes_t nframes, void *arg);
int fluid_jack_driver_process(jack_nframes_t nframes, void *arg);
int delete_fluid_jack_midi_driver(fluid_midi_driver_t *p);
static int fluid_jack_midi_driver_process (jack_nframes_t nframes, void *arg);
void
@ -94,145 +103,98 @@ fluid_jack_audio_driver_settings(fluid_settings_t* settings)
fluid_settings_register_str(settings, "audio.jack.server", "", 0, NULL, NULL);
}
/*
* new_fluid_alsa_audio_driver
* Create Jack client as necessary, share clients of the same server.
* @param settings Settings object
* @param isaudio TRUE if audio driver, FALSE if MIDI
* @param driver fluid_jack_audio_driver_t or fluid_jack_midi_driver_t
* @param data The user data instance associated with the driver (fluid_synth_t for example)
* @return New or paired Audio/MIDI Jack client
*/
fluid_audio_driver_t*
new_fluid_jack_audio_driver(fluid_settings_t* settings, fluid_synth_t* synth)
static fluid_jack_client_t *
new_fluid_jack_client (fluid_settings_t *settings, int isaudio, void *driver)
{
return new_fluid_jack_audio_driver2(settings, NULL, synth);
}
fluid_audio_driver_t*
new_fluid_jack_audio_driver2(fluid_settings_t* settings, fluid_audio_func_t func, void* data) {
fluid_jack_audio_driver_t* dev = NULL;
const char ** jack_ports; /* for looking up ports */
static fluid_mutex_t mutex = G_STATIC_MUTEX_INIT; /* Probably not necessary, but just in case drivers are created by multiple threads */
static fluid_jack_client_t *last_client = NULL; /* Last unpaired client. For audio/MIDI driver pairing. */
fluid_jack_client_t *client_ref = NULL;
char *server = NULL;
char* client_name;
int autoconnect = 0;
int jack_srate;
double sample_rate;
char name[64];
char *server;
int i;
dev = FLUID_NEW(fluid_jack_audio_driver_t);
if (dev == NULL) {
FLUID_LOG(FLUID_ERR, "Out of memory");
return NULL;
fluid_settings_dupstr (settings, isaudio ? "audio.jack.server" /* ++ alloc server name */
: "midi.jack.server", &server);
fluid_mutex_lock (mutex); /* ++ lock last_client */
/* If the last client uses the same server and is not the same type (audio or MIDI),
* then re-use the client. */
if (last_client && ((!last_client->server && !server)
|| FLUID_STRCMP (last_client->server, server) == 0)
&& ((!isaudio && !last_client->midi_driver) || (isaudio && !last_client->audio_driver)))
{
client_ref = last_client;
last_client = NULL; /* No more pairing for this client */
/* Register ports */
if (fluid_jack_client_register_ports (driver, isaudio, client_ref->client, settings) != FLUID_OK)
goto error_recovery;
if (isaudio) fluid_atomic_pointer_set (&client_ref->audio_driver, driver);
else fluid_atomic_pointer_set (&client_ref->midi_driver, driver);
fluid_mutex_unlock (mutex); /* -- unlock last_client */
if (server) FLUID_FREE (server);
return client_ref;
}
FLUID_MEMSET(dev, 0, sizeof(fluid_jack_audio_driver_t));
dev->callback = func;
dev->data = data;
/* No existing client for this Jack server */
client_ref = FLUID_NEW (fluid_jack_client_t);
/* try to become a client of the JACK server */
if (!client_ref)
{
FLUID_LOG (FLUID_ERR, "Out of memory");
goto error_recovery;
}
if (fluid_settings_dupstr(settings, "audio.jack.id", &client_name) /* ++ alloc client name */
&& (client_name != NULL)
&& (strlen(client_name) > 0)) {
FLUID_MEMSET (client_ref, 0, sizeof (fluid_jack_client_t));
fluid_settings_dupstr (settings, isaudio ? "audio.jack.id" /* ++ alloc client name */
: "midi.jack.id", &client_name);
if (client_name != NULL && client_name[0] != 0)
snprintf(name, 64, "%s", client_name);
} else {
snprintf(name, 64, "fluidsynth");
}
else strcpy (name, "fluidsynth");
name[63] = '\0';
if (client_name) FLUID_FREE (client_name); /* -- free client name */
fluid_settings_dupstr (settings, "audio.jack.server", &server);
/* Open a connection to the Jack server and use the server name if specified */
if (server && server[0] != '\0')
dev->client = jack_client_open (name, JackServerName, NULL, server);
else dev->client = jack_client_open (name, JackNullOption, NULL);
client_ref->client = jack_client_open (name, JackServerName, NULL, server);
else client_ref->client = jack_client_open (name, JackNullOption, NULL);
if (server) FLUID_FREE (server);
if (dev->client == NULL) {
FLUID_LOG(FLUID_ERR, "Jack server not running?");
if (!client_ref->client)
{
FLUID_LOG (FLUID_ERR, "Failed to connect to Jack server.");
goto error_recovery;
}
/* set callbacks */
jack_set_process_callback(dev->client, fluid_jack_audio_driver_process, (void*) dev);
jack_set_buffer_size_callback(dev->client, fluid_jack_audio_driver_bufsize, (void*) dev);
jack_set_sample_rate_callback(dev->client, fluid_jack_audio_driver_srate, (void*) dev);
jack_on_shutdown(dev->client, fluid_jack_audio_driver_shutdown, (void*) dev);
jack_set_process_callback (client_ref->client, fluid_jack_driver_process, client_ref);
jack_set_buffer_size_callback (client_ref->client, fluid_jack_driver_bufsize, client_ref);
jack_set_sample_rate_callback (client_ref->client, fluid_jack_driver_srate, client_ref);
jack_on_shutdown (client_ref->client, fluid_jack_driver_shutdown, client_ref);
/* display the current sample rate. once the client is activated
(see below), you should rely on your own sample rate
callback (see above) for this value.
*/
jack_srate = jack_get_sample_rate(dev->client);
FLUID_LOG(FLUID_DBG, "Jack engine sample rate: %lu", jack_srate);
fluid_settings_getnum(settings, "synth.sample-rate", &sample_rate);
if ((int)sample_rate != jack_srate) {
/* There's currently no way to change the sampling rate of the
synthesizer after it's been created. */
FLUID_LOG(FLUID_WARN, "Jack sample rate mismatch, expect tuning issues"
" (synth.sample-rate=%lu, jackd=%lu)", (int)sample_rate, jack_srate);
}
fluid_settings_getint (settings, "audio.jack.multi", &i);
if (i) {
/* create the two audio output ports */
dev->num_output_ports = 1;
dev->output_ports = FLUID_ARRAY(jack_port_t*, 2 * dev->num_output_ports);
if (dev->output_ports == NULL) {
FLUID_LOG(FLUID_PANIC, "Jack server not running?");
goto error_recovery;
}
dev->output_bufs = FLUID_ARRAY(float*, 2 * dev->num_output_ports);
FLUID_MEMSET(dev->output_ports, 0, 2 * dev->num_output_ports * sizeof(jack_port_t*));
dev->output_ports[0] = jack_port_register(dev->client, "left",
JACK_DEFAULT_AUDIO_TYPE,
JackPortIsOutput, 0);
dev->output_ports[1] = jack_port_register(dev->client, "right",
JACK_DEFAULT_AUDIO_TYPE,
JackPortIsOutput, 0);
} else {
fluid_settings_getint(settings, "synth.audio-channels", &dev->num_output_ports);
dev->output_ports = FLUID_ARRAY(jack_port_t*, 2 * dev->num_output_ports);
if (dev->output_ports == NULL) {
FLUID_LOG(FLUID_PANIC, "Out of memory");
goto error_recovery;
}
dev->output_bufs = FLUID_ARRAY(float*, 2 * dev->num_output_ports);
if (dev->output_bufs == NULL) {
FLUID_LOG(FLUID_PANIC, "Out of memory");
goto error_recovery;
}
FLUID_MEMSET(dev->output_ports, 0, 2 * dev->num_output_ports * sizeof(jack_port_t*));
for (i = 0; i < dev->num_output_ports; i++) {
sprintf(name, "l_%02d", i);
dev->output_ports[2 * i] = jack_port_register(dev->client, name,
JACK_DEFAULT_AUDIO_TYPE,
JackPortIsOutput, 0);
sprintf(name, "r_%02d", i);
dev->output_ports[2 * i + 1] = jack_port_register(dev->client, name,
JACK_DEFAULT_AUDIO_TYPE,
JackPortIsOutput, 0);
}
}
/* Register ports */
if (fluid_jack_client_register_ports (driver, isaudio, client_ref->client, settings) != FLUID_OK)
goto error_recovery;
/* tell the JACK server that we are ready to roll */
if (jack_activate(dev->client)) {
FLUID_LOG(FLUID_ERR, "Cannot activate the fluidsynth as a JACK client");
if (jack_activate (client_ref->client))
{
FLUID_LOG (FLUID_ERR, "Failed to activate Jack client");
goto error_recovery;
}
@ -246,6 +208,201 @@ new_fluid_jack_audio_driver2(fluid_settings_t* settings, fluid_audio_func_t func
}
#endif /* LASH_ENABLED */
client_ref->server = server; /* !! takes over allocation */
server = NULL; /* Set to NULL so it doesn't get freed below */
last_client = client_ref;
if (isaudio) fluid_atomic_pointer_set (&client_ref->audio_driver, driver);
else fluid_atomic_pointer_set (&client_ref->midi_driver, driver);
fluid_mutex_unlock (mutex); /* -- unlock last_client */
if (server) FLUID_FREE (server);
return client_ref;
error_recovery:
fluid_mutex_unlock (mutex); /* -- unlock clients list */
if (server) FLUID_FREE (server); /* -- free server name */
if (client_ref)
{
if (client_ref->client)
jack_client_close (client_ref->client);
FLUID_FREE (client_ref);
}
return NULL;
}
static int
fluid_jack_client_register_ports (void *driver, int isaudio, jack_client_t *client,
fluid_settings_t *settings)
{
fluid_jack_audio_driver_t *dev;
char name[64];
int multi;
int i;
if (!isaudio)
{
fluid_jack_midi_driver_t *dev = driver;
dev->midi_port = jack_port_register (client, "midi", JACK_DEFAULT_MIDI_TYPE,
JackPortIsInput | JackPortIsTerminal, 0);
if (!dev->midi_port)
{
FLUID_LOG (FLUID_ERR, "Failed to create Jack MIDI port");
return FLUID_FAILED;
}
return FLUID_OK;
}
dev = driver;
fluid_settings_getint (settings, "audio.jack.multi", &multi);
if (multi)
{
/* create the two audio output ports */
dev->num_output_ports = 1;
dev->output_ports = FLUID_ARRAY (jack_port_t*, 2 * dev->num_output_ports);
if (dev->output_ports == NULL)
{
FLUID_LOG (FLUID_PANIC, "Jack server not running?");
return FLUID_FAILED;
}
dev->output_bufs = FLUID_ARRAY (float*, 2 * dev->num_output_ports);
FLUID_MEMSET (dev->output_ports, 0, 2 * dev->num_output_ports * sizeof(jack_port_t*));
dev->output_ports[0]
= jack_port_register (client, "left", JACK_DEFAULT_AUDIO_TYPE, JackPortIsOutput, 0);
dev->output_ports[1]
= jack_port_register (client, "right", JACK_DEFAULT_AUDIO_TYPE, JackPortIsOutput, 0);
}
else
{
fluid_settings_getint (settings, "synth.audio-channels", &dev->num_output_ports);
dev->output_ports = FLUID_ARRAY (jack_port_t *, 2 * dev->num_output_ports);
if (dev->output_ports == NULL)
{
FLUID_LOG (FLUID_PANIC, "Out of memory");
return FLUID_FAILED;
}
dev->output_bufs = FLUID_ARRAY (float *, 2 * dev->num_output_ports);
if (dev->output_bufs == NULL)
{
FLUID_LOG (FLUID_PANIC, "Out of memory");
return FLUID_FAILED;
}
FLUID_MEMSET (dev->output_ports, 0, 2 * dev->num_output_ports * sizeof (jack_port_t*));
for (i = 0; i < dev->num_output_ports; i++)
{
sprintf(name, "l_%02d", i);
dev->output_ports[2 * i]
= jack_port_register (client, name, JACK_DEFAULT_AUDIO_TYPE, JackPortIsOutput, 0);
sprintf(name, "r_%02d", i);
dev->output_ports[2 * i + 1]
= jack_port_register (client, name, JACK_DEFAULT_AUDIO_TYPE, JackPortIsOutput, 0);
}
}
return FLUID_OK;
}
static void
fluid_jack_client_close (fluid_jack_client_t *client_ref, void *driver)
{
if (client_ref->audio_driver == driver)
fluid_atomic_pointer_set (&client_ref->audio_driver, NULL);
else if (client_ref->midi_driver == driver)
fluid_atomic_pointer_set (&client_ref->midi_driver, NULL);
if (client_ref->audio_driver || client_ref->midi_driver)
{
g_usleep (100000); /* FIXME - Hack to make sure that resources don't get freed while Jack callback is active */
return;
}
if (client_ref->client)
jack_client_close (client_ref->client);
if (client_ref->server)
FLUID_FREE (client_ref->server);
FLUID_FREE (client_ref);
}
fluid_audio_driver_t*
new_fluid_jack_audio_driver(fluid_settings_t* settings, fluid_synth_t* synth)
{
return new_fluid_jack_audio_driver2(settings, NULL, synth);
}
fluid_audio_driver_t*
new_fluid_jack_audio_driver2(fluid_settings_t* settings, fluid_audio_func_t func, void* data)
{
fluid_jack_audio_driver_t* dev = NULL;
jack_client_t *client;
const char ** jack_ports; /* for looking up ports */
int autoconnect = 0;
int jack_srate;
double sample_rate;
int i;
dev = FLUID_NEW(fluid_jack_audio_driver_t);
if (dev == NULL) {
FLUID_LOG(FLUID_ERR, "Out of memory");
return NULL;
}
FLUID_MEMSET(dev, 0, sizeof(fluid_jack_audio_driver_t));
dev->callback = func;
dev->data = data;
dev->client_ref = new_fluid_jack_client (settings, TRUE, dev);
if (!dev->client_ref)
{
FLUID_FREE (dev);
return NULL;
}
client = dev->client_ref->client;
/* display the current sample rate. once the client is activated
(see below), you should rely on your own sample rate
callback (see above) for this value.
*/
jack_srate = jack_get_sample_rate (client);
FLUID_LOG (FLUID_DBG, "Jack engine sample rate: %lu", jack_srate);
fluid_settings_getnum (settings, "synth.sample-rate", &sample_rate);
if ((int)sample_rate != jack_srate) {
/* There's currently no way to change the sampling rate of the
synthesizer after it's been created. */
FLUID_LOG(FLUID_WARN, "Jack sample rate mismatch, expect tuning issues"
" (synth.sample-rate=%lu, jackd=%lu)", (int)sample_rate, jack_srate);
}
/* connect the ports. */
@ -255,13 +412,13 @@ new_fluid_jack_audio_driver2(fluid_settings_t* settings, fluid_audio_func_t func
/* find some physical ports and connect to them */
fluid_settings_getint (settings, "audio.jack.autoconnect", &autoconnect);
if (autoconnect) {
jack_ports = jack_get_ports (dev->client, NULL, NULL, JackPortIsInput|JackPortIsPhysical);
jack_ports = jack_get_ports (client, NULL, NULL, JackPortIsInput|JackPortIsPhysical);
if (jack_ports) {
int err;
int connected = 0;
for (i = 0; jack_ports[i] && i<2 * dev->num_output_ports; ++i) {
err = jack_connect (dev->client, jack_port_name(dev->output_ports[i]), jack_ports[i]);
err = jack_connect (client, jack_port_name(dev->output_ports[i]), jack_ports[i]);
if (err) {
FLUID_LOG(FLUID_ERR, "Error connecting jack port");
} else {
@ -276,11 +433,6 @@ new_fluid_jack_audio_driver2(fluid_settings_t* settings, fluid_audio_func_t func
}
return (fluid_audio_driver_t*) dev;
error_recovery:
delete_fluid_jack_audio_driver((fluid_audio_driver_t*) dev);
return NULL;
}
/*
@ -291,77 +443,103 @@ delete_fluid_jack_audio_driver(fluid_audio_driver_t* p)
{
fluid_jack_audio_driver_t* dev = (fluid_jack_audio_driver_t*) p;
if (dev == NULL) {
return 0;
}
if (dev == NULL) return 0;
if (dev->client != 0) {
jack_client_close(dev->client);
}
if (dev->client_ref != NULL)
fluid_jack_client_close (dev->client_ref, dev);
if (dev->output_bufs) {
FLUID_FREE(dev->output_bufs);
}
if (dev->output_bufs)
FLUID_FREE (dev->output_bufs);
if (dev->output_ports) {
FLUID_FREE(dev->output_ports);
}
if (dev->output_ports)
FLUID_FREE (dev->output_ports);
FLUID_FREE(dev);
return 0;
}
/* Process function for audio and MIDI Jack drivers */
int
fluid_jack_audio_driver_process(jack_nframes_t nframes, void *arg)
fluid_jack_driver_process (jack_nframes_t nframes, void *arg)
{
fluid_jack_audio_driver_t* dev = (fluid_jack_audio_driver_t*) arg;
fluid_jack_client_t *client = (fluid_jack_client_t *)arg;
fluid_jack_audio_driver_t *audio_driver;
fluid_jack_midi_driver_t *midi_driver;
float *left, *right;
int i, k;
if (dev->callback!=NULL) {
int i;
for (i = 0; i < dev->num_output_ports*2; i++) {
dev->output_bufs[i] = (float*) jack_port_get_buffer(dev->output_ports[i], nframes);
jack_midi_event_t midi_event;
fluid_midi_event_t *evt;
void *midi_buffer;
jack_nframes_t event_count;
jack_nframes_t event_index;
unsigned int u;
/* Process MIDI events first, so that they take effect before audio synthesis */
midi_driver = fluid_atomic_pointer_get (&client->midi_driver);
if (midi_driver)
{
midi_buffer = jack_port_get_buffer (midi_driver->midi_port, 0);
event_count = jack_midi_get_event_count (midi_buffer);
for (event_index = 0; event_index < event_count; event_index++)
{
jack_midi_event_get (&midi_event, midi_buffer, event_index);
/* let the parser convert the data into events */
for (u = 0; u < midi_event.size; u++)
{
evt = fluid_midi_parser_parse (midi_driver->parser, midi_event.buffer[u]);
/* send the event to the next link in the chain */
if (evt != NULL) midi_driver->driver.handler (midi_driver->driver.data, evt);
}
}
return (*dev->callback)(dev->data, nframes,
0, NULL, 2 * dev->num_output_ports, dev->output_bufs);
}
if (dev->num_output_ports == 1) {
float *left;
float *right;
left = (float*) jack_port_get_buffer(dev->output_ports[0], nframes);
right = (float*) jack_port_get_buffer(dev->output_ports[1], nframes);
audio_driver = client->audio_driver;
if (!audio_driver) return 0;
fluid_synth_write_float(dev->data, nframes, left, 0, 1, right, 0, 1);
if (audio_driver->callback != NULL)
{
for (i = 0; i < audio_driver->num_output_ports * 2; i++)
audio_driver->output_bufs[i] = (float *)jack_port_get_buffer (audio_driver->output_ports[i], nframes);
} else {
return (*audio_driver->callback)(audio_driver->data, nframes, 0, NULL,
2 * audio_driver->num_output_ports,
audio_driver->output_bufs);
}
else if (audio_driver->num_output_ports == 1)
{
left = (float*) jack_port_get_buffer (audio_driver->output_ports[0], nframes);
right = (float*) jack_port_get_buffer (audio_driver->output_ports[1], nframes);
int i, k;
for (i = 0, k = dev->num_output_ports; i < dev->num_output_ports; i++, k++) {
dev->output_bufs[i] = (float*) jack_port_get_buffer(dev->output_ports[2*i], nframes);
dev->output_bufs[k] = (float*) jack_port_get_buffer(dev->output_ports[2*i+1], nframes);
fluid_synth_write_float (audio_driver->data, nframes, left, 0, 1, right, 0, 1);
}
else
{
for (i = 0, k = audio_driver->num_output_ports; i < audio_driver->num_output_ports; i++, k++) {
audio_driver->output_bufs[i] = (float *)jack_port_get_buffer (audio_driver->output_ports[2*i], nframes);
audio_driver->output_bufs[k] = (float *)jack_port_get_buffer (audio_driver->output_ports[2*i+1], nframes);
}
fluid_synth_nwrite_float(dev->data, nframes,
dev->output_bufs,
dev->output_bufs + dev->num_output_ports,
NULL, NULL);
fluid_synth_nwrite_float (audio_driver->data, nframes, audio_driver->output_bufs,
audio_driver->output_bufs + audio_driver->num_output_ports, NULL, NULL);
}
return 0;
}
int
fluid_jack_audio_driver_bufsize(jack_nframes_t nframes, void *arg)
fluid_jack_driver_bufsize(jack_nframes_t nframes, void *arg)
{
/* printf("the maximum buffer size is now %lu\n", nframes); */
return 0;
}
int
fluid_jack_audio_driver_srate(jack_nframes_t nframes, void *arg)
fluid_jack_driver_srate(jack_nframes_t nframes, void *arg)
{
/* printf("the sample rate is now %lu/sec\n", nframes); */
/* FIXME: change the sample rate of the synthesizer! */
@ -369,7 +547,7 @@ fluid_jack_audio_driver_srate(jack_nframes_t nframes, void *arg)
}
void
fluid_jack_audio_driver_shutdown(void *arg)
fluid_jack_driver_shutdown(void *arg)
{
// fluid_jack_audio_driver_t* dev = (fluid_jack_audio_driver_t*) arg;
FLUID_LOG(FLUID_ERR, "Help! Lost the connection to the JACK server");
@ -391,27 +569,19 @@ new_fluid_jack_midi_driver (fluid_settings_t *settings,
handle_midi_event_func_t handler, void *data)
{
fluid_jack_midi_driver_t* dev;
char *client_name;
char name[64];
char *server;
/* not much use doing anything */
if (handler == NULL)
{
FLUID_LOG(FLUID_ERR, "Invalid argument");
return NULL;
}
fluid_return_val_if_fail (handler != NULL, NULL);
/* allocate the device */
dev = FLUID_NEW(fluid_jack_midi_driver_t);
dev = FLUID_NEW (fluid_jack_midi_driver_t);
if (dev == NULL)
{
FLUID_LOG(FLUID_ERR, "Out of memory");
FLUID_LOG (FLUID_ERR, "Out of memory");
return NULL;
}
FLUID_MEMSET(dev, 0, sizeof(fluid_jack_midi_driver_t));
FLUID_MEMSET (dev, 0, sizeof (fluid_jack_midi_driver_t));
dev->driver.handler = handler;
dev->driver.data = data;
@ -421,75 +591,31 @@ new_fluid_jack_midi_driver (fluid_settings_t *settings,
if (dev->parser == NULL)
{
FLUID_LOG(FLUID_ERR, "Out of memory");
goto error_recovery;
FLUID_LOG (FLUID_ERR, "Out of memory");
FLUID_FREE (dev);
return NULL;
}
/* try to become a client of the JACK server */
dev->client_ref = new_fluid_jack_client (settings, FALSE, dev);
if (fluid_settings_dupstr(settings, "midi.jack.id", &client_name) /* ++ alloc client name */
&& (client_name != NULL)
&& (strlen(client_name) > 0))
snprintf(name, 64, "%s", client_name);
else snprintf(name, 64, "fluidsynth-midi");
name[63] = '\0';
if (client_name) FLUID_FREE (client_name); /* -- free client name */
fluid_settings_dupstr (settings, "audio.jack.server", &server);
if (server && server[0] != '\0')
dev->client = jack_client_open (name, JackServerName, NULL, server);
else dev->client = jack_client_open (name, JackNullOption, NULL);
if (server) FLUID_FREE (server);
if (dev->client == NULL) {
FLUID_LOG(FLUID_ERR, "Jack server not running?");
goto error_recovery;
}
jack_set_process_callback (dev->client, fluid_jack_midi_driver_process, dev);
dev->midi_port = jack_port_register (dev->client, "midi",
JACK_DEFAULT_MIDI_TYPE,
JackPortIsInput | JackPortIsTerminal, 0);
if (!dev->midi_port)
if (!dev->client_ref)
{
FLUID_LOG (FLUID_ERR, "Failed to create Jack MIDI port");
goto error_recovery;
}
/* tell the JACK server that we are ready to roll */
if (jack_activate (dev->client) != 0)
{
FLUID_LOG (FLUID_ERR, "Failed to activate FluidSynth Jack MIDI driver");
goto error_recovery;
FLUID_FREE (dev);
return NULL;
}
return (fluid_midi_driver_t *)dev;
error_recovery:
delete_fluid_jack_midi_driver((fluid_midi_driver_t *)dev);
return NULL;
}
/*
* delete_fluid_jack_midi_driver
*/
int
delete_fluid_jack_midi_driver(fluid_midi_driver_t *p)
{
fluid_jack_midi_driver_t* dev;
fluid_jack_midi_driver_t *dev = (fluid_jack_midi_driver_t *)p;
dev = (fluid_jack_midi_driver_t *)p;
if (dev == NULL) return FLUID_OK;
if (dev == NULL)
return FLUID_OK;
if (dev->client != NULL)
jack_client_close (dev->client);
if (dev->client_ref != NULL)
fluid_jack_client_close (dev->client_ref, dev);
if (dev->parser != NULL)
delete_fluid_midi_parser (dev->parser);
@ -498,37 +624,3 @@ delete_fluid_jack_midi_driver(fluid_midi_driver_t *p)
return FLUID_OK;
}
/*
* fluid_jack_midi_driver_process
*/
static int
fluid_jack_midi_driver_process (jack_nframes_t nframes, void *arg)
{
fluid_jack_midi_driver_t *dev = (fluid_jack_midi_driver_t *)arg;
jack_midi_event_t midi_event;
fluid_midi_event_t *evt;
void *midi_buffer;
jack_nframes_t event_count;
jack_nframes_t event_index;
unsigned int i;
midi_buffer = jack_port_get_buffer (dev->midi_port, 0);
event_count = jack_midi_get_event_count (midi_buffer);
for (event_index = 0; event_index < event_count; event_index++)
{
jack_midi_event_get (&midi_event, midi_buffer, event_index);
/* let the parser convert the data into events */
for (i = 0; i < midi_event.size; i++)
{
evt = fluid_midi_parser_parse (dev->parser, midi_event.buffer[i]);
/* send the event to the next link in the chain */
if (evt != NULL) dev->driver.handler (dev->driver.data, evt);
}
}
return 0;
}

View file

@ -714,9 +714,14 @@ new_fluid_timer (int msec, fluid_timer_callback_t callback, void* data,
int
delete_fluid_timer (fluid_timer_t *timer)
{
int auto_destroy = timer->auto_destroy;
timer->cont = 0;
fluid_timer_join (timer);
if (!timer->auto_destroy) FLUID_FREE (timer);
/* Shouldn't access timer now if auto_destroy enabled, since it has been destroyed */
if (!auto_destroy) FLUID_FREE (timer);
return FLUID_OK;
}