yquake2/yquake2remaster
0
0
Fork 0
mirror of https://github.com/yquake2/yquake2remaster.git synced 2024-11-30 00:10:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix potential memory leak in R_Upload8() in GL1.

Browse source 
This is a corner case, next to unlikely that anyone would have ever hit
it. That's why my tests with asan didn't find the leak. The if case are
paletted textures which must be enabled by setting `gl1_palettedtexture`
to 1 and requires an GPU with support for `GL_EXT_paletted_texture`.
Nvidia dropped support for that in 2005. Additionally a sky texture
must be uploaded.
This commit is contained in:
Yamagi 2021-11-01 18:42:40 +01:00
parent b16b1b13d0
commit 8bb845b037
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/client/refresh/gl1/gl1_image.c
View file

@ -786,7 +786,6 @@ qboolean
R_Upload8(byte *data, int width, int height, qboolean mipmap, qboolean is_sky) R_Upload8(byte *data, int width, int height, qboolean mipmap, qboolean is_sky)
{ {
int s = width * height; int s = width * height;
unsigned *trans = malloc(s * sizeof(unsigned));
if (gl_config.palettedtexture && is_sky) if (gl_config.palettedtexture && is_sky)
{ {
@ -801,6 +800,8 @@ R_Upload8(byte *data, int width, int height, qboolean mipmap, qboolean is_sky)
} }
else else
{ {
unsigned *trans = malloc(s * sizeof(unsigned));
for (int i = 0; i < s; i++) for (int i = 0; i < s; i++)
{ {
int p = data[i]; int p = data[i];