yquake2/yquake2remaster
0
0
Fork 0
mirror of https://github.com/yquake2/yquake2remaster.git synced 2025-01-31 21:30:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix potential overflow on env vars settings.

Browse source 
changing a bit Q_strlcpy flow as it can report wrong bytes copied
if src > buffer size.
This commit is contained in:
David CARLIER 2023-05-14 09:23:51 +01:00
parent e0dd7c9d00
commit 07553f0980
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/client/cl_main.c
View file

@ -270,13 +270,13 @@ CL_Setenv_f(void)
char buffer[1000]; char buffer[1000];
int i; int i;
strcpy(buffer, Cmd_Argv(1)); Q_strlcpy(buffer, Cmd_Argv(1), sizeof(buffer));
strcat(buffer, "="); Q_strlcat(buffer, "=", sizeof(buffer));
for (i = 2; i < argc; i++) for (i = 2; i < argc; i++)
{ {
strcat(buffer, Cmd_Argv(i)); Q_strlcat(buffer, Cmd_Argv(i), sizeof(buffer));
strcat(buffer, " "); Q_strlcat(buffer, " ", sizeof(buffer));
} }
putenv(buffer); putenv(buffer);