qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-02-25 13:11:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

[qfcc] Switch is_lvalue to use bool instead of int

Browse source 
Self documentation for the win.
This commit is contained in:
Bill Currie 2024-11-13 12:13:05 +09:00
parent 6649d8238e
commit e4e04b183a
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/qfcc/include/expr.h
View file

@ -1004,7 +1004,7 @@ const expr_t *build_for_statement (const expr_t *init, const expr_t *test,
const expr_t *continue_label); const expr_t *continue_label);
const expr_t *build_state_expr (const expr_t *e); const expr_t *build_state_expr (const expr_t *e);
const expr_t *think_expr (struct symbol_s *think_sym); const expr_t *think_expr (struct symbol_s *think_sym);
int is_lvalue (const expr_t *expr) __attribute__((pure)); bool is_lvalue (const expr_t *expr) __attribute__((pure));
const expr_t *assign_expr (const expr_t *dst, const expr_t *src); const expr_t *assign_expr (const expr_t *dst, const expr_t *src);
const expr_t *cast_expr (const type_t *t, const expr_t *e); const expr_t *cast_expr (const type_t *t, const expr_t *e);
const expr_t *cast_error (const expr_t *e, const type_t *t1, const type_t *t2); const expr_t *cast_error (const expr_t *e, const type_t *t1, const type_t *t2);

18
tools/qfcc/source/expr_assign.c
View file

@ -81,7 +81,7 @@ check_assign_logic_precedence (const expr_t *dst, const expr_t *src)
return 0; return 0;
} }
int bool
is_lvalue (const expr_t *expr) is_lvalue (const expr_t *expr)
{ {
switch (expr->type) { switch (expr->type) {
@ -90,21 +90,21 @@ is_lvalue (const expr_t *expr)
case ex_symbol: case ex_symbol:
return expr->symbol->lvalue; return expr->symbol->lvalue;
case ex_temp: case ex_temp:
return 1; return true;
case ex_expr: case ex_expr:
if (expr->expr.op == '.') { if (expr->expr.op == '.') {
return 1; return true;
} }
break; break;
case ex_alias: case ex_alias:
return is_lvalue (expr->alias.expr); return is_lvalue (expr->alias.expr);
case ex_address: case ex_address:
return 0; return false;
case ex_assign: case ex_assign:
return 0; return false;
case ex_uexpr: case ex_uexpr:
if (expr->expr.op == '.') { if (expr->expr.op == '.') {
return 1; return true;
} }
break; break;
case ex_branch: case ex_branch:
@ -138,13 +138,13 @@ is_lvalue (const expr_t *expr)
return (is_lvalue (expr->cond.true_expr) return (is_lvalue (expr->cond.true_expr)
&& is_lvalue (expr->cond.false_expr)); && is_lvalue (expr->cond.false_expr));
case ex_field: case ex_field:
return 1; return true;
case ex_array: case ex_array:
return 1; return true;
case ex_count: case ex_count:
internal_error (expr, "invalid expression"); internal_error (expr, "invalid expression");
} }
return 0; return false;
} }
static const expr_t * static const expr_t *