qf
/
quakeforge
mirror of https://git.code.sf.net/p/quake/quakeforge
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix the micro-optimization that avoided emitting x = x 

The check was broken by alias defs. If a def is aliased, the alias must be
checked.
This commit is contained in:
Bill Currie 2011-01-12 23:33:51 +09:00
parent c787923c99
commit 96ba4605fa
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/qfcc/source/emit.c
View File

@ -253,7 +253,7 @@ emit_function_call (expr_t *e, def_t *dest)
static def_t * static def_t *
emit_assign_expr (int oper, expr_t *e) emit_assign_expr (int oper, expr_t *e)
{ {
def_t *def_a, *def_b, *def_c; def_t *def_a, *def_b, *def_c, *a, *b;
opcode_t *op; opcode_t *op;
expr_t *e1 = e->e.expr.e1; expr_t *e1 = e->e.expr.e1;
expr_t *e2 = e->e.expr.e2; expr_t *e2 = e->e.expr.e2;
@ -288,7 +288,13 @@ emit_assign_expr (int oper, expr_t *e)
} }
} }
def_b = emit_sub_expr (e2, def_a); def_b = emit_sub_expr (e2, def_a);
if (def_b != def_a) { a = def_a;
if (a->alias)
a = a->alias;
b = def_b;
if (b->alias)
b = b->alias;
if (b != a) {
op = opcode_find (operator, def_b->type, def_a->type, op = opcode_find (operator, def_b->type, def_a->type,
&type_invalid); &type_invalid);
emit_statement (e, op, def_b, def_a, 0); emit_statement (e, op, def_b, def_a, 0);