qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-02-24 20:51:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

[vulkan] Fix some out-by-one errors

Browse source 
I don't know why I thought <= was useful in those loops. Fixes some
segfaults for incorrect references.
This commit is contained in:
Bill Currie 2023-12-15 23:52:34 +09:00
parent fa6598c389
commit 24aa81e085
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
libs/video/renderer/vulkan/render_load.c
View file

@ -230,7 +230,7 @@ find_imageinfo (qfv_jobinfo_t *jobinfo, const qfv_reference_t *ref)
//job->image_views[i].image_view.external_image = image;
//job->image_views[i].image_view.image = -1;
} else {
for (uint32_t i = 0; i <= jobinfo->num_images; i++) {
for (uint32_t i = 0; i < jobinfo->num_images; i++) {
auto img = &jobinfo->images[i];
if (strcmp (ref->name, img->name) == 0) {
return img;
@ -244,7 +244,7 @@ find_imageinfo (qfv_jobinfo_t *jobinfo, const qfv_reference_t *ref)
static qfv_imageviewinfo_t * __attribute__((pure))
find_imageviewinfo (qfv_jobinfo_t *jobinfo, const qfv_reference_t *ref)
{
for (uint32_t i = 0; i <= jobinfo->num_imageviews; i++) {
for (uint32_t i = 0; i < jobinfo->num_imageviews; i++) {
auto imgview = &jobinfo->imageviews[i];
if (strcmp (ref->name, imgview->name) == 0) {
return imgview;
@ -388,7 +388,7 @@ find_subpass (qfv_dependencyinfo_t *d, uint32_t spind,
if (strcmp (d->name, "$external") == 0) {
return VK_SUBPASS_EXTERNAL;
}
for (uint32_t i = 0; i <= spind; i++) {
for (uint32_t i = 0; i < spind; i++) {
__auto_type s = &subpasses[i];
if (strcmp (d->name, s->name) == 0) {
return i;