qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-05-30 08:20:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

[cvar] Make cvars properly typed

Browse source 
This is an extremely extensive patch as it hits every cvar, and every
usage of the cvars. Cvars no longer store the value they control,
instead, they use a cexpr value object to reference the value and
specify the value's type (currently, a null type is used for strings).
Non-string cvars are passed through cexpr, allowing expressions in the
cvars' settings. Also, cvars have returned to an enhanced version of the
original (id quake) registration scheme.

As a minor benefit, relevant code having direct access to the
cvar-controlled variables is probably a slight optimization as it
removed a pointer dereference, and the variables can be located for data
locality.

The static cvar descriptors are made private as an additional safety
layer, though there's nothing stopping external modification via
Cvar_FindVar (which is needed for adding listeners).

While not used yet (partly due to working out the design), cvars can
have a validation function.

Registering a cvar allows a primary listener (and its data) to be
specified: it will always be called first when the cvar is modified. The
combination of proper listeners and direct access to the controlled
variable greatly simplifies the more complex cvar interactions as much
less null checking is required, and there's no need for one cvar's
callback to call another's.

nq-x11 is known to work at least well enough for the demos. More testing
will come.
This commit is contained in:
Bill Currie 2022-04-23 12:22:45 +09:00
parent 87b3c64801
commit 12c84046f3
240 changed files with 8069 additions and 4224 deletions
Download patch file Download diff file Expand all files Collapse all files

31
qw/include/client.h
View file

@ -257,28 +257,28 @@ typedef struct client_state_s {
/*
cvars
*/
extern struct cvar_s *cl_netgraph;
extern struct cvar_s *cl_netgraph_height;
extern struct cvar_s *cl_netgraph_alpha;
extern struct cvar_s *cl_netgraph_box;
extern int cl_netgraph;
extern int cl_netgraph_height;
extern float cl_netgraph_alpha;
extern int cl_netgraph_box;
extern struct cvar_s *cl_draw_locs;
extern struct cvar_s *cl_shownet;
extern int cl_draw_locs;
extern int cl_shownet;
extern struct cvar_s *cl_name;
extern char *cl_name;
extern struct cvar_s *cl_model_crcs;
extern int cl_model_crcs;
extern struct cvar_s *rate;
extern float rate;
extern struct cvar_s *hud_ping;
extern struct cvar_s *hud_pl;
extern int hud_ping;
extern int hud_pl;
extern struct cvar_s *skin;
extern char *skin;
extern struct cvar_s *cl_fb_players;
extern float cl_fb_players;
extern struct cvar_s *hud_scoreboard_uid;
extern int hud_scoreboard_uid;
extern client_state_t cl;
@ -294,7 +294,8 @@ extern int fps_count;
extern struct cbuf_s *cl_cbuf;
extern struct cbuf_s *cl_stbuf;
void Cvar_Info (struct cvar_s *var);
struct cvar_s;
void Cvar_Info (void *data, const struct cvar_s *cvar);
extern struct view_s *cl_netgraph_view;
void CL_NetGraph (struct view_s *view);