qf
/
quakeforge
mirror of https://git.code.sf.net/p/quake/quakeforge
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

make integer constant division warnings optional

This commit is contained in:
Bill Currie 2001-12-12 22:00:42 +00:00
parent 2db08923e8
commit 112f74a357
3 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/qfcc/include/qfcc.h
View File

@ -603,6 +603,7 @@ typedef struct {
qboolean undefined_function; // Warn on undefined function use qboolean undefined_function; // Warn on undefined function use
qboolean uninited_variable; // Warn on use of uninitialized vars qboolean uninited_variable; // Warn on use of uninitialized vars
qboolean vararg_integer; // Warn on passing an integer to vararg func qboolean vararg_integer; // Warn on passing an integer to vararg func
qboolean integer_divide; // Warn on integer constant division
} warn_options_t; } warn_options_t;
typedef struct { typedef struct {

2
tools/qfcc/source/expr.c
View File

@ -736,6 +736,7 @@ do_op_integer (int op, expr_t *e1, expr_t *e2)
e1->e.integer_val *= i2; e1->e.integer_val *= i2;
break; break;
case '/': case '/':
if (options.warnings.integer_divide)
warning (e2, "%d / %d == %d", i1, i2, i1 / i2); warning (e2, "%d / %d == %d", i1, i2, i1 / i2);
e1->e.integer_val /= i2; e1->e.integer_val /= i2;
break; break;
@ -812,6 +813,7 @@ do_op_uinteger (int op, expr_t *e1, expr_t *e2)
e1->e.uinteger_val *= i2; e1->e.uinteger_val *= i2;
break; break;
case '/': case '/':
if (options.warnings.integer_divide)
warning (e2, "%d / %d == %d", i1, i2, i1 / i2); warning (e2, "%d / %d == %d", i1, i2, i1 / i2);
e1->e.uinteger_val /= i2; e1->e.uinteger_val /= i2;
break; break;

6
tools/qfcc/source/qfcc.c
View File

@ -793,11 +793,13 @@ DecodeArgs (int argc, char **argv)
options.warnings.undefined_function = true; options.warnings.undefined_function = true;
options.warnings.uninited_variable = true; options.warnings.uninited_variable = true;
options.warnings.vararg_integer = true; options.warnings.vararg_integer = true;
options.warnings.integer_divide = true;
} else if (!(strcasecmp (temp, "none"))) { } else if (!(strcasecmp (temp, "none"))) {
options.warnings.cow = false; options.warnings.cow = false;
options.warnings.undefined_function = false; options.warnings.undefined_function = false;
options.warnings.uninited_variable = false; options.warnings.uninited_variable = false;
options.warnings.vararg_integer = false; options.warnings.vararg_integer = false;
options.warnings.integer_divide = false;
} else if (!(strcasecmp (temp, "cow"))) { } else if (!(strcasecmp (temp, "cow"))) {
options.warnings.cow = true; options.warnings.cow = true;
} else if (!(strcasecmp (temp, "no-cow"))) { } else if (!(strcasecmp (temp, "no-cow"))) {
@ -818,6 +820,10 @@ DecodeArgs (int argc, char **argv)
options.warnings.vararg_integer = true; options.warnings.vararg_integer = true;
} else if (!(strcasecmp (temp, "no-vararg-integer"))) { } else if (!(strcasecmp (temp, "no-vararg-integer"))) {
options.warnings.vararg_integer = false; options.warnings.vararg_integer = false;
} else if (!(strcasecmp (temp, "integer-divide"))) {
options.warnings.integer_divide = true;
} else if (!(strcasecmp (temp, "no-integer-divide"))) {
options.warnings.integer_divide = false;
} }
temp = strtok (NULL, ","); temp = strtok (NULL, ",");
} }