Fixed some bugs in idSysSignal.

neo/idlib/Thread.h

@@ -138,127 +138,17 @@ class idSysSignal
 public:
 	static const int	WAIT_INFINITE = -1;
 
-	idSysSignal( bool manualReset = false )
-	{
-		pthread_mutexattr_t attr;
+	idSysSignal( bool manualReset = false );
+	~idSysSignal();
 
-		pthread_mutexattr_init( &attr );
-		pthread_mutexattr_settype( &attr, PTHREAD_MUTEX_ERRORCHECK );
-		pthread_mutex_init( &mutex, &attr );
-		pthread_mutexattr_destroy( &attr );
+	void	Raise();
 
-		pthread_cond_init( &cond, NULL );
-
-		signaled = false;
-		waiting = false;
-	}
-
-	~idSysSignal()
-	{
-		pthread_cond_destroy( &cond );
-	}
-
-	void	Raise()
-	{
-		pthread_mutex_lock( &mutex );
-
-		if( waiting )
-		{
-			pthread_cond_signal( &cond );
-		}
-		else
-		{
-			// emulate Windows behaviour: if no thread is waiting, leave the signal on so next wait keeps going
-			signaled = true;
-		}
-
-		pthread_mutex_unlock( &mutex );
-	}
-
-	void	Clear()
-	{
-		pthread_mutex_lock( &mutex );
-
-		signaled = false;
-
-		pthread_mutex_unlock( &mutex );
-	}
+	void	Clear();
 
 	// Wait returns true if the object is in a signalled state and
 	// returns false if the wait timed out. Wait also clears the signalled
 	// state when the signalled state is reached within the time out period.
-	bool	Wait( int timeout = WAIT_INFINITE )
-	{
-		pthread_mutex_lock( &mutex );
-
-		//DWORD result = WaitForSingleObject( handle, timeout == idSysSignal::WAIT_INFINITE ? INFINITE : timeout );
-		//assert( result == WAIT_OBJECT_0 || ( timeout != idSysSignal::WAIT_INFINITE && result == WAIT_TIMEOUT ) );
-		//return ( result == WAIT_OBJECT_0 );
-
-		int result = 1;
-
-		/*
-		Return Value
-
-		Except in the case of [ETIMEDOUT], all these error checks shall act as if they were performed immediately at the beginning of processing for the function and shall cause an error return, in effect, prior to modifying the state of the mutex specified by mutex or the condition variable specified by cond.
-
-		Upon successful completion, a value of zero shall be returned; otherwise, an error number shall be returned to indicate the error.
-
-		Errors
-
-		The pthread_cond_timedwait() function shall fail if:
-
-		ETIMEDOUT
-			The time specified by abstime to pthread_cond_timedwait() has passed.
-
-		The pthread_cond_timedwait() and pthread_cond_wait() functions may fail if:
-
-		EINVAL
-			The value specified by cond, mutex, or abstime is invalid.
-		EINVAL
-			Different mutexes were supplied for concurrent pthread_cond_timedwait() or pthread_cond_wait() operations on the same condition variable.
-		EPERM
-			The mutex was not owned by the current thread at the time of the call.
-		 */
-
-		assert( !waiting );	// WaitForEvent from multiple threads? that wouldn't be good
-		if( signaled )
-		{
-			// emulate Windows behaviour: signal has been raised already. clear and keep going
-			signaled = false;
-			result = 0;
-		}
-		else
-		{
-			waiting = true;
-#if 0
-			result = pthread_cond_wait( &cond, &mutex );
-#else
-			if( timeout == WAIT_INFINITE )
-			{
-				result = pthread_cond_wait( &cond, &mutex );
-
-				assert( result == 0 );
-			}
-			else
-			{
-				timespec ts;
-				clock_gettime( CLOCK_REALTIME, &ts );
-
-				ts.tv_nsec += ( timeout * 1000000 );
-
-				result = pthread_cond_timedwait( &cond, &mutex, &ts );
-
-				assert( result == 0 || ( timeout != idSysSignal::WAIT_INFINITE && result == ETIMEDOUT ) );
-			}
-#endif
-			waiting = false;
-		}
-
-		pthread_mutex_unlock( &mutex );
-
-		return ( result == 0 );
-	}
+	bool	Wait( int timeout = WAIT_INFINITE );
 
 private:
 	pthread_mutex_t	mutex;

neo/idlib/sys/posix/posix_thread.cpp

@@ -119,9 +119,10 @@ void Sys_DestroyThread( uintptr_t threadHandle )
 	}
 	
 	char	name[128];
+	name[0] = '\0';
 	pthread_getname_np( threadHandle, name, sizeof( name ) );
 	
-#if !defined(__ANDROID__)
+#if 1 //!defined(__ANDROID__)
 	if( pthread_cancel( ( pthread_t )threadHandle ) != 0 )
 	{
 		idLib::common->FatalError( "ERROR: pthread_cancel %s failed\n", name );
@@ -152,6 +153,128 @@ void Sys_Yield()
 ================================================================================================
 */
 
+idSysSignal::idSysSignal( bool manualReset )
+{
+	pthread_mutexattr_t attr;
+
+	//pthread_mutexattr_init( &attr );
+	pthread_mutexattr_settype( &attr, PTHREAD_MUTEX_ERRORCHECK );
+	pthread_mutexattr_settype( &attr, PTHREAD_MUTEX_DEFAULT );
+	pthread_mutex_init( &mutex, &attr );
+	pthread_mutexattr_destroy( &attr );
+
+	pthread_cond_init( &cond, NULL );
+
+	signaled = false;
+	waiting = false;
+}
+
+idSysSignal::~idSysSignal()
+{
+	pthread_cond_destroy( &cond );
+}
+
+void idSysSignal::Raise()
+{
+	pthread_mutex_lock( &mutex );
+
+	if( waiting )
+	{
+		pthread_cond_signal( &cond );
+	}
+	else
+	{
+		// emulate Windows behaviour: if no thread is waiting, leave the signal on so next wait keeps going
+		signaled = true;
+	}
+
+	pthread_mutex_unlock( &mutex );
+}
+
+void idSysSignal::Clear()
+{
+	pthread_mutex_lock( &mutex );
+
+	signaled = false;
+
+	pthread_mutex_unlock( &mutex );
+}
+
+// Wait returns true if the object is in a signalled state and
+// returns false if the wait timed out. Wait also clears the signalled
+// state when the signalled state is reached within the time out period.
+bool idSysSignal::Wait( int timeout )
+{
+	pthread_mutex_lock( &mutex );
+
+	//DWORD result = WaitForSingleObject( handle, timeout == idSysSignal::WAIT_INFINITE ? INFINITE : timeout );
+	//assert( result == WAIT_OBJECT_0 || ( timeout != idSysSignal::WAIT_INFINITE && result == WAIT_TIMEOUT ) );
+	//return ( result == WAIT_OBJECT_0 );
+
+	int result = 0;
+
+	/*
+	Return Value
+
+	Except in the case of [ETIMEDOUT], all these error checks shall act as if they were performed immediately at the beginning of processing for the function and shall cause an error return, in effect, prior to modifying the state of the mutex specified by mutex or the condition variable specified by cond.
+
+	Upon successful completion, a value of zero shall be returned; otherwise, an error number shall be returned to indicate the error.
+
+	Errors
+
+	The pthread_cond_timedwait() function shall fail if:
+
+	ETIMEDOUT
+		The time specified by abstime to pthread_cond_timedwait() has passed.
+
+	The pthread_cond_timedwait() and pthread_cond_wait() functions may fail if:
+
+	EINVAL
+		The value specified by cond, mutex, or abstime is invalid.
+	EINVAL
+		Different mutexes were supplied for concurrent pthread_cond_timedwait() or pthread_cond_wait() operations on the same condition variable.
+	EPERM
+		The mutex was not owned by the current thread at the time of the call.
+	 */
+
+	assert( !waiting );	// WaitForEvent from multiple threads? that wouldn't be good
+	if( signaled )
+	{
+		// emulate Windows behaviour: signal has been raised already. clear and keep going
+		signaled = false;
+		result = 0;
+	}
+	else
+	{
+		waiting = true;
+#if 0
+		result = pthread_cond_wait( &cond, &mutex );
+#else
+		if( timeout == WAIT_INFINITE )
+		{
+			result = pthread_cond_wait( &cond, &mutex );
+
+			assert( result == 0 );
+		}
+		else
+		{
+			timespec ts;
+			clock_gettime( CLOCK_REALTIME, &ts );
+
+			ts.tv_nsec += ( timeout * 1000000 );
+
+			result = pthread_cond_timedwait( &cond, &mutex, &ts );
+
+			assert( result == 0 || ( timeout != idSysSignal::WAIT_INFINITE && result == ETIMEDOUT ) );
+		}
+#endif
+		waiting = false;
+	}
+
+	pthread_mutex_unlock( &mutex );
+
+	return ( result == 0 );
+}
 /*
 ================================================================================================
 
@@ -193,7 +316,7 @@ Sys_MutexLock
 */
 bool Sys_MutexLock( mutexHandle_t& handle, bool blocking )
 {
-	if( pthread_mutex_trylock( &handle ) == 0 )
+	if( pthread_mutex_trylock( &handle ) != 0 )
 	{
 		if( !blocking )
 		{

neo/idlib/sys/sys_threading.h

@@ -47,7 +47,7 @@ typedef LONG					interlockedInt_t;
 #else
 typedef pthread_mutex_t			mutexHandle_t;
 typedef pthread_cond_t			signalHandle_t;
-typedef unsigned long			interlockedInt_t;
+typedef int						interlockedInt_t;
 #endif
 // RB end