Commit graph

199 commits

Author SHA1 Message Date
Wolfgang Lux
fbf8c3edb5 Fix incorrect assignment in last commit.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29162 72102866-910b-0410-8b05-ffd578937521
2009-12-22 23:27:56 +00:00
Wolfgang Lux
f1f4f87395 Usability improvement: A single click into a cell of an unselected row
of a table view now can change the cell's state even when the table
view allows dragging.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29161 72102866-910b-0410-8b05-ffd578937521
2009-12-22 23:21:40 +00:00
Quentin Mathe
0f48d893e8 Corrected table view to support drop on root with -1 as the drop row (as
explained in the Cocoa documentation).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29137 72102866-910b-0410-8b05-ffd578937521
2009-12-17 13:51:40 +00:00
Wolfgang Lux
786f376f1b Fix various issues when drawing controls with edited cells. This
includes a fix for the problem of properly resizing and redrawing the
editor when the cell is resized or moved during editing (bug #22678).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29133 72102866-910b-0410-8b05-ffd578937521
2009-12-17 01:03:07 +00:00
Quentin Mathe
19dad5cba6 Modified the drag code to call -canDragRowsWithIndexes:atPoint: as expected
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29100 72102866-910b-0410-8b05-ffd578937521
2009-12-05 23:22:39 +00:00
Richard Frith-MacDonald
8a7cfaf918 fix drawing bug when number of rows decreases
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29065 72102866-910b-0410-8b05-ffd578937521
2009-11-26 20:33:44 +00:00
Fred Kiefer
17ef668924 Move corner view drawing into GSTheme.
Add new 10.3 methods for NSTableHeaderCell.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28985 72102866-910b-0410-8b05-ffd578937521
2009-11-09 14:53:59 +00:00
Richard Frith-MacDonald
452ffee567 Small theme update, plus documentation fixes and tweaks to avoid warnings.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28538 72102866-910b-0410-8b05-ffd578937521
2009-08-25 07:46:37 +00:00
Fred Kiefer
e00133c375 * Source/NSTableView.m (-_editPreviousEditableCellBeforeRow:column:,
-_editNextEditableCellAfterRow:column:): Comment out the loop
around of the last change. This leads to wrong results, when the
table view isn't the only view in the window.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28383 72102866-910b-0410-8b05-ffd578937521
2009-07-06 14:21:22 +00:00
Fred Kiefer
1dc747bf5d Better implementation of changing the edited cell in a table view.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28381 72102866-910b-0410-8b05-ffd578937521
2009-07-05 21:52:17 +00:00
Fred Kiefer
45726cd72c Compare row against _numberOfRows not _numberOfColumns.
Patch by Tim Schmielau <tim@smmo.org>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28379 72102866-910b-0410-8b05-ffd578937521
2009-07-05 09:45:18 +00:00
Gregory John Casamento
8369481079 * Source/NSScrollView.m: If the scrollview has scrollers,
don't pay attention to the hidden flag in nib loading.
	* Source/NSTableView.m: if the table has a cornerview, don't
	pay attention to the hidden flag in nib loading.  
	NOTE: In both instances it appears that Cocoa sets the hidden flag 
	when autohide is set to true.   GNUstep handles this case differently,
	so it's okay to ignore this flag when the scroller is in an
	NSScrollView.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28231 72102866-910b-0410-8b05-ffd578937521
2009-04-19 03:23:11 +00:00
Richard Frith-MacDonald
25dc9dc650 fix for bug #25553 reported by Lu Liyi
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27842 72102866-910b-0410-8b05-ffd578937521
2009-02-11 08:32:50 +00:00
Gregory John Casamento
8e20be5f2d * Source/NSTableView.m: Switch to the alternate highlighting color
only when the background is white.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27252 72102866-910b-0410-8b05-ffd578937521
2008-12-08 03:44:52 +00:00
Gregory John Casamento
5518bc8938 * Source/NSTableView.m: Change highlighting color so that it shows
on both white and grey backgrounds.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27251 72102866-910b-0410-8b05-ffd578937521
2008-12-08 03:26:23 +00:00
Adam Fedor
7afdd32ac1 Revert library license version to 2 until applications can be converted
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26619 72102866-910b-0410-8b05-ffd578937521
2008-06-10 04:01:49 +00:00
Fred Kiefer
1a9a9468c0 Check in the control not in the text field whether the cell is currently
being edited.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26613 72102866-910b-0410-8b05-ffd578937521
2008-06-09 10:04:49 +00:00
Fred Kiefer
0cb8c36a82 Don't raise exception on invalid row or column indexes for table view.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26486 72102866-910b-0410-8b05-ffd578937521
2008-05-03 18:05:07 +00:00
Fred Kiefer
0cba457027 Better check for click on table column border.
Allow table column identifier to be nil.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26482 72102866-910b-0410-8b05-ffd578937521
2008-05-01 19:48:28 +00:00
Fred Kiefer
68fc3bc403 Made data source method optional on NSTableView.
Add marker objects for KVB.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25751 72102866-910b-0410-8b05-ffd578937521
2007-12-17 13:35:31 +00:00
Fred Kiefer
8730f4cab8 Allow table views without header.
Popup buttons no longer display values from old menus after a change.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25702 72102866-910b-0410-8b05-ffd578937521
2007-12-07 18:46:27 +00:00
Fred Kiefer
3cbe23c511 Patch for bezier path encoding.
Add support for new dragging methods in table view.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25660 72102866-910b-0410-8b05-ffd578937521
2007-12-02 20:43:32 +00:00
Fred Kiefer
74841fc8ad Add MacOS 10.4 methods.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25653 72102866-910b-0410-8b05-ffd578937521
2007-12-01 22:15:48 +00:00
Richard Frith-MacDonald
03a4a96a40 Update includes ... closer MacOS-X compatibility.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25635 72102866-910b-0410-8b05-ffd578937521
2007-11-29 20:28:03 +00:00
Fred Kiefer
00a7c05d91 Add binding implementation.
Clean up table view decoding.
Move image draw code to back.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25602 72102866-910b-0410-8b05-ffd578937521
2007-11-22 12:15:50 +00:00
Fred Kiefer
5ddb7aac7c Two small patches by Wolfgang Lux <wolfgang.lux@gmail.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25549 72102866-910b-0410-8b05-ffd578937521
2007-11-01 10:15:35 +00:00
Fred Kiefer
193e31e678 Change all files to use GPL 3 and LGPL 3.
Prepare for next release.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25536 72102866-910b-0410-8b05-ffd578937521
2007-10-29 21:16:17 +00:00
Gregory John Casamento
13d360fed5 Correction for bug#21445. Reverted change to validateEditing to correct crashes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25535 72102866-910b-0410-8b05-ffd578937521
2007-10-28 05:46:13 +00:00
Fred Kiefer
3b7fca1db8 Correct flip adjustment for table header.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25533 72102866-910b-0410-8b05-ffd578937521
2007-10-27 14:38:59 +00:00
Fred Kiefer
8ecf8c2aed Patches by Wolfgang Lux <wolfgang.lux@gmail.com>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25526 72102866-910b-0410-8b05-ffd578937521
2007-10-11 20:55:21 +00:00
Fred Kiefer
dc55ca286e Small corrections to recent changes.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25481 72102866-910b-0410-8b05-ffd578937521
2007-09-13 19:13:46 +00:00
Fred Kiefer
ae19679271 Patches partly by Andreas Höschler <ahoesch@smartsoft.de>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25476 72102866-910b-0410-8b05-ffd578937521
2007-09-11 12:13:35 +00:00
Fred Kiefer
b3dc35f126 Editing patches partly by Andreas Höschler <ahoesch@smartsoft.de>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25426 72102866-910b-0410-8b05-ffd578937521
2007-08-31 10:52:52 +00:00
Fred Kiefer
cc412d3a43 Set the background colour of the text object and make it draw its
background.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25091 72102866-910b-0410-8b05-ffd578937521
2007-04-27 14:15:39 +00:00
Fred Kiefer
01e550219a Corrected handling of _allowsEmptySelection in noteNumberOfRowsChanged.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25070 72102866-910b-0410-8b05-ffd578937521
2007-04-24 19:09:10 +00:00
Matt Rice
7030dbfbb9 * Source/NSTableView.m (-_numRows): New quasi private method.
(-noteNumberOfRowsChanged:): Call _numRows instead of data source
        method.
        * Source/NSOutlineView.m (-noteNumberOfRowsChanged:): Don't override
        supers.
        (-_numRows): Implement.
        (-collapseItem:collapseChildren:): Remove use of _selectedObjects.
        (-expandItem:expandChildren:): Ditto.
        (-_removeChildren:): Ditto.
        (-initWithFrame:): Don't initialize _selectedObjects.
        (-initWithCoder:): Ditto.
        * Headers/AppKit/NSOutlineView.h: Mark _selectedObjects as unused.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24478 72102866-910b-0410-8b05-ffd578937521
2007-02-06 01:07:44 +00:00
Matt Rice
1c2821470e * Source/NSTableView (-mouseDown:): Release oldSelectedRows.
Mark done as yes instead of returning early, and avoid sending action
        multiple times.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24469 72102866-910b-0410-8b05-ffd578937521
2007-02-05 08:04:10 +00:00
Matt Rice
2d12498c2e * Source/NSTableView (-mouseDown:): Compute the selection immediately
instead of at the end of the loop.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24468 72102866-910b-0410-8b05-ffd578937521
2007-02-05 06:15:42 +00:00
Matt Rice
16fcaeab83 * Source/NSTableView.m (-mouseDown:): Return early after tracking a
cell which prefersTrackingUntilMouseUp.
        * Source/NSPopUpButtonCell.m (+prefersTrackingUntilMouseUp:): Return
        yes.
        (-trackMouse:inRect:ofView:untilMouseUp:): Return yes or no
        depending on whether the mouse went up inside the menu or not.
        Fixes bug #18946



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24465 72102866-910b-0410-8b05-ffd578937521
2007-02-04 12:53:49 +00:00
Matt Rice
0a9783724b * Source/NSTableView.m: Revert previous patch.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24431 72102866-910b-0410-8b05-ffd578937521
2007-01-30 03:37:11 +00:00
Matt Rice
c222792abd * Source/NSTableView.m (-textDidEndEditing:): Add missing break
to previous commit.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24426 72102866-910b-0410-8b05-ffd578937521
2007-01-28 21:00:11 +00:00
Matt Rice
a4eddcb158 * Source/NSTableView.m (-textDidEndEditing:): Handle
NSIllegalTextMovement.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24425 72102866-910b-0410-8b05-ffd578937521
2007-01-28 18:20:54 +00:00
Fred Kiefer
91dccc4280 Mark for redisplay when selecting or deselecting the whole table.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24403 72102866-910b-0410-8b05-ffd578937521
2007-01-23 15:46:42 +00:00
Fred Kiefer
ebc0de97f3 Added MacOSX 10.4 methods to NSControl and reworked the whole cell
editing mechanism.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24380 72102866-910b-0410-8b05-ffd578937521
2007-01-18 17:24:33 +00:00
Matt Rice
a61f6e5479 * Source/NSTableView.m (rectOfColumn:): Use the height of the rows,
not the bounds.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24290 72102866-910b-0410-8b05-ffd578937521
2006-12-28 23:18:44 +00:00
Matt Rice
640612f030 * Source/NSTableView.m (_trackCellAtColumn:row:withEvent:):
Remove check for column editablity.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24152 72102866-910b-0410-8b05-ffd578937521
2006-11-23 11:57:03 +00:00
Matt Rice
4475b975b8 * Source/NSTableView.m (-noteNumberOfRowsChanged:): Post selection
is and did change notifications if changing the selected rows.
        * Source/NSSliderCell.m (-copyWithZone:): Make a little clearer.
        * Source/NSMatrix.m (-_rebuildLayoutAfterResize): Don't change the
        intercell spacing if not autosizing cells.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24080 72102866-910b-0410-8b05-ffd578937521
2006-11-13 05:23:24 +00:00
Matt Rice
84a0a59321 * Source/NSOutlineView.m: Handle rowAtPoint: returning -1.
* Source/NSTableView.m (drawRect:): Only call
        -highlightSelectionInClipRect: and -drawGridInClipRect: once.
        (-drawGridInClipRect:): Constrain the vertical grid line to the last
	 row drawn in the rect.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24071 72102866-910b-0410-8b05-ffd578937521
2006-11-10 19:12:32 +00:00
Matt Rice
86c8735342 * Source/NSTableView.m (rowAtPoint:): Return -1 if the point is under
the last row.
        (mouseDown:): Handle rowAtPoint: returning -1.
        (rectOfRows:): Ditto.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24070 72102866-910b-0410-8b05-ffd578937521
2006-11-10 17:05:20 +00:00
Matt Rice
edf055a980 * Source/NSTableView.m (mouseDown:): Rename some local variables
to be less ambiguous.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24068 72102866-910b-0410-8b05-ffd578937521
2006-11-10 14:35:31 +00:00