fredkiefer
30240921b4
First batch of corrections based on David's static analysis.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31337 72102866-910b-0410-8b05-ffd578937521
2010-09-12 16:34:22 +00:00
wlux
26c6942f2d
Fix bug where the _selectedRow attribute of an NSTableView could be
...
updated incorrectly.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31207 72102866-910b-0410-8b05-ffd578937521
2010-08-30 06:59:00 +00:00
wlux
10c98c9b2f
Correct serious nib loading bug on big endian machines.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30472 72102866-910b-0410-8b05-ffd578937521
2010-05-29 08:32:02 +00:00
fredkiefer
cec34abb20
Remove compiler warnings from clang.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30117 72102866-910b-0410-8b05-ffd578937521
2010-04-10 17:48:46 +00:00
fredkiefer
3d559c477e
Yet another set of #include -> #import replacement.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30083 72102866-910b-0410-8b05-ffd578937521
2010-03-31 08:14:50 +00:00
gcasa
025a72aaca
* Source/NSTableView.m: Add nil check to make sure that the
...
nil values set for certain keys don't get set since they are
normally set by connections later in the nib loading process.
I'm not sure why IB includes these when they're set to nil.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30082 72102866-910b-0410-8b05-ffd578937521
2010-03-31 04:02:03 +00:00
jonathanosx
808f778c16
Don't attempt to add a nil sort descriptor
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@30005 72102866-910b-0410-8b05-ffd578937521
2010-03-19 23:39:07 +00:00
qmathe
43c76c02df
Fixed table header/content random disappearance with unarchived table/outline
...
views.
NSTableView non-keyed unarchiving was not always initializing _columnOrigins.
NSScrollView keyed unarchiving was decoding non-encoded flags (the flags were
thus initialized with random memory content).
See ChangeLog for detailed explanations.
Also added double action keyed archiving to NSTableView.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29494 72102866-910b-0410-8b05-ffd578937521
2010-02-06 11:32:34 +00:00
qmathe
b5d13a91db
Fixed sort direction stuck to the reverse of the sort descriptor prototype
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29298 72102866-910b-0410-8b05-ffd578937521
2010-01-16 22:43:31 +00:00
qmathe
ec403f1296
Rewrote _selectColumn:modifiers: to be simpler, support selection by range as
...
Cocoa does, and remove the toggle selection behavior when a column is clicked
twice (in conflict with the ability to change the sort direction).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29296 72102866-910b-0410-8b05-ffd578937521
2010-01-16 20:29:59 +00:00
qmathe
239eec74dc
Finished to implement the NSTable/OutlineView sort descriptor support.
...
More changes are needed to get proper sorting support (e.g. visual feedback).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29293 72102866-910b-0410-8b05-ffd578937521
2010-01-16 14:45:13 +00:00
qmathe
6dd84b196f
Added -columnIndexesInRect: and updated documentation
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29175 72102866-910b-0410-8b05-ffd578937521
2009-12-27 16:05:48 +00:00
wlux
b16ee73226
Fix incorrect assignment in last commit.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29162 72102866-910b-0410-8b05-ffd578937521
2009-12-22 23:27:56 +00:00
wlux
bd09833337
Usability improvement: A single click into a cell of an unselected row
...
of a table view now can change the cell's state even when the table
view allows dragging.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29161 72102866-910b-0410-8b05-ffd578937521
2009-12-22 23:21:40 +00:00
qmathe
78dcbb6c4e
Corrected table view to support drop on root with -1 as the drop row (as
...
explained in the Cocoa documentation).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29137 72102866-910b-0410-8b05-ffd578937521
2009-12-17 13:51:40 +00:00
wlux
68b0f819f2
Fix various issues when drawing controls with edited cells. This
...
includes a fix for the problem of properly resizing and redrawing the
editor when the cell is resized or moved during editing (bug #22678 ).
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29133 72102866-910b-0410-8b05-ffd578937521
2009-12-17 01:03:07 +00:00
qmathe
cd86476602
Modified the drag code to call -canDragRowsWithIndexes:atPoint: as expected
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29100 72102866-910b-0410-8b05-ffd578937521
2009-12-05 23:22:39 +00:00
rfm
82d1ada3dc
fix drawing bug when number of rows decreases
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@29065 72102866-910b-0410-8b05-ffd578937521
2009-11-26 20:33:44 +00:00
fredkiefer
48bf51f21c
Move corner view drawing into GSTheme.
...
Add new 10.3 methods for NSTableHeaderCell.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28985 72102866-910b-0410-8b05-ffd578937521
2009-11-09 14:53:59 +00:00
rfm
f48b5d132e
Small theme update, plus documentation fixes and tweaks to avoid warnings.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28538 72102866-910b-0410-8b05-ffd578937521
2009-08-25 07:46:37 +00:00
fredkiefer
b6208240c8
* Source/NSTableView.m (-_editPreviousEditableCellBeforeRow:column:,
...
-_editNextEditableCellAfterRow:column:): Comment out the loop
around of the last change. This leads to wrong results, when the
table view isn't the only view in the window.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28383 72102866-910b-0410-8b05-ffd578937521
2009-07-06 14:21:22 +00:00
fredkiefer
0e7730756b
Better implementation of changing the edited cell in a table view.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28381 72102866-910b-0410-8b05-ffd578937521
2009-07-05 21:52:17 +00:00
fredkiefer
fc7b0dd25d
Compare row against _numberOfRows not _numberOfColumns.
...
Patch by Tim Schmielau <tim@smmo.org>.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28379 72102866-910b-0410-8b05-ffd578937521
2009-07-05 09:45:18 +00:00
gcasa
6ea6f0f5e2
* Source/NSScrollView.m: If the scrollview has scrollers,
...
don't pay attention to the hidden flag in nib loading.
* Source/NSTableView.m: if the table has a cornerview, don't
pay attention to the hidden flag in nib loading.
NOTE: In both instances it appears that Cocoa sets the hidden flag
when autohide is set to true. GNUstep handles this case differently,
so it's okay to ignore this flag when the scroller is in an
NSScrollView.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@28231 72102866-910b-0410-8b05-ffd578937521
2009-04-19 03:23:11 +00:00
rfm
bee145baba
fix for bug #25553 reported by Lu Liyi
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27842 72102866-910b-0410-8b05-ffd578937521
2009-02-11 08:32:50 +00:00
gcasa
1fafb8ade5
* Source/NSTableView.m: Switch to the alternate highlighting color
...
only when the background is white.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27252 72102866-910b-0410-8b05-ffd578937521
2008-12-08 03:44:52 +00:00
gcasa
15e5e645fb
* Source/NSTableView.m: Change highlighting color so that it shows
...
on both white and grey backgrounds.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@27251 72102866-910b-0410-8b05-ffd578937521
2008-12-08 03:26:23 +00:00
fedor
ce41d782c1
Revert library license version to 2 until applications can be converted
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26619 72102866-910b-0410-8b05-ffd578937521
2008-06-10 04:01:49 +00:00
fredkiefer
d2cdcf7415
Check in the control not in the text field whether the cell is currently
...
being edited.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26613 72102866-910b-0410-8b05-ffd578937521
2008-06-09 10:04:49 +00:00
fredkiefer
c6ff462516
Don't raise exception on invalid row or column indexes for table view.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26486 72102866-910b-0410-8b05-ffd578937521
2008-05-03 18:05:07 +00:00
fredkiefer
676eb09e4f
Better check for click on table column border.
...
Allow table column identifier to be nil.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@26482 72102866-910b-0410-8b05-ffd578937521
2008-05-01 19:48:28 +00:00
fredkiefer
2cb413a872
Made data source method optional on NSTableView.
...
Add marker objects for KVB.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25751 72102866-910b-0410-8b05-ffd578937521
2007-12-17 13:35:31 +00:00
fredkiefer
1da7d6f33f
Allow table views without header.
...
Popup buttons no longer display values from old menus after a change.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25702 72102866-910b-0410-8b05-ffd578937521
2007-12-07 18:46:27 +00:00
fredkiefer
e82473deaa
Patch for bezier path encoding.
...
Add support for new dragging methods in table view.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25660 72102866-910b-0410-8b05-ffd578937521
2007-12-02 20:43:32 +00:00
fredkiefer
81385cfc14
Add MacOS 10.4 methods.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25653 72102866-910b-0410-8b05-ffd578937521
2007-12-01 22:15:48 +00:00
rfm
efe3ed5993
Update includes ... closer MacOS-X compatibility.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25635 72102866-910b-0410-8b05-ffd578937521
2007-11-29 20:28:03 +00:00
fredkiefer
e2f2a194e6
Add binding implementation.
...
Clean up table view decoding.
Move image draw code to back.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25602 72102866-910b-0410-8b05-ffd578937521
2007-11-22 12:15:50 +00:00
fredkiefer
eb23e9991d
Two small patches by Wolfgang Lux <wolfgang.lux@gmail.com>.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25549 72102866-910b-0410-8b05-ffd578937521
2007-11-01 10:15:35 +00:00
fredkiefer
e25cceb710
Change all files to use GPL 3 and LGPL 3.
...
Prepare for next release.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25536 72102866-910b-0410-8b05-ffd578937521
2007-10-29 21:16:17 +00:00
gcasa
67c9a282d8
Correction for bug#21445. Reverted change to validateEditing to correct crashes.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25535 72102866-910b-0410-8b05-ffd578937521
2007-10-28 05:46:13 +00:00
fredkiefer
a32ea9627a
Correct flip adjustment for table header.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25533 72102866-910b-0410-8b05-ffd578937521
2007-10-27 14:38:59 +00:00
fredkiefer
a503b7d0a2
Patches by Wolfgang Lux <wolfgang.lux@gmail.com>.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25526 72102866-910b-0410-8b05-ffd578937521
2007-10-11 20:55:21 +00:00
fredkiefer
b8a916ee31
Small corrections to recent changes.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25481 72102866-910b-0410-8b05-ffd578937521
2007-09-13 19:13:46 +00:00
fredkiefer
339e3acbef
Patches partly by Andreas Höschler <ahoesch@smartsoft.de>.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25476 72102866-910b-0410-8b05-ffd578937521
2007-09-11 12:13:35 +00:00
fredkiefer
ddb1df7caa
Editing patches partly by Andreas Höschler <ahoesch@smartsoft.de>.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25426 72102866-910b-0410-8b05-ffd578937521
2007-08-31 10:52:52 +00:00
fredkiefer
fca5bf9954
Set the background colour of the text object and make it draw its
...
background.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25091 72102866-910b-0410-8b05-ffd578937521
2007-04-27 14:15:39 +00:00
fredkiefer
7b3e14d77f
Corrected handling of _allowsEmptySelection in noteNumberOfRowsChanged.
...
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@25070 72102866-910b-0410-8b05-ffd578937521
2007-04-24 19:09:10 +00:00
ratmice
76c79cb918
* Source/NSTableView.m (-_numRows): New quasi private method.
...
(-noteNumberOfRowsChanged:): Call _numRows instead of data source
method.
* Source/NSOutlineView.m (-noteNumberOfRowsChanged:): Don't override
supers.
(-_numRows): Implement.
(-collapseItem:collapseChildren:): Remove use of _selectedObjects.
(-expandItem:expandChildren:): Ditto.
(-_removeChildren:): Ditto.
(-initWithFrame:): Don't initialize _selectedObjects.
(-initWithCoder:): Ditto.
* Headers/AppKit/NSOutlineView.h: Mark _selectedObjects as unused.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24478 72102866-910b-0410-8b05-ffd578937521
2007-02-06 01:07:44 +00:00
ratmice
332f75de55
* Source/NSTableView (-mouseDown:): Release oldSelectedRows.
...
Mark done as yes instead of returning early, and avoid sending action
multiple times.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24469 72102866-910b-0410-8b05-ffd578937521
2007-02-05 08:04:10 +00:00
ratmice
e0eb8df6e9
* Source/NSTableView (-mouseDown:): Compute the selection immediately
...
instead of at the end of the loop.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@24468 72102866-910b-0410-8b05-ffd578937521
2007-02-05 06:15:42 +00:00