Benjamin Johnson
1f7f4cd40f
Fix typo in intrinsic and address comments
2023-05-28 22:10:14 +00:00
Benjamin Johnson
2e98bd5366
Implement layout constraint conversion to internal solver constraints
2023-05-28 18:33:44 +10:00
Benjamin Johnson
0c493d9e7a
Address PR feedback on #181
2023-05-09 06:26:26 +10:00
Benjamin Johnson
bddf6cfd03
Implement GSCSConstraint and suppoorting classes
2023-05-07 08:01:25 +10:00
Benjamin Johnson
2be7334ce2
Implement part of GSAutoLayoutEngine dependency management logic ( #178 )
...
* Implement part of GSAutoLayoutEngine dependency management logic
* Fix formatting of GSAutoLayoutEngine, GSCSFloatComparator and GSCSSolution
* Address PR feedback
* Address PR feedback
* Replace assignment with ASSIGN macro and fix makefile
* Add back dealloc in GSAutoLayoutEngine.m and GSCSSolution.m
2023-04-19 09:06:53 +02:00
Gregory John Casamento
5c098cc539
Minor fix in glyph info
2023-04-09 21:09:22 -04:00
Gregory Casamento
e64d8d4b02
Merge pull request #170 from gnustep/NSDictionaryController2_branch
2023-03-24 18:33:52 -04:00
Gregory John Casamento
58748243d5
Update per comments by Fred before merge
2023-03-24 17:57:29 -04:00
Gregory Casamento
81f21e2094
Merge pull request #172 from BennyKJohnson/bootstrap-layout-engine
2023-03-17 14:11:20 -04:00
Riccardo
62d16bff24
Implement acceptsFirstMouse so to return YES, otherwise tablees in new windows do not get mouse selection events. ( #173 )
...
Seems to match Apple's implementation.
2023-03-02 12:13:50 +01:00
Benjamin Johnson
708f7c337e
Address feedback on bootstrap layout engine PR
2023-03-01 18:57:08 +11:00
Gregory Casamento
09e9cc0330
Update NSDictionaryController.m. Correct removeObjects:
2023-02-28 16:58:21 -05:00
Gregory John Casamento
99e921ea35
Fix type issue with getting value from KVP in a couple of places and fix memory issue with NSDictionaryControllerKeyValuePair
2023-02-28 03:55:34 -05:00
Gregory John Casamento
dcf5fbe74b
Update using rearrangeObjects, clean up white space for review
2023-02-28 03:42:43 -05:00
Gregory John Casamento
b9841fe493
Update build array to properly exclude keys
2023-02-28 03:33:50 -05:00
Benjamin Johnson
7b9bede733
Improve memory management with layout engine
2023-02-28 19:18:52 +11:00
Gregory John Casamento
08fc055321
Override addObject(s):, removeObject(s): update _contentDictionary
2023-02-28 03:17:07 -05:00
Gregory John Casamento
99e25244af
Remove uneeded bind: code
2023-02-28 00:40:40 -05:00
Benjamin Johnson
f6f1a7ef82
Remove unnecessary check for _layoutEngine
2023-02-27 21:39:14 +00:00
Benjamin Johnson
2a1c0f88b3
Move layoutEngine ownership to NSWindow
2023-02-27 19:56:37 +11:00
Benjamin Johnson
93769f3a52
Implement bootstrapping auto layout
2023-02-27 17:46:39 +11:00
Gregory John Casamento
5799e4a9c7
Update how key/value is generated in newObject
2023-02-24 17:54:17 -05:00
Gregory John Casamento
917585cfab
Update how key/value is generated in newObject
2023-02-24 17:51:54 -05:00
Gregory John Casamento
3fdccf627e
Add code to handle strings->dictionary and dictionary->strings for setLocalizedKeyTable/Dictionary methods
2023-02-24 17:38:30 -05:00
Gregory John Casamento
0d5ab325ab
update bind:toObject:withKeyPath:options: method for all bindings, sort resulting array of NSDictionaryControllerKeyValuePair objects by key value
2023-02-23 18:39:06 -05:00
Gregory John Casamento
386bec0435
use superclass implementation of valueClassForBinding:
2023-02-23 16:17:44 -05:00
Gregory John Casamento
728968505e
Get rid of white space and minor cleanup
2023-02-23 16:17:44 -05:00
Gregory John Casamento
2b20808ddd
Add preserves_selection encoding/decoding
2023-02-23 16:17:44 -05:00
Gregory John Casamento
c1ad87a546
Eliminate white space, some experimental changes
2023-02-23 16:17:44 -05:00
Gregory John Casamento
8de600877b
simplify existing implementation of dictionary controller
2023-02-23 16:17:44 -05:00
Gregory John Casamento
7250e3fac1
Remove uneeded GSObservableDictionary class declaration and implementation, start to diagnose and fix the issue with NSDictionaryController
2023-02-23 16:17:44 -05:00
Gregory John Casamento
c6c0dc7c3f
Expose more bindings and override some methods from NSArrayController
2023-02-23 16:17:44 -05:00
Gregory John Casamento
03f1ddecd5
latest changes
2023-02-23 16:17:44 -05:00
Gregory John Casamento
5958734de0
Implement NSDictionaryControllerKeyValuePair. Add implementation for the rest of the methods.
2023-02-23 16:17:44 -05:00
Gregory John Casamento
8760ff9b7b
Add externs for key bindings.
2023-02-23 16:17:44 -05:00
Gregory John Casamento
3d850f7eae
Add method definitions.
2023-02-23 16:17:44 -05:00
Gregory John Casamento
67966d6cdd
Initial template for NSDictionaryController
2023-02-23 16:17:44 -05:00
Benjamin Johnson
928dd71439
Fix whitespace between argument in method call
2023-02-23 01:29:28 +00:00
Benjamin Johnson
75fcf49b62
Refactor layout core methods implementation to use ivars
2023-02-20 18:09:23 +11:00
Benjamin Johnson
571ad7a613
Implement supporting core layout methods on NSView
2023-02-19 15:21:13 +11:00
Fred Kiefer
72b05b514a
Merge pull request #169 from BennyKJohnson/nsautoresizingMaskLayoutConstraint
...
Implement NSAutoresizingMaskLayoutConstraint class
2023-02-17 19:58:34 +01:00
Gregory John Casamento
95c7e31ccb
Remove uneeded item object
2023-02-12 15:32:21 -05:00
Gregory John Casamento
30c2f1da6b
Minor update, remove redundant setSelected: calls
2023-02-12 15:27:50 -05:00
Gregory John Casamento
ea398eab4c
Remove extra call to setSelected: in selectAll: deselectAll: etc methods, this should only happen in setSelectionIndexes and setSelectionIndexPaths
2023-02-12 14:25:36 -05:00
Gregory John Casamento
b6048a27f4
Run cleanup-whitespace in emacs to eliminate all extraneous whitespace
2023-02-12 14:19:37 -05:00
Gregory John Casamento
1c879a1522
Add private methods to internal private category
2023-02-12 09:55:29 -05:00
Gregory John Casamento
41e6a45e8d
Add private methods to internal private category
2023-02-12 09:33:48 -05:00
Gregory John Casamento
50889771d0
Fix issue with FOR_IN loop
2023-02-11 18:27:55 -05:00
Gregory John Casamento
2eb23858d6
Methods to keep selectionIndexes and selectionIndexPaths in sync per discussion with @fredkiefer
2023-02-11 18:20:36 -05:00
Benjamin Johnson
f46e6596cc
Make layout constraint attribute constants static and add comment for ordering
2023-02-12 08:47:55 +11:00
Gregory John Casamento
731f5a248d
Fix OVERIDDEN macro, override method in NSCollectionViewGridLayout
2023-02-09 14:39:37 -05:00
Gregory John Casamento
fd4b07ff09
Get rid of extranous include
2023-02-07 21:56:26 -05:00
Gregory John Casamento
b891dea575
Update as discussed, get rid of extra commented out code and of uneeded imports
2023-02-07 21:41:13 -05:00
Gregory John Casamento
0ad9143b39
Add better var names in flow layout
2023-02-07 21:39:05 -05:00
Gregory John Casamento
bb77c072cb
Correct spaces
2023-02-07 21:30:46 -05:00
Gregory John Casamento
4bcdf6f5d4
Fix issues mentioned by @fredkiefer in review, remove check in NSViewController
2023-02-07 21:27:39 -05:00
Gregory John Casamento
d6d2f430ad
Update encode/decode to remove unecessary 64bit call
2023-02-07 21:09:23 -05:00
Gregory John Casamento
2a33aab039
Update implemention suggested by @fredkiefer
2023-02-07 21:05:12 -05:00
Gregory John Casamento
7244519365
Change call indexPathsForVisibleSupplementaryElementsOfKind to call indexPathForItem: as suggested by @fredkiefer
2023-02-07 20:55:22 -05:00
Gregory John Casamento
330599e248
Inline the frame update
2023-02-04 11:37:36 -05:00
Gregory John Casamento
73759407bb
Add delegate call to collectionView:didSelectItemsAtIndexPaths:
2023-02-04 10:28:11 -05:00
Gregory John Casamento
ec6a845cb1
Suggestions by @fredkiefer, correct spacing and fix comment
2023-02-04 09:39:48 -05:00
Gregory John Casamento
99103a83dc
Fix more suggestions by @fredkiefer. Add AUTORELEASE for nib, generate indexes for visible items
2023-02-04 09:31:13 -05:00
Gregory John Casamento
cf16dde246
Update selectAll:, deselectAll:, selectItemsAtIndexPaths:..., deselectItemsAtPaths: to correctly update setSelectionIndexPaths:
2023-02-04 07:41:42 -05:00
Benjamin Johnson
4fec29a66b
Implement NSAutoresizingMaskLayoutConstraint class
2023-02-04 19:24:03 +11:00
Gregory John Casamento
e754180dcf
Add OVERRIDDEN macro per suggestion from @fredkiefer
2023-01-30 18:12:53 -05:00
Gregory John Casamento
19e8a48ba3
Add APPKIT_DECLARE
2023-01-30 10:48:03 -05:00
Gregory John Casamento
4e49c2a8cf
Add APPKIT_DECLARE
2023-01-30 10:48:03 -05:00
Gregory John Casamento
8afffbb121
Fix leak and add to maps in makeItemWithIdentifier:forIndexPath:, per review
2023-01-30 10:48:03 -05:00
Gregory John Casamento
cd52649076
Fix encoding issue, formatting issues, per review
2023-01-30 10:48:03 -05:00
Gregory John Casamento
d4d60dd5de
Remove strange comment, per review
2023-01-30 10:48:03 -05:00
Gregory John Casamento
e1fa590102
Remove commented out code, per review
2023-01-30 10:48:03 -05:00
Gregory John Casamento
dd01e8b59b
Correct formatting, per review
2023-01-30 10:48:03 -05:00
Gregory John Casamento
c7c6d887e2
Correct formatting, per review
2023-01-30 10:48:03 -05:00
Gregory John Casamento
c7c3c65f4e
Correct formatting, per review
2023-01-30 10:48:03 -05:00
Gregory John Casamento
03cbc95076
Remove log per review by @fredkiefer
2023-01-30 10:48:03 -05:00
Gregory John Casamento
20a59e45b5
Add code to call viewWillLoad/viewDidLoad into loadView
2023-01-30 10:48:03 -05:00
Gregory John Casamento
5e5e2bd317
Add proper error
2023-01-30 10:48:03 -05:00
Gregory John Casamento
cb8e805d0d
Add method to check if method is overriden on layout subclass
2023-01-30 10:48:03 -05:00
Gregory John Casamento
af643cc821
Fix externs for collection view, correct NSFontIdentityMatrix type
2023-01-30 10:48:03 -05:00
Gregory John Casamento
5612120c06
Remove extra #import directives
2023-01-30 10:48:03 -05:00
Gregory John Casamento
3e8b8386b1
Add correct API version defines for NSCollectionViewItem
2023-01-30 10:48:03 -05:00
Gregory John Casamento
fe2a988111
Fix duplicate _size and use the _frame in the attributes class
2023-01-30 10:48:03 -05:00
Gregory John Casamento
95fa4e0368
Add tracking view to allow easier selection
2023-01-30 10:48:03 -05:00
Gregory John Casamento
c95bbcf714
Changes to fix item selection when an NSImageView is present
2023-01-30 10:48:03 -05:00
Gregory John Casamento
7ee05a6869
Make sure to consider when view is flipped when calculating which indexPath was hit; minor cleanup of code; remove uneeded comments
2023-01-30 10:48:03 -05:00
Gregory John Casamento
bfa088fd0e
Fix size issue with flow view
2023-01-30 10:48:03 -05:00
Gregory John Casamento
3b44aa3608
Fix size issue with grid view
2023-01-30 10:48:03 -05:00
Gregory John Casamento
bbfa1d84bc
Fix proportions of each item
2023-01-30 10:48:03 -05:00
Gregory John Casamento
5ff478ac85
Fix implementation of resize when elements overflow the size of the view
2023-01-30 10:48:03 -05:00
Gregory Casamento
b96dbcba2e
Update GSXib5KeyedUnarchiver.m
...
Remove extra space.
2023-01-30 10:48:03 -05:00
Gregory John Casamento
627c51ec45
Changes to implement grid layout
2023-01-30 10:48:03 -05:00
Gregory John Casamento
a5b878c690
Implement selectAll:, deselectAll:, selectItemsAtIndex:..., deselectItemsAtIndexPaths:
2023-01-30 10:48:03 -05:00
Gregory John Casamento
e9e1615cdb
Don't update the delegate unless the selection actually changes
2023-01-30 10:48:03 -05:00
Gregory John Casamento
a6f83ab00b
Add code to clean up views when resizing. Prevent recursion. Call reload when 'tile' method is called
2023-01-30 10:48:03 -05:00
Gregory John Casamento
2d70c42790
Fix issue with loading collectionview. Correct sprious calls to reloadData and tile method. Fix call back to delegate when item is clicked
2023-01-30 10:48:03 -05:00
Gregory John Casamento
94f616436f
Add mapping to XmlKeyMapTable for NSBackroundColors
2023-01-30 10:48:03 -05:00
Gregory John Casamento
f1552faaee
Remove uneeded ivars, release maps
2023-01-30 10:48:03 -05:00
Gregory John Casamento
01ca2cb6c2
Fix compilation error in CI
2023-01-30 10:48:03 -05:00
Gregory John Casamento
2bec53bf0f
Switch to using maptables to track some metadata bout items so that we can match items up when we need to find them by indexPath or point. Remove uneeded ivar from layout. Add call to delegate when selecting item
2023-01-30 10:48:03 -05:00
