Commit graph

5428 commits

Author SHA1 Message Date
Wolfgang Lux
70fe303412 Prevent potential crashes due to invalid pointers left in text
containers and layout managers when their respective layout manager
and text storage are deallocated.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35178 72102866-910b-0410-8b05-ffd578937521
2012-06-05 11:34:02 +00:00
Wolfgang Lux
1dd7be22f7 Update text storage directly when undoing text changes in a NSTextView
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35175 72102866-910b-0410-8b05-ffd578937521
2012-06-02 22:31:54 +00:00
Gregory John Casamento
f8c5c4673d * Source/GSXibLoader.m:
Added NSMenu (XibCompatibility) category with method: _isMainMenu
	Added NSMenu (XibCompatibility) category implementation.
        Modified setting main menu in awake:inContainer:withContext:
	Fixes bug #36427
	Committed by: gcasa



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35159 72102866-910b-0410-8b05-ffd578937521
2012-05-21 17:56:05 +00:00
Fred Kiefer
82a110d152 * Headers/AppKit/NSInterfaceStyle.h: Remove GSNativeInterfaceStyle.
* Source/NSComboBoxCell.m (-encodeWithCoder:, -initWithCoder:):
Add a few more keyed coding values. Fixes bug #36426.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35146 72102866-910b-0410-8b05-ffd578937521
2012-05-07 20:21:59 +00:00
Fred Kiefer
023f0030e2 * Source/GSXibLoader.m: Add some (currently unused) helper code
for class substitution in flattenedProperties.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35138 72102866-910b-0410-8b05-ffd578937521
2012-05-05 16:49:43 +00:00
Fred Kiefer
74139f4848 * Source/NSPasteboard.m (NSURL-writeToPasteboard:): Revert the
last change.
* Source/NSWorkspace.m (-openURL:): Declare the URL pasteboard
type here.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35110 72102866-910b-0410-8b05-ffd578937521
2012-04-24 16:54:53 +00:00
Fred Kiefer
ea5e2a3c97 * Source/NSPasteboard.m (NSURL-writeToPasteboard:): Declare the type.
Patch by Andreas Schik <andreas.schik@web.de>.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35109 72102866-910b-0410-8b05-ffd578937521
2012-04-24 07:48:53 +00:00
Fred Kiefer
323e1dc02f * Source/NSTabView.m (+initialize): Increase version number.
* Source/NSTabView.m (-encodeWithCoder:, -decodeWithCoder:):
Clean up last patch.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35054 72102866-910b-0410-8b05-ffd578937521
2012-04-10 21:42:25 +00:00
Sebastian Reitenbach
e65c5bc665 some int/NSInteger to NSUInteger changes to better
match return values of methods

OK Fred Kiefer



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35052 72102866-910b-0410-8b05-ffd578937521
2012-04-10 07:16:36 +00:00
Fred Kiefer
4efed91607 * Source/NSMenuItem.m (GSMenuSeparator -classForCoder): Add
missing method to get separator coding correct.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35023 72102866-910b-0410-8b05-ffd578937521
2012-04-02 20:51:06 +00:00
Eric Wasylishen
c500d8379f * Source/NSCell.m (_updateFieldEditor:): Fix what I presume is
a typo. The "if (nil == _contents) { contents = @""; }" blocks were
dead code because the contents variable would later
be set to nil if _contents was nil. This was causing an exception
when starting editing an empty text field loaded from a xib.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35011 72102866-910b-0410-8b05-ffd578937521
2012-03-27 19:26:17 +00:00
Eric Wasylishen
a900e2f5cb * Headers/AppKit/NSSplitView.h:
* Source/NSSplitView.m: Add support for
splitView:shouldAdjustSizeOfSubview: delegate method.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35002 72102866-910b-0410-8b05-ffd578937521
2012-03-27 04:32:57 +00:00
Eric Wasylishen
32aa3f4c83 * Source/GSToolTips.m (-mouseEntered:): When calling the owner's
view:stringForToolTip:point:userData: method, make the point
relative to the view's coordinate system (tested on OS X) instead
of relative to the tracking rect (as before.)
* Source/GSToolTips.m (-_timedOut:): Fix a crash caused by
invalidating the timer and then using its userInfo object.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@35000 72102866-910b-0410-8b05-ffd578937521
2012-03-27 03:38:59 +00:00
Eric Wasylishen
62a3374ae9 * Source/NSAttributedString.m
(-initWithData:options:documentAttributes:error:): Set
NSCharacterEncodingDocumentAttribute in the documentAttributes dict
when reading plain text.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34987 72102866-910b-0410-8b05-ffd578937521
2012-03-23 03:16:40 +00:00
Eric Wasylishen
9345069a14 * Source/NSAttributedString.m
(-initWithData:options:documentAttributes:error:): Fixes for TextEdit.
If no type is provided, assume plain text. If no encoding is provided,
assume UTF-8 unless a UTF-16 BOM is detected.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34985 72102866-910b-0410-8b05-ffd578937521
2012-03-23 01:40:11 +00:00
Eric Wasylishen
93ca7c0e0e * Source/GSThemeDrawing.m (-toolbarBorderColor): Change default to
[NSColor darkGrayColor]
* Source/NSToolbar.m (-initWithIdentifier:): Call
[self setShowsBaselineSeparator: YES] by default so the toolbar has
a bottom border.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34983 72102866-910b-0410-8b05-ffd578937521
2012-03-22 23:11:44 +00:00
Fred Kiefer
e8d2648aca * Headers/AppKit/NSKeyValueBinding.h,
* Source/externs.m: Additional binding names.
* Source/GSBindingHelpers.h,
* Source/NSKeyValueBinding.m: Additional helper methods.
* Source/NSObjectController.m: Use helper methods.
* Source/NSArrayController.m: Signal when the arranged objects
change.
* Source/NSTableColumn.m,
* Source/NSTableView.m: First attempt at support for content
binding.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34923 72102866-910b-0410-8b05-ffd578937521
2012-03-12 12:24:17 +00:00
Eric Wasylishen
df87a9f362 * Source/NSTableView.m:
* Source/GSNibLoading.m: Move -[coder setClassName: @"_NSCornerView"
forClass: [GSTableCornerView class]] call from
-[NSTableView initWithCoder:] to GSNibLoading, because corner views
can be encountered before hitting -[NSTableView initWithCoder:]


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34919 72102866-910b-0410-8b05-ffd578937521
2012-03-09 23:18:18 +00:00
Eric Wasylishen
325a56881f * Source/NSClipView.m: Re-enable copy-on-scroll
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34918 72102866-910b-0410-8b05-ffd578937521
2012-03-09 22:28:59 +00:00
Eric Wasylishen
88fdeb6886 * Source/NSWindow.m: Only invoke -prepareForDragOperation: if the
most recent -draggingEntered: or -draggingUpdated: call returned
something other than NSDragOperationNone.
* Source/NSOutlineView.m (-draggingUpdated:): Save the drag operation
value returned from the data source in a static variable.
Previously it was fetched once and then discarded, so all drags were
being mistakenly permitted.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34910 72102866-910b-0410-8b05-ffd578937521
2012-03-09 08:03:45 +00:00
Fred Kiefer
37db8ec30e * Source/NSObjectController.m: Complete encoding/decoding methods.
* Headers/AppKit/NSArrayController.h,
* Source/NSArrayController.m: Add some implementation to this class.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34904 72102866-910b-0410-8b05-ffd578937521
2012-03-07 23:58:57 +00:00
Eric Wasylishen
733983d52b * Source/NSMenuItemCell.m (-titleRectForBounds:): Attempted fix
for bug 35702.
Don't use [_menuView imageAndTitleWidth] or
_titleWidth in calculating the size to put the title in. In other
words, -titleRectForBounds: will now return the available space
for the title, rather than the rect that the title text is
predicted to use up.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34885 72102866-910b-0410-8b05-ffd578937521
2012-03-06 04:24:51 +00:00
Gregory John Casamento
4193fb4122 * Headers/AppKit/NSTreeController.h
* Headers/AppKit/NSTreeNode.h
	* Source/NSTreeController.m: Add tree controller skeleton.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34847 72102866-910b-0410-8b05-ffd578937521
2012-02-29 15:32:09 +00:00
Gregory John Casamento
444f88c80c * Source/GNUmakefile: Add GSXibLoading.m file to GNUmakefile.
* Source/GSXibLoading.m: Add some classes which I found
	are relevant to Xib loading: IBAccessibilityAttribute,
	IBUserDefinedRuntimeAttributesPlaceholder.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34846 72102866-910b-0410-8b05-ffd578937521
2012-02-29 15:27:09 +00:00
Eric Wasylishen
fa247da211 * Source/NSPrintPanel.m: Add file type chooser (PDF, PostScript)
to save panel


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34844 72102866-910b-0410-8b05-ffd578937521
2012-02-28 07:22:16 +00:00
Eric Wasylishen
ac0663e17a * Source/NSMenuItemCell.m (-titleRectForBounds:): Keep title rect
inside cell bounds, to prevent drawing text outside of a
NSPopUpButtonCell which has a label that is too long to fit.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34838 72102866-910b-0410-8b05-ffd578937521
2012-02-28 00:13:04 +00:00
Fred Kiefer
3d73efb55c * Source/NSWindowController.m (-initWithWindow:): Set the owner to
self and only call setDocument: if we have an actual window.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34825 72102866-910b-0410-8b05-ffd578937521
2012-02-27 12:23:05 +00:00
Fred Kiefer
d3321c2ffa * Source/NSWindow.m (-setFrameFromString:): Correct bug in
handling of in-window menus.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34798 72102866-910b-0410-8b05-ffd578937521
2012-02-20 17:46:28 +00:00
Wolfgang Lux
44fb01a3fb Replace calls to private method -_setupForTypes: in NSOpenPanel, as
that method was removed from its superclass NSSavePanel.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34782 72102866-910b-0410-8b05-ffd578937521
2012-02-19 16:32:52 +00:00
Wolfgang Lux
1d0294acc2 Revert change from r34642 which has broken OS X compatibility and fix
sender of a pop up button's action when it is sent through one of the
menu items.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34781 72102866-910b-0410-8b05-ffd578937521
2012-02-19 16:22:49 +00:00
Fred Kiefer
e654c1c5b5 Replace NSCompositeHighlight with GSCompositeHighlight and map NSCompositeHighlight onto
NSCompositeSourceOver.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34773 72102866-910b-0410-8b05-ffd578937521
2012-02-18 21:10:07 +00:00
Fred Kiefer
4d8bbcfe9b * Source/NSBitmapImageRep.m (-_convertToFormatBitsPerSample:...bitsPerPixel:): Correct
handling of black data.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34762 72102866-910b-0410-8b05-ffd578937521
2012-02-15 22:04:08 +00:00
Richard Frith-MacDonald
b18a55a842 filter service fixes
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34752 72102866-910b-0410-8b05-ffd578937521
2012-02-14 18:31:28 +00:00
Richard Frith-MacDonald
b71be91d36 minor tidyup
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34742 72102866-910b-0410-8b05-ffd578937521
2012-02-08 10:36:46 +00:00
Fred Kiefer
0bf9693431 * Source/NSPasteboard.m (+pasteboardByFilteringFile:): Correct
typo in Richard's change.
* Source/NSPasteboard.m (-pasteboard:provideDataForType:): Use
 the file name directly instead of reading the file contents.
* Source/NSImageRep.m (+imageRepsWithContentsOfFile:,
+imageFileTypes):
Start working on filter service support for images.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34741 72102866-910b-0410-8b05-ffd578937521
2012-02-08 09:42:46 +00:00
Richard Frith-MacDonald
4efb00ae4c fixup error in filtering file by name
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34740 72102866-910b-0410-8b05-ffd578937521
2012-02-08 09:21:06 +00:00
Eric Wasylishen
bd5ff5ba95 * Headers/AppKit/NSOutlineView.h:
* Source/NSOutlineView.m: Add support for
outlineView:dataCellForTableColumn:item: delegate method
* Headers/AppKit/NSTableView.h:
* Source/NSTableView.m: Add support for
tableView:dataCellForTableColumn:row: delegate method


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34717 72102866-910b-0410-8b05-ffd578937521
2012-02-03 21:41:41 +00:00
Riccardo Mottola
7f6bdeb0a2 centerScanRect button to avoid blurring
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34693 72102866-910b-0410-8b05-ffd578937521
2012-02-01 22:07:41 +00:00
Fred Kiefer
cea7a7e137 * Source/GSThemeInspector.m: Add missing include.
This was causing prblems on Windows.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34692 72102866-910b-0410-8b05-ffd578937521
2012-02-01 18:42:10 +00:00
Fred Kiefer
2d48b49175 Deal with images taht result in no data. This happens in themes that
have to small images to be split up into 9 tiles.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34688 72102866-910b-0410-8b05-ffd578937521
2012-02-01 10:49:35 +00:00
Fred Kiefer
462b24489f * Source/NSMenu.m (-setMain:): Rearrange code to avoid duplicate
menu for in-window menu themes.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34687 72102866-910b-0410-8b05-ffd578937521
2012-02-01 09:12:34 +00:00
Fred Kiefer
1b398c6621 * Source/GSThemeInspector.m (-update:): Don't get the frame from a
non-existing view. This was currupting the stack with gcc 4.6 on i386.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34686 72102866-910b-0410-8b05-ffd578937521
2012-02-01 09:00:23 +00:00
Eric Wasylishen
6e4da7d0e3 * Source/NSImageCell.m (-drawInteriorWithFrame:inView:): Only
draw at 50% opacity if no bezel is set for cocoa compatibility.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34674 72102866-910b-0410-8b05-ffd578937521
2012-01-31 02:27:18 +00:00
Eric Wasylishen
c2ef95964f * Source/GNUmakefile: Remove GSGhostscriptImageRep from the build
* Source/NSImageRep.m: Remove GSGhostscriptImageRep
* configure.ac: Disable ImageMagic by default
* configure: Regenerate


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34671 72102866-910b-0410-8b05-ffd578937521
2012-01-30 21:06:08 +00:00
Fred Kiefer
9d0b8b4dfd * Source/NSMenu.m (-setMain:): Remove the in-window menu when
switching to a theme without that.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34652 72102866-910b-0410-8b05-ffd578937521
2012-01-29 00:43:50 +00:00
Fred Kiefer
899ce772cb * Source/NSMenu.m (-performActionForItemAtIndex:): Check for the
popup button cell and its action, before checking for the item
action. This caused a problem due to NIB decoding changes.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34642 72102866-910b-0410-8b05-ffd578937521
2012-01-26 22:38:50 +00:00
Fred Kiefer
2d2026e7fc Revert last change and replace with something a little bit better. The
whole ruler handling will need some deeper inspection.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34636 72102866-910b-0410-8b05-ffd578937521
2012-01-26 09:25:29 +00:00
Doug Simons
3e7c9bceef Call setClientView: before calling setMarkers: to fix a problem when a textView's text is set or changed when the textView is not the first responder, such as at windowControllerDidLoadNib: time.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34633 72102866-910b-0410-8b05-ffd578937521
2012-01-25 23:28:51 +00:00
Eric Wasylishen
cbf7bc52a9 * Source/NSImage.m (+imageNamed:): Don't try to look up path
if called with nil (just return nil).


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34632 72102866-910b-0410-8b05-ffd578937521
2012-01-25 23:25:14 +00:00
Eric Wasylishen
d81df878a5 * Source/NSClipView.m: Disable copy-on-scroll until after release
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34631 72102866-910b-0410-8b05-ffd578937521
2012-01-25 22:17:53 +00:00