Commit graph

6917 commits

Author SHA1 Message Date
Riccardo Mottola
6ec6f20f19 subclass initImageCell, so that RefusesFirstResponder can be set, matching Mac. 2022-03-22 22:52:06 +01:00
Wolfgang Lux
efb9bcb2e7 Select the first item of a NSPopUpButtonCell's new menu 2022-02-26 15:30:26 +01:00
Wolfgang Lux
ec3353ecd8 Never change the state of the selected item of a NSPopUpButton configured as a pull down 2022-02-26 15:21:04 +01:00
Gregory John Casamento
606505326c Minor change: Add all new headers to DocMakefile 2022-02-21 14:22:47 -05:00
Fred Kiefer
7c1af2c874
Merge pull request #140 from williameveretteggplant/autoreleasepool_NSTextView
Fix memory leak in NSTextView
2022-02-14 23:42:08 +01:00
williameveretteggplant
b70fad26a6
Use autorelease pool macros 2022-02-14 15:35:37 -07:00
williameveretteggplant
0211713766
Remove extra line 2022-02-14 14:16:42 -07:00
williameveretteggplant
9925f50aef
Indentation 2022-02-14 14:15:26 -07:00
williameveretteggplant
aae1f34d0d
Undo change 2022-02-14 14:09:34 -07:00
williameveretteggplant
2403c21978
Fix memory leak of tool tips
Prevents the creation of tool tips where they don't already exist. Tool tips only need to be removed in the rect if there are tool tips.
2022-02-14 14:03:49 -07:00
williameveretteggplant
f37e93a440
Fix memory leak in NSTextView
On Windows, there is an occasional sporadic failure of autorelease to work correctly. In particular, this seems to happen when autorelease is invoked on an object while a call stack is in the middle of draining an autorelease pool. So, for example, when dealloc is called on an NSTextContainer, it then calls setTextContainer: on the associated NSTextView, which in turn calls textContainers on the layoutManager, which returns an autoreleased array of NSTextContainers. This array is sometimes released and sometimes it isn't.
Wrapping the setTextContainer: in an autorelease pool, which will then drain at the end of the method, rather than relying on the main autorelease pool in the run loop (which is in the middle of being drained), appears to fix this problem. This adds a small amount of overhead, but also makes the memory usage a little more efficient, since anything autoretained during the course of this method is released more quickly.
2022-02-11 17:12:50 -07:00
williameveretteggplant
3190ce4363
Merge pull request #1 from williameveretteggplant/patch-1
Fix memory leak in NSBox
2022-02-11 16:17:11 -07:00
williameveretteggplant
d744b26429
Fix GSToolTips leak in NSView
ToolTips can be present even when the flag is false, and it does no harm to invoke removeTipsForView: even if there are none. So this fixes a memory leak without any downside.
2022-02-11 16:15:28 -07:00
williameveretteggplant
db5ad42d8a
Fix memory leak in NSBox 2022-02-11 16:09:35 -07:00
Wolfgang Lux
f5ebdcd1d2 Do not update selected item's state when changing the menu 2022-02-08 22:21:38 +01:00
Wolfgang Lux
c50ef9d8fa Restore fix for @97351199e 2022-02-07 18:19:03 +01:00
Wolfgang Lux
e4bd00f6eb Fix to avoid dangling pointer when changing the menu of a NSPopUpButtonCell 2022-02-06 15:58:18 +01:00
Gregory John Casamento
67860bf8c1 Add declarations for setPlaceholderString:/setPlaceholderAttributedString and getters to header and implementation to NSTextField.m 2022-01-12 04:45:56 -05:00
Gregory John Casamento
ebc6eb99a3 Quick fix for compilation error 2022-01-12 01:45:49 -05:00
Gregory John Casamento
937c309c15 Quick fix for compilation error 2022-01-12 01:45:10 -05:00
Gregory John Casamento
fda74bfde8 Add changelog 2022-01-11 20:13:00 -05:00
Gregory John Casamento
93a0fc46ea Use macro for fast enumeration 2022-01-11 20:10:09 -05:00
anthony
49e30a3378 GSStandardWindowDecorationView: Apply userSpaceScaleFactor to title bar height when calculating offsets 2022-01-11 19:51:45 +00:00
Fred Kiefer
b84d8cc3fd * Headers/Additions/GNUstepGUI/GSWindowDecorationView.h:
Move new addon methods for Wayland to correct class
GSStandardWindowDecorationView.
* Source/GSWindowDecorationView.m: Keep variables declarations together.
2021-12-28 17:23:48 +01:00
Fred Kiefer
bc9d477a9f
Merge pull request #124 from nongio/windowdecoration-expose
Add helper methods in GSWindowDecorator protocol
2021-12-27 17:51:50 +01:00
Riccardo Canalicchio
8ec514e049 pointInTitleBarRect: remove hit-test from window buttons 2021-12-27 15:12:17 +01:00
Fred Kiefer
97351199e3 * Source/NSPopUpButtonCell.m: Try to prevent segmenation fault
when deallocating a popup button.
2021-12-26 23:46:02 +01:00
Fred Kiefer
4ad217d5c3 * Source/NSMenu.m: Rename method on NSMenuPanel for the Wayland
backend to -_menu to keep it apart from the already existing method
-menu on NSResponder.
* Source/NSSplitView.m: Correct decoded integer type.
2021-12-26 14:50:50 +01:00
Riccardo Canalicchio
4eafb6f34c Add helper methods in GSWindowDecorator protocol for pointer hit test on window decorations 2021-12-17 09:09:37 +01:00
Gregory John Casamento
1d3f33b694 Restore older behavior for version 0 of NSSplitView. The previous change broke some older .gorm files. 2021-12-01 19:42:40 -05:00
Gregory John Casamento
d20fa6cc61 Make sure that the setDividerStyle: mthod is called only once when decoding from a gorm file 2021-11-18 18:01:45 -05:00
Gregory John Casamento
dae13af553 Check [bc isLoaded] before making window first responder 2021-11-18 13:17:56 -05:00
Gregory John Casamento
334e26eeb0 Add support for Thick/Thin/PaneSplitter NSSplitView settings 2021-11-15 10:20:33 -05:00
Gregory John Casamento
8ac4bf7547 NSSplitView, use CGFloat to encode _draggedBarWidth 2021-11-15 09:52:26 -05:00
Gregory Casamento
aae4b5897d Use macro for encoding and decoding NSInteger. 2021-11-15 09:52:26 -05:00
Gregory Casamento
963938923b Make some of the updates suggested by fred. 2021-11-15 09:52:26 -05:00
Gregory John Casamento
f88f70ca17 Implement arrangesAllSubview and other related methods. 2021-11-15 09:52:26 -05:00
Gregory John Casamento
54e555bc33 Add support for dividerThickness and bump version of NSSplitView to 1 2021-11-15 09:52:26 -05:00
Gregory John Casamento
8fa489282b Fix compilation error. Added cast to (id) for nil when working with GSIArrayItem and GSIArray. This issue wasn't caught by CI since gui was not recompiled after base was altered. 2021-11-15 08:59:36 -05:00
Fred Kiefer
a047b10a51
16bit (#123)
* Fix compiler warnings

* Attempt to sort out byte order for 15 bit images.

* Try to get integer types from standard location

* Remove extra swap code by using more complex condition.
Thanks to Riccardo Mottola.
2021-11-08 22:46:25 +01:00
Riccardo Canalicchio
1e670335f6 expose menu attribute, required for wayland backend submenu 2021-11-07 15:33:21 -05:00
Gregory John Casamento
97379423f0 Revert change per discussion with @fredkiefer. 2021-10-27 16:14:57 -04:00
Gregory John Casamento
7023c7d06d Add remaining changes contributed by testplant. 2021-10-27 15:18:23 -04:00
Gregory John Casamento
ac5b949f2a Add fix to prevent iterating past the number of visible back views. 2021-10-27 15:00:38 -04:00
Gregory John Casamento
5666d7b7c2 Add NSScrollView keys for init/encodeWithCoder 2021-10-27 12:34:58 -04:00
Gregory John Casamento
e9548dd057 Add extra pixels to tooltip 2021-10-27 11:59:39 -04:00
Riccardo
58359b8de3
update signatures to match Apple (#120) 2021-10-26 16:17:45 +02:00
Riccardo Mottola
5e837b6858 Keep local variables to ensure correct values during recursion. 2021-10-25 23:22:32 +02:00
Gregory Casamento
7617392f80
Merge pull request #118 from gnustep/NSGlyphInfo_branch 2021-10-21 16:38:54 -04:00
Riccardo
8892408c8f
add a preference to disable spellchecker (#115)
* add a preference to disable spellchecker

* add GSDisableSpellCheckerServer

* fix typo and unintentional error.

* be clearer about default.

* one was too much
2021-10-18 22:29:50 +02:00