Commit graph

81 commits

Author SHA1 Message Date
Johnathan Becker
c80105a312
try this 2024-11-15 12:39:29 -07:00
Johnathan Becker
299af29885
try this 2024-11-15 12:36:08 -07:00
Johnathan Becker
7d477230ec
try this 2024-11-15 12:32:31 -07:00
Fred Kiefer
3a6dce02be Remove some gcc compiler warnings 2023-12-28 14:45:16 +01:00
Riccardo Mottola
08411ea68f fix some trailing semicolons 2023-11-17 16:53:43 +01:00
Gregory John Casamento
95c7e31ccb Remove uneeded item object 2023-02-12 15:32:21 -05:00
Gregory John Casamento
30c2f1da6b Minor update, remove redundant setSelected: calls 2023-02-12 15:27:50 -05:00
Gregory John Casamento
ea398eab4c Remove extra call to setSelected: in selectAll: deselectAll: etc methods, this should only happen in setSelectionIndexes and setSelectionIndexPaths 2023-02-12 14:25:36 -05:00
Gregory John Casamento
b6048a27f4 Run cleanup-whitespace in emacs to eliminate all extraneous whitespace 2023-02-12 14:19:37 -05:00
Gregory John Casamento
1c879a1522 Add private methods to internal private category 2023-02-12 09:55:29 -05:00
Gregory John Casamento
41e6a45e8d Add private methods to internal private category 2023-02-12 09:33:48 -05:00
Gregory John Casamento
50889771d0 Fix issue with FOR_IN loop 2023-02-11 18:27:55 -05:00
Gregory John Casamento
2eb23858d6 Methods to keep selectionIndexes and selectionIndexPaths in sync per discussion with @fredkiefer 2023-02-11 18:20:36 -05:00
Gregory John Casamento
731f5a248d Fix OVERIDDEN macro, override method in NSCollectionViewGridLayout 2023-02-09 14:39:37 -05:00
Gregory John Casamento
fd4b07ff09 Get rid of extranous include 2023-02-07 21:56:26 -05:00
Gregory John Casamento
4bcdf6f5d4 Fix issues mentioned by @fredkiefer in review, remove check in NSViewController 2023-02-07 21:27:39 -05:00
Gregory John Casamento
d6d2f430ad Update encode/decode to remove unecessary 64bit call 2023-02-07 21:09:23 -05:00
Gregory John Casamento
2a33aab039 Update implemention suggested by @fredkiefer 2023-02-07 21:05:12 -05:00
Gregory John Casamento
7244519365 Change call indexPathsForVisibleSupplementaryElementsOfKind to call indexPathForItem: as suggested by @fredkiefer 2023-02-07 20:55:22 -05:00
Gregory John Casamento
330599e248 Inline the frame update 2023-02-04 11:37:36 -05:00
Gregory John Casamento
73759407bb Add delegate call to collectionView:didSelectItemsAtIndexPaths: 2023-02-04 10:28:11 -05:00
Gregory John Casamento
ec6a845cb1 Suggestions by @fredkiefer, correct spacing and fix comment 2023-02-04 09:39:48 -05:00
Gregory John Casamento
99103a83dc Fix more suggestions by @fredkiefer. Add AUTORELEASE for nib, generate indexes for visible items 2023-02-04 09:31:13 -05:00
Gregory John Casamento
cf16dde246 Update selectAll:, deselectAll:, selectItemsAtIndexPaths:..., deselectItemsAtPaths: to correctly update setSelectionIndexPaths: 2023-02-04 07:41:42 -05:00
Gregory John Casamento
e754180dcf Add OVERRIDDEN macro per suggestion from @fredkiefer 2023-01-30 18:12:53 -05:00
Gregory John Casamento
19e8a48ba3 Add APPKIT_DECLARE 2023-01-30 10:48:03 -05:00
Gregory John Casamento
4e49c2a8cf Add APPKIT_DECLARE 2023-01-30 10:48:03 -05:00
Gregory John Casamento
8afffbb121 Fix leak and add to maps in makeItemWithIdentifier:forIndexPath:, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
d4d60dd5de Remove strange comment, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
e1fa590102 Remove commented out code, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
dd01e8b59b Correct formatting, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
c7c6d887e2 Correct formatting, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
c7c3c65f4e Correct formatting, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
03cbc95076 Remove log per review by @fredkiefer 2023-01-30 10:48:03 -05:00
Gregory John Casamento
5e5e2bd317 Add proper error 2023-01-30 10:48:03 -05:00
Gregory John Casamento
cb8e805d0d Add method to check if method is overriden on layout subclass 2023-01-30 10:48:03 -05:00
Gregory John Casamento
95fa4e0368 Add tracking view to allow easier selection 2023-01-30 10:48:03 -05:00
Gregory John Casamento
c95bbcf714 Changes to fix item selection when an NSImageView is present 2023-01-30 10:48:03 -05:00
Gregory John Casamento
7ee05a6869 Make sure to consider when view is flipped when calculating which indexPath was hit; minor cleanup of code; remove uneeded comments 2023-01-30 10:48:03 -05:00
Gregory John Casamento
5ff478ac85 Fix implementation of resize when elements overflow the size of the view 2023-01-30 10:48:03 -05:00
Gregory John Casamento
627c51ec45 Changes to implement grid layout 2023-01-30 10:48:03 -05:00
Gregory John Casamento
a5b878c690 Implement selectAll:, deselectAll:, selectItemsAtIndex:..., deselectItemsAtIndexPaths: 2023-01-30 10:48:03 -05:00
Gregory John Casamento
e9e1615cdb Don't update the delegate unless the selection actually changes 2023-01-30 10:48:03 -05:00
Gregory John Casamento
a6f83ab00b Add code to clean up views when resizing. Prevent recursion. Call reload when 'tile' method is called 2023-01-30 10:48:03 -05:00
Gregory John Casamento
2d70c42790 Fix issue with loading collectionview. Correct sprious calls to reloadData and tile method. Fix call back to delegate when item is clicked 2023-01-30 10:48:03 -05:00
Gregory John Casamento
f1552faaee Remove uneeded ivars, release maps 2023-01-30 10:48:03 -05:00
Gregory John Casamento
01ca2cb6c2 Fix compilation error in CI 2023-01-30 10:48:03 -05:00
Gregory John Casamento
2bec53bf0f Switch to using maptables to track some metadata bout items so that we can match items up when we need to find them by indexPath or point. Remove uneeded ivar from layout. Add call to delegate when selecting item 2023-01-30 10:48:03 -05:00
Gregory John Casamento
bf3ddc8cad Add call to delegate when selecting item 2023-01-30 10:48:03 -05:00
Gregory John Casamento
b7156def8f Implement setSelectionIndexPaths: 2023-01-30 10:48:03 -05:00