Riccardo Mottola
34c5a5e841
use defined() to check if a variable is defined, also, rename it to be clearer about a feature availability and not enabling one
2023-10-26 02:38:29 +02:00
Frederik Carlier
31a71a1090
NSWorkspace: Throw a descriptive exception when make_services could not be found ( #208 )
...
`[NSTask launchPathForTool: @"make_services"]; can return nil when the tool is not found. In this case, [NSTask launchedTaskWithLaunchPath] would raise a NSInvalidArgumentException with error message "NSTask - no launch path set" which is not very descriptive.
2023-10-11 17:54:38 +02:00
Frederik Carlier
8619fe33c2
GifQuantizeBuffer
is considered private API in libgif 5.2 and later (#207 )
...
See befe188771
/
2023-10-09 19:35:37 +02:00
Gregory John Casamento
2ac57c147f
Remove uneeded calls to orderOut: and setDelegate: as this is done in the close method
2023-10-08 06:23:26 -04:00
Gregory John Casamento
a4beb1266f
Fix spaces / formatting issue for return types
2023-10-08 05:43:18 -04:00
Gregory John Casamento
791a5d0aaf
Cleanup classes.
2023-10-08 04:44:31 -04:00
Gregory John Casamento
4bb0270759
Update NSViewController with lifeCycle methods
2023-10-08 04:44:31 -04:00
Gregory John Casamento
24eee8e7dd
Allow popover to be dismissed
2023-10-08 04:44:31 -04:00
Frederik Carlier
bcc8011580
Avoid accessing instance variables in inline functions when compiling with msvc ( #205 )
...
* Rename `DPSshfill` to `DPSshfill_`
This method takes one argument, so by convention, the name of the variable in the method table should end with a single underscore
* DPSOperators.h: Use macros to define inline functions
* Don't access instance variables when compiling with Visual Studio
2023-10-01 22:56:02 +02:00
Riccardo Mottola
9faf904349
Merge branch 'warningfix' of https://github.com/gnustep/libs-gui into warningfix
2023-09-18 18:05:35 +02:00
Riccardo Mottola
670a86bb59
cleanup trailing backslash
2023-09-18 18:02:28 +02:00
Riccardo Mottola
5e68ebec91
fix warning, comparison with NULL
2023-09-13 01:11:48 +02:00
Riccardo Mottola
88a0e1e390
use destroy instead of assigning nil, avoids warnings and make smore sense anyway
2023-09-13 00:40:58 +02:00
Riccardo Mottola
a3117e5598
Put in methd in a private category to silence warning. Apple doesn't expose the method in its header, but we don't we don't know if it has it private. In case it is a GS extension, perhaps we should name it private with an _.
2023-09-12 23:49:05 +02:00
Riccardo Mottola
9e0685b315
do not install private headers
2023-09-12 23:19:06 +02:00
Riccardo Mottola
1815556e4e
remove unused functions
2023-09-12 23:09:08 +02:00
Richard Frith-Macdonald
2e4af41c70
Fixup for APPKIT_EXPORT_CLASS
2023-09-05 17:02:06 +01:00
Gregory Casamento
3575f0af77
Add implementation of removeAllItems
2023-09-01 17:12:05 +00:00
Gregory Casamento
3f35da7860
Update code in GSXib5KeyedUnarchiver.m to read alternative toolTip format ( #193 )
...
* Update code in GSXib5KeyedUnarchiver.m to read alternative toolTip format
* Update to make the code a bit tighter, per suggestion by @fredkiefer
2023-08-31 23:46:34 +02:00
Gregory Casamento
629d065b91
Add dummy awakeFromNib dummy method ( #195 )
2023-08-31 23:41:46 +02:00
d99c96efcc
* Source/NSMenuItemCell.m (-_keyEquivalentString): Fix the 'and' check so that shiftKeyString can display ( #190 )
2023-08-26 11:32:30 +02:00
Fred Kiefer
570f2b4d2a
* Source/NSSwitch.m (-drawRect:): Correct drawing as suggested by Austin Clow (dr_clow@me.com).
2023-08-13 20:27:48 +02:00
Benjamin Johnson
305bcd56a3
Implement GSCSTableau, GSCSEditInfo, GSCSEditVariableManager ( #186 )
...
* Implement GSCSTableau, GSCSEditInfo, GSCSEditVariableManager
* Update GSTableau based on feedback
* Remove adding expression term variable to external parameteric variables
2023-08-05 10:26:22 +02:00
Frederik Carlier
eb480b7748
NSGraphicsContext
: Add methods
method (#179 )
...
gnustep-back uses the `NSGraphicsContext->methods` _variable_, but using an instance variable across module boundaries is not supported when building with Visual Studio.
This commits adds a `[NSGraphicsContext methods]` _method_, which can be accessed across module boundaries (and hence when building with Visual Studio).
2023-08-01 22:39:46 +02:00
Riccardo Mottola
0b9924e094
reduce scope of _imageRep from ivar to local to init
2023-07-27 14:35:25 +02:00
Gregory Casamento
f2b79365f4
NSDockTile - Implement methods to update the icon and show badge ( #185 )
...
NSDockTile - Implement methods to update the icon and show badge using a NSCustomImageRep. Link the NSDockTile view with the AppIcon window contentView.
GSTheme - add badgeColor color and corresponding methods to theme background, decoration and text color
2023-07-27 09:17:18 +02:00
Gregory Casamento
a34867faee
Merge pull request #184 from gnustep/gsdisplayserver_cleanup
2023-05-31 17:10:55 -04:00
Riccardo Mottola
3341f6f149
Remove now unused NSCurrentServerThreadKey key, previously it was used tor GSCurrentServer(), but it it is not needed anymore. Please use the function directly.
2023-05-30 00:15:47 +02:00
Benjamin Johnson
47a945603b
Fix typo and spacing
2023-05-29 22:14:11 +00:00
Benjamin Johnson
1f7f4cd40f
Fix typo in intrinsic and address comments
2023-05-28 22:10:14 +00:00
Benjamin Johnson
2e98bd5366
Implement layout constraint conversion to internal solver constraints
2023-05-28 18:33:44 +10:00
Benjamin Johnson
0c493d9e7a
Address PR feedback on #181
2023-05-09 06:26:26 +10:00
Benjamin Johnson
bddf6cfd03
Implement GSCSConstraint and suppoorting classes
2023-05-07 08:01:25 +10:00
Benjamin Johnson
2be7334ce2
Implement part of GSAutoLayoutEngine dependency management logic ( #178 )
...
* Implement part of GSAutoLayoutEngine dependency management logic
* Fix formatting of GSAutoLayoutEngine, GSCSFloatComparator and GSCSSolution
* Address PR feedback
* Address PR feedback
* Replace assignment with ASSIGN macro and fix makefile
* Add back dealloc in GSAutoLayoutEngine.m and GSCSSolution.m
2023-04-19 09:06:53 +02:00
Gregory John Casamento
5c098cc539
Minor fix in glyph info
2023-04-09 21:09:22 -04:00
Gregory Casamento
e64d8d4b02
Merge pull request #170 from gnustep/NSDictionaryController2_branch
2023-03-24 18:33:52 -04:00
Gregory John Casamento
58748243d5
Update per comments by Fred before merge
2023-03-24 17:57:29 -04:00
Gregory Casamento
81f21e2094
Merge pull request #172 from BennyKJohnson/bootstrap-layout-engine
2023-03-17 14:11:20 -04:00
Riccardo
62d16bff24
Implement acceptsFirstMouse so to return YES, otherwise tablees in new windows do not get mouse selection events. ( #173 )
...
Seems to match Apple's implementation.
2023-03-02 12:13:50 +01:00
Benjamin Johnson
708f7c337e
Address feedback on bootstrap layout engine PR
2023-03-01 18:57:08 +11:00
Gregory Casamento
09e9cc0330
Update NSDictionaryController.m. Correct removeObjects:
2023-02-28 16:58:21 -05:00
Gregory John Casamento
99e921ea35
Fix type issue with getting value from KVP in a couple of places and fix memory issue with NSDictionaryControllerKeyValuePair
2023-02-28 03:55:34 -05:00
Gregory John Casamento
dcf5fbe74b
Update using rearrangeObjects, clean up white space for review
2023-02-28 03:42:43 -05:00
Gregory John Casamento
b9841fe493
Update build array to properly exclude keys
2023-02-28 03:33:50 -05:00
Benjamin Johnson
7b9bede733
Improve memory management with layout engine
2023-02-28 19:18:52 +11:00
Gregory John Casamento
08fc055321
Override addObject(s):, removeObject(s): update _contentDictionary
2023-02-28 03:17:07 -05:00
Gregory John Casamento
99e25244af
Remove uneeded bind: code
2023-02-28 00:40:40 -05:00
Benjamin Johnson
f6f1a7ef82
Remove unnecessary check for _layoutEngine
2023-02-27 21:39:14 +00:00
Benjamin Johnson
2a1c0f88b3
Move layoutEngine ownership to NSWindow
2023-02-27 19:56:37 +11:00
Benjamin Johnson
93769f3a52
Implement bootstrapping auto layout
2023-02-27 17:46:39 +11:00