gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-04-23 07:00:46 +00:00
Code Issues Projects Releases Packages Wiki Activity
9598 commits 87 branches 112 tags 32 MiB
Commit graph

7041 commits

Author SHA1 Message Date
Gregory John Casamento
2eb23858d6 Methods to keep selectionIndexes and selectionIndexPaths in sync per discussion with @fredkiefer 2023-02-11 18:20:36 -05:00
Benjamin Johnson
f46e6596cc Make layout constraint attribute constants static and add comment for ordering 2023-02-12 08:47:55 +11:00
Gregory John Casamento
731f5a248d Fix OVERIDDEN macro, override method in NSCollectionViewGridLayout 2023-02-09 14:39:37 -05:00
Gregory John Casamento
fd4b07ff09 Get rid of extranous include 2023-02-07 21:56:26 -05:00
Gregory John Casamento
b891dea575 Update as discussed, get rid of extra commented out code and of uneeded imports 2023-02-07 21:41:13 -05:00
Gregory John Casamento
0ad9143b39 Add better var names in flow layout 2023-02-07 21:39:05 -05:00
Gregory John Casamento
bb77c072cb Correct spaces 2023-02-07 21:30:46 -05:00
Gregory John Casamento
4bcdf6f5d4 Fix issues mentioned by @fredkiefer in review, remove check in NSViewController 2023-02-07 21:27:39 -05:00
Gregory John Casamento
d6d2f430ad Update encode/decode to remove unecessary 64bit call 2023-02-07 21:09:23 -05:00
Gregory John Casamento
2a33aab039 Update implemention suggested by @fredkiefer 2023-02-07 21:05:12 -05:00
Gregory John Casamento
7244519365 Change call indexPathsForVisibleSupplementaryElementsOfKind to call indexPathForItem: as suggested by @fredkiefer 2023-02-07 20:55:22 -05:00
Gregory John Casamento
330599e248 Inline the frame update 2023-02-04 11:37:36 -05:00
Gregory John Casamento
73759407bb Add delegate call to collectionView:didSelectItemsAtIndexPaths: 2023-02-04 10:28:11 -05:00
Gregory John Casamento
ec6a845cb1 Suggestions by @fredkiefer, correct spacing and fix comment 2023-02-04 09:39:48 -05:00
Gregory John Casamento
99103a83dc Fix more suggestions by @fredkiefer. Add AUTORELEASE for nib, generate indexes for visible items 2023-02-04 09:31:13 -05:00
Gregory John Casamento
cf16dde246 Update selectAll:, deselectAll:, selectItemsAtIndexPaths:..., deselectItemsAtPaths: to correctly update setSelectionIndexPaths: 2023-02-04 07:41:42 -05:00
Benjamin Johnson
4fec29a66b Implement NSAutoresizingMaskLayoutConstraint class 2023-02-04 19:24:03 +11:00
Gregory John Casamento
e754180dcf Add OVERRIDDEN macro per suggestion from @fredkiefer 2023-01-30 18:12:53 -05:00
Gregory John Casamento
19e8a48ba3 Add APPKIT_DECLARE 2023-01-30 10:48:03 -05:00
Gregory John Casamento
4e49c2a8cf Add APPKIT_DECLARE 2023-01-30 10:48:03 -05:00
Gregory John Casamento
8afffbb121 Fix leak and add to maps in makeItemWithIdentifier:forIndexPath:, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
cd52649076 Fix encoding issue, formatting issues, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
d4d60dd5de Remove strange comment, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
e1fa590102 Remove commented out code, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
dd01e8b59b Correct formatting, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
c7c6d887e2 Correct formatting, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
c7c3c65f4e Correct formatting, per review 2023-01-30 10:48:03 -05:00
Gregory John Casamento
03cbc95076 Remove log per review by @fredkiefer 2023-01-30 10:48:03 -05:00
Gregory John Casamento
20a59e45b5 Add code to call viewWillLoad/viewDidLoad into loadView 2023-01-30 10:48:03 -05:00
Gregory John Casamento
5e5e2bd317 Add proper error 2023-01-30 10:48:03 -05:00
Gregory John Casamento
cb8e805d0d Add method to check if method is overriden on layout subclass 2023-01-30 10:48:03 -05:00
Gregory John Casamento
af643cc821 Fix externs for collection view, correct NSFontIdentityMatrix type 2023-01-30 10:48:03 -05:00
Gregory John Casamento
5612120c06 Remove extra #import directives 2023-01-30 10:48:03 -05:00
Gregory John Casamento
3e8b8386b1 Add correct API version defines for NSCollectionViewItem 2023-01-30 10:48:03 -05:00
Gregory John Casamento
fe2a988111 Fix duplicate _size and use the _frame in the attributes class 2023-01-30 10:48:03 -05:00
Gregory John Casamento
95fa4e0368 Add tracking view to allow easier selection 2023-01-30 10:48:03 -05:00
Gregory John Casamento
c95bbcf714 Changes to fix item selection when an NSImageView is present 2023-01-30 10:48:03 -05:00
Gregory John Casamento
7ee05a6869 Make sure to consider when view is flipped when calculating which indexPath was hit; minor cleanup of code; remove uneeded comments 2023-01-30 10:48:03 -05:00
Gregory John Casamento
bfa088fd0e Fix size issue with flow view 2023-01-30 10:48:03 -05:00
Gregory John Casamento
3b44aa3608 Fix size issue with grid view 2023-01-30 10:48:03 -05:00
Gregory John Casamento
bbfa1d84bc Fix proportions of each item 2023-01-30 10:48:03 -05:00
Gregory John Casamento
5ff478ac85 Fix implementation of resize when elements overflow the size of the view 2023-01-30 10:48:03 -05:00
Gregory Casamento
b96dbcba2e Update GSXib5KeyedUnarchiver.m 
Remove extra space.
 2023-01-30 10:48:03 -05:00
Gregory John Casamento
627c51ec45 Changes to implement grid layout 2023-01-30 10:48:03 -05:00
Gregory John Casamento
a5b878c690 Implement selectAll:, deselectAll:, selectItemsAtIndex:..., deselectItemsAtIndexPaths: 2023-01-30 10:48:03 -05:00
Gregory John Casamento
e9e1615cdb Don't update the delegate unless the selection actually changes 2023-01-30 10:48:03 -05:00
Gregory John Casamento
a6f83ab00b Add code to clean up views when resizing. Prevent recursion. Call reload when 'tile' method is called 2023-01-30 10:48:03 -05:00
Gregory John Casamento
2d70c42790 Fix issue with loading collectionview. Correct sprious calls to reloadData and tile method. Fix call back to delegate when item is clicked 2023-01-30 10:48:03 -05:00
Gregory John Casamento
94f616436f Add mapping to XmlKeyMapTable for NSBackroundColors 2023-01-30 10:48:03 -05:00
Gregory John Casamento
f1552faaee Remove uneeded ivars, release maps 2023-01-30 10:48:03 -05:00
Gregory John Casamento
01ca2cb6c2 Fix compilation error in CI 2023-01-30 10:48:03 -05:00
Gregory John Casamento
2bec53bf0f Switch to using maptables to track some metadata bout items so that we can match items up when we need to find them by indexPath or point. Remove uneeded ivar from layout. Add call to delegate when selecting item 2023-01-30 10:48:03 -05:00
Gregory John Casamento
bf3ddc8cad Add call to delegate when selecting item 2023-01-30 10:48:03 -05:00
Gregory John Casamento
b7156def8f Implement setSelectionIndexPaths: 2023-01-30 10:48:03 -05:00
Gregory John Casamento
8a9185ee84 Update selection methods 2023-01-30 10:48:03 -05:00
Gregory John Casamento
a16ad6168b Update selection methods 2023-01-30 10:48:03 -05:00
Gregory John Casamento
3ea04c0e36 Fix compilation issue, comment out temporary code in _selectWithEvent:indexPath: 2023-01-30 10:48:02 -05:00
Gregory John Casamento
eeb8718452 Add indexpath methods 2023-01-30 10:48:02 -05:00
Gregory John Casamento
5108348ca6 Add code to return the item properly from layoutAttributesForElementsInRect:, add missing NSCopying declaration to NSCollectionViewItem.h, minor cleanup in NSCollectionViewCompositionalLayout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
f3672c31e9 Update attributes 2023-01-30 10:48:02 -05:00
Gregory John Casamento
5b57e65002 Update attributes 2023-01-30 10:48:02 -05:00
Gregory John Casamento
3f402d292b Return attributes for items that intersect 2023-01-30 10:48:02 -05:00
Gregory John Casamento
9c1aec70e7 Fix resize issue with flow 2023-01-30 10:48:02 -05:00
Gregory John Casamento
2246da3d0e Implement re-flow when view is resized 2023-01-30 10:48:02 -05:00
Gregory John Casamento
b28eaac9eb Minor updates and formatting change 2023-01-30 10:48:02 -05:00
Gregory John Casamento
466ebedd04 Add calls to additional delegate methods 2023-01-30 10:48:02 -05:00
Gregory John Casamento
00ac1adf7f Implement collapse section 2023-01-30 10:48:02 -05:00
Gregory John Casamento
83e8cf6a15 Add non-keyed decoding 2023-01-30 10:48:02 -05:00
Gregory John Casamento
fdf39cf110 Add non-keyed encoding 2023-01-30 10:48:02 -05:00
Gregory John Casamento
64a5d19b19 Update encoding/decoding 2023-01-30 10:48:02 -05:00
Gregory John Casamento
d6b78ff06e Change encode/init to use encode/decode functions to handle integers 2023-01-30 10:48:02 -05:00
Gregory John Casamento
f7730c97d3 Encode all information for the grid layout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
dade8c4068 Decode all information for the grid layout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
35e0e62144 Add implementation of setters and getters in NSCollectionViewGridLayout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
7d46f9f69a Update to the correct size when laying out the collection view. 2023-01-30 10:48:02 -05:00
Gregory John Casamento
9c0f4ed731 Update visibleItems when arranging items 2023-01-30 10:48:02 -05:00
Gregory John Casamento
04b0a15526 Implement makeItemWithIdentifier:atIndexPath: 2023-01-30 10:48:02 -05:00
Gregory John Casamento
8948aecae5 Update implementation to calculate position of items for the flow layout. implementation of copyWithZone. Implementation of initWithCoder for flow layout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
7fe30c6db2 Update flow layout. Fix decoding issue with Xib interpretation for NSCollectionViewLayout. 2023-01-30 10:48:02 -05:00
Gregory John Casamento
fc56a78840 Add implementation of new methods 2023-01-30 10:48:02 -05:00
Gregory John Casamento
f8e99166e2 Add documentation to methods in NSCollectionView and remove initWithCoder call from NSCollectionViewLayout 2023-01-30 10:48:02 -05:00
Gregory John Casamento
b65c5bca9d Add implementation of reloadSections and reloadItemsAtIndexPaths 2023-01-30 10:48:02 -05:00
Gregory John Casamento
b7eb68b67c Fix warnings and errors, apply attributes from NSCollectionViewLayoutAttributes to view 2023-01-30 10:48:02 -05:00
Gregory John Casamento
68f1444de3 Add all overriden methods in flow layout. In NSCollectionView set collectionView in layout. Minor code cleanup. 2023-01-30 10:48:02 -05:00
Gregory John Casamento
42a5f34095 Add code to correctly read information for NSCollectiViewLayout from xib file 2023-01-30 10:48:02 -05:00
Gregory John Casamento
a90ddfc9c5 Add changes for Xib reading and some minor cleanup for NSCollectionView 2023-01-30 10:48:02 -05:00
Gregory John Casamento
8572458a5d Add methods and actions for layout classes as well as the abstract classes for NSCollectionViewLayout. 
Declarations added to collectionview layout header.

Clean compile for NSCollectionViewLayout abstract class

Add header for NSCollectionViewFlowLayout.h

Add skeleton implementation of NSCollectionViewFlowLayout

Add implementation for simple setter/getter methods.

Correct compilation error with non-clang compilers

Fix compilation issues

Add getter/setter for collectionViewLayout

Skeleton of NSCollectionViewTransitionLayout implementation

Add encoding/decoding for collectionViewLayout key

Make NSCollectionViewGridLayout default if the NSCollectionViewLayoutKey is not set

Add protocols for DataSource and Prefetching for NSCollectionView

Add 10.11 methods to delegate declaration

remove templating from NSCollectionViewDelegate that gcc can't handle.

New delegate methods for NSCollectionViewDelegate to support NSSets of NSIndexPaths and multiple selection.

Reset .travis.yml to the proper version and modify NSCollectionView.h to use forward declarations for both NSPasteboard and NSPasteboardWriting so that we don't explicitly import.

Add declarations for missing methods from 10.11 version of NSCollectionView

Add new methods for 10.11 for moving, deleting and collapsing sections.

Add new methods from 10.11

Add the remaining missing methods as well as delcarations for blocks needed for batch handler and completion handler.

Add skeleton implementations for all new methods

Changes to add new methods to collection view for delegate

Consolidate the registeredClass and registeredNib maps.

Implementation of dataSource related methods

Implment nib loading for NSCollectionViewItem subclasses

Remove uneeded ivars, add categories for override and layout

Minor formatting change

Update categories and organization of code

Add init method to NSCollectionViewFlowLayoutInvalidationContext

Add collectionview layout subclasses

Declarations added to collectionview layout header.

Clean compile for NSCollectionViewLayout abstract class

Add skeleton implementation of NSCollectionViewFlowLayout

Add implementation for simple setter/getter methods.

Correct compilation error with non-clang compilers

Fix compilation issues

Add getter/setter for collectionViewLayout

Add encoding/decoding for collectionViewLayout key

Make NSCollectionViewGridLayout default if the NSCollectionViewLayoutKey is not set

Add protocols for DataSource and Prefetching for NSCollectionView

New delegate methods for NSCollectionViewDelegate to support NSSets of NSIndexPaths and multiple selection.

Reset .travis.yml to the proper version and modify NSCollectionView.h to use forward declarations for both NSPasteboard and NSPasteboardWriting so that we don't explicitly import.

Add declarations for missing methods from 10.11 version of NSCollectionView

Add new methods for 10.11 for moving, deleting and collapsing sections.

Add new methods from 10.11

Changes to add new methods to collection view for delegate

Consolidate the registeredClass and registeredNib maps.

Add init method to NSCollectionViewFlowLayoutInvalidationContext

Fix issues with rebase
 2023-01-30 10:48:02 -05:00
Gregory John Casamento
aee03ee7c4 Add collectionview layout subclasses 2023-01-30 10:48:02 -05:00
Gregory John Casamento
b803d348fb Set size to size of the view that was added as the content view 2023-01-14 03:34:04 -05:00
Gregory John Casamento
e87e48a4b2 Add spaces 2023-01-12 18:40:27 -05:00
Gregory John Casamento
0f650158a8 Attempt to capture what @fredkiefer had suggested and fix issue mentioned by @rmotolla 2023-01-12 18:40:27 -05:00
Gregory John Casamento
b12d151163 Implement it the way @fredkiefer suggested. Check which side has more room. 2023-01-12 18:40:27 -05:00
Gregory John Casamento
d649b99418 Minor positional adjustment 2023-01-12 18:40:27 -05:00
Gregory John Casamento
5a71c1c944 Fix issues raised by fred's comments 2023-01-12 18:40:27 -05:00
Gregory John Casamento
b434708d5e Fix issue where drawer opens for a moment on the preferredEdge instead of the computed one 2023-01-12 18:40:27 -05:00
Gregory John Casamento
3f1e8af9c4 Open on side away from the edge of the screen if there is not enough room 2023-01-12 18:40:27 -05:00
Richard Frith-Macdonald
3477b3f1d9 Fix potential call of null block 2022-12-29 09:01:33 +00:00
Fred Kiefer
8ccc89b83d
Merge pull request #161 from BennyKJohnson/constraint-vfl-support 
Implement constraintsWithVisualFormat method on NSLayoutConstraint
 2022-11-24 22:52:34 +01:00
Benjamin Johnson
a1c2115bc3 Fix GCC compiler warnings for GSAutoLayoutVFLParser.m 2022-11-22 08:21:05 +11:00
Benjamin Johnson
44f8950e3b Address for feedback for GSAutoLayoutVFLParser 
- Move assertion for empty string to parse method
- Add missing spaces between colon and parameter
- Use GSFastEnumeration macro
- Modify parseObjectOfPredicate to use in out parameter of struct and remove heap allocation
 2022-11-13 06:15:02 +11:00
Benjamin Johnson
609d03ac41 Address feedback on GSAutoLayoutVFLParser 
- Add space between parameter name and parameter
- Use release macro in constraintsWithVisualFormat
 2022-11-12 12:09:29 +11:00
Benjamin Johnson
13123a054e Fix formatting of GSAutoLayoutVFLParser and add copyright notice 2022-11-11 05:55:02 +11:00
Fred Kiefer
e4ecfb0801 * Headers/Additions/GNUstepGUI/GSLayoutManager.h, 
* Source/GSLayoutManager.m: Add new methods
-defaultLineHeightForFont: and -defaultBaselineOffsetForFont:.
 2022-11-05 21:01:53 +01:00
Benjamin Johnson
1aff56cb9b Implement constraintsWithVisualFormat method on NSLayoutConstraint 2022-11-05 20:33:23 +11:00
Fred Kiefer
59558a519d
Merge pull request #160 from gnustep/AttachmentIndexFix 
Fix click on TextAttachmentCells, where the left side was not respected.
 2022-10-25 23:06:47 +02:00
Riccardo Mottola
85155fd64f Fix click on TextAttachmentCells, where the left side was not respected. 
This was because index was respecting fraction and thus loosing the attachment when clicking on the right part, only for this case, recalculate character index without respectFraction.
 2022-10-11 23:26:51 +02:00
Gregory John Casamento
92d27c494f Add defines for export of classes to DLL when building on WIndows 2022-09-29 12:09:13 -04:00
Gregory John Casamento
0633f214c5 Remove unneeded import 2022-09-01 15:39:45 -04:00
Gregory John Casamento
a2b57fd1f3 Move logic to detect if it's a radio button to NSButtonCell, also simplify logic to flip the button state and prevent switch to off if button is currently on and is a radio button. This is consistent with 10.7+ behavior 2022-09-01 09:22:45 -04:00
Gregory John Casamento
3558247662 Move the call to a more centralized method so that it will be called in all cases without repeating code. 2022-08-28 05:22:16 -04:00
Gregory John Casamento
fdba6d2be6 Fixes as discussed with @fredkiefer 2022-08-27 10:09:56 -04:00
Gregory John Casamento
a9ca806c2b Changes to address issue #151. This should correct behavior of NSRadio buttons in GS and should implement the behavior seen in 10.7+ 2022-08-27 03:46:12 -04:00
Sebastian Reitenbach
857c173d03 Don't misuse libgnustep-gui_INTERFACE_VERSION to define Resource Install paths 
$(GNUSTEP_INSTANCE)_INTERFACE_VERSION is used in gnustep-make to define
the version of the shared object.

As a packager, there might be various reasons to
override the $(GNUSTEP_INSTANCE)_INTERFACE_VERSION
in order to control the library version.

So I do for gnustep-gui on OpenBSD packages. The problem here is, that
the libgnustep-gui_INTERFACE_VERSION is additionally used to specify the path
where resources like Panels, Localizations etc. get installed, however,
in Source/NSApplication.m, the use of
GNUSTEP_GUI_MAJOR_VERSION.GNUSTEP_GUI_MINOR_VERSION

As long as the libgnustep-gui_INTERFACE_VERSION is not overridden with
some other value, everything is fine. However, as in my case, Applications
aren't able to find the Panels/Translations provided by -gui anymore.

Decided to just remove the definition of libgnustep-gui_INTERFACE_VERSION
in these three Makefiles, as it was only used once, and used the
GNUSTEP_GUI_MAJOR_VERSION.GNUSTEP_GUI_MINOR_VERSION directly.

Alternatively, libgnustep-gui_INTERFACE_VERSION in these Makefiles
could could have been renamed to avoid this conflict.
 2022-08-19 15:54:41 +02:00
Gregory John Casamento
bd3c954807 Merge branch 'master' of github.com:gnustep/libs-gui 2022-08-09 01:25:59 -04:00
Fred Kiefer
34423da47e * Source/NSImageCell.m, 
* Source/NSAccessibilityCustomAction.m,
* Source/NSStackView.m,
* Source/NSGridView.m: Fix compiler warnings
 2022-06-12 22:13:06 +02:00
Gregory John Casamento
751d94aa2c Temporary fix for issue caused by libs-base change 2022-04-30 02:27:38 -04:00
Riccardo Mottola
e0012349f6 Refactor resize bar notch width to be a constant and private inside GSTheme, making it accessible through -[GSTheme resizebarNotchWidth]. 2022-03-31 23:43:52 +02:00
Riccardo Mottola
96db5bf89c Fix resizing mode by fixing initialization order. 2022-03-31 22:58:02 +02:00
Gregory John Casamento
f21aa20815 Move check of index in 'key' before the xpath call 2022-03-29 20:06:53 -04:00
Gregory John Casamento
5f3b54e330 GSXibKeyedUnarchiver: Change format of customClasses dictionary 2022-03-29 19:49:35 -04:00
Gregory John Casamento
39bd359505 Move createCustomClassRecordForId:... to parent class 2022-03-28 18:47:41 -04:00
Gregory Casamento
33fea1762d
Merge branch 'master' into custom_class_xib3_changes 2022-03-26 11:28:29 -04:00
Gregory John Casamento
790b686f0d Move _customClasses to GSXibKeyedUnarchiver and implement logic to build the _customClasses array for use in Gorm when loading the xib file. 2022-03-26 11:19:59 -04:00
Gregory John Casamento
de767ac0e0 Add version logic to correct issue for older gorm archives 2022-03-24 07:57:09 -04:00
Riccardo Mottola
6ec6f20f19 subclass initImageCell, so that RefusesFirstResponder can be set, matching Mac. 2022-03-22 22:52:06 +01:00
Wolfgang Lux
efb9bcb2e7 Select the first item of a NSPopUpButtonCell's new menu 2022-02-26 15:30:26 +01:00
Wolfgang Lux
ec3353ecd8 Never change the state of the selected item of a NSPopUpButton configured as a pull down 2022-02-26 15:21:04 +01:00
Gregory John Casamento
606505326c Minor change: Add all new headers to DocMakefile 2022-02-21 14:22:47 -05:00
Fred Kiefer
7c1af2c874
Merge pull request #140 from williameveretteggplant/autoreleasepool_NSTextView 
Fix memory leak in NSTextView
 2022-02-14 23:42:08 +01:00
williameveretteggplant
b70fad26a6
Use autorelease pool macros 2022-02-14 15:35:37 -07:00
williameveretteggplant
0211713766
Remove extra line 2022-02-14 14:16:42 -07:00
williameveretteggplant
9925f50aef
Indentation 2022-02-14 14:15:26 -07:00
williameveretteggplant
aae1f34d0d
Undo change 2022-02-14 14:09:34 -07:00
williameveretteggplant
2403c21978
Fix memory leak of tool tips 
Prevents the creation of tool tips where they don't already exist. Tool tips only need to be removed in the rect if there are tool tips.
 2022-02-14 14:03:49 -07:00
williameveretteggplant
f37e93a440
Fix memory leak in NSTextView 
On Windows, there is an occasional sporadic failure of autorelease to work correctly. In particular, this seems to happen when autorelease is invoked on an object while a call stack is in the middle of draining an autorelease pool. So, for example, when dealloc is called on an NSTextContainer, it then calls setTextContainer: on the associated NSTextView, which in turn calls textContainers on the layoutManager, which returns an autoreleased array of NSTextContainers. This array is sometimes released and sometimes it isn't.
Wrapping the setTextContainer: in an autorelease pool, which will then drain at the end of the method, rather than relying on the main autorelease pool in the run loop (which is in the middle of being drained), appears to fix this problem. This adds a small amount of overhead, but also makes the memory usage a little more efficient, since anything autoretained during the course of this method is released more quickly.
 2022-02-11 17:12:50 -07:00
williameveretteggplant
3190ce4363
Merge pull request #1 from williameveretteggplant/patch-1 
Fix memory leak in NSBox
 2022-02-11 16:17:11 -07:00
williameveretteggplant
d744b26429
Fix GSToolTips leak in NSView 
ToolTips can be present even when the flag is false, and it does no harm to invoke removeTipsForView: even if there are none. So this fixes a memory leak without any downside.
 2022-02-11 16:15:28 -07:00
williameveretteggplant
db5ad42d8a
Fix memory leak in NSBox 2022-02-11 16:09:35 -07:00
Wolfgang Lux
f5ebdcd1d2 Do not update selected item's state when changing the menu 2022-02-08 22:21:38 +01:00
Wolfgang Lux
c50ef9d8fa Restore fix for @97351199e 2022-02-07 18:19:03 +01:00
Wolfgang Lux
e4bd00f6eb Fix to avoid dangling pointer when changing the menu of a NSPopUpButtonCell 2022-02-06 15:58:18 +01:00
Gregory John Casamento
67860bf8c1 Add declarations for setPlaceholderString:/setPlaceholderAttributedString and getters to header and implementation to NSTextField.m 2022-01-12 04:45:56 -05:00
Gregory John Casamento
ebc6eb99a3 Quick fix for compilation error 2022-01-12 01:45:49 -05:00
Gregory John Casamento
937c309c15 Quick fix for compilation error 2022-01-12 01:45:10 -05:00
Gregory John Casamento
fda74bfde8 Add changelog 2022-01-11 20:13:00 -05:00
Gregory John Casamento
93a0fc46ea Use macro for fast enumeration 2022-01-11 20:10:09 -05:00
anthony
49e30a3378 GSStandardWindowDecorationView: Apply userSpaceScaleFactor to title bar height when calculating offsets 2022-01-11 19:51:45 +00:00
Fred Kiefer
b84d8cc3fd * Headers/Additions/GNUstepGUI/GSWindowDecorationView.h: 
Move new addon methods for Wayland to correct class
GSStandardWindowDecorationView.
* Source/GSWindowDecorationView.m: Keep variables declarations together.
 2021-12-28 17:23:48 +01:00
Fred Kiefer
bc9d477a9f
Merge pull request #124 from nongio/windowdecoration-expose 
Add helper methods in GSWindowDecorator protocol
 2021-12-27 17:51:50 +01:00
Riccardo Canalicchio
8ec514e049 pointInTitleBarRect: remove hit-test from window buttons 2021-12-27 15:12:17 +01:00
Fred Kiefer
97351199e3 * Source/NSPopUpButtonCell.m: Try to prevent segmenation fault 
when deallocating a popup button.
 2021-12-26 23:46:02 +01:00
Fred Kiefer
4ad217d5c3 * Source/NSMenu.m: Rename method on NSMenuPanel for the Wayland 
backend to -_menu to keep it apart from the already existing method
-menu on NSResponder.
* Source/NSSplitView.m: Correct decoded integer type.
 2021-12-26 14:50:50 +01:00
Riccardo Canalicchio
4eafb6f34c Add helper methods in GSWindowDecorator protocol for pointer hit test on window decorations 2021-12-17 09:09:37 +01:00
Gregory John Casamento
1d3f33b694 Restore older behavior for version 0 of NSSplitView. The previous change broke some older .gorm files. 2021-12-01 19:42:40 -05:00
Gregory John Casamento
d20fa6cc61 Make sure that the setDividerStyle: mthod is called only once when decoding from a gorm file 2021-11-18 18:01:45 -05:00
Gregory John Casamento
dae13af553 Check [bc isLoaded] before making window first responder 2021-11-18 13:17:56 -05:00
Gregory John Casamento
334e26eeb0 Add support for Thick/Thin/PaneSplitter NSSplitView settings 2021-11-15 10:20:33 -05:00
Gregory John Casamento
8ac4bf7547 NSSplitView, use CGFloat to encode _draggedBarWidth 2021-11-15 09:52:26 -05:00
Gregory Casamento
aae4b5897d Use macro for encoding and decoding NSInteger. 2021-11-15 09:52:26 -05:00
Gregory Casamento
963938923b Make some of the updates suggested by fred. 2021-11-15 09:52:26 -05:00
Gregory John Casamento
f88f70ca17 Implement arrangesAllSubview and other related methods. 2021-11-15 09:52:26 -05:00
Gregory John Casamento
54e555bc33 Add support for dividerThickness and bump version of NSSplitView to 1 2021-11-15 09:52:26 -05:00
Gregory John Casamento
8fa489282b Fix compilation error. Added cast to (id) for nil when working with GSIArrayItem and GSIArray. This issue wasn't caught by CI since gui was not recompiled after base was altered. 2021-11-15 08:59:36 -05:00
Fred Kiefer
a047b10a51
16bit (#123) 
* Fix compiler warnings

* Attempt to sort out byte order for 15 bit images.

* Try to get integer types from standard location

* Remove extra swap code by using more complex condition.
Thanks to Riccardo Mottola.
 2021-11-08 22:46:25 +01:00
Riccardo Canalicchio
1e670335f6 expose menu attribute, required for wayland backend submenu 2021-11-07 15:33:21 -05:00
Gregory John Casamento
97379423f0 Revert change per discussion with @fredkiefer. 2021-10-27 16:14:57 -04:00
Gregory John Casamento
7023c7d06d Add remaining changes contributed by testplant. 2021-10-27 15:18:23 -04:00
Gregory John Casamento
ac5b949f2a Add fix to prevent iterating past the number of visible back views. 2021-10-27 15:00:38 -04:00
Gregory John Casamento
5666d7b7c2 Add NSScrollView keys for init/encodeWithCoder 2021-10-27 12:34:58 -04:00
Gregory John Casamento
e9548dd057 Add extra pixels to tooltip 2021-10-27 11:59:39 -04:00
Riccardo
58359b8de3
update signatures to match Apple (#120) 2021-10-26 16:17:45 +02:00
Riccardo Mottola
5e837b6858 Keep local variables to ensure correct values during recursion. 2021-10-25 23:22:32 +02:00
Gregory Casamento
7617392f80
Merge pull request #118 from gnustep/NSGlyphInfo_branch 2021-10-21 16:38:54 -04:00
Riccardo
8892408c8f
add a preference to disable spellchecker (#115) 
* add a preference to disable spellchecker

* add GSDisableSpellCheckerServer

* fix typo and unintentional error.

* be clearer about default.

* one was too much
 2021-10-18 22:29:50 +02:00
Gregory John Casamento
ffdffbe65e Add comment to NSGlyphInfo 2021-10-15 11:35:48 -04:00
Gregory John Casamento
8d4b0b26da Add NSGlyphInfo class. Initial implementation, will write some tests to determine behavior on macOS 2021-10-14 07:11:36 -04:00
Gregory John Casamento
98ebe51150 Remove exception when [indexes lastIndex] > numberOfColumns 2021-10-13 13:54:43 -04:00
Gregory John Casamento
a3d73cd3fb Merge branch 'master' of github.com:gnustep/libs-gui 2021-10-13 08:26:42 -04:00
Gregory John Casamento
73c03767df Add tabview enum to header, fix signture issue. 2021-10-13 08:26:37 -04:00
Riccardo Mottola
c6e4f8ef40 reapply checks about structs more carefully 2021-10-13 12:42:18 +02:00
Riccardo Mottola
08baddba7f Revert "be more careful when freeing structs" for accidentally committing another patch together which should be reviewed separately. 
This reverts commit 0c2157deaf.
 2021-10-13 12:36:20 +02:00
Gregory Casamento
723ddc2a22
Merge pull request #114 from gnustep/TP_NSNibLoading_branch 2021-10-12 19:39:05 -04:00
Gregory John Casamento
edc38e137f Merge branch 'master' of github.com:gnustep/libs-gui 2021-10-12 19:20:30 -04:00
Gregory John Casamento
19426c573d Update behavior of initWithBitmapDataPlanes:... to match documentation and return nil if it cannot initialize given the existing data 2021-10-12 19:20:24 -04:00
Gregory John Casamento
9c3f0fbbf3 Add new test for NSNibLoading. Add method loadNibNamed:owner:topLevelObjects: 2021-10-11 09:42:46 -04:00
Riccardo Mottola
f23139ddfb match delegates to actual Apple signature 2021-10-11 01:39:08 +02:00
Riccardo Mottola
0c2157deaf be more careful when freeing structs 2021-10-09 07:54:44 +02:00
Gregory John Casamento
0e54694019 Remove uneeded method declaration. 2021-10-03 05:17:00 -04:00
Gregory John Casamento
8395509199 Merge branch 'NSPopover_branch' of github.com:gnustep/libs-gui into NSPopover_branch 2021-10-03 05:15:31 -04:00
Gregory John Casamento
35a5b3c156 Fix final issues. 2021-10-03 05:15:16 -04:00
Gregory Casamento
9a5d7a2071
Yet again, to fix indentation. 2021-10-03 05:01:50 -04:00
Gregory Casamento
5600d29cc3
Force fix for spacing issue. 
It seems as though, even though this shows correctly in emacs, it does not show the proper spacing on github.
 2021-10-03 05:00:14 -04:00
Gregory John Casamento
5a2b657431 Remove gsdoc comments from source and move them to the header file for NSPopover.m/h. Correct indentation. Remove _contentView as it was causing a memory leak, simply add as a subview. 2021-10-03 04:54:35 -04:00
Gregory John Casamento
87e30f8514 Add code to dismiss popover if another window issmade key. Minor corrections to GSToolTips.m so that it uses the RELEASE/AUTORELEASE macros. 2021-10-02 17:28:24 -04:00
Gregory John Casamento
166ea25ef0 Add code to load the popover properly when not using a storyboard based application 2021-09-30 03:38:22 -04:00
Marco Hladik
86fa9b1d67
Added version checks for ImageMagick 7, to be safe! 2021-09-28 02:50:18 +02:00
Marco Hladik
092f93aed5
Fix compilation against ImageMagick 7.X when compiling with --enable-imagemagick 2021-09-24 23:05:58 +02:00
Gregory John Casamento
9abf2a7494 ASSIGN name to _name in initWithName:target:selector: 2021-09-14 02:38:24 -04:00
Gregory John Casamento
c6fc8e0984 Add simple implementation to NSAccessibilityCustomAction.m 2021-09-13 18:19:31 -04:00
Riccardo Mottola
0ded9f7ea2 force origin to (0,0) as suggested by Fred for a Subview 2021-06-17 23:16:20 +02:00
Riccardo Mottola
0b1771198f When initializing the text view do not use the document view of the scroll view which is not yet set and invalid. (Fixes exceptions/crashes - fix by Fred Kiefer) 2021-06-17 14:12:59 +02:00
Gregory John Casamento
d3a1fd1119 Remove some unneeded comments in init method 2021-05-27 18:35:15 -04:00
Gregory John Casamento
ec1eb16cc8 Changes to return proper subview and arrangedSubview arrays for NSStackView. Refresh view when arranged subviews are set. 2021-05-27 08:14:43 -04:00
Gregory John Casamento
f481605a6a Intermediate work on layout for container. 2021-05-27 08:05:14 -04:00
Gregory John Casamento
4002c0efa0 Show stack view container contents 2021-05-27 06:34:00 -04:00
Gregory John Casamento
1687283ccf Fix decoding of NSStackViewContainerNonDroppedViews 2021-05-26 06:56:30 -04:00
Gregory John Casamento
e96de59a83 Fix decoding of NSStackViewContainerNonDroppedViews 2021-05-26 06:41:19 -04:00
Gregory John Casamento
1ed368de09 Add encoding for NSStackViewContainer class 2021-05-26 03:24:08 -04:00
Gregory John Casamento
6e5abba867 Add decoding keys for NSStackViewContainer 2021-05-26 02:31:43 -04:00
Gregory John Casamento
386d5aee5f Fix distribution decoding for NSStackView 2021-05-25 12:56:57 -04:00
Gregory John Casamento
7a01dc7a99 Minor improvements 2021-05-25 07:25:19 -04:00
Gregory John Casamento
65ade78a5a Fix issue with expanding control when needed 2021-05-24 08:13:28 -04:00
Gregory John Casamento
1414cfeff6 Add implementation for horizontal view without containers 2021-05-24 07:14:44 -04:00
Gregory John Casamento
ba065e55e2 More corrections to calculation. 2021-05-24 06:54:38 -04:00
Gregory John Casamento
f06f27f40d More corrections to calculation. Move logic to _layoutViewsInView:withOrientation: 2021-05-24 06:40:52 -04:00
Gregory John Casamento
9c43880d85 More corrections to calculation. Move logic to _layoutViewsInView:withOrientation: 2021-05-24 06:03:23 -04:00
Gregory John Casamento
346138b042 More fixes 2021-05-23 16:13:30 -04:00
Gregory John Casamento
47b7b0b084 More fixes 2021-05-23 15:40:17 -04:00
Gregory John Casamento
37b1475f54 Slightly refactor where we are getting the frame 2021-05-23 15:33:40 -04:00
Gregory John Casamento
b4e7f7c065 Correct the math for calculating view position. 2021-05-23 14:29:05 -04:00
Gregory John Casamento
d9ed92cdec Fix xib encoding for stack view, update MISSING file, add decoding for distribution, update NSStackView _refreshView method, update methods for adding views to stackview. 2021-05-20 22:31:00 -04:00
Gregory John Casamento
47d48a1659 Add methods to handle orientation in NSStackView. 2021-05-18 21:34:19 -04:00
Gregory John Casamento
8814229de5 Add container and methods needed to manage views 2021-05-17 23:56:42 -04:00
Gregory John Casamento
c67a284440 Add private stackview container class. 2021-05-17 22:46:13 -04:00
Gregory John Casamento
fe365693bd Add middle and end containers. Rename keys correctly according to nib file. 2021-05-17 10:56:37 -04:00
Gregory John Casamento
b5f820d052 Implement _hasEqualSpacing 2021-05-17 06:15:56 -04:00
Gregory John Casamento
3fd0f590f4 Implement encodeWithCoder: for NSStackView 2021-05-17 05:45:25 -04:00
Gregory John Casamento
00672662de Implement initWithCoder for NSStackView 2021-05-17 05:29:22 -04:00
Gregory John Casamento
2fe5ce8056 Add more info to debug when insert or addView methods are called 2021-05-17 01:08:08 -04:00
Gregory John Casamento
a2b48d2103 Add private views for storing things in different gravity settings 2021-05-17 01:06:59 -04:00
Gregory John Casamento
d415a75a03 Decoding for NSStackView 2021-05-16 02:47:55 -04:00
Gregory John Casamento
6e954298e2 Add call to allowsKeyedCoding to determine if encoding should be done for NSProxyObject 2021-05-15 21:37:59 -04:00
Gregory Casamento
a354fb0f7f
Merge pull request #103 from gnustep/xib_gorm_integration 
XIB/Gorm integration
 2021-05-06 23:08:16 -04:00
Riccardo Mottola
a4c5e48839 if a Help viewer is found and the file is opened, do not beep 2021-05-07 02:46:45 +02:00
Gregory Casamento
91fe895197
Merge branch 'master' into xib_gorm_integration 2021-05-02 12:17:13 -04:00
Gregory John Casamento
9534755dbb Add logic to build an array which contains information to recreate custom class associations in GSXib5KeyedUnarchiver 2021-04-28 19:04:04 -04:00
Gregory John Casamento
74f8e99c2c Add to the description of IBConnector so that it shows more detail. 2021-04-26 19:57:39 -04:00
Gregory John Casamento
79fa1b68cd Changes to facilitate XIB loading in IB/Gorm. Added customClassNames to IBObjectContainer and skipped instantiation of custom classes in GSXib5KeyedUnarchiver if we are currently loading as a model in IB/Gorm. 2021-04-25 10:04:34 -04:00
Gregory John Casamento
b97aca9cd4 Removed unused GSXibObjectContainer.[hm] files from directory and from GNUmakefile 2021-04-24 11:08:21 -04:00
Gregory John Casamento
d9921efd8e Use [GSModelLoaderFactory modelLoaderForData:] to generically implement methods that unarchive a model purely from data since we cannot use the file extension to determine which loader to instantiate. 2021-04-24 08:51:32 -04:00
Gregory John Casamento
0d3c3d1b2a Add interface and abstract implementation of modelLoaderForData: 2021-04-24 06:06:45 -04:00
Gregory John Casamento
b5ecb4e490 Quick fix. Remove unecessary warning about storyboard in NSApplicationMain function 2021-04-23 07:04:47 -04:00
Gregory Casamento
72d9db4e4b
Merge pull request #74 from gnustep/NSGridView_NSStackView_branch 
NSGridView branch
 2021-03-29 10:12:05 -04:00
Fred Kiefer
0576f2736b * Source/NSControl.m (-textDidChange:): If there is a binding with 
continious update, pass on the changed text.
* Source/GSXibElement.m: Correct the handling of boolean values in attributes.
* Source/GSBindingHelpers.h,
* Source/NSKeyValueBinding.m: Prevent recursion when
reverseSetValue: is used.
* Source/NSTextField.m (-textDidChange:): Remove empty code line.
 2021-03-27 21:20:28 +01:00
Gregory John Casamento
b1b6e9a2a1 Add padding back into calculation 2021-03-26 18:08:30 -04:00
Gregory John Casamento
a9598d9d10 Commit fixes for all issues Fred mentioned except for formatting. 2021-03-26 02:58:30 -04:00
Gregory John Casamento
bf381f8c31 Remove incorrect calculations in _refreshCells 2021-03-23 20:11:54 -04:00
Gregory John Casamento
914bcb6f68 Incorporate all suggestions made by Fred K. 2021-03-23 19:58:05 -04:00
Gregory John Casamento
d818fc42d4 Fix implementation of initWithViews: 2021-03-22 20:03:46 -04:00
Gregory John Casamento
ac2e5ff680 Change name of method _findPrototypeView to _prototypeFrame 2021-03-22 18:10:32 -04:00