gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-06-01 00:50:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

* Source/NSView.m (-setBounds:, -setBoundsOrigin:, -setBoundsSize:):

Browse source 
Revert a portion of r32955 which I committed last april but I now
see was a mistake, and I just discovered is breaking the  copy-on-scroll
behaviour of NSClipView - we end up always redrawing the entire visible
portion of the document view right now.

In r32955 I added [self setNeedsDisplay: YES] calls to these methods
even though these are documented explicitly as not marking the view for
needing display. Approved by Fred for commit during the code freeze.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@34606 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
ericwa 2012-01-21 19:15:51 +00:00
parent 73222b4de7
commit 81b8b6a826
2 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
ChangeLog
View file

@ -1,3 +1,15 @@
2012-01-21 Eric Wasylishen <ewasylishen@gmail.com>
* Source/NSView.m (-setBounds:, -setBoundsOrigin:, -setBoundsSize:):
Revert a portion of r32955 which I committed last april but I now
see was a mistake, and I just discovered is breaking the copy-on-scroll
behaviour of NSClipView - we end up always redrawing the entire visible
portion of the document view right now.
In r32955 I added [self setNeedsDisplay: YES] calls to these methods
even though these are documented explicitly as not marking the view for
needing display. Approved by Fred for commit during the code freeze.
2012-01-20 German Arias <german@xelalug.org> 2012-01-20 German Arias <german@xelalug.org>
* Source/GSInfoPanel.m (-initWithDictionary:): Fix bug #35335. * Source/GSInfoPanel.m (-initWithDictionary:): Fix bug #35335.

12
Source/NSView.m
View file

@ -1447,10 +1447,6 @@ static NSSize _computeScale(NSSize fs, NSSize bs)
object: self]; object: self];
} }
} }
// FIXME: Should not be called here according to Cocoa docs, but
// Cocoa seems to in practice
[self setNeedsDisplay: YES];
} }
- (void) setBoundsOrigin: (NSPoint)newOrigin - (void) setBoundsOrigin: (NSPoint)newOrigin
@ -1471,10 +1467,6 @@ static NSSize _computeScale(NSSize fs, NSSize bs)
} }
[self translateOriginToPoint: NSMakePoint(oldOrigin.x - newOrigin.x, [self translateOriginToPoint: NSMakePoint(oldOrigin.x - newOrigin.x,
oldOrigin.y - newOrigin.y)]; oldOrigin.y - newOrigin.y)];
// FIXME: Should not be called here according to Cocoa docs, but
// Cocoa seems to in practice
[self setNeedsDisplay: YES];
} }
- (void) setBoundsSize: (NSSize)newSize - (void) setBoundsSize: (NSSize)newSize
@ -1535,10 +1527,6 @@ static NSSize _computeScale(NSSize fs, NSSize bs)
[nc postNotificationName: NSViewBoundsDidChangeNotification [nc postNotificationName: NSViewBoundsDidChangeNotification
object: self]; object: self];
} }
// FIXME: Should not be called here according to Cocoa docs, but
// Cocoa seems to in practice
[self setNeedsDisplay: YES];
} }
- (void) setBoundsRotation: (CGFloat)angle - (void) setBoundsRotation: (CGFloat)angle