gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-05-31 23:30:48 +00:00
Code Issues Projects Releases Packages Wiki Activity

* Source/NSBrowser.m fixed bug where column matrix was getting released

Browse source 
twice in method _performLoadOfColumn.
* NSCell.m: isOpaque returns whether cell is bezeled per NS docs.
* NSText.m: implemented setBackground and back color release in dealloc.
* NSMenu.m: insertItemWithTitle moved set font position for performance


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@2856 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
far 1998-07-18 19:21:22 +00:00
parent 05cca82b8e
commit 6759387bf1
3 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog
View file

@ -1,8 +1,10 @@
Tues July 14 1998 Felipe A. Rodriguez <far@ix.netcom.com> Tues July 18 1998 Felipe A. Rodriguez <far@ix.netcom.com>
* Source/NSBrowser.m fixed bug where column matrix was getting released * Source/NSBrowser.m fixed bug where column matrix was getting released
twice in method _performLoadOfColumn. twice in method _performLoadOfColumn.
* NSCell.m: isOpaque returns whether cell is bezeled per NS docs. * NSCell.m: isOpaque returns whether cell is bezeled per NS docs.
* NSText.m: implemented setBackground and back color release in dealloc.
* NSMenu.m: insertItemWithTitle moved set font position for performance
Fri May 29 13:30:14 1998 Adam Fedor <fedor@ultra.doc.com> Fri May 29 13:30:14 1998 Adam Fedor <fedor@ultra.doc.com>

3
Source/NSMenu.m
View file

@ -142,10 +142,11 @@ static NSFont* menuFont = nil;
{ {
id menuCell = [[[NSMenu cellClass] new] autorelease]; id menuCell = [[[NSMenu cellClass] new] autorelease];
[menuCell setFont:menuFont]; // set font first in order to avoid
// recalc of some cached params in xraw
[menuCell setTitle:aString]; [menuCell setTitle:aString];
[menuCell setAction:aSelector]; [menuCell setAction:aSelector];
[menuCell setKeyEquivalent:charCode]; [menuCell setKeyEquivalent:charCode];
[menuCell setFont:menuFont];
[cells insertObject:menuCell atIndex:index]; [cells insertObject:menuCell atIndex:index];
[self _resizeMenuForCellSize]; [self _resizeMenuForCellSize];

14
Source/NSText.m
View file

@ -35,6 +35,10 @@
#include <AppKit/NSFont.h> #include <AppKit/NSFont.h>
#include <AppKit/NSColor.h> #include <AppKit/NSColor.h>
#define ASSIGN(variable, value) [value retain]; \
[variable release]; \
variable = value;
// //
// NSText implementation // NSText implementation
// //
@ -78,6 +82,14 @@
default_font = [NSFont userFontOfSize:12]; default_font = [NSFont userFontOfSize:12];
return self; return self;
} }
- (void)dealloc
{
[background_color release];
[super dealloc];
}
// //
// Getting and Setting Contents // Getting and Setting Contents
// //
@ -201,7 +213,7 @@
- (void)setBackgroundColor:(NSColor *)color - (void)setBackgroundColor:(NSColor *)color
{ {
background_color = color; ASSIGN(background_color, color);
} }
- (void)setColor:(NSColor *)color - (void)setColor:(NSColor *)color