gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-05-31 20:40:47 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix problem with pull-down menu not allowing same item to be selected twice in a row

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@31232 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
dpsimons 2010-09-02 21:18:00 +00:00
parent ae51e23b36
commit 3d9f597bca
2 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
ChangeLog
View file

@ -1,3 +1,10 @@
2010-09-02 Doug Simons <doug.simons@testplant.com>
* Source/NSPopUpButtonCell.m:
Fix problem with pull-down menu not allowing same item to be selected
twice in a row. Also correct setAltersStateOfSelectedItem: to work as
described in the Cocoa docs (states were reversed).
2010-08-30 Doug Simons <doug.simons@testplant.com> 2010-08-30 Doug Simons <doug.simons@testplant.com>
* Source/NSPopUpButtonCell.m: * Source/NSPopUpButtonCell.m:

12
Source/NSPopUpButtonCell.m
View file

@ -320,11 +320,11 @@ static NSImage *_pbc_image[5];
if (flag) if (flag)
{ {
[selectedItem setState: NSOffState]; [selectedItem setState: NSOnState];
} }
else else
{ {
[selectedItem setState: NSOnState]; [selectedItem setState: NSOffState];
} }
_pbcFlags.altersStateOfSelectedItem = flag; _pbcFlags.altersStateOfSelectedItem = flag;
@ -649,7 +649,13 @@ static NSImage *_pbc_image[5];
id<NSMenuItem> oldSelectedItem = _selectedItem; id<NSMenuItem> oldSelectedItem = _selectedItem;
if (_selectedItem == item) if (_selectedItem == item)
return; {
// pull-down should set highlighted item even when selection is unchanged
if (_pbcFlags.pullsDown)
[[_menu menuRepresentation] setHighlightedItemIndex:
[_menu indexOfItem: _selectedItem]];
return;
}
if (_selectedItem != nil) if (_selectedItem != nil)
{ {