gnustep/libs-gui
0
0
Fork 0
mirror of https://github.com/gnustep/libs-gui.git synced 2025-05-31 21:00:47 +00:00
Code Issues Projects Releases Packages Wiki Activity

* Source/NSBrowser.m fixed bug where column matrix was getting released

Browse source 
twice in method _performLoadOfColumn.
* NSCell.m:  isOpaque returns whether cell is bezeled per NS docs.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gui/trunk@2835 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
far 1998-07-14 17:51:44 +00:00
parent 5d589124bb
commit 05cca82b8e
4 changed files with 33 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog
View file

@ -1,3 +1,9 @@
Tues July 14 1998 Felipe A. Rodriguez <far@ix.netcom.com>
* Source/NSBrowser.m fixed bug where column matrix was getting released
twice in method _performLoadOfColumn.
* NSCell.m: isOpaque returns whether cell is bezeled per NS docs.
Fri May 29 13:30:14 1998 Adam Fedor <fedor@ultra.doc.com> Fri May 29 13:30:14 1998 Adam Fedor <fedor@ultra.doc.com>
* Headers/gnustep/gui/AppKit.h: Include Foundation.h. * Headers/gnustep/gui/AppKit.h: Include Foundation.h.

38
Source/NSBrowser.m
View file

@ -1475,16 +1475,13 @@
NSRect matrixRect = {{0, 0}, {100, 100}}; NSRect matrixRect = {{0, 0}, {100, 100}};
int i; int i;
// If we are not reusing matrixes matrix = [[[_browserMatrixClass alloc] // create a new col matrix
// then delete the old matrix and create a new one initWithFrame: matrixRect
// [oldm release]; mode: NSListModeMatrix
matrix = [[[_browserMatrixClass alloc] prototype: _browserCellPrototype
initWithFrame: matrixRect numberOfRows: n
mode: NSListModeMatrix numberOfColumns: 1]
prototype: _browserCellPrototype autorelease];
numberOfRows: n
numberOfColumns: 1]
autorelease];
[matrix setAllowsEmptySelection: _allowsEmptySelection]; [matrix setAllowsEmptySelection: _allowsEmptySelection];
if (!_allowsMultipleSelection) if (!_allowsMultipleSelection)
[matrix setMode: NSRadioModeMatrix]; [matrix setMode: NSRadioModeMatrix];
@ -1492,7 +1489,7 @@
[matrix setAction: @selector(doClick:)]; [matrix setAction: @selector(doClick:)];
[matrix setDoubleAction: @selector(doDoubleClick:)]; [matrix setDoubleAction: @selector(doDoubleClick:)];
[bc setColumnMatrix: matrix]; [bc setColumnMatrix: matrix]; // set new col matrix and release old
[sc setDocumentView: matrix]; [sc setDocumentView: matrix];
// Now loop through the cells and load each one // Now loop through the cells and load each one
@ -1512,16 +1509,13 @@
id oldm = [bc columnMatrix]; id oldm = [bc columnMatrix];
NSRect matrixRect = {{0, 0}, {100, 100}}; NSRect matrixRect = {{0, 0}, {100, 100}};
// If we are not reusing matrixes matrix = [[[_browserMatrixClass alloc] // create a new col matrix
// then delete the old matrix and create a new one initWithFrame: matrixRect
// [oldm release]; mode: NSListModeMatrix
matrix = [[[_browserMatrixClass alloc] prototype: _browserCellPrototype
initWithFrame: matrixRect numberOfRows: 0
mode: NSListModeMatrix numberOfColumns: 0]
prototype: _browserCellPrototype autorelease];
numberOfRows: 0
numberOfColumns: 0]
autorelease];
[matrix setAllowsEmptySelection: _allowsEmptySelection]; [matrix setAllowsEmptySelection: _allowsEmptySelection];
if (!_allowsMultipleSelection) if (!_allowsMultipleSelection)
[matrix setMode: NSRadioModeMatrix]; [matrix setMode: NSRadioModeMatrix];
@ -1529,7 +1523,7 @@
[matrix setAction: @selector(doClick:)]; [matrix setAction: @selector(doClick:)];
[matrix setDoubleAction: @selector(doDoubleClick:)]; [matrix setDoubleAction: @selector(doDoubleClick:)];
[bc setColumnMatrix: matrix]; [bc setColumnMatrix: matrix]; // set new col matrix and release old
[sc setDocumentView: matrix]; [sc setDocumentView: matrix];
// Tell the delegate to create the rows // Tell the delegate to create the rows

22
Source/NSCell.m
View file

@ -392,22 +392,22 @@
// //
// Editing Text // Editing Text
// //
- (void)editWithFrame:(NSRect)aRect - (void)editWithFrame:(NSRect)aRect
inView:(NSView *)controlView inView:(NSView *)controlView
editor:(NSText *)textObject editor:(NSText *)textObject
delegate:(id)anObject delegate:(id)anObject
event:(NSEvent *)theEvent event:(NSEvent *)theEvent
{} {}
- (void)endEditing:(NSText *)textObject - (void)endEditing:(NSText *)textObject
{} {}
- (void)selectWithFrame:(NSRect)aRect - (void)selectWithFrame:(NSRect)aRect
inView:(NSView *)controlView inView:(NSView *)controlView
editor:(NSText *)textObject editor:(NSText *)textObject
delegate:(id)anObject delegate:(id)anObject
start:(int)selStart start:(int)selStart
length:(int)selLength length:(int)selLength
{} {}
// //
@ -455,7 +455,7 @@
- (BOOL)isOpaque - (BOOL)isOpaque
{ {
return NO; return cell_bezeled;
} }
- (void)setBezeled:(BOOL)flag - (void)setBezeled:(BOOL)flag

2
Source/NSView.m
View file

@ -363,8 +363,6 @@ static NSRecursiveLock *gnustep_gui_nsview_lock = nil;
if (post_frame_changes) if (post_frame_changes)
[[NSNotificationCenter defaultCenter] [[NSNotificationCenter defaultCenter]
postNotificationName:NSViewFrameDidChangeNotification object:self]; postNotificationName:NSViewFrameDidChangeNotification object:self];
[self setNeedsDisplay:YES]; // FAR
} }
- (void)setFrameOrigin:(NSPoint)newOrigin - (void)setFrameOrigin:(NSPoint)newOrigin